Jump to content

Tile Entity GUI Not working


DuckCreeper

Recommended Posts

So I've been learning Tile entities and adding gui to them. I've created a tile entity with a simple gui but when i right click the block. Nothing happens.. Its a fare bit of code. But I will include some. I can post more if needed.

 

Main class:

package com.duckcreeper.steelcraft;


import net.minecraft.init.Items;
import net.minecraft.item.ItemStack;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.Mod.EventHandler;
import net.minecraftforge.fml.common.Mod.Instance;
import net.minecraftforge.fml.common.SidedProxy;
import net.minecraftforge.fml.common.event.FMLInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPostInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPreInitializationEvent;
import net.minecraftforge.fml.common.network.NetworkRegistry;
import net.minecraftforge.fml.common.registry.GameRegistry;

import com.duckcreeper.steelcraft.gui.SCGuiHandler;
import com.duckcreeper.steelcraft.init.SteelAchievements;
import com.duckcreeper.steelcraft.init.SteelCraftBlocks;
import com.duckcreeper.steelcraft.init.SteelCraftItems;
import com.duckcreeper.steelcraft.init.SteelTileEntities;
import com.duckcreeper.steelcraft.proxy.CommonProxy;
import com.duckcreeper.steelcraft.tileentity.SCTileEntities;


@Mod(modid = Reference.MOD_ID, name = Reference.MOD_NAME, version = Reference.VERISION)
public class SteelMain {

@SidedProxy(clientSide = Reference.CLIENT_PROXY_CLASS, serverSide = Reference.SERVER_PROXY_CLASS)
public static CommonProxy proxy;

public static final SteelTab tabSteel = new SteelTab("tabSteel");

    @Instance
    public static SteelMain instance = new SteelMain();

@EventHandler
public void preInit(FMLPreInitializationEvent event)
{
	SteelCraftBlocks.init();
	SteelCraftBlocks.register();
	SteelCraftItems.init();
	SteelCraftItems.register();	

	/** Achievement Registering */
	SteelAchievements.loadAchievements();
	SteelAchievements.registerPage();

	/** Tile Entites*/
	SCTileEntities.init();

}

@EventHandler
public void init(FMLInitializationEvent event)
{
	proxy.registerRenders();
	GameRegistry.addRecipe(new ItemStack(SteelCraftBlocks.block_turbine, 4),
		"SIS", 
            "IBI",
            "SIS", 'I', Items.iron_ingot, 'S', SteelCraftItems.steel_ingot, 'B', new ItemStack(Items.dye, 1, 15) ); 

	GameRegistry.addRecipe(new ItemStack(SteelCraftItems.duck_bill_float),
		"SIR",
		"SIS",
		" S ", 'S', SteelCraftItems.steel_ingot, 'I', Items.iron_ingot, 'R', new ItemStack(Items.dye, 1, 1) );

	/** GUI Registering*/
	NetworkRegistry.INSTANCE.registerGuiHandler(this, new SCGuiHandler());

	/** TileEntity Registering */
	SteelTileEntities.register();

}
@EventHandler
public void postInit(FMLPostInitializationEvent event)
{

}

}

 

Tile Entity

package com.duckcreeper.steelcraft.tileentity;


import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.InventoryPlayer;
import net.minecraft.inventory.Container;
import net.minecraft.inventory.ISidedInventory;
import net.minecraft.item.ItemFood;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagList;
import net.minecraft.network.NetworkManager;
import net.minecraft.network.Packet;
import net.minecraft.network.play.server.S35PacketUpdateTileEntity;
import net.minecraft.tileentity.TileEntityLockable;
import net.minecraft.util.ChatComponentText;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.IChatComponent;

import com.duckcreeper.steelcraft.gui.containers.ContainerSCTileEntity;

public class SCTileEntity extends TileEntityLockable implements ISidedInventory
{
private static final int[] slots = new int[] { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14 };

private ItemStack[] inventory = new ItemStack[15];
private String customName;

public int getSizeInventory()
{
	return 15;
}

@Override
public ItemStack getStackInSlot(int par1)
{
	return this.inventory[par1];
}

@Override
public ItemStack decrStackSize(int par1, int par2)
{
	if (this.inventory[par1] != null)
	{
		ItemStack var3;

		if (this.inventory[par1].stackSize <= par2)
		{
			var3 = this.inventory[par1];
			this.inventory[par1] = null;
			this.markDirty();
			return var3;
		}
		var3 = this.inventory[par1].splitStack(par2);

		if (this.inventory[par1].stackSize == 0)
		{
			this.inventory[par1] = null;
		}

		this.markDirty();
		return var3;
	}
	return null;
}

@Override
public ItemStack getStackInSlotOnClosing(int par1)
{
	if (this.inventory[par1] != null)
	{
		ItemStack var2 = this.inventory[par1];
		this.inventory[par1] = null;
		return var2;
	}
	return null;
}

@Override
public void setInventorySlotContents(int par1, ItemStack par2ItemStack)
{
	this.inventory[par1] = par2ItemStack;

	if (par2ItemStack != null && par2ItemStack.stackSize > this.getInventoryStackLimit())
	{
		par2ItemStack.stackSize = this.getInventoryStackLimit();
	}

	this.markDirty();
}

/**
 * Reads a tile entity from NBT.
 */
public void readFromNBT(NBTTagCompound tagCompound)
{
	super.readFromNBT(tagCompound);
	NBTTagList tagList = (NBTTagList) tagCompound.getTag("Items");
	this.inventory = new ItemStack[this.getSizeInventory()];

	for (int count = 0; count < tagList.tagCount(); ++count)
	{
		NBTTagCompound nbt = (NBTTagCompound) tagList.getCompoundTagAt(count);
		int slot = nbt.getByte("Slot") & 255;

		if (slot >= 0 && slot < this.inventory.length)
		{
			this.inventory[slot] = ItemStack.loadItemStackFromNBT(nbt);
		}
	}

	if (tagCompound.hasKey("CustomName", )
	{
		this.customName = tagCompound.getString("CustomName");
	}
}

@Override
public void writeToNBT(NBTTagCompound par1NBTTagCompound)
{
	super.writeToNBT(par1NBTTagCompound);
	NBTTagList var2 = new NBTTagList();

	for (int var3 = 0; var3 < this.inventory.length; ++var3)
	{
		if (this.inventory[var3] != null)
		{
			NBTTagCompound var4 = new NBTTagCompound();
			var4.setByte("Slot", (byte) var3);
			this.inventory[var3].writeToNBT(var4);
			var2.appendTag(var4);
		}
	}

	par1NBTTagCompound.setTag("Items", var2);
}

@Override
public void onDataPacket(NetworkManager net, S35PacketUpdateTileEntity pkt)
{
	NBTTagCompound tagCom = pkt.getNbtCompound();
	this.readFromNBT(tagCom);
}

@Override
public Packet getDescriptionPacket()
{
	NBTTagCompound tagCom = new NBTTagCompound();
	this.writeToNBT(tagCom);
	return new S35PacketUpdateTileEntity(pos, getBlockMetadata(), tagCom);
}

@Override
public int getInventoryStackLimit()
{
	return 64;
}

@Override
public boolean isUseableByPlayer(EntityPlayer par1EntityPlayer)
{
	return this.worldObj.getTileEntity(pos) != this ? false : par1EntityPlayer.getDistanceSq(this.pos.getX() + 0.5D, this.pos.getY() + 0.5D, this.pos.getZ() + 0.5D) <= 64.0D;
}

@Override
public void invalidate()
{
	this.updateContainingBlockInfo();
	super.invalidate();
}

@Override
public boolean isItemValidForSlot(int par1, ItemStack par2ItemStack)
{
	return true;
}

@Override
public String getName()
{
	return this.hasCustomName() ? this.customName : "container.fridge";
}

@Override
public boolean hasCustomName()
{
	return this.customName != null && this.customName.length() > 0;
}

@Override
public IChatComponent getDisplayName()
{
	return new ChatComponentText(getName());
}

@Override
public void openInventory(EntityPlayer playerIn)
{
}

@Override
public void closeInventory(EntityPlayer playerIn)
{
}

@Override
public int getField(int id)
{
	return 0;
}

@Override
public void setField(int id, int value)
{
}

@Override
public int getFieldCount()
{
	return 0;
}

@Override
public void clear()
{
	for (int i = 0; i < inventory.length; i++)
	{
		inventory[i] = null;
	}
}

@Override
public Container createContainer(InventoryPlayer playerInventory, EntityPlayer playerIn) 
{
	return new ContainerSCTileEntity(playerInventory, this);
}

@Override
public String getGuiID() 
{
	return "0";
}

@Override
public int[] getSlotsForFace(EnumFacing side) 
{
	return slots;
}

@Override
public boolean canInsertItem(int index, ItemStack stack, EnumFacing direction) 
{
	return stack.getItem() instanceof ItemFood && !isLocked();
}

@Override
public boolean canExtractItem(int index, ItemStack stack, EnumFacing direction) 
{
	return !isLocked();
}
}

 

Tile Entities Class

package com.duckcreeper.steelcraft.tileentity;

import net.minecraftforge.fml.common.registry.GameRegistry;

public class SCTileEntities {

public static void init(){
	GameRegistry.registerTileEntity(SCTileEntity.class, "test_tile_entity");
}

}

 

Container For Tile Entity

package com.duckcreeper.steelcraft.gui.containers;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.inventory.Container;
import net.minecraft.inventory.IInventory;
import net.minecraft.inventory.Slot;
import net.minecraft.item.ItemFood;
import net.minecraft.item.ItemStack;

import com.duckcreeper.steelcraft.gui.GuiSCTileEntity;
import com.duckcreeper.steelcraft.gui.slots.SlotSCTile;
import com.duckcreeper.steelcraft.tileentity.SCTileEntity;

public class ContainerSCTileEntity extends Container
{
private IInventory lowerChestInventory;
private int numRows;

public ContainerSCTileEntity(IInventory playerInventory, IInventory SCTileEntityInventory)
{
	this.lowerChestInventory = playerInventory;
	SCTileEntityInventory.openInventory(null);
	int var4, var5;

	int count = 0;
	for (int i = 0; i < 3; i++)
	{
		for (int j = 0; j < 5; j++)
		{
			this.addSlotToContainer(new SlotSCTile(SCTileEntityInventory, count, j * 18 + 44, i * 18 + 18));
			count++;
		}
	}

	for (int i = 0; i < 3; i++)
	{
		for (int j = 0; j < 9; ++j)
		{
			this.addSlotToContainer(new Slot(playerInventory, j + i * 9 + 9, j * 18 + 8, i * 18 + 85));
		}
	}

	for (int i = 0; i < 9; i++)
	{
		this.addSlotToContainer(new Slot(playerInventory, i, i * 18 + 8, 143));
	}
}

public boolean canInteractWith(EntityPlayer par1EntityPlayer)
{
	return this.lowerChestInventory.isUseableByPlayer(par1EntityPlayer);
}

public ItemStack transferStackInSlot(EntityPlayer par1EntityPlayer, int par2)
{
	ItemStack var3 = null;
	Slot var4 = (Slot) this.inventorySlots.get(par2);

	if (var4 != null && var4.getHasStack())
	{
		ItemStack var5 = var4.getStack();
		var3 = var5.copy();

		if (!(var5.getItem() instanceof ItemFood))
			return null;

		if (par2 < 16)
		{
			if (!this.mergeItemStack(var5, 16, this.inventorySlots.size(), true))
			{
				return null;
			}
		}
		else if (!this.mergeItemStack(var5, 0, 16, false))
		{
			return null;
		}

		if (var5.stackSize == 0)
		{
			var4.putStack((ItemStack) null);
		}
		else
		{
			var4.onSlotChanged();
		}
	}

	return var3;
}

/**
 * Callback for when the crafting gui is closed.
 */
public void onContainerClosed(EntityPlayer par1EntityPlayer)
{
	super.onContainerClosed(par1EntityPlayer);
	this.lowerChestInventory.closeInventory(par1EntityPlayer);
}

public IInventory func_85151_d()
{
	return this.lowerChestInventory;
}
}

Link to comment
Share on other sites

You don't have to do this: (initializing I mean)

    @Instance
    public static SteelMain instance = new SteelMain();

This is useless: (tab[0, 1, ..., n-1] is literally a number from 0 to n-1.)

private static final int[] slots = new int[] { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14 };

 

As to your problem - "we" need Block, Gui and GuiHandler classes.

1st one is basically responsible for calling opening, which should be done with GuiHandler implementation and which should then open Container AND Gui accordingly (to side).

1.7.10 is no longer supported by forge, you are on your own.

Link to comment
Share on other sites

You do not have an onBlockActivated method telling the game to open the gui

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

GUI Handler

package com.duckcreeper.steelcraft.gui;


import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.BlockPos;
import net.minecraft.world.World;
import net.minecraftforge.fml.common.network.IGuiHandler;

import com.duckcreeper.steelcraft.gui.containers.ContainerSCTileEntity;
import com.duckcreeper.steelcraft.tileentity.SCTileEntity;

public class SCGuiHandler implements IGuiHandler
{
@Override
public Object getServerGuiElement(int id, EntityPlayer player, World world, int x, int y, int z)
{
	TileEntity tile_entity = world.getTileEntity(new BlockPos(x, y, z));
	if (tile_entity instanceof SCTileEntity)
	{
		return new ContainerSCTileEntity(player.inventory, (SCTileEntity) tile_entity);
	}
	return null;
}

@Override
public Object getClientGuiElement(int id, EntityPlayer player, World world, int x, int y, int z)
{
	TileEntity tile_entity = world.getTileEntity(new BlockPos(x, y, z));
	if (tile_entity instanceof SCTileEntity)
	{
		return new GuiSCTileEntity(player.inventory, (SCTileEntity) tile_entity);
	}

	return null;
}

}

 

GUI

package com.duckcreeper.steelcraft.gui;

import net.minecraft.client.gui.inventory.GuiContainer;
import net.minecraft.inventory.IInventory;
import net.minecraft.util.ResourceLocation;

import com.duckcreeper.steelcraft.gui.containers.ContainerSCTileEntity;
import com.duckcreeper.steelcraft.tileentity.SCTileEntity;

public class GuiSCTileEntity extends GuiContainer
{
private static final ResourceLocation gui = new ResourceLocation("sc:textures/gui/basic_machine.png");

public GuiSCTileEntity(IInventory playerInv, SCTileEntity te){
	super(new ContainerSCTileEntity(playerInv, te));

this.xSize = 176;
this.ySize = 166;
}

@Override
protected void drawGuiContainerBackgroundLayer(float partialTicks, int mouseX, int mouseY) {
    }
}

 

Block

package com.duckcreeper.steelcraft.blocks;

import com.duckcreeper.steelcraft.tileentity.SCTileEntity;

import net.minecraft.block.BlockContainer;
import net.minecraft.block.material.Material;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.EnumWorldBlockLayer;
import net.minecraft.world.World;

public class basic_rebar_machine extends BlockContainer{

public basic_rebar_machine(Material materialIn) {
	super(materialIn);
}

@Override
public int getRenderType() {
	return 3;
}

@Override
public boolean isOpaqueCube() {
	return false;
}

@Override
public EnumWorldBlockLayer getBlockLayer() {
	return EnumWorldBlockLayer.CUTOUT;
}

@Override
public TileEntity createNewTileEntity(World worldIn, int meta) {
	return new SCTileEntity();
}

}

 

Hope that helps? :P

Link to comment
Share on other sites

Well, basically Draco is right (Was that a pure guess Draco?).

 

You need to override onBlockActivated method in your Block class and call player.openGui(id, Mod.instance, x, y, z);

Looking at GuiHandler and everything else - it should work.

1.7.10 is no longer supported by forge, you are on your own.

Link to comment
Share on other sites

Well, basically Draco is right (Was that a pure guess Draco?).

 

You need to override onBlockActivated method in your Block class and call player.openGui(id, Mod.instance, x, y, z);

Looking at GuiHandler and everything else - it should work.

 

		player.openGui(1, SteelMain.instance, world, x, y, z);

 

I tried this but its says that

SteelMain.instance

"Instance" should be changed to int but i dont know what to do lol :P

Link to comment
Share on other sites

Well, basically Draco is right (Was that a pure guess Draco?).

 

Not a pure guess. I guessed, looked at his block (labeled container) and it wasn't there.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Hello DuckCreeper,

 

I am fairly new to modding, so feel free to beheckle me if my observation is born of ignorance, but I noticed in your GUI handler, you have overridden the drawGuiContainerBackgroundLayer, but you are not doing anything in the body. Which, if I understand things correctly, would mean that the UI would be effectively invisible.

 

If it is any help at all, I have recently been learning in this area too, and my source repository has code that does not much more than enable a block inventory / gui... so it may be of some help as cross-reference in resolving your issues.

 

(Though, as stated, I am very new, so there maybe many glaring errors and bad practices in play in my code.)

 

https://github.com/lynchiem/ClockworkAdventure/blob/master/src/main/java/net/clockworkrocketry/clockworkadventure/gui/GUIPortableChest.java

 

I also noticed that when you register your guiHandler, you are passing in "this" where all the examples I have seen pass in "instance"... though I am not sure this will make any difference, as assuming the instantiation is done without voodoo they are probably equivalent.

 

Sorry I could not be of more help, and best of luck resolving your issue.

 

 

 

 

Link to comment
Share on other sites

Sorry, I haven't had a huge amount of time today, but had a quick look over now and my first thoughts are:

 

Your proxy and guihandler are separate. When I implemented mine, based on examples I had seen, my proxy is also the guihandler.

 

I am not experienced enough with modding to know if this would cause a problem, but figured I would mention it, because perhaps there is a conflict happening between server code and client code.

 

If you look at my code (linked in a post above) you will note that my CommonProxy, used by the server, returns null for the getClientGuiElement, but my ClientProxy overrides that behaviour.

 

I will have more time tomorrow after work, so if you haven't resolved by then, I will take a more thorough look at your code.

Link to comment
Share on other sites

So I've been playing around. Now I get this in my console and my game crashes. I mean now i know its trying to make one. But I dont know what to do.

 

Invalid attempt to create a GUI during mod construction. Use an EventHandler instead
at net.minecraftforge.fml.common.network.NetworkRegistry.registerGuiHandler(NetworkRegistry.java:219)

 

Here is my main class

 @EventHandler
 public void load(FMLInitializationEvent event)
    {
    	NetworkRegistry.INSTANCE.registerGuiHandler(instance, proxy);
            }

 

 

NOTE

 

I changed the part that says

   

NetworkRegistry.INSTANCE.registerGuiHandler(instance, proxy);

 

to

   

NetworkRegistry.INSTANCE.registerGuiHandler(this, proxy);

 

and now my game loads.... and when i right click it... nothing pops up but my hand moves... just like when you open a chest or something. So basically my GUI is not showing ingame now...

 

What do i do!?!?!!?

Link to comment
Share on other sites

Your proxy and guihandler are separate. When I implemented mine, based on examples I had seen, my proxy is also the guihandler.

 

Ew.

There is no reason to combine them.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

So in the onBlockActivated Method. I'm using

player.openGui(SteelMain.instance, 1, world, pos.getX(), pos.getY(), pos.getZ());

But When looking at the openGui its self. The second parameter is the GuiID for the gui. Here is what its set to in my code. :

    @Override
    public String getGuiID()
    {
        return Reference.SteelCraftBlocks.BASIC_REBAR_MACHINE.getRegistryName() + ":Basic";
    }

 

But what do I do? I'm a bit confused on this. An explanation would be helpful :P

Link to comment
Share on other sites

So in the onBlockActivated Method. I'm using

player.openGui(SteelMain.instance, 1, world, pos.getX(), pos.getY(), pos.getZ());

But When looking at the openGui its self. The second parameter is the GuiID for the gui. Here is what its set to in my code. :

    @Override
    public String getGuiID()
    {
        return Reference.SteelCraftBlocks.BASIC_REBAR_MACHINE.getRegistryName() + ":Basic";
    }

 

But what do I do? I'm a bit confused on this. An explanation would be helpful :P

 

The gui id is the integer 1 in the opengui call.that other method is badly named as does not do what it is called, nor have you shown what you use it for.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

So in the onBlockActivated Method. I'm using

player.openGui(SteelMain.instance, 1, world, pos.getX(), pos.getY(), pos.getZ());

But When looking at the openGui its self. The second parameter is the GuiID for the gui. Here is what its set to in my code. :

    @Override
    public String getGuiID()
    {
        return Reference.SteelCraftBlocks.BASIC_REBAR_MACHINE.getRegistryName() + ":Basic";
    }

 

But what do I do? I'm a bit confused on this. An explanation would be helpful :P

 

The gui id is the integer 1 in the opengui call.that other method is badly named as does not do what it is called, nor have you shown what you use it for.

 

Draco I have figured that out now. I now need help on figureing out why the GUI wont show ingame... Tell me if code is needed.

Link to comment
Share on other sites

Try replacing:

 

@Override
public Object getServerGuiElement(int id, EntityPlayer player, World world, int x, int y, int z)
{
	TileEntity tile_entity = world.getTileEntity(new BlockPos(x, y, z));
	if (tile_entity instanceof SCTileEntity)
	{
		return new ContainerSCTileEntity(player.inventory, (SCTileEntity) tile_entity, x, y);
	}
	return null;
}

@Override
public Object getClientGuiElement(int id, EntityPlayer player, World world, int x, int y, int z)
{
	TileEntity tile_entity = world.getTileEntity(new BlockPos(x, y, z));
	if (tile_entity instanceof SCTileEntity)
	{
		return new GuiSCTileEntity(player.inventory, (SCTileEntity) tile_entity);
	}

	return null;
}

 

with:

 

@Override
public Object getServerGuiElement(int id, EntityPlayer player, World world, int x, int y, int z)
{
	TileEntity tile_entity = world.getTileEntity(new BlockPos(x, y, z));
	switch(id){
                     case YOURCONTAINERANDGUIID:
                             return new ContainerSCTileEntity(player.inventory, (SCTileEntity) tile_entity, x, y);
                             break;
                }
	return null;
}

@Override
public Object getClientGuiElement(int id, EntityPlayer player, World world, int x, int y, int z)
{
	TileEntity tile_entity = world.getTileEntity(new BlockPos(x, y, z));
	switch(id){
                     case YOURCONTAINERANDGUIID:
                             return new GuiSCTileEntity(player.inventory, (SCTileEntity) tile_entity);
                             break;
                }

	return null;
}

 

PS: sorry for my bad english :D

Link to comment
Share on other sites

Yeah. YOURCONTAINERANDGUIID is the number you used when opening the gui

 

player.openGui(modInstance, ID....);

 

additional info: gui id's should be unique for your mod, don't define them multiple

 

Create a field in your gui handler class:

 

public static final YOUR_GUIID=0;

public static final ANOTHER_GUIID=1;

 

and then access this ids instead of typing a number, so you can't get confused if you need them :D

 

EDIT: please place the onBlockActivated in your block class and not in your tileentity (maybe you already done that, i've seen it in your sources you linked)

Link to comment
Share on other sites

Your proxy and guihandler are separate. When I implemented mine, based on examples I had seen, my proxy is also the guihandler.

 

Ew.

There is no reason to combine them.

 

Thank you.

 

As I have mentioned, I am very new to modding, and was simply sharing thoughts based on the difference I could identify between my working code and the problematic code.

 

Combined is probably an overstatement, given the GUI related functions are the only ones I am currently handling over riding in the "proxy".

 

I am still struggling to get my head around how the proxy system works. I need to explicitly tell the mod which class to use as the client and server proxies.

 

@SidedProxy(clientSide = "net.clockworkrocketry.clockworkadventure.network.ClientProxy", serverSide = "net.clockworkrocketry.clockworkadventure.network.CommonProxy")

 

If I get rid of this, my GUI stops working.

 

And my proxy is nothing more than in implementation of IGuiHandler at this stage, containing pretty much only the getClientGuiElement and getServerGuiElement functions.

 

So I thought it was worth exploring as a possible breakage point, as I thought maybe the getClientGuiElement and getServerGuiElement functions needed to be "wired" up to the server/client workflow.

 

But obviously this is incorrect.

Link to comment
Share on other sites

Take a look at my code sometime.

I don't so things the best, objectively. But the class layout is more standard.

 

https://github.com/Draco18s/Artifacts/tree/master/main/java/com/draco18s/artifacts/

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hey, Me and my friends decided to start up a Server with "a few" mods, the last few days everything went well we used all the items we wanted. Now our Game crashes the moment we touch a Lava Bucket inside our Inventory. It just instantly closes and gives me an "Alc Cleanup"  Crash screen (Using GDLauncher). I honestly dont have a clue how to resolve this error. If anyone could help id really appreciate it, I speak German and Englisch so you can choose whatever you speak more fluently. Thanks in Advance. Plus I dont know how to link my Crash Report help for that would be nice too whoops
    • I hosted a minecraft server and I modded it, and there is always an error on the console which closes the server. If someone knows how to repair it, it would be amazing. Thank you. I paste the crash report down here: ---- Minecraft Crash Report ---- WARNING: coremods are present:   llibrary (llibrary-core-1.0.11-1.12.2.jar)   WolfArmorCore (WolfArmorAndStorage-1.12.2-3.8.0-universal-signed.jar)   AstralCore (astralsorcery-1.12.2-1.10.27.jar)   CreativePatchingLoader (CreativeCore_v1.10.71_mc1.12.2.jar)   SecurityCraftLoadingPlugin ([1.12.2] SecurityCraft v1.9.8.jar)   ForgelinPlugin (Forgelin-1.8.4.jar)   midnight (themidnight-0.3.5.jar)   FutureMC (Future-MC-0.2.19.jar)   SpartanWeaponry-MixinLoader (SpartanWeaponry-1.12.2-1.5.3.jar)   Backpacked (backpacked-1.4.3-1.12.2.jar)   LoadingPlugin (Reskillable-1.12.2-1.13.0.jar)   LoadingPlugin (Bloodmoon-MC1.12.2-1.5.3.jar) Contact their authors BEFORE contacting forge // There are four lights! Time: 3/28/24 12:17 PM Description: Exception in server tick loop net.minecraftforge.fml.common.LoaderException: java.lang.NoClassDefFoundError: net/minecraft/client/multiplayer/WorldClient     at net.minecraftforge.fml.common.AutomaticEventSubscriber.inject(AutomaticEventSubscriber.java:89)     at net.minecraftforge.fml.common.FMLModContainer.constructMod(FMLModContainer.java:612)     at sun.reflect.GeneratedMethodAccessor10.invoke(Unknown Source)     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)     at java.lang.reflect.Method.invoke(Method.java:498)     at com.google.common.eventbus.Subscriber.invokeSubscriberMethod(Subscriber.java:91)     at com.google.common.eventbus.Subscriber$SynchronizedSubscriber.invokeSubscriberMethod(Subscriber.java:150)     at com.google.common.eventbus.Subscriber$1.run(Subscriber.java:76)     at com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:399)     at com.google.common.eventbus.Subscriber.dispatchEvent(Subscriber.java:71)     at com.google.common.eventbus.Dispatcher$PerThreadQueuedDispatcher.dispatch(Dispatcher.java:116)     at com.google.common.eventbus.EventBus.post(EventBus.java:217)     at net.minecraftforge.fml.common.LoadController.sendEventToModContainer(LoadController.java:219)     at net.minecraftforge.fml.common.LoadController.propogateStateMessage(LoadController.java:197)     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)     at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)     at java.lang.reflect.Method.invoke(Method.java:498)     at com.google.common.eventbus.Subscriber.invokeSubscriberMethod(Subscriber.java:91)     at com.google.common.eventbus.Subscriber$SynchronizedSubscriber.invokeSubscriberMethod(Subscriber.java:150)     at com.google.common.eventbus.Subscriber$1.run(Subscriber.java:76)     at com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:399)     at com.google.common.eventbus.Subscriber.dispatchEvent(Subscriber.java:71)     at com.google.common.eventbus.Dispatcher$PerThreadQueuedDispatcher.dispatch(Dispatcher.java:116)     at com.google.common.eventbus.EventBus.post(EventBus.java:217)     at net.minecraftforge.fml.common.LoadController.distributeStateMessage(LoadController.java:136)     at net.minecraftforge.fml.common.Loader.loadMods(Loader.java:595)     at net.minecraftforge.fml.server.FMLServerHandler.beginServerLoading(FMLServerHandler.java:98)     at net.minecraftforge.fml.common.FMLCommonHandler.onServerStart(FMLCommonHandler.java:333)     at net.minecraft.server.dedicated.DedicatedServer.func_71197_b(DedicatedServer.java:125)     at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:486)     at java.lang.Thread.run(Thread.java:750) Caused by: java.lang.NoClassDefFoundError: net/minecraft/client/multiplayer/WorldClient     at java.lang.Class.getDeclaredMethods0(Native Method)     at java.lang.Class.privateGetDeclaredMethods(Class.java:2701)     at java.lang.Class.privateGetPublicMethods(Class.java:2902)     at java.lang.Class.getMethods(Class.java:1615)     at net.minecraftforge.fml.common.eventhandler.EventBus.register(EventBus.java:82)     at net.minecraftforge.fml.common.AutomaticEventSubscriber.inject(AutomaticEventSubscriber.java:82)     ... 31 more Caused by: java.lang.ClassNotFoundException: net.minecraft.client.multiplayer.WorldClient     at net.minecraft.launchwrapper.LaunchClassLoader.findClass(LaunchClassLoader.java:191)     at java.lang.ClassLoader.loadClass(ClassLoader.java:418)     at java.lang.ClassLoader.loadClass(ClassLoader.java:351)     ... 37 more Caused by: net.minecraftforge.fml.common.asm.ASMTransformerWrapper$TransformerException: Exception in class transformer net.minecraftforge.fml.common.asm.transformers.SideTransformer@4e558728 from coremod FMLCorePlugin     at net.minecraftforge.fml.common.asm.ASMTransformerWrapper$TransformerWrapper.transform(ASMTransformerWrapper.java:260)     at net.minecraft.launchwrapper.LaunchClassLoader.runTransformers(LaunchClassLoader.java:279)     at net.minecraft.launchwrapper.LaunchClassLoader.findClass(LaunchClassLoader.java:176)     ... 39 more Caused by: java.lang.RuntimeException: Attempted to load class bsb for invalid side SERVER     at net.minecraftforge.fml.common.asm.transformers.SideTransformer.transform(SideTransformer.java:62)     at net.minecraftforge.fml.common.asm.ASMTransformerWrapper$TransformerWrapper.transform(ASMTransformerWrapper.java:256)     ... 41 more A detailed walkthrough of the error, its code path and all known details is as follows: --------------------------------------------------------------------------------------- -- System Details -- Details:     Minecraft Version: 1.12.2     Operating System: Linux (amd64) version 5.10.0-28-cloud-amd64     Java Version: 1.8.0_382, Temurin     Java VM Version: OpenJDK 64-Bit Server VM (mixed mode), Temurin     Memory: 948745536 bytes (904 MB) / 1564999680 bytes (1492 MB) up to 7635730432 bytes (7282 MB)     JVM Flags: 2 total; -Xmx8192M -Xms256M     IntCache: cache: 0, tcache: 0, allocated: 0, tallocated: 0     FML: MCP 9.42 Powered by Forge 14.23.5.2860 63 mods loaded, 63 mods active     States: 'U' = Unloaded 'L' = Loaded 'C' = Constructed 'H' = Pre-initialized 'I' = Initialized 'J' = Post-initialized 'A' = Available 'D' = Disabled 'E' = Errored     | State | ID                 | Version                 | Source                                                | Signature                                |     |:----- |:------------------ |:----------------------- |:----------------------------------------------------- |:---------------------------------------- |     | LC    | minecraft          | 1.12.2                  | minecraft.jar                                         | None                                     |     | LC    | mcp                | 9.42                    | minecraft.jar                                         | None                                     |     | LC    | FML                | 8.0.99.99               | forge-1.12.2-14.23.5.2860.jar                         | e3c3d50c7c986df74c645c0ac54639741c90a557 |     | LC    | forge              | 14.23.5.2860            | forge-1.12.2-14.23.5.2860.jar                         | e3c3d50c7c986df74c645c0ac54639741c90a557 |     | LC    | creativecoredummy  | 1.0.0                   | minecraft.jar                                         | None                                     |     | LC    | backpacked         | 1.4.2                   | backpacked-1.4.3-1.12.2.jar                           | None                                     |     | LC    | itemblacklist      | 1.4.3                   | ItemBlacklist-1.4.3.jar                               | None                                     |     | LC    | securitycraft      | v1.9.8                  | [1.12.2] SecurityCraft v1.9.8.jar                     | None                                     |     | LC    | aiimprovements     | 0.0.1.3                 | AIImprovements-1.12-0.0.1b3.jar                       | None                                     |     | LC    | jei                | 4.16.1.301              | jei_1.12.2-4.16.1.301.jar                             | None                                     |     | LC    | appleskin          | 1.0.14                  | AppleSkin-mc1.12-1.0.14.jar                           | None                                     |     | LC    | baubles            | 1.5.2                   | Baubles-1.12-1.5.2.jar                                | None                                     |     | LC    | astralsorcery      | 1.10.27                 | astralsorcery-1.12.2-1.10.27.jar                      | a0f0b759d895c15ceb3e3bcb5f3c2db7c582edf0 |     | LC    | attributefix       | 1.0.12                  | AttributeFix-Forge-1.12.2-1.0.12.jar                  | None                                     |     | LC    | atum               | 2.0.20                  | Atum-1.12.2-2.0.20.jar                                | None                                     |     | LC    | bloodmoon          | 1.5.3                   | Bloodmoon-MC1.12.2-1.5.3.jar                          | d72e0dd57935b3e9476212aea0c0df352dd76291 |     | LC    | forgelin           | 1.8.4                   | Forgelin-1.8.4.jar                                    | None                                     |     | LC    | bountiful          | 2.2.2                   | Bountiful-2.2.2.jar                                   | None                                     |     | LC    | camera             | 1.0.10                  | camera-1.0.10.jar                                     | None                                     |     | LC    | chisel             | MC1.12.2-1.0.2.45       | Chisel-MC1.12.2-1.0.2.45.jar                          | None                                     |     | LC    | collective         | 3.0                     | collective-1.12.2-3.0.jar                             | None                                     |     | LC    | reskillable        | 1.12.2-1.13.0           | Reskillable-1.12.2-1.13.0.jar                         | None                                     |     | LC    | compatskills       | 1.12.2-1.17.0           | CompatSkills-1.12.2-1.17.0.jar                        | None                                     |     | LC    | creativecore       | 1.10.0                  | CreativeCore_v1.10.71_mc1.12.2.jar                    | None                                     |     | LC    | customnpcs         | 1.12                    | CustomNPCs_1.12.2-(05Jul20).jar                       | None                                     |     | LC    | darknesslib        | 1.1.2                   | DarknessLib-1.12.2-1.1.2.jar                          | 220f10d3a93b3ff5fbaa7434cc629d863d6751b9 |     | LC    | dungeonsmod        | @VERSION@               | DungeonsMod-1.12.2-1.0.8.jar                          | None                                     |     | LC    | enhancedvisuals    | 1.3.0                   | EnhancedVisuals_v1.4.4_mc1.12.2.jar                   | None                                     |     | LC    | extrautils2        | 1.0                     | extrautils2-1.12-1.9.9.jar                            | None                                     |     | LC    | futuremc           | 0.2.6                   | Future-MC-0.2.19.jar                                  | None                                     |     | LC    | geckolib3          | 3.0.30                  | geckolib-forge-1.12.2-3.0.31.jar                      | None                                     |     | LC    | gottschcore        | 1.15.1                  | GottschCore-mc1.12.2-f14.23.5.2859-v1.15.1.jar        | None                                     |     | LC    | hardcorerevival    | 1.2.0                   | HardcoreRevival_1.12.2-1.2.0.jar                      | None                                     |     | LC    | waila              | 1.8.26                  | Hwyla-1.8.26-B41_1.12.2.jar                           | None                                     |     | LE    | imsm               | 1.12                    | Instant Massive Structures Mod 1.12.2.jar             | None                                     |     | L     | journeymap         | 1.12.2-5.7.1p2          | journeymap-1.12.2-5.7.1p2.jar                         | None                                     |     | L     | mobsunscreen       | @version@               | mobsunscreen-1.12.2-3.1.5.jar                         | None                                     |     | L     | morpheus           | 1.12.2-3.5.106          | Morpheus-1.12.2-3.5.106.jar                           | None                                     |     | L     | llibrary           | 1.7.20                  | llibrary-1.7.20-1.12.2.jar                            | None                                     |     | L     | mowziesmobs        | 1.5.8                   | mowziesmobs-1.5.8.jar                                 | None                                     |     | L     | nocubessrparmory   | 3.0.0                   | NoCubes_SRP_Combat_Addon_3.0.0.jar                    | None                                     |     | L     | nocubessrpnests    | 3.0.0                   | NoCubes_SRP_Nests_Addon_3.0.0.jar                     | None                                     |     | L     | nocubessrpsurvival | 3.0.0                   | NoCubes_SRP_Survival_Addon_3.0.0.jar                  | None                                     |     | L     | nocubesrptweaks    | V4.1                    | nocubesrptweaks-V4.1.jar                              | None                                     |     | L     | patchouli          | 1.0-23.6                | Patchouli-1.0-23.6.jar                                | None                                     |     | L     | artifacts          | 1.1.2                   | RLArtifacts-1.1.2.jar                                 | None                                     |     | L     | rsgauges           | 1.2.8                   | rsgauges-1.12.2-1.2.8.jar                             | None                                     |     | L     | rustic             | 1.1.7                   | rustic-1.1.7.jar                                      | None                                     |     | L     | silentlib          | 3.0.13                  | SilentLib-1.12.2-3.0.14+168.jar                       | None                                     |     | L     | scalinghealth      | 1.3.37                  | ScalingHealth-1.12.2-1.3.42+147.jar                   | None                                     |     | L     | lteleporters       | 1.12.2-3.0.2            | simpleteleporters-1.12.2-3.0.2.jar                    | None                                     |     | L     | spartanshields     | 1.5.5                   | SpartanShields-1.12.2-1.5.5.jar                       | None                                     |     | L     | spartanweaponry    | 1.5.3                   | SpartanWeaponry-1.12.2-1.5.3.jar                      | None                                     |     | L     | srparasites        | 1.9.18                  | SRParasites-1.12.2v1.9.18.jar                         | None                                     |     | L     | treasure2          | 2.2.0                   | Treasure2-mc1.12.2-f14.23.5.2859-v2.2.1.jar           | None                                     |     | L     | treeharvester      | 4.0                     | treeharvester_1.12.2-4.0.jar                          | None                                     |     | L     | twilightforest     | 3.11.1021               | twilightforest-1.12.2-3.11.1021-universal.jar         | None                                     |     | L     | variedcommodities  | 1.12.2                  | VariedCommodities_1.12.2-(31Mar23).jar                | None                                     |     | L     | voicechat          | 1.12.2-2.4.32           | voicechat-forge-1.12.2-2.4.32.jar                     | None                                     |     | L     | wolfarmor          | 3.8.0                   | WolfArmorAndStorage-1.12.2-3.8.0-universal-signed.jar | None                                     |     | L     | worldborder        | 2.3                     | worldborder_1.12.2-2.3.jar                            | None                                     |     | L     | midnight           | 0.3.5                   | themidnight-0.3.5.jar                                 | None                                     |     | L     | structurize        | 1.12.2-0.10.277-RELEASE | structurize-1.12.2-0.10.277-RELEASE.jar               | None                                     |     Loaded coremods (and transformers):  llibrary (llibrary-core-1.0.11-1.12.2.jar)   net.ilexiconn.llibrary.server.core.plugin.LLibraryTransformer   net.ilexiconn.llibrary.server.core.patcher.LLibraryRuntimePatcher WolfArmorCore (WolfArmorAndStorage-1.12.2-3.8.0-universal-signed.jar)    AstralCore (astralsorcery-1.12.2-1.10.27.jar)    CreativePatchingLoader (CreativeCore_v1.10.71_mc1.12.2.jar)    SecurityCraftLoadingPlugin ([1.12.2] SecurityCraft v1.9.8.jar)    ForgelinPlugin (Forgelin-1.8.4.jar)    midnight (themidnight-0.3.5.jar)   com.mushroom.midnight.core.transformer.MidnightClassTransformer FutureMC (Future-MC-0.2.19.jar)   thedarkcolour.futuremc.asm.CoreTransformer SpartanWeaponry-MixinLoader (SpartanWeaponry-1.12.2-1.5.3.jar)    Backpacked (backpacked-1.4.3-1.12.2.jar)   com.mrcrayfish.backpacked.asm.BackpackedTransformer LoadingPlugin (Reskillable-1.12.2-1.13.0.jar)   codersafterdark.reskillable.base.asm.ClassTransformer LoadingPlugin (Bloodmoon-MC1.12.2-1.5.3.jar)   lumien.bloodmoon.asm.ClassTransformer     Profiler Position: N/A (disabled)     Is Modded: Definitely; Server brand changed to 'fml,forge'     Type: Dedicated Server (map_server.txt)
    • When i add mods like falling leaves, visuality and kappas shaders, even if i restart Minecraft they dont show up in the mods menu and they dont work
    • Delete the forge-client.toml file in your config folder  
    • If you are using AMD/ATI, get the latest drivers from their website - do not update via system  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.