[1.8] TileEntity - How to get Stack in Slot?

[DerT0bey]

Hi,

 

I try to get the item from my slots in my TileEntity. I'm using the update() methode, but it always returns null, doesnt matter if an item is in that slot or not.

Can someone help me?

 

Here's the code of my TileEntity:

public class TileEntityXpBlock extends TileEntity implements /*ISidedInventory,*/ IUpdatePlayerListBox, IInteractionObject {

public ItemStack[] stack = new ItemStack[7];
private String name;

@Override
public void writeToNBT(NBTTagCompound compound) {
	super.writeToNBT(compound);
	NBTTagList tagList = new NBTTagList();

	for (int i = 0; i < this.stack.length; ++i) {
		if (this.stack[i] != null) {
			NBTTagCompound tagCompound1 = new NBTTagCompound();
			tagCompound1.setByte("Slot", (byte) i);
			this.stack[i].writeToNBT(tagCompound1);
			tagList.appendTag(tagCompound1);
		}
	}

	compound.setTag("Items", tagList);

	if (this.hasCustomName()) {
		compound.setString("CustomName", this.name);
	}
}

@Override
public void readFromNBT(NBTTagCompound compound) {
	super.readFromNBT(compound);
	NBTTagList tagList = compound.getTagList("Items", 10);
	this.stack = new ItemStack[7];

	for (int i = 0; i < tagList.tagCount(); ++i) {
		NBTTagCompound tabCompound1 = tagList.getCompoundTagAt(i);
		byte byte0 = tabCompound1.getByte("Slot");

		if (byte0 >= 0 && byte0 < this.stack.length) {
			this.stack[byte0] = ItemStack.loadItemStackFromNBT(tabCompound1);
		}
	}

	if (compound.hasKey("CustomName", ) {
		this.name = compound.getString("CustomName");
	}
}

public boolean hasCustomName() {
	return name != null && name.length() > 0;
}

@Override
public String getName() {
	// TODO Auto-generated method stub
	return null;
}

@Override
public IChatComponent getDisplayName() {
	// TODO Auto-generated method stub
	return null;
}

@Override
public Container createContainer(InventoryPlayer playerInventory, EntityPlayer playerIn) {
	return new XpBlockContainer(playerInventory, this.pos, this.worldObj);
}

@Override
public String getGuiID() {
	// TODO Auto-generated method stub
	return null;
}

@Override
public void update() {
	if(this.worldObj.isRemote) {
		ItemStack itemstack = this.stack[2];
		if(itemstack != null) {
			System.out.println("INPUT");
		} else {
			System.out.println("NULL");
		}
	}


}


}

[RANKSHANK]

Well your update() is run on clientside only.... Also you don't appear to be sending a description packet, so the itemstack will be null on the client where it is checked

[IceMetalPunk]

Try changing the if (world.isRemote) in your update method to if (!world.isRemote). Inventory contents generally should be checked on the server, not the client.

[DerT0bey]

Thanks for your replies.

 

I changed it to !isRemote but it still returns null.

Do i really need a PacketHandler? In a earlier Forge version i created a TileEntity without and it worked fine

[DerT0bey]

I see nowhere where you even put stuff into the slots. Your TileEntity doesn't even implement IInventory. So naturally the slots all stay null, since nobody changes them.

 

Thats why i was looking at the TileEntityEnchantment and thought its not necessarily.

So i try it with IInventory now

[DerT0bey]

I implemented ISidedInventory but it's still Null

Is there anything i forgot?

 

Here's my code:

public class TileEntityXpBlock extends TileEntity implements ISidedInventory, IUpdatePlayerListBox {

public ItemStack[] stack = new ItemStack[7];
private String name;

@Override
public void writeToNBT(NBTTagCompound compound) {
	super.writeToNBT(compound);
	NBTTagList tagList = new NBTTagList();

	for (int i = 0; i < this.stack.length; ++i) {
		if (this.stack[i] != null) {
			NBTTagCompound tagCompound1 = new NBTTagCompound();
			tagCompound1.setByte("Slot", (byte) i);
			this.stack[i].writeToNBT(tagCompound1);
			tagList.appendTag(tagCompound1);
		}
	}

	compound.setTag("Items", tagList);

	if (this.hasCustomName()) {
		compound.setString("CustomName", this.name);
	}
}

@Override
public void readFromNBT(NBTTagCompound compound) {
	super.readFromNBT(compound);
	NBTTagList tagList = compound.getTagList("Items", 10);
	this.stack = new ItemStack[7];

	for (int i = 0; i < tagList.tagCount(); ++i) {
		NBTTagCompound tabCompound1 = tagList.getCompoundTagAt(i);
		byte byte0 = tabCompound1.getByte("Slot");

		if (byte0 >= 0 && byte0 < this.stack.length) {
			this.stack[byte0] = ItemStack.loadItemStackFromNBT(tabCompound1);
		}
	}

	if (compound.hasKey("CustomName", ) {
		this.name = compound.getString("CustomName");
	}
}

@Override
public boolean hasCustomName() {
	return name != null && name.length() > 0;
}

@Override
public String getName() {
	return this.hasCustomName() ? this.name : "";
}

@Override
public IChatComponent getDisplayName() {
	return new ChatComponentText(getName());
}

@Override
public int getSizeInventory() {
	return this.stack.length;
}

@Override
public ItemStack getStackInSlot(int index) {
	return this.stack[index];
}

@Override
public ItemStack decrStackSize(int index, int count) {
	if (this.stack[index] != null) {
		ItemStack itemstack;
		if (this.stack[index].stackSize <= count) {
			itemstack = this.stack[index];
			this.stack[index] = null;
			return itemstack;
		} else {
			itemstack = this.stack[index].splitStack(count);

			if (this.stack[index].stackSize == 0) {
				this.stack[index] = null;
			}
			return itemstack;
		}
	} else {
		return null;
	}
}

@Override
public ItemStack getStackInSlotOnClosing(int index) {
	if (this.stack[index] != null) {
		ItemStack itemstack = this.stack[index];
		this.stack[index] = null;
		return itemstack;
	} else {
		return null;
	}
}

@Override
public void setInventorySlotContents(int index, ItemStack stack) {
	this.stack[index] = stack;

	if (stack != null && stack.stackSize > this.getInventoryStackLimit()) {
		stack.stackSize = this.getInventoryStackLimit();
	}
}

@Override
public int getInventoryStackLimit() {
	return 64;
}

@Override
public boolean isUseableByPlayer(EntityPlayer player) {
	return this.worldObj.getTileEntity(this.getPos()) != this ? false : player.getDistanceSq((double) this.pos.getX() + 0.5D, (double) this.pos.getY() + 0.5D, (double) this.pos.getZ() + 0.5D) <= 64.0D;
}

@Override
public void openInventory(EntityPlayer player) {}

@Override
public void closeInventory(EntityPlayer player) {}

@Override
public boolean isItemValidForSlot(int index, ItemStack stack) {
	return index == 6 ? false : true;
}

@Override
public int getField(int id) {
	return 0;
}

@Override
public void setField(int id, int value) {
}

@Override
public int getFieldCount() {
	return 0;
}

@Override
public void clear() {
	for (int i = 0; i < stack.length; ++i) {
		stack[i] = null;
	}
}

@Override
public int[] getSlotsForFace(EnumFacing side) {
	return null;
}

@Override
public boolean canInsertItem(int index, ItemStack itemStackIn, EnumFacing direction) {
	return this.isItemValidForSlot(index, itemStackIn);
}

@Override
public boolean canExtractItem(int index, ItemStack stack, EnumFacing direction) {
	return index != 0 || index != 1 || stack.getItem() == Items.bucket;
}

@Override
public void update() {
	if(!this.worldObj.isRemote) {
		ItemStack itemstack = this.stack[2];
		if(itemstack != null) {
			System.out.println("INPUT");
		} else {
			System.out.println("NULL");
		}
	}	
}

[DerT0bey]

Found out it's working fine with the detectAndSendChanges() methode in my container class

public void detectAndSendChanges() {
	super.detectAndSendChanges();
	ItemStack stack = tableInventory.getStackInSlot(0);
	if(stack != null) {
		System.out.println("In");
	} else System.out.println("Null");
}