Jump to content

[SOLVED] [1.8] Some problems with custom chest


JimiIT92

Recommended Posts

Hi guys, i'm making a custom chest and i have some little problems. Now, the chest itself works fine, but i still have 3 problems:

  • 1. Chest is not rendering in inventory (it's just rendering as a block with missing texture)
    opfRBJ.png
    How can i rendering it properly? In 1.7 i used this class

package mw.entities.renderer.colored;

import net.minecraft.client.model.ModelChest;
import net.minecraft.item.EnumDyeColor;
import net.minecraft.item.ItemDye;
import net.minecraft.item.ItemStack;
import net.minecraft.util.ResourceLocation;
import net.minecraftforge.client.IItemRenderer;
import net.minecraftforge.client.IItemRenderer.ItemRenderType;
import net.minecraftforge.client.IItemRenderer.ItemRendererHelper;
import net.minecraftforge.fml.client.FMLClientHandler;

import org.lwjgl.opengl.GL11;

public class RenderColoredChest implements IItemRenderer {

private ModelChest chestModel;
private int num;
private ResourceLocation forge = new ResourceLocation("mw:textures/entities/chest/normal_white.png");

public RenderColoredChest(int i){

	chestModel = new ModelChest();
	num = i;

}

@Override
public boolean handleRenderType(ItemStack item, ItemRenderType type) {
	return true;
}

@Override
public boolean shouldUseRenderHelper(ItemRenderType type, ItemStack item,
		ItemRendererHelper helper) {
	return true;
}

@Override
public void renderItem(ItemRenderType type, ItemStack item, Object... data) {
	switch (type) {
	case ENTITY: {
		renderStratosChest(0.5F, 0.5F, 0.5F);
		break;
	}
	case EQUIPPED: {
		renderStratosChest(1.0F, 1.0F, 1.0F);
		break;
	}
	case EQUIPPED_FIRST_PERSON: {
		renderStratosChest(1.0F, 1.0F, 1.0F);
		break;
	}
	case INVENTORY: {
		renderStratosChest(0.0F, 0.075F, 0.0F);
		break;
	}
	default:
		break;
	}
}
private void renderStratosChest(float x, float y, float z) {
	forge = new ResourceLocation("mw:textures/entities/chest/normal_" + EnumDyeColor.byDyeDamage(num).getUnlocalizedName() + ".png");
	FMLClientHandler.instance().getClient().renderEngine.bindTexture(forge);
	GL11.glPushMatrix(); //start
	GL11.glTranslatef(x, y, z); //size
	GL11.glRotatef(180, 1, 0, 0);
	GL11.glRotatef(-90, 0, 1, 0);
	chestModel.renderAll();
	GL11.glPopMatrix(); //end
}

}

Wich i also use for other chests, but it seems that this no longer works, so how should i change that?

  • 2. Forge is asking me for the blockstate files of the chest (legit, but i don't have a "vanilla" chest blockstate file for reference)

[11:41:34] [Client thread/ERROR] [FML]: Model definition for location mw:white_chest#facing=south not found
[11:41:34] [Client thread/ERROR] [FML]: Model definition for location mw:white_chest#facing=north not found
[11:41:34] [Client thread/ERROR] [FML]: Model definition for location mw:white_chest#inventory not found
[11:41:34] [Client thread/ERROR] [FML]: Model definition for location mw:white_chest#facing=west not found
[11:41:34] [Client thread/ERROR] [FML]: Model definition for location mw:white_chest#facing=east not found

Where can i found a reference file for this? Or would i make a "fake" file for that?

  • 3. Chest is not rendered if i rotate my view (video below)

https://www.youtube.com/watch?v=bqZrT2qpdO8

Actually this problem was there since 1.6, but i've never find out how to solve that :/

Here is the rendering class for the TileEntity of the White Chest

package mw.entities.tileentity.colored.renderer;

import java.util.Calendar;

import mw.blocks.colored.chests.BlockWhiteChest;
import mw.entities.tileentity.colored.TileEntityWhiteChest;
import net.minecraft.block.Block;
import net.minecraft.client.model.ModelChest;
import net.minecraft.client.model.ModelLargeChest;
import net.minecraft.client.renderer.GlStateManager;
import net.minecraft.client.renderer.tileentity.TileEntitySpecialRenderer;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.ResourceLocation;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

@SideOnly(Side.CLIENT)
public class TileEntityWhiteChestRenderer extends TileEntitySpecialRenderer
{
    private static final ResourceLocation textureTrappedDouble = new ResourceLocation("mw:textures/entities/chest/trapped_double_white.png");
    private static final ResourceLocation textureNormalDouble = new ResourceLocation("mw:textures/entities/chest/normal_double_white.png");
    private static final ResourceLocation textureTrapped = new ResourceLocation("mw:textures/entities/chest/trapped_white.png");
    private static final ResourceLocation textureNormal = new ResourceLocation("mw:textures/entities/chest/normal_white.png");
    
    private static final ResourceLocation textureChristmasDouble = new ResourceLocation("textures/entity/chest/christmas_double.png");
    private static final ResourceLocation textureChristmas = new ResourceLocation("textures/entity/chest/christmas.png");
    private ModelChest simpleChest = new ModelChest();
    private ModelChest largeChest = new ModelLargeChest();
    private boolean isChristams;

    public TileEntityWhiteChestRenderer()
    {
        Calendar calendar = Calendar.getInstance();

        if (calendar.get(2) + 1 == 12 && calendar.get(5) >= 24 && calendar.get(5) <= 26)
        {
            this.isChristams = true;
        }
    }

    public void func_180538_a(TileEntityWhiteChest tileentitywhitechest, double par2, double par3, double par4, float par5, int par6)
    {
        int j;

        if (!tileentitywhitechest.hasWorldObj())
        {
            j = 0;
        }
        else
        {
            Block block = tileentitywhitechest.getBlockType();
            j = tileentitywhitechest.getBlockMetadata();

            if (block instanceof BlockWhiteChest && j == 0)
            {
                ((BlockWhiteChest)block).checkForSurroundingChests(tileentitywhitechest.getWorld(), tileentitywhitechest.getPos(), tileentitywhitechest.getWorld().getBlockState(tileentitywhitechest.getPos()));
                j = tileentitywhitechest.getBlockMetadata();
            }

            tileentitywhitechest.checkForAdjacentChests();
        }

        if (tileentitywhitechest.adjacentChestZNeg == null && tileentitywhitechest.adjacentChestXNeg == null)
        {
            ModelChest modelchest;

            if (tileentitywhitechest.adjacentChestXPos == null && tileentitywhitechest.adjacentChestZPos == null)
            {
                modelchest = this.simpleChest;

                if (par6 >= 0)
                {
                    this.bindTexture(DESTROY_STAGES[par6]);
                    GlStateManager.matrixMode(5890);
                    GlStateManager.pushMatrix();
                    GlStateManager.scale(4.0F, 4.0F, 1.0F);
                    GlStateManager.translate(0.0625F, 0.0625F, 0.0625F);
                    GlStateManager.matrixMode(5888);
                }
                else if (tileentitywhitechest.getChestType() == 1)
                {
                    this.bindTexture(textureTrapped);
                }
                else if (this.isChristams)
                {
                    this.bindTexture(textureChristmas);
                }
                else
                {
                    this.bindTexture(textureNormal);
                }
            }
            else
            {
                modelchest = this.largeChest;

                if (par6 >= 0)
                {
                    this.bindTexture(DESTROY_STAGES[par6]);
                    GlStateManager.matrixMode(5890);
                    GlStateManager.pushMatrix();
                    GlStateManager.scale(8.0F, 4.0F, 1.0F);
                    GlStateManager.translate(0.0625F, 0.0625F, 0.0625F);
                    GlStateManager.matrixMode(5888);
                }
                else if (tileentitywhitechest.getChestType() == 1)
                {
                    this.bindTexture(textureTrappedDouble);
                }
                else if (this.isChristams)
                {
                    this.bindTexture(textureChristmasDouble);
                }
                else
                {
                    this.bindTexture(textureNormalDouble);
                }
            }

            GlStateManager.pushMatrix();
            GlStateManager.enableRescaleNormal();

            if (par6 < 0)
            {
                GlStateManager.color(1.0F, 1.0F, 1.0F, 1.0F);
            }

            GlStateManager.translate((float)par2, (float)par3 + 1.0F, (float)par4 + 1.0F);
            GlStateManager.scale(1.0F, -1.0F, -1.0F);
            GlStateManager.translate(0.5F, 0.5F, 0.5F);
            short short1 = 0;

            if (j == 2)
            {
                short1 = 180;
            }

            if (j == 3)
            {
                short1 = 0;
            }

            if (j == 4)
            {
                short1 = 90;
            }

            if (j == 5)
            {
                short1 = -90;
            }

            if (j == 2 && tileentitywhitechest.adjacentChestXPos != null)
            {
                GlStateManager.translate(1.0F, 0.0F, 0.0F);
            }

            if (j == 5 && tileentitywhitechest.adjacentChestZPos != null)
            {
                GlStateManager.translate(0.0F, 0.0F, -1.0F);
            }

            GlStateManager.rotate((float)short1, 0.0F, 1.0F, 0.0F);
            GlStateManager.translate(-0.5F, -0.5F, -0.5F);
            float f1 = tileentitywhitechest.prevLidAngle + (tileentitywhitechest.lidAngle - tileentitywhitechest.prevLidAngle) * par5;
            float f2;

            if (tileentitywhitechest.adjacentChestZNeg != null)
            {
                f2 = tileentitywhitechest.adjacentChestZNeg.prevLidAngle + (tileentitywhitechest.adjacentChestZNeg.lidAngle - tileentitywhitechest.adjacentChestZNeg.prevLidAngle) * par5;

                if (f2 > f1)
                {
                    f1 = f2;
                }
            }

            if (tileentitywhitechest.adjacentChestXNeg != null)
            {
                f2 = tileentitywhitechest.adjacentChestXNeg.prevLidAngle + (tileentitywhitechest.adjacentChestXNeg.lidAngle - tileentitywhitechest.adjacentChestXNeg.prevLidAngle) * par5;

                if (f2 > f1)
                {
                    f1 = f2;
                }
            }

            f1 = 1.0F - f1;
            f1 = 1.0F - f1 * f1 * f1;
            modelchest.chestLid.rotateAngleX = -(f1 * (float)Math.PI / 2.0F);
            modelchest.renderAll();
            GlStateManager.disableRescaleNormal();
            GlStateManager.popMatrix();
            GlStateManager.color(1.0F, 1.0F, 1.0F, 1.0F);

            if (par6 >= 0)
            {
                GlStateManager.matrixMode(5890);
                GlStateManager.popMatrix();
                GlStateManager.matrixMode(5888);
            }
        }
    }

    public void renderTileEntityAt(TileEntity tileentitywhitechest, double posX, double posZ, double par4, float par5, int par6)
    {
        this.func_180538_a((TileEntityWhiteChest)tileentitywhitechest, posX, posZ, par4, par5, par6);
    }
}

Of course it has been properly registered in the Client Proxy with

ClientRegistry.bindTileEntitySpecialRenderer(TileEntityWhiteChest.class, new TileEntityWhiteChestRenderer());

 

If any other files or informations are needed please aks them :) Thanks in advance for all who will help me, have a nice day :D

Don't blame me if i always ask for your help. I just want to learn to be better :)

Link to comment
Share on other sites

Hi

 

This tutorial project has some examples of block models

https://github.com/TheGreyGhost/MinecraftByExample

 

Some more background info on block models here

http://greyminecraftcoder.blogspot.com.au/p/list-of-topics.html

and troubleshooting those missing texture problems here

http://greyminecraftcoder.blogspot.com.au/2015/03/troubleshooting-block-and-item-rendering.html

 

-TGG

Link to comment
Share on other sites

Hi, thanks for your response :) So, i've now a chest rendering in my inventory but it's a normal chest. I mean: i expect to render a white chest in inventory. The #1 problem was that i don't have a "white_chest.json" file in my item folder, and all the content of that file is:

{
    "parent": "builtin/entity"
}

How can i change that? Is it related to the fact that the BlockWhiteChest is extending the BlockChest?

This is the block class

package mw.blocks.colored.chests;

import java.util.Iterator;

import mw.core.utils.Utils;
import mw.entities.tileentity.colored.TileEntityWhiteChest;
import net.minecraft.block.Block;
import net.minecraft.block.BlockChest;
import net.minecraft.block.state.IBlockState;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.passive.EntityOcelot;
import net.minecraft.inventory.InventoryLargeChest;
import net.minecraft.item.ItemStack;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.AxisAlignedBB;
import net.minecraft.util.BlockPos;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.MathHelper;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.ILockableContainer;
import net.minecraft.world.World;


public class BlockWhiteChest extends BlockChest
{
private int chestType;

    public BlockWhiteChest(int type, String name)
    {
        super(type);
        this.chestType = type;
        this.setDefaultState(this.blockState.getBaseState().withProperty(FACING, EnumFacing.NORTH));
        Utils.setColorChestBlockInfo(this, name, 2.5F, Block.soundTypeWood);
    }

    public void onBlockPlacedBy(World worldIn, BlockPos pos, IBlockState state, EntityLivingBase placer, ItemStack stack)
    {
        EnumFacing enumfacing = EnumFacing.getHorizontal(MathHelper.floor_double((double)(placer.rotationYaw * 4.0F / 360.0F) + 0.5D) & 3).getOpposite();
        state = state.withProperty(FACING, enumfacing);
        BlockPos blockpos1 = pos.north();
        BlockPos blockpos2 = pos.south();
        BlockPos blockpos3 = pos.west();
        BlockPos blockpos4 = pos.east();
        boolean flag = this == worldIn.getBlockState(blockpos1).getBlock();
        boolean flag1 = this == worldIn.getBlockState(blockpos2).getBlock();
        boolean flag2 = this == worldIn.getBlockState(blockpos3).getBlock();
        boolean flag3 = this == worldIn.getBlockState(blockpos4).getBlock();

        if (!flag && !flag1 && !flag2 && !flag3)
        {
            worldIn.setBlockState(pos, state, 3);
        }
        else if (enumfacing.getAxis() == EnumFacing.Axis.X && (flag || flag1))
        {
            if (flag)
            {
                worldIn.setBlockState(blockpos1, state, 3);
            }
            else
            {
                worldIn.setBlockState(blockpos2, state, 3);
            }

            worldIn.setBlockState(pos, state, 3);
        }
        else if (enumfacing.getAxis() == EnumFacing.Axis.Z && (flag2 || flag3))
        {
            if (flag2)
            {
                worldIn.setBlockState(blockpos3, state, 3);
            }
            else
            {
                worldIn.setBlockState(blockpos4, state, 3);
            }

            worldIn.setBlockState(pos, state, 3);
        }

        if (stack.hasDisplayName())
        {
            TileEntity tileentity = worldIn.getTileEntity(pos);

            if (tileentity instanceof TileEntityWhiteChest)
            {
                ((TileEntityWhiteChest)tileentity).setCustomName(stack.getDisplayName());
            }
        }
    }

    public ILockableContainer getLockableContainer(World worldIn, BlockPos pos)
    {
        TileEntity tileentity = worldIn.getTileEntity(pos);

        if (!(tileentity instanceof TileEntityWhiteChest))
        {
            return null;
        }
        else
        {
            Object object = (TileEntityWhiteChest)tileentity;

            if (this.isBlocked(worldIn, pos))
            {
                return null;
            }
            else
            {
                Iterator iterator = EnumFacing.Plane.HORIZONTAL.iterator();

                while (iterator.hasNext())
                {
                    EnumFacing enumfacing = (EnumFacing)iterator.next();
                    BlockPos blockpos1 = pos.offset(enumfacing);
                    Block block = worldIn.getBlockState(blockpos1).getBlock();

                    if (block == this)
                    {
                        if (this.isBlocked(worldIn, blockpos1))
                        {
                            return null;
                        }

                        TileEntity tileentity1 = worldIn.getTileEntity(blockpos1);

                        if (tileentity1 instanceof TileEntityWhiteChest)
                        {
                            if (enumfacing != EnumFacing.WEST && enumfacing != EnumFacing.NORTH)
                            {
                                object = new InventoryLargeChest("container.chestDouble.white", (ILockableContainer)object, (TileEntityWhiteChest)tileentity1);
                            }
                            else
                            {
                                object = new InventoryLargeChest("container.chestDouble.white", (TileEntityWhiteChest)tileentity1, (ILockableContainer)object);
                            }
                        }
                    }
                }

                return (ILockableContainer)object;
            }
        }
    }

    /**
     * Returns a new instance of a block's tile entity class. Called on placing the block.
     */
    public TileEntity createNewTileEntity(World worldIn, int meta)
    {
        return new TileEntityWhiteChest(this.chestType);
    }

    public int isProvidingWeakPower(IBlockAccess worldIn, BlockPos pos, IBlockState state, EnumFacing side)
    {
        if (!this.canProvidePower())
        {
            return 0;
        }
        else
        {
            int i = 0;
            TileEntity tileentity = worldIn.getTileEntity(pos);

            if (tileentity instanceof TileEntityWhiteChest)
            {
                i = ((TileEntityWhiteChest)tileentity).numPlayersUsing;
            }

            return MathHelper.clamp_int(i, 0, 15);
        }
    }

    private boolean isBlocked(World worldIn, BlockPos pos)
    {
        return this.isBelowSolidBlock(worldIn, pos) || this.isOcelotSittingOnChest(worldIn, pos);
    }

    private boolean isBelowSolidBlock(World worldIn, BlockPos pos)
    {
        return worldIn.isSideSolid(pos.up(), EnumFacing.DOWN, false);
    }

    private boolean isOcelotSittingOnChest(World worldIn, BlockPos pos)
    {
        Iterator iterator = worldIn.getEntitiesWithinAABB(EntityOcelot.class, new AxisAlignedBB((double)pos.getX(), (double)(pos.getY() + 1), (double)pos.getZ(), (double)(pos.getX() + 1), (double)(pos.getY() + 2), (double)(pos.getZ() + 1))).iterator();
        EntityOcelot entityocelot;

        do
        {
            if (!iterator.hasNext())
            {
                return false;
            }

            Entity entity = (Entity)iterator.next();
            entityocelot = (EntityOcelot)entity;
        }
        while (!entityocelot.isSitting());

        return true;
    }
}

I also notice that breaking the chest gives the "Missing Texture" particles, i'm sure it's realted to the fact that i don't have a block model file for the chest (but as i said above, i don't know how to write it, since i have no reference for chests in particular).

Here is two screenshots to better show you what i've described (i know my english is bad, sorry :( )

rXjlL87.png

kPzhJzV.png

Unfortunately problems #2 and #3 are still there, i know how to make blockstates but i don't know how to make it for a chest :/

I'm sorry if i'm making too much questions, but unfortunately i haven't found tutorials or references about the chests in particular :(

Don't blame me if i always ask for your help. I just want to learn to be better :)

Link to comment
Share on other sites

Hi

 

For your item, just use a json model file for a normal item (see the MinecraftByExample for some examples of just a simple item).  Your current json builtin/entity says "use the TileEntitySpecialRenderer for this item" which defaults to the vanilla chest it seems.

 

Your missing texture when you smash the block -

you can generate them yourself using Block.addDestroyEffects(), or alternative you can add a "particle" texture to your model json.

 

If you want to trace through in the code to see where it is getting your blocks' destruction texture from, you can put a breakpoint into Block.addDestroyEffects() or alternatively EffectRenderer.func_180533_a()

 

-TGG

 

Link to comment
Share on other sites

Thanks for your answer :) For the item i can't understand how to change that texture since for the chest i don't have an icon (it's just the texture for the model like normal one), so how can i tell in the json file: "use this texture but be careful beacuse is not an icon but a texture for a model?" Or perhaps there is a way to tell what specific TileEntitySpecialRender it will use? I know how to make a normal item json file ;) Same for the model, how can i tell him that "it's not a normal block, it's a chest, and there's no "normal" texture, only for the model"? I'm literally going crazy about this :/ The only references for blockstates and block/item model json files i found are for normal blocks/items (wich i know how to make them), but for the chest in particular (ora any other block that has a texture made by an entity) i don't find anything :(

Don't blame me if i always ask for your help. I just want to learn to be better :)

Link to comment
Share on other sites

Ok, quick update :D Thanks to your answer i now have particles, i've made this blockstate file:

{
    "variants": {
        "facing=east": { "model": "mw:white_chest" },
	"facing=west": { "model": "mw:white_chest" },
	"facing=north": { "model": "mw:white_chest" },
	"facing=south": { "model": "mw:white_chest" }
    }
}

and this block model file:

{
    "parent": "block/cube",
    "textures": {
        "particle": "mw:blocks/colors/planks_oak_colored_white"
    }
}

 

Still try to understand how to change it's rendering in inventory :/

Don't blame me if i always ask for your help. I just want to learn to be better :)

Link to comment
Share on other sites

I've tried to do this as my item model file:

{
    "parent": "builtin/entity",
    "textures": {
        "layer0": "mw:blocks/colors/planks_oak_colored_white"
    }
}

but nothing happens, still render as a normal chest :(

Don't blame me if i always ask for your help. I just want to learn to be better :)

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.