Jump to content

[Solved | 1.7.10] How to detect Right Clicks with items?


noahc3

Recommended Posts

Hey, I'm having some issues with detecting right clicks with an item.

 

Here is the code I'm using:

 

public ItemStack onItemRightClick(ItemStack itemstack, World par2World, EntityPlayer par3EntityPlayer)
{
        if(itemstack.stackTagCompound.getInteger("enabled") == 1)
        {
        	itemstack.stackTagCompound.setInteger("enabled", 0);
		System.out.println("Was Enabled, now Disabled");
             return null;
        }
        else
        {
        	itemstack.stackTagCompound.setInteger("enabled", 1);
		 System.out.println("Was Disabled, now Enabled");
		 return null;
        }
}

 

Minecraft successfully loads, but right clicking the item crashes the game. (But it does detect the right click as sysout prints to console)

 

Any help would be appreciated.

Link to comment
Share on other sites

Wait... Why are you returning null??? You have to return the itemstack provided (I'm pretty sure). I think that's why if it is a null pointer. Problem solved.

No, you can return null to set the current item to nothing. EDIT: I stand corrected :P

 

@OP Your problem is you are using the NBT tag directly without checking if it exists - ItemStacks generally do not have an NBT tag until you give them one.

if (!itemstack.hasTagCompound()) {
   itemstack.setTagCompound(new NBTTagCompound());
}

Link to comment
Share on other sites

@AwesomeSpider Thanks, switching it to return itemstack fixed it. Yea, it was a nullpointer exception.

 

@coolAlias I have created the NBT tag further in the code with this:

 

if(itemstack.stackTagCompound == null){
		 itemstack.stackTagCompound = new NBTTagCompound();
		 itemstack.stackTagCompound.setInteger("timer", 24000);
		 itemstack.stackTagCompound.setInteger("enabled", 0);
		 }

 

 

Thanks for the help.

 

That's inside onUpdate.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.