noahc3 Posted July 12, 2015 Share Posted July 12, 2015 Hey, I'm having some issues with detecting right clicks with an item. Here is the code I'm using: public ItemStack onItemRightClick(ItemStack itemstack, World par2World, EntityPlayer par3EntityPlayer) { if(itemstack.stackTagCompound.getInteger("enabled") == 1) { itemstack.stackTagCompound.setInteger("enabled", 0); System.out.println("Was Enabled, now Disabled"); return null; } else { itemstack.stackTagCompound.setInteger("enabled", 1); System.out.println("Was Disabled, now Enabled"); return null; } } Minecraft successfully loads, but right clicking the item crashes the game. (But it does detect the right click as sysout prints to console) Any help would be appreciated. Quote Link to comment Share on other sites More sharing options...
Awesome_Spider Posted July 12, 2015 Share Posted July 12, 2015 Show your crash report. If it is a NullPointerException, they are easy to diagnose. Quote Link to comment Share on other sites More sharing options...
Awesome_Spider Posted July 12, 2015 Share Posted July 12, 2015 Wait... Why are you returning null??? You have to return the itemstack provided (I'm pretty sure). I think that's why if it is a null pointer. Problem solved. Quote Link to comment Share on other sites More sharing options...
coolAlias Posted July 12, 2015 Share Posted July 12, 2015 Wait... Why are you returning null??? You have to return the itemstack provided (I'm pretty sure). I think that's why if it is a null pointer. Problem solved. No, you can return null to set the current item to nothing. EDIT: I stand corrected @OP Your problem is you are using the NBT tag directly without checking if it exists - ItemStacks generally do not have an NBT tag until you give them one. if (!itemstack.hasTagCompound()) { itemstack.setTagCompound(new NBTTagCompound()); } Quote http://i.imgur.com/NdrFdld.png[/img] Link to comment Share on other sites More sharing options...
noahc3 Posted July 12, 2015 Author Share Posted July 12, 2015 @AwesomeSpider Thanks, switching it to return itemstack fixed it. Yea, it was a nullpointer exception. @coolAlias I have created the NBT tag further in the code with this: if(itemstack.stackTagCompound == null){ itemstack.stackTagCompound = new NBTTagCompound(); itemstack.stackTagCompound.setInteger("timer", 24000); itemstack.stackTagCompound.setInteger("enabled", 0); } Thanks for the help. That's inside onUpdate. Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.