[Almost Solved][1.8] Detect Player Using Furnace or Craft's an item

[PlayPrey 0]

Hello, this is something I could do fine (3 years ago)... Now I returned and see that this is completely diffrent.

How do I check if the player has smelted or crafted an item?

 

I tried:

 

public class CraftingHandler (Usually I could implement CraftingHandler, however its now gone??? )

{

@SubscribeEvent

public void onSmelt(EntityPlayer player, ItemStack item)

{

if (item == new ItemStack(Items.baked_potato))

        {

                player.addStat(AE.bakePotato, 1);

        }

}

}

 

I am sorry for all the stupid questions, but it has been a long time since I modded Minecraft, I lost almost all the knowledge I had

 

[Draco18s 2096]

Creating is an event now.

[diesieben07 6689]

PlayerEvent.ItemSmeltedEvent is the event. Also you cannot compare ItemStacks that way. Please learn what == does in Java.

[iame6162013 0]

"item == new ItemStack(Items.baked_potato)" I think this is wrong... (because nothing will ever be == to it.)

[PlayPrey 0]

Hmm, just noticed that some code didnt get pasted.

 

So I got;

 

@SubscribeEvent

public void onSmelt(PlayerEvent.ItemSmeltedEvent e)

{

EntityPlayer player = (EntityPlayer) e.player;

player.addChatMessage(new ChatComponentText("TYETJOASD"));

if (e.smelting.equals(Items.baked_potato))

        {

                player.addStat(AE.bakePotato 1);

        }

}

 

But the achievement is still not unlocking, neither am I getting the chat message.

 

What am I missing here?

 

(Also; I do know basic Java, but it has been 3 years since I programmed with Java, so things go about slowly. Also; Forge was diffrent back then.. Very diffrent , Nothing of my old code was usable.. )

 

So I am sorry for the stupid questions; I really am. But how do I compare with the event, and an Item?

 

(Also x2: I know what == does, it compares 2 values to see if theyre the same... right? )

[diesieben07 6689]

Ok, now you are comparing ItemStack with Item using equals. Do not tell me you know Java if you code that.

ItemStack has getItem method.

 

Did you register your event handler? If not: there is your problem. If yes: show the code.

[PlayPrey 0]

Hehe sorry; Dont know why I tried equals.

 

Here's the up to date code: (Not including the proxy classes)

 

Main.java

http://pastebin.com/9PCZ05hS

 

CraftingHandler.java

http://pastebin.com/qz4RKLx7

 

Additional notes;

-Yes the achievement is being registered.

-The other handler's (found in main.java) work fine for what I use them for.

[diesieben07 6689]

ItemCraftedEvent is an FML event, you have to use the FML EventBus (FMLCommonHandler.instance().bus()).

[PlayPrey 0]

Thank you! The game now gives the achievement and outputs the text!

 

Just wondering though, why does the message appear at a random amount? Sometimes I get the message 4 times, sometimes 2, others 5 and so on...

If I were to try and count the amount of times something has been smelted, I would get a completely wrong resoult.

 

(int bakedPotatos;

(inside method)

 

bakedPotatos += 1;  )

 

If I did that It would get more than just one.

[diesieben07 6689]

That's not what the event is for, the event is pretty much just for achievements. The vanilla code for this is messy. The event fires in the same location that vanilla checks for achievements.