Jump to content

ItemSmeltedEvent stack size 0 when shift-clicking


Zetal

Recommended Posts

 

@SubscribeEvent

public void onSmelted(PlayerEvent.ItemSmeltedEvent event)

{

ItemStack stack = event.smelting;

                System.out.println(stack);

        }

 

 

Regular clicking when there are 3 stacks gives a stack size of 3.

Shiftclicking when there are 3 stacks gives a stack size of 0. How can I get the true stacksize?

Have a modding question? PM me and hopefully I'll be able to help. Good at 2d Pixel Art? We need your help!  http://www.minecraftforum.net/topic/1806355-looking-for-2d-pixel-artist/

Link to comment
Share on other sites

ItemSmeltedEvent is called when a player takes the finished item out of the Furnace. They can do this by either clicking the item and picking it up on their cursor (this functions, and the stack size is reported correctly) or they can hold down shift and left-click the itemstack, which does not correctly report the stack size.

 

I'm using Forge 1.8, Build 1433.

Have a modding question? PM me and hopefully I'll be able to help. Good at 2d Pixel Art? We need your help!  http://www.minecraftforum.net/topic/1806355-looking-for-2d-pixel-artist/

Link to comment
Share on other sites

If anyone in Olympus (forge gods, hear me!) is interested in this issue, I believe it can be fixed in SlotFurnaceOutput at line 99 by changing

        this.field_75228_b = 0;

        net.minecraftforge.fml.common.FMLCommonHandler.instance().firePlayerSmeltedEvent(thePlayer, stack);

 

to

 

       stack.stacksize = this.field_75228_b;
       net.minecraftforge.fml.common.FMLCommonHandler.instance().firePlayerSmeltedEvent(thePlayer, stack);

       this.field_75228_b = 0;

Have a modding question? PM me and hopefully I'll be able to help. Good at 2d Pixel Art? We need your help!  http://www.minecraftforum.net/topic/1806355-looking-for-2d-pixel-artist/

Link to comment
Share on other sites

I've looked into it as much as anyone can be expected to and I don't see how that would affect anything. "stack" is a parameter passed in, so changing it wouldn't affect anything outside of the method. In this case, another solution would be adding an 'amount' variable to the "firePlayerSmeltedEvent" method but simply setting the stacksize to the "field_75228_b" is the easier solution.

 

Thanks for the response. I'd appreciate an explanation, as extensive searching hasn't led to your conclusion.

Have a modding question? PM me and hopefully I'll be able to help. Good at 2d Pixel Art? We need your help!  http://www.minecraftforum.net/topic/1806355-looking-for-2d-pixel-artist/

Link to comment
Share on other sites

Try out this code:

public static class Main {
  private static class Foo {
    public String bar = "bar";
  }
  public static void main(String... args) {
    Foo foo = new Foo();
    System.out.println("Foo: " + foo.bar);
    buzz(foo);
    System.out.println("Foo? " + foo.bar);
  }
  public static void buzz(Foo foo){
    foo.bar = "wat?";
  }
}

 

Note: your change doesnt take into account machines/that double call thing.

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

Link to comment
Share on other sites

Well! You learn something new every day. Thank you for helping me clear that up!

 

Onwards! I don't see any reason to not just add a new variable to the ItemSmeltedEvent "amount" that takes in the "field_75228_b" variable. Would be a bit more work, but accomplish the same thing I had intended. And I'm almost positive it wouldn't affect anything, since "field_75228_b" is set to 0 immediately afterwards anyways.

Have a modding question? PM me and hopefully I'll be able to help. Good at 2d Pixel Art? We need your help!  http://www.minecraftforum.net/topic/1806355-looking-for-2d-pixel-artist/

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.