[1.7.10] Lag with Chunk.Load event For discovery of new Biomes

[Jershy]

            What i'm trying to do is create a List of the loaded biomes in that world as well as a list of all the loaded biomes inside the player(s) render distance. So what did was create an event class that uses the Chunk.Load event and find new biomes.

 

CLASS;

 package src.IVWeather.sideWorldHandlers;

import java.util.ArrayList;
import java.util.List;

import src.IVWeather.biome.BiomeTemperatureIndex;
import src.IVWeather.entity.EntityWeatherAirmass;
import cpw.mods.fml.common.eventhandler.SubscribeEvent;
import net.minecraft.entity.passive.EntityChicken;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.util.ChatComponentText;
import net.minecraft.util.IChatComponent;
import net.minecraft.world.World;
import net.minecraft.world.biome.BiomeCache;
import net.minecraft.world.biome.BiomeGenBase;
import net.minecraft.world.chunk.Chunk;
import net.minecraftforge.client.event.RenderGameOverlayEvent.Chat;
import net.minecraftforge.event.terraingen.BiomeEvent;
import net.minecraftforge.event.world.ChunkEvent;
import net.minecraftforge.event.world.ChunkEvent.Load;

public class ChunkLoadHandler {

public List LoadedBiomes = new ArrayList();

public ChunkLoadHandler() {
	super();
}

Chunk chunk;
World worldObj;

@SubscribeEvent
public void eventSpawnAirmassOnLoad(ChunkEvent.Load event) {

			int blockX = event.getChunk().xPosition << 4;
			int blockZ = event.getChunk().zPosition << 4;
				BiomeGenBase bgb = event.world.getBiomeGenForCoords(blockX, blockZ);
				BiomeGenBase bgb1;
		System.out.println(bgb.getClass().getName());
	if(LoadedBiomes.size() == 0) {

			this.LoadedBiomes.add(bgb);
			System.out.println("ADDED BIOME TO LOAD LIST");
		}else{
			for(int w = 0; w < this.LoadedBiomes.size(); w++) {

				BiomeGenBase iLikeFire = (BiomeGenBase) LoadedBiomes.get(w);

				if(iLikeFire != bgb) {

					this.LoadedBiomes.add(bgb);
					System.out.println("ADDED BIOME TO LOAD LIST");

				}
			}
		}
	}



}

 

This causes noticeable lag in the world and I would like to do something to reduce the lag.

 

Thank You for reading

[Draco18s]

That is not how you make an array of unique objects.

 

indexOf() and contains() exist, use them.

 

Secondly, you add a copy of the biome to the array for every non-matching entry, so your method doubly fails the "unique instances only" requirement:

 

array = {plains, mountains}
newBiome = plains
//loop
does newBiome == plains? yes.  next
does newBiome == mountains?  no, add it to array
//end loop
array = {plains, mountains, plains}

[Jershy]

i looked in the tutorials and tried to find how to save Lists and Objects to NBTs  but i could not find how to do that.