Jump to content

[1.7.10] Tile entity update problems


limexplosion7

Recommended Posts

I am making a machine and have all the things ready (gui,slots,container) but the (!worldObj.isRemote) condition is not triggering in the updateEntity() regardless of any changes I have made to it.

package limemods.advpwrsys;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.inventory.ISidedInventory;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagList;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.item.ItemStack;
import cofh.api.energy.IEnergyReceiver;
import cofh.api.energy.EnergyStorage;
import net.minecraftforge.common.util.ForgeDirection;

public class TileEntityProcessor extends TileEntity implements ISidedInventory
{
    protected EnergyStorage energy = new EnergyStorage(32000);
    private ItemStack[] slots = new ItemStack[3];
    public int cycleTime;
    private String customName;

    private static final int[] slots_top = new int[] {0,1};
    private static final int[] slots_bottom = new int[] {2};

    public int getEnergyScaled()
    {
        return (energy.getEnergyStored() * 62 / 32000);
    }

    public int getProgressScaled()
    {
        return (cycleTime * 24 / 80);
    }

    public void writeToNBT(NBTTagCompound nbt)
    {
        super.writeToNBT(nbt);

        nbt.setShort("CycleTime", (short)cycleTime);
        NBTTagList list = new NBTTagList();
        for (int i = 0; i < slots.length; i++)
        {
            if (slots[i]!=null) {
                NBTTagCompound nbt1 = new NBTTagCompound();
                nbt1.setByte("Slot", (byte) i);
                slots[i].writeToNBT(nbt1);
                list.appendTag(nbt1);
            }
        }
        nbt.setTag("Items",list);
    }

    public void readFromNBT(NBTTagCompound nbt)
    {
        super.readFromNBT(nbt);
        NBTTagList list = nbt.getTagList("Items", 10);
        slots = new ItemStack[getSizeInventory()];
        for (int i = 0; i < list.tagCount(); i++)
        {
            NBTTagCompound nbt1 = (NBTTagCompound)list.getCompoundTagAt(i);
            byte b0 = nbt1.getByte("Slot");
            if (b0 >= 0 && b0 < slots.length)
            {
                slots[b0] = ItemStack.loadItemStackFromNBT(nbt1);
            }
        }
        cycleTime = nbt.getShort("CycleTime");
    }

    public void updateEntity()
    {
        boolean f = cycleTime > 0;
        boolean f1 = false;

        if (!worldObj.isRemote)
        {
            if (canCycle())
            {
                cycleTime++;
                if (cycleTime == 40)
                {
                    cycleTime = 0;
                    cycle();
                    f1 = true;
                }
                else {
                    cycleTime = 0;
                }
            }
            if (f != cycleTime > 0)
            {
                f1 = true;
                BlockProcessor.updateBlockState(cycleTime > 0, worldObj, xCoord,yCoord,zCoord);
            }
        }
        if (f1)
        {
            this.markDirty();
        }
    }

    private void cycle()
    {
        if (canCycle())
        {
            ItemStack is = ProcessorRecipes.getOutput(slots[0].getItem(), slots[1].getItem());
            if (slots[2] == null)
            {
                slots[2] = is.copy();
            }
            else if (slots[2].isItemEqual(is))
            {
                slots[2].stackSize+=1;
            }

            for (int i = 0; i<2;i++)
            {
                if (slots[i].stackSize <= 0) {
                    slots[i] = new ItemStack(slots[i].getItem().setFull3D());
                }else{
                    slots[i].stackSize--;
                }
                if(slots[i].stackSize<=0) {
                    slots[i] = null;
                }
            }
        }
    }

    public boolean canExtractItem(int i, ItemStack itemstack, int j) {
        return j != 0 || i != 1;
    }

    public int getInventoryStackLimit() {return 64;}

    private boolean canCycle()
    {
        // TODO: Restore energy requirement
        if (slots[0] == null || slots[1] == null){
            return false;
        }
        ItemStack is = ProcessorRecipes.getOutput(slots[0].getItem(), slots[1].getItem());
        if (is==null){return false;}
        if(slots[2]==null){return true;}
        if(!slots[2].isItemEqual(is)){return false;}
        //if (energy.getEnergyStored() < 800) {return false;}
        if(slots[2].stackSize < getInventoryStackLimit() && slots[3].stackSize < slots[3].getMaxStackSize()){ return true;} else{return false;}
    }

    public int[] getAccessibleSlotsFromSide(int i) {
        return i == 0 ? slots_bottom : slots_top;
    }

    public boolean canConnectEnergy(ForgeDirection fd) {return true;}

    public int receiveEnergy(ForgeDirection fd, int i, boolean b)
    {
        return energy.receiveEnergy(i,b);
    }

    public int getEnergyStored(ForgeDirection fd)
    {
        return energy.getEnergyStored();
    }

    public int getMaxEnergyStored(ForgeDirection fd)
    {
        return energy.getMaxEnergyStored();
    }

    public ItemStack decrStackSize(int i, int j) {
        if(this.slots[i] != null){
            ItemStack is;

            if(this.slots[i].stackSize <= j ){
                is = this.slots[i];
                this.slots[i] = null;
                return is;
            }else{
                is = this.slots[i].splitStack(j);

                if(this.slots[i].stackSize == 0) {
                    this.slots[i] = null;
                }

                return is;
            }
        }else{
            return null;
        }
    }

    public boolean isItemValidForSlot(int i, ItemStack is) {return i!=2;}

    public boolean canInsertItem(int i, ItemStack is, int j) {
        return this.isItemValidForSlot(i, is);
    }

    public void setInventorySlotContents(int i, ItemStack is) {
        slots[i] = is;
        if (is != null && is.stackSize > this.getInventoryStackLimit()) {
            is.stackSize = this.getInventoryStackLimit();
        }
    }

    public String getInventoryName(){return "container.processor";}

    public boolean hasCustomInventoryName(){return customName != null && customName.length() > 0;}

    public ItemStack getStackInSlotOnClosing(int i) {
        if (slots[i] != null) {
            ItemStack is = slots[i];
            slots[i] = null;
            return is;
        }else{
            return null;
        }
    }

    public boolean isUseableByPlayer(EntityPlayer p) {
        if (worldObj.getTileEntity(xCoord, yCoord, zCoord) != this)
        {
            return false;
        }else{
            return p.getDistanceSq((double)xCoord+0.5D,(double)yCoord+0.5D,(double)zCoord+0.5D) <= 64;
        }
    }

    public ItemStack getStackInSlot(int i)
    {
        return slots[i];
    }

    public int getSizeInventory() {return slots.length;}

    public void openInventory(){}
    public void closeInventory(){}
}

Link to comment
Share on other sites

Yes, my block implements ITileEntityProvider and the tile entity is registered. Everything works, the GUI opens, the NBT tags are persistent, it just won't run the code inside the (!worldObj.isRemote). I removed that line to test it out but it didn't work either.

How do you know it is not running at all? Did you put some System.out.println statements inside the updateEntity method? If not, you should and see if they print to the console.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.