1.7.10 1231 is failing in setupDecomWorkspace

[arungupta]

Latest 1.7.10 (http://files.minecraftforge.net/maven/net/minecraftforge/forge/1.7.10-10.13.2.1231/forge-1.7.10-10.13.2.1231-src.zip) is giving a patch error:

 

Applying forge patches

Patching failed: net/minecraft/world/gen/feature/WorldGenDungeons.java Cannot find hunk target

  2: Cannot find hunk target @ 0

  1/3 failed

  Rejects written to /Users/arungupta/tools/minecraft/forge-1.7.10-1231/build/tmp/expandedArchives/forgepatches.zip_65do1hgfnb3dpj1qsdv38go5bq/net/minecraft/world/gen/feature/WorldGenDungeons.java.patch.rej

:remapJar

:extractMinecraftSrc

:recompMinecraft

warning: [options] bootstrap class path not set in conjunction with -source 1.6

Note: Some input files use or override a deprecated API.

Note: Recompile with -Xlint:deprecation for details.

Note: Some input files use unchecked or unsafe operations.

Note: Recompile with -Xlint:unchecked for details.

1 warning

:repackMinecraft

:setupDecompWorkspace

 

[arungupta]

Never mind, the correct order of commands is:

 

setupDevWorkspace setupDecompWorkspace eclipse

 

And now it does!

[LexManos]

you dont need dev if you do decomp.

If you get patch errors its because you're decompiling something odd, i would need to see your decompiled output.

[arungupta]

So just "setupDecompWorkspace eclipse" is enough to setup workspace where all the source files from forge can be correctly opened ?

 

Arun

[shieldbug1]

Yes.

[arungupta]

Thanks!

 

Once "setupDecompWorkspace" is invoked and the package is zipped, is the zip bundle platform agnostic and can be used on Windows, Mac, and Linux ?

[LexManos]

What do you mean by zipping the package?

[arungupta]

I download the XXX-src.zip from files.minecraftforge.net, run the gradlew commands, and zip up the bundle. This is then shared in a class setting so that all attendees don't have to go through the commands themselves. We call this "modkit".

 

Is the zip bundle such created would be platform agnostic ? Can the same bundle run on Windows and Mac ? Or even Linux ?

[arungupta]

Specifically ...

 

I create a zip bundle on Mac and when I unzip it on Windows and try to open the project in Eclipse, then the Minecraft project does not show up by default. When I try to explicitly import the project in Eclipse, then it says "No project found" or a similar message.

 

I tried building a zip package on a Windows machine (where project can be opened successfully) and unzipping on a different one. The Minecraft project is not showing up on the other machine.

 

The bundles are available at: https://github.com/arun-gupta/forge-plugins

 

Any clues ?

 

Arun

[arungupta]

Ah, I suspected something like that.

 

Is there any thing that can be done to keep the installation confined to a single bundle ? This used to work very well with 1.6.4 bundles.

[LexManos]

Do not do this,

 

1) its very bad practice, if you're in a classroom environment you should be teaching people the correct procedures not 'here is a specific magic zip' We developed Forge/ForgeGradle so that it would be simple to use. If you can't get them to run a single command then there is bigger issues at play.

 

2) Redistributing that package is illegal as it contains copywritten mojang code, in many forms. Please remove them from github.

 

3) Diesieben is correct, a lot of the libraries and other materials are cached outside of this folder as to allow for faster subsequent development of different projects on the same machine. This is simply how gradle, or any other build system works.

 

Basically, What you are doing should not be done. For many reasons both technical and legal. And as such we will encourage you to do things properly by not supporting you.

[arungupta]

Sounds fair, I removed the files from github.

 

The classroom setting where I teach may not have Internet access. How do you recommend we work around that ?

 

Is there anyway, such a bundle can be provided on http://files.minecraftforge.net/ ?

[luacs1998]

Well, if you don't have internet access, you wouldn't be able to access files.minecraftforge.net anyway...

 

Consider setting up an internal maven repository: http://maven.apache.org/repository-management.html

[arungupta]

With no Internet, we can carry a zip file on a USB drive and get started that way. Configuring Maven on a 8-14-yrs old kid's machine is quite a harrowing task. We've done that multiple times and prefer to go the simpler route. Especially when 20-50 kids are involved in a classroom setting.

 

I'd really love to see an offline version of the installer. Any thoughts ?

 

 

[LexManos]

Not going to happen and not going to be supported.

It can be done if you want to spend to time and learn how gradle works.

However we can not support it due to legal reasons.

 

As for the setup not having internet, you can setup your own lan with a cheap laptop, setup the db on there and have the kids computers pull from that.

Anyways, there isnt much we can do to support you as I said because 1) you're in bad legal areas 2) it's out of our scope of support.

[arungupta]

OK, thanks for clarifying.