Is this the right way to check if the item in an ItemStack is an Item or a Block

[UntouchedWagons]

I want to check if the result of a crafting recipe is a block (planks, gold blocks, etc...) rather than an item. Is this the right way to check?

 

ItemStack result = recipe.getRecipeOutput();

Block result_block = Block.getBlockFromItem(result .getItem());

if (result_block != null)
    System.out.println("Yup the result is a block");

 

Likewise if I want to check if the result is an Item (fish, diamond sword, etc...):

 

ItemStack result = recipe.getRecipeOutput();

Item result_item = Item.getItemById(Item.getIdFromItem(result.getItem()));

if (result_item != null)
    System.out.println("Yup the result is an item");

 

Is this right?

[shieldbug1]

The top one for blocks is right. For items just use ItemStack#getItem directly.

[bcwadsworth]

It may be easier to do ItemStack.getItem() and check if it is an instance of ItemBlock. If it is, it is a block, if not it is an item.

 

if (result.getItem() instanceof ItemBlock)

{

//Code if the item is a block

}

else

{

//Code if the item is an item

}

[UntouchedWagons]

It may be easier to do ItemStack.getItem() and check if it is an instance of ItemBlock. If it is, it is a block, if not it is an item.

 

That's exactly what I want, thanks.