[Looking for explanation but SOLVED] Unprogrammed entity movement [1.7]

[david476]

I made an entity that the player is riding. when ridden both entities seem to jump up and down (not fluid) after a random amount of time. Probably some inconstancy between client and server or weird minecraft quirk. Hope someone can shed some light!

 

http://s28.postimg.org/he70lcdwt/2014_09_19_11_21_04.png[/img]

 

http://s27.postimg.org/kbay7orjn/2014_09_19_11_21_07.png[/img]

[david476]

bump

[TheGreyGhost]

Hi

 

Show some code?

 

I've found position logging to be extremely useful for this type of problem eg

System.out.println("position on side " + (this.worldObj.isRemote() ? "client" : "server") + " is [" + this.posX + ", " + this.posY + ", " + this.posZ + "]"  );

(in one of the entity's tick update methods)

 

That will show you if it really is a client/server mismatch, and might help you figure out where to look next.

 

-TGG

 

 

 

[david476]

Sorry, I should know better than to forget my code. Update: after adding a bit of code to the controller class (relating to bounding boxes and collision)  the controller and ship block go up after a second (possibly just after I mount it, happens automatically) but not back (instead of the seat).

 

According to:

class com.deb.debmodularships.entities.EntityController's position on side server is [-2475.5, 56.0, 785.5]

class com.deb.debmodularships.entities.EntityController's position on side client is [-2475.5, 56.0, 785.5]

 

class com.deb.debmodularships.entities.EntityController's position on side server is [-2475.5, 56.0, 785.5]

class com.deb.debmodularships.entities.EntityController's position on side client is [-2475.5, 57.0, 785.5]

 

it does seem to be a client issue.

 

Controller(screen, buttons)

package com.deb.debmodularships.entities;

import java.util.UUID;

import net.minecraft.entity.Entity;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.util.AxisAlignedBB;
import net.minecraft.world.World;

public class EntityController extends Entity {

public EntityShipSeat ShipCSeat = null;
public String ShipCSeatid = "";

public EntityController(World par1World) {
	super(par1World);
	this.setSize(1, 1);
}

@Override
protected void entityInit() {

}

@Override
public void readFromNBT(NBTTagCompound nbt) {
	super.readFromNBT(nbt);
	ShipCSeatid = nbt.getString("ShipCSeatid");
}

@Override
public void writeToNBT(NBTTagCompound nbt) {
	super.writeToNBT(nbt);
	nbt.setString("ShipCSeatid", ShipCSeat.getUniqueID().toString());
}

public void onUpdate() {
	//System.out.println(this.ShipCSeat);
	System.out.println(this.getClass() + "'s position on side " + (this.worldObj.isRemote ? "client" : "server") + " is [" + this.posX + ", " + this.posY + ", " + this.posZ + "]"  );
	if (ShipCSeat == null && this.ShipCSeatid != "") {
		this.worldObj.getLoadedEntityList();

		for (int i = 0; i < this.worldObj.getLoadedEntityList().size(); ++i) {
			if (this.worldObj.getLoadedEntityList().get(i) instanceof EntityShipSeat) {
				EntityShipSeat tested = (EntityShipSeat)this.worldObj.getLoadedEntityList().get(i);
				if (UUID.fromString(this.ShipCSeatid).equals(tested.getUniqueID())) {
					this.ShipCSeat = (EntityShipSeat)this.worldObj.getLoadedEntityList().get(i);
				}
			}
    		}
	}
}

@Override
public AxisAlignedBB getCollisionBox(Entity par1Entity)
{
	return this.boundingBox;
}

/**
 * returns the bounding box for this entity
 */
@Override
public AxisAlignedBB getBoundingBox()
{
	return this.boundingBox;
}

@Override
public boolean canBePushed()
    {
        return false;
    }

@Override
public boolean canBeCollidedWith()
{
	return true;
}

//IGNORE

@Override
protected void readEntityFromNBT(NBTTagCompound var1) {
	// TODO Auto-generated method stub

}

@Override
protected void writeEntityToNBT(NBTTagCompound var1) {
	// TODO Auto-generated method stub

}
}

 

Ship Block (plain)

package com.deb.debmodularships.entities;

import java.util.UUID;

import scala.reflect.internal.Trees.This;
import net.minecraft.entity.Entity;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.util.AxisAlignedBB;
import net.minecraft.world.World;

public class EntityShipBlock extends Entity {

public EntityController controller = null;
String controllerid = "";

public EntityShipBlock(World par1World) {
	super(par1World);
	this.setSize(1, 1);
}

@Override
public boolean interactFirst(EntityPlayer player) {
	//player.mountEntity(controller.ShipCSeat);
	if (this.controller != null && this.controller.ShipCSeat != null) {
		System.out.println(this.controller.ShipCSeat);
		player.mountEntity(controller.ShipCSeat);
	}
        return true;
    }

@Override
protected void entityInit() {
	AxisAlignedBB.getBoundingBox(-0.5d, -0.5d, -0.5d, 0.5d, 0.5d, 0.5d);
}

@Override
public void readFromNBT(NBTTagCompound nbt) {
	super.readFromNBT(nbt);
	this.controllerid = nbt.getString("controllerid");
}

@Override
public void writeToNBT(NBTTagCompound nbt) {
	super.writeToNBT(nbt);
	nbt.setString("controllerid", this.controller.getUniqueID().toString());
}

public void onUpdate() {
	System.out.println(this.getClass() + "'s position on side " + (this.worldObj.isRemote ? "client" : "server") + " is [" + this.posX + ", " + this.posY + ", " + this.posZ + "]"  );
	if (controller == null && this.controllerid != "") {
		this.worldObj.getLoadedEntityList();

		for (int i = 0; i < this.worldObj.getLoadedEntityList().size(); ++i) {
			if (this.worldObj.getLoadedEntityList().get(i) instanceof EntityController) {
				EntityController tested = (EntityController)this.worldObj.getLoadedEntityList().get(i);
				if (UUID.fromString(this.controllerid).equals(tested.getUniqueID())) {
					this.controller = (EntityController)this.worldObj.getLoadedEntityList().get(i);
				}
			}
    		}
	}
}

@Override
public AxisAlignedBB getCollisionBox(Entity par1Entity)
{
	return this.boundingBox;
}

/**
 * returns the bounding box for this entity
 */
@Override
public AxisAlignedBB getBoundingBox()
{
	return this.boundingBox;
}

@Override
public boolean canBePushed()
    {
        return false;
    }

@Override
public boolean canBeCollidedWith()
{
	return true;
}

@Override
protected void readEntityFromNBT(NBTTagCompound var1) {
	// TODO Auto-generated method stub

}

@Override
protected void writeEntityToNBT(NBTTagCompound var1) {
	// TODO Auto-generated method stub

}
}

 

Ship Seat (Short wooly one)

package com.deb.debmodularships.entities;

import net.minecraft.world.World;

public class EntityShipSeat extends EntityShipBlock {

public EntityShipSeat(World par1World) {
	super(par1World);
	this.setSize(1f, 0.25f);
	this.boundingBox.offset(0f, -0.5f, 0f);
}

public double getMountedYOffset() {
        return 0.3d;
    }

}

[david476]

Update:

When I sit in the seat it goes up a bit and the blocks randomly move up and down a tiny tiny bit.

[TheGreyGhost]

sorry mate, nothing is coming to mind and I don't see anything obvious in that code (but then - I've never programmed riding entity stuff before either).

 

What I would try next is to put a breakpoint on the client side posY (i.e. to break when it turns to say > 56.5) and see which method is writing the changed value in there.  It will slow your code down a lot but with any luck it should show you exactly what is causing the problem.

 

-TGG

[david476]

Anybody else?

[MultiMote]

Look at the setPositionAndRotation2 of boat or minecart.

[david476]

Why, I only set the position at spawn and that seems to work fine...

[david476]

bump

[MultiMote]

I mean Override this method. Not call.

[david476]

I'll try it but could you elaborate on why and what to replace it with?

[david476]

bump

[david476]

bumpitybump

[GotoLink]

You didn't put super call in onUpdate().

Nor in writeToNBT(NBTTagCompound) and readFromNBT(NBTTagCompound).

[david476]

I definitely did put the super calls in nbt stuff but after changing onUpdate, the same thing happens. New Controller file:

 

package com.deb.debmodularships.entities;

import net.minecraft.entity.Entity;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.util.AxisAlignedBB;
import net.minecraft.world.World;

public class EntityController extends Entity {

public EntityController(World par1World) {
	super(par1World);
	this.setSize(1, 1);
}

@Override
protected void entityInit() {

}

@Override
public void readFromNBT(NBTTagCompound nbt) {
	super.readFromNBT(nbt);
}

@Override
public void writeToNBT(NBTTagCompound nbt) {
	super.writeToNBT(nbt);
}

public void onUpdate() {
	super.onUpdate();
	System.out.println(this.boundingBox);
}

public boolean canBeCollidedWith() {
        return true;
    }

public AxisAlignedBB getCollisionBox(Entity p_70114_1_) {
        return this.boundingBox;
    }

public AxisAlignedBB getBoundingBox()
    {
        return this.boundingBox;
    }

//IGNORE

@Override
protected void readEntityFromNBT(NBTTagCompound var1) {
	// TODO Auto-generated method stub

}

@Override
protected void writeEntityToNBT(NBTTagCompound var1) {
	// TODO Auto-generated method stub

}
}

[david476]

Looks like overriding OEU2 solved it, just wondering why... Thanking MultiMote now!

[david476]

bump, really curious .