Jump to content

[SOLVED]Flint from Stone


Zelpher

Recommended Posts

I'm having an issue I can't seem to find a resolution to.

 

I'm wanting Stone to drop Flint if broken with any tool that isn't a pickaxe.

 

public class StoneEventHandler {
@SubscribeEvent
public void onHarvestBlock(BlockEvent.HarvestDropsEvent event){

	Block block = event.block;
	EntityPlayer player = event.harvester;

	if(block == Blocks.stone){
		if (player.getHeldItem().getItem() != Items.stone_pickaxe && player.getHeldItem().getItem() != Items.iron_pickaxe){
			player.inventory.addItemStackToInventory(new ItemStack(Items.flint, 1));
		}

	}
}
}

 

This is my third attempt. I'm assuming it has to do directly with the event I've used except I don't know what one I should be using. It probably isn't being run as it isn't being broken with the designed tool.

 

Okay, I changed the event and it seems to work. I have a new question. How can I compare the item/tool used to break the block?

 

My old line of

if (player.getHeldItem().getItem() != Items.stone_pickaxe && player.getHeldItem().getItem() != Items.iron_pickaxe)

 

no longer works and I'm new to forge. Should I just go digging around in reflection or can someone help me out really fast and give me something that will work?

 

Small steps to progress. I'm now getting Flint with my hand. I'm using BreakEvent now, is that problematic?

 

EDIT: Now I'm looking for a way to check if a players using a pickaxe but will work if the player isn't holding anything.

Link to comment
Share on other sites

Just create a new field of Item. I don't think you can compare like that.

 

Item heldItem = player.getHeldItem().getItem();

if (heldItem != Items.stone_pickaxe ...etc...)

 

Crashes my game when I use my fist which is why I removed it in the first place...

java.lang.NullPointerException: Ticking memory connection

It also points to the line number that uses the if statement.

 

... Oh, if anyone wants to try it themselves.

 

public class StoneEventHandler {
@SubscribeEvent
public void onBlockBreak(BreakEvent event){
	EntityPlayer player = event.getPlayer();
	Block block = event.block;
	Item heldItem = player.getHeldItem().getItem();

	if(block == Blocks.stone){
		if(heldItem != Items.stone_pickaxe){
			player.inventory.addItemStackToInventory(new ItemStack(Items.flint, 1));
		}
	}

}
}

is what I'm using now

Link to comment
Share on other sites

Check first if player.getHeldItem != null.

You can only use player.getHeldItem.getItem if the player.getHeldItem is not null, this will make a crash.

 

I figured that out, thanks! I need a workaround as this is the starting base of my mod. I need an accessible and logical way to get flint... before stone even. So if you can't get it when using your fist I'd have to find a convoluted work around that would forego stone and add a new common resource to the world.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
    • It is an issue with quark - update it to this build: https://www.curseforge.com/minecraft/mc-mods/quark/files/3642325
    • Remove Instant Massive Structures Mod from your server     Add new crash-reports with sites like https://paste.ee/  
    • Update your drivers: https://www.amd.com/en/support/graphics/amd-radeon-r9-series/amd-radeon-r9-200-series/amd-radeon-r9-280x
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.