Jump to content

[1.7.10] Give player random items


Bugzoo

Recommended Posts

You should double the list if you need it twice.

 

Random rand = new Random();

for(int m = 0; m < 6; m++)
{
          int r = rand.nextInt(YOURLIST.size() - 1);
          ItemStack stack = YOURLIST.get(r);
          player.inventory.addItemStackToInventory(stack);

   //if you want not 2 times the same one
          YOURLIST.remove(r); 
}

Link to comment
Share on other sites

You should double the list if you need it twice.

 

Random rand = new Random();

for(int m = 0; m < 6; m++)
{
          int r = rand.nextInt(YOURLIST.size() - 1);
          ItemStack stack = YOURLIST.get(r);
          player.inventory.addItemStackToInventory(stack);

   //if you want not 2 times the same one
          YOURLIST.remove(r); 
}

 

MyList.get and MyList.remove dont work

Link to comment
Share on other sites

With a Array I don't know how to delete, but you get it in this way.

 

Random rand = new Random();

for(int m = 0; m < 6; m++)
{
          int r = rand.nextInt(YOURLIST.size() - 1);
          ItemStack stack = YOURLIST[r];
          player.inventory.addItemStackToInventory(stack);
}

 

I would use a ArrayList in your situation.

Link to comment
Share on other sites

With a Array I don't know how to delete, but you get it in this way.

 

Random rand = new Random();

for(int m = 0; m < 6; m++)
{
          int r = rand.nextInt(YOURLIST.size() - 1);
          ItemStack stack = YOURLIST[r];
          player.inventory.addItemStackToInventory(stack);
}

 

I would use a ArrayList in your situation.

 

That doesnt seem to be giving me any items at all

Link to comment
Share on other sites

In this case I need your full code

 

package com.bugzoo.Lootcube;

import java.util.Random;

import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.world.World;

public class ItemPokepack extends Item{
public ItemPokepack(){
	setMaxStackSize(1);
	setUnlocalizedName("pokePack");
}

@Override
public ItemStack onItemRightClick(ItemStack itemStack, World world, EntityPlayer player){
	Random rand = new Random();

	for(int m = 0; m < 6; m++)
	{
	          int r = rand.nextInt(Lootcube.pokelist.length - 1);
	          ItemStack stack = Lootcube.pokelist[r];
	          player.inventory.addItemStackToInventory(stack);
	}
	return itemStack;
}


}

 

MyList:

public static ItemStack[] pokelist = {new ItemStack(Cascoon), new ItemStack(Silcoon), new ItemStack(Purugly), new ItemStack(Gothita), new ItemStack(Watchog), new ItemStack(Dunsparce), new ItemStack(Sunkern), new ItemStack(Wormadam), new ItemStack(Patrat), new ItemStack(Luvdisk), new ItemStack(Mewtwo), new ItemStack(Charizard), new ItemStack(Arceus), new ItemStack(Lugia), new ItemStack(Slaking), new ItemStack(Dragonite), new ItemStack(Mew)};
   

Link to comment
Share on other sites

Store Item links (Mymod.someitem etc.) in your array. NOT ItemStacks. Create new ItemStacks from items in your loop.

Still doesnt give me any items

ItemClass:

package com.bugzoo.Lootcube;

import java.util.List;
import java.util.Random;

import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;

import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.world.World;

public class ItemPokepack extends Item{
public ItemPokepack(){
	setMaxStackSize(1);
	setUnlocalizedName("pokePack");
}

public Item stack;

@Override
public ItemStack onItemRightClick(ItemStack itemStack, World world, EntityPlayer player){
	Random rand = new Random();

	for(int m = 0; m < 6; m++)
	{
	          int r = rand.nextInt(Lootcube.pokelist.length - 1);
	          stack = Lootcube.pokelist[r];
	          player.inventory.addItemStackToInventory(new ItemStack(stack));
	          player.inventory.consumeInventoryItem(this);
	}
	return new ItemStack(stack);
}

@SideOnly(Side.CLIENT)
@Override
public void addInformation(ItemStack itemstack, EntityPlayer player, List dataList, boolean b){
	dataList.add("Pack Of Random Pokemon Cards");
}
}

List:

public static Item[] pokelist = {Cascoon, Silcoon, Purugly, Gothita, Watchog, Dunsparce};

Link to comment
Share on other sites

You IDE is not giving you an error message about this nonsense:

public static Item[] pokelist = {Cascoon, Silcoon, Purugly, Gothita, Watchog, Dunsparce};

Class names are not items. Do you even read error messages? On the other hand, many new coders name instances with initial cap... either is very wrong.

Link to comment
Share on other sites

public Item stack;

 

@Override

public ItemStack onItemRightClick(ItemStack itemStack, World world, EntityPlayer player){

Random rand = new Random(); //itemRand

 

for(int m = 0; m < 6; m++) //you said 5

{

          int r = rand.nextInt(Lootcube.pokelist.length - 1); //nextInt counts from 0

                          stack = Lootcube.pokelist[r];

          player.inventory.addItemStackToInventory(new ItemStack(stack));

          player.inventory.consumeInventoryItem(this);

                          itemStack.stackSize--;

 

}

 

return new ItemStack(stack); //why?

                return itemStack;

 

}

 

 

 

 

    public static Item[] pokelist = {Items.apple, Items.carrot, Items.potato, Items.slime_ball, Items.arrow, Items.beef, Items.shears};

 

    @Override

    public ItemStack onItemRightClick(ItemStack itemStack, World world, EntityPlayer player){

        if(world.isRemote)return itemStack; //because ghost items

 

        List<Item> tempList = new ArrayList<Item>();

        tempList.addAll(Arrays.asList(pokelist)); //because remove() causes UnsupportedOperationException

 

        for(int m = 0; m < 5; m++)

        {

            player.inventory.addItemStackToInventory(new ItemStack(tempList.remove(itemRand.nextInt(tempList.size())))); //because science

            itemStack.stackSize--;

        }

        return itemStack;

    }

 

Link to comment
Share on other sites

public Item stack;

 

@Override

public ItemStack onItemRightClick(ItemStack itemStack, World world, EntityPlayer player){

Random rand = new Random(); //itemRand

 

for(int m = 0; m < 6; m++) //you said 5

{

          int r = rand.nextInt(Lootcube.pokelist.length - 1); //nextInt counts from 0

                          stack = Lootcube.pokelist[r];

          player.inventory.addItemStackToInventory(new ItemStack(stack));

          player.inventory.consumeInventoryItem(this);

                          itemStack.stackSize--;

 

}

 

return new ItemStack(stack); //why?

                return itemStack;

 

}

 

 

 

 

    public static Item[] pokelist = {Items.apple, Items.carrot, Items.potato, Items.slime_ball, Items.arrow, Items.beef, Items.shears};

 

    @Override

    public ItemStack onItemRightClick(ItemStack itemStack, World world, EntityPlayer player){

        if(world.isRemote)return itemStack; //because ghost items

 

        List<Item> tempList = new ArrayList<Item>();

        tempList.addAll(Arrays.asList(pokelist)); //because remove() causes UnsupportedOperationException

 

        for(int m = 0; m < 5; m++)

        {

            player.inventory.addItemStackToInventory(new ItemStack(tempList.remove(itemRand.nextInt(tempList.size())))); //because science

            itemStack.stackSize--;

        }

        return itemStack;

    }

I'm still not getting any items when I right click

Link to comment
Share on other sites

I'd just use this:

    
Random rand = new Random();
        ItemStack[] itemstack = new ItemStack[20];
        itemstack[0] = new ItemStack(Items.apple, 2);
        itemstack[1] = new ItemStack(Items.bread, 34);
        //...
        for(int i = 0; i < 5; i++) {
        	player.inventory.addItemStackToInventory(itemstack[rand.nextInt(20)]);
        }

Link to comment
Share on other sites

I'd just use this:

    
Random rand = new Random();
        ItemStack[] itemstack = new ItemStack[20];
        itemstack[0] = new ItemStack(Items.apple, 2);
        itemstack[1] = new ItemStack(Items.bread, 34);
        //...
        for(int i = 0; i < 5; i++) {
        	player.inventory.addItemStackToInventory(itemstack[rand.nextInt(20)]);
        }

Thank you, this works. I dont know how I didnt think of that earlier. But im having a problem where sometimes it gives me 3 items, sometimes 4 and sometimes 5

Link to comment
Share on other sites

I'd just use this:

    
Random rand = new Random();
        ItemStack[] itemstack = new ItemStack[20];
        itemstack[0] = new ItemStack(Items.apple, 2);
        itemstack[1] = new ItemStack(Items.bread, 34);
        //...
        for(int i = 0; i < 5; i++) {
        	player.inventory.addItemStackToInventory(itemstack[rand.nextInt(20)]);
        }

Thank you, this works. I dont know how I didnt think of that earlier. But im having a problem where sometimes it gives me 3 items, sometimes 4 and sometimes 5

 

uhhm, U have to put itemstack[2] = new ItemStack(theItemYouWant, TheAmountUWant);

and so on ofc into there too (up too 19).

If you have already done that and its still not working show your code. And if its adding e.g. 5 eggs 3 eggs u dont get 5 and 3 eggs but 8 in one stack ofc. And I dont know if you want to deny the chance of an ItemStack beeing added twice, if so u have to put in a check for that.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.