Jump to content

[1.7.10] Item rendering a second model of itself?


DaNatin

Recommended Posts

I've made an item render as a custom 3D model, the problem is that I can see two of the same model (or a part of it) in third person. Here's what I see:

 

This only happens when I'm in third person:

width=346 height=2984fj0Tpd.png?1 [/img]

 

Here is the rendering code:

package com.natin.borderlands2mod.entities.render;

import net.minecraft.client.Minecraft;
import net.minecraft.client.gui.inventory.GuiContainerCreative;
import net.minecraft.client.gui.inventory.GuiInventory;
import net.minecraft.client.renderer.entity.RenderManager;
import net.minecraft.entity.Entity;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.EnumAction;
import net.minecraft.item.ItemStack;
import net.minecraft.util.ResourceLocation;
import net.minecraftforge.client.IItemRenderer;

import org.lwjgl.opengl.GL11;

import com.natin.borderlands2mod.guns.models.RocketLauncherModel;


public class RenderRocketLauncher implements IItemRenderer 
{
//public static final ResourceLocation Texture = new ResourceLocation(BattleOfTheBeastsMod.modid, "/textures/entity/RocketLauncher.png");

protected RocketLauncherModel rocketlaunchermodel;



public RenderRocketLauncher()
{
	rocketlaunchermodel = new RocketLauncherModel();
}

// protected ResourceLocation func_110832_a(RocketLauncherModel par1EntitySpiderQueen)
    //{
  //      return Texture;
    //}

   
@Override
public boolean handleRenderType(ItemStack item, ItemRenderType type) 
{
	switch(type)
	{
	case EQUIPPED: return true;
	case EQUIPPED_FIRST_PERSON: return true;
	default: return false;
	}
}

@Override
public boolean shouldUseRenderHelper(ItemRenderType type, ItemStack item, ItemRendererHelper helper) 
{
	return false;
}

  public EnumAction EQUIPPED(ItemStack par1ItemStack)
    {
        return EnumAction.bow;
    }

@Override
public void renderItem(ItemRenderType type, ItemStack item, Object... data) 
{
	switch(type)
	{
	case EQUIPPED:
	{


	        
		GL11.glPushMatrix();

		Minecraft.getMinecraft().renderEngine.bindTexture(new ResourceLocation("borderlands2mod", "textures/models/RocketLauncher.png"));			//ResourceLocation Texture = new ResourceLocation(BattleOfTheBeastsMod.modid, "/textures/entity/RocketLauncher.png");




		boolean isFirstPerson = false;

	if(data[1] != null && data[1] instanceof EntityPlayer)	
	{
		if(!((EntityPlayer)data[1] == Minecraft.getMinecraft().renderViewEntity && Minecraft.getMinecraft().gameSettings.thirdPersonView == 0 && !((Minecraft.getMinecraft().currentScreen instanceof GuiInventory || Minecraft.getMinecraft().currentScreen instanceof GuiContainerCreative) && RenderManager.instance.playerViewY == 180.0F)))			
		{
			isFirstPerson = false;
			GL11.glTranslatef(0.4F, 0.5F, 0.08F); //position
			GL11.glRotatef(-26F, 1.0F, 0.0F, 0.0F);	//X
			GL11.glRotatef(165F, 0.0F, 1.0F, 0.0F); //y
			GL11.glRotatef(140F, 1.0F, 0.0F, 1.0F);   //z
			//Size
			rocketlaunchermodel.render((Entity)data[1], 0.0F, 0.0F, 0.0F, 0.0F, 0.0F, 0.07F);

		}

	}	


	}

	case EQUIPPED_FIRST_PERSON:
	{


	        
		GL11.glPushMatrix();

		Minecraft.getMinecraft().renderEngine.bindTexture(new ResourceLocation("borderlands2mod", "textures/models/RocketLauncher.png"));			//ResourceLocation Texture = new ResourceLocation(BattleOfTheBeastsMod.modid, "/textures/entity/RocketLauncher.png");




		boolean isFirstPerson = true;

	if(data[1] != null && data[1] instanceof EntityPlayer)	
	{

			if(!((EntityPlayer)data[1] == Minecraft.getMinecraft().renderViewEntity && Minecraft.getMinecraft().gameSettings.thirdPersonView == 0 && !((Minecraft.getMinecraft().currentScreen instanceof GuiInventory || Minecraft.getMinecraft().currentScreen instanceof GuiContainerCreative) && RenderManager.instance.playerViewY == 0.0F)))			

			isFirstPerson = true;
			GL11.glTranslatef(0.5F, 0.8F, 0.1F); //position
			GL11.glRotatef(-10F, 1.0F, 0.0F, 0.0F);	//X
			GL11.glRotatef(165F, 0.0F, 1.0F, 0.0F); //y
			GL11.glRotatef(160F, 1.0F, 0.0F, 1.0F);   //z
			//Size
			rocketlaunchermodel.render((Entity)data[1], 0.0F, 0.0F, 0.0F, 0.0F, 0.0F, 0.07F);

	}	

	}	
	GL11.glPopMatrix();

	default: break;
	}


}
}

 

Also in the console, this message is spammed repeatedly when I go into third person:

[13:51:44] [Client thread/ERROR]: ########## GL ERROR ##########

[13:51:44] [Client thread/ERROR]: @ Post render

[13:51:44] [Client thread/ERROR]: 1283: Stack overflow

Link to comment
Share on other sites

Oh, I should have said, I'd love to help you more, but two things: I am very unfamiliar with rendering issues as I haven't done anything with Render handlers; and I really cannot see anything given how dark your image is.

Link to comment
Share on other sites

You have forgotten a break; in your switch so it is falling through from EQUIPPED into EQUIPPED_FIRST_PERSON

 

:)

 

-TGG

Good catch. Now, if the code had been formatted in a reasonable manner, I would have seen that right away. (I get blind in my old age 8-)

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.