Jump to content

[SOLVED] mcp72 - getchangedsrc - src/common not included


MPirious

Recommended Posts

Hi,

 

following the tutorial(s) at

 

 

 

the sources of the tutorial are placed under %MCP_LOC%/src/minecraft and %MCP_LOC%/src/common.

 

When using the reobfuscate.bat, it seems, that only the files at src/minecraft are copied to ./modsrc. The files at src/common are ignored.

 

Output of bat:

 

 

> Getting changed client source

> New class found      : tutorial/generic/TileEntityTiny

> New class found      : tutorial/generic/GuiHandler

> New class found      : tutorial/generic/GenericBlock

> New class found      : tutorial/generic/GuiTiny

> New class found      : tutorial/generic/client/ClientProxy

> New class found      : tutorial/generic/ContainerTiny

> New class found      : tutorial/generic/BlockTiny

> New class found      : tutorial/generic/Generic

> New class found      : tutorial/generic/SuperTool

> New class found      : tutorial/generic/CommonProxy

> New class found      : tutorial/generic/GenericItem

> New class found      : tutorial/generic/GenericOre

> Outputted tutorial/generic/client/ClientProxy to modsrc\minecraft

> Getting changed server source

 

 

 

(FYI: recompile.bat & reobfuscate.bat work fine. (I didn't test more.))

 

Since I'm no python-developer, I wasn't able to figure out, what the reason for this was.

Maybe the results of my tries to debug it are helpful:

 

 

 

./runtime/commands.py->unpackmodifiedclasses seems to be the place of interest

the line containing "if os.path.isfile(src_file):" (line 1693 for me) seems to be the one deciding, which files to copy.

I added a debug output the line before:

self.logger.info('>> %s  %s', src_file, os.path.isfile(src_file))

 

I think, the problem is "os.path.isfile(src_file)" returning "false" for files.

Unfortunately, this is where my lack of python-knowledge stops me from going deeper into the problem.

 

 

>> src\minecraft\tutorial\generic\TileEntityTiny.java  False

>> src\minecraft\tutorial\generic\GuiHandler.java  False

>> src\minecraft\tutorial\generic\GenericBlock.java  False

>> src\minecraft\tutorial\generic\GuiTiny.java  False

>> src\minecraft\tutorial\generic\client\ClientProxy.java  True

> Outputted tutorial/generic/client/ClientProxy to modsrc\minecraft

>> src\minecraft\tutorial\generic\ContainerTiny.java  False

>> src\minecraft\tutorial\generic\BlockTiny.java  False

>> src\minecraft\tutorial\generic\Generic.java  False

>> src\minecraft\tutorial\generic\SuperTool.java  False

>> src\minecraft\tutorial\generic\CommonProxy.java  False

>> src\minecraft\tutorial\generic\GenericItem.java  False

>> src\minecraft\tutorial\generic\GenericOre.java  False

 

 

 

If the problem I have is based on a mistake I made, please explain, what I did wrong.

 

MPirious

 

 

edit:

Or is this a question I'd have to ask in the MCP-Community?

Link to comment
Share on other sites

Ya I know about it, its a non-priority, so I don't really care about fixing it.

There are a few things in mcp that we break  by merging things together, but none of them are of any importance.

This isn't a MCP issue its a FML/Forge issue as we are the ones merging the codebase. {We patch MCP}

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.