Jump to content

Problems with getEntitiesWithinAABB


robertcarr22

Recommended Posts

Minecraft is a client side only class.

You should try to get the entity the player is pointing at in the server side without Minecraft#objectMouseOver.

As it's client only, when the target is not null, it would be always client side.

 

Ahhhh i see! Is there anyway to find the entity a player is looking at that will work on server side?

Link to comment
Share on other sites

I did it with worldObj#getEntitiesWithinAABB and scan for every entity in the list(Maybe there is a better way, tell me if you have one afterwards).

 

and this is partly(or all? I cant remember) copy from code of enderman to know if the obj is looking at by the player.

		EntityLivingBase obj = (EntityLivingBase) iterator.next();

		Vec3 vec3 = player.getLook(1.0F).normalize();
            Vec3 vec31 = obj.worldObj.getWorldVec3Pool().getVecFromPool(
            		obj.posX - player.posX, 
            		obj.boundingBox.minY + (double)(obj.height / 2.0F) - (player.posY + (double)player.getEyeHeight()), 
            		obj.posZ - player.posZ);
            double d0 = vec31.lengthVector();
            vec31 = vec31.normalize();
            double d1 = vec3.dotProduct(vec31);
            if (d1 > 1.0D - 0.025D / d0 && player.canEntityBeSeen(obj)) {
            	return obj;
            }

Link to comment
Share on other sites

I did it with worldObj#getEntitiesWithinAABB and scan for every entity in the list(Maybe there is a better way, tell me if you have one afterwards).

 

and this is partly(or all? I cant remember) copy from code of enderman to know if the obj is looking at by the player.

--snip--

 

never heard of that method… :/ what are the 2 params you put in the getEntitiesWithinAABB method? and where does that code get used?

Link to comment
Share on other sites

The two params are:

 

1) The entity class you are interested in.

2) An axis aligned bounding box.*

 

It's pretty widely used for things like splash potions and mob spawners.  Also pressure plates, if I recall correctly.

 

*You can get one by calling AxisAlignedBoundingBox.getAABBFromPool(xmin, ymin, zmin, xmax, ymax, zmax) if I am recalling the class and method names correctly.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

The two params are:

 

1) The entity class you are interested in.

2) An axis aligned bounding box.*

 

It's pretty widely used for things like splash potions and mob spawners.  Also pressure plates, if I recall correctly.

 

*You can get one by calling AxisAlignedBoundingBox.getAABBFromPool(xmin, ymin, zmin, xmax, ymax, zmax) if I am recalling the class and method names correctly.

 

Right okay I tried this code out: https://gist.github.com/robertcarr22/21f97f33584c3e0b8468

and it works well in the south east direction but doesn't work at all in any other direction.

This is probably because I've don't the maths for the bounding box wrong but Im not entirely sure..

 

EDIT: Seems to be with the calculation of where the player is looking not the bounding box

Link to comment
Share on other sites

Use:

 

  Side side = FMLCommonHandler.instance().getEffectiveSide();
                if (side == Side.CLIENT) {
                    if(tickCooldown<=0){
                      ClientSideStuff
                      tickCooldown = 2;
                     }
                }else{
          ServerStuff
}

 

the tick cooldown should be --'d every client side tick also.

Link to comment
Share on other sites

Use:

 

  Side side = FMLCommonHandler.instance().getEffectiveSide();
                if (side == Side.CLIENT) {
                    if(tickCooldown<=0){
                      ClientSideStuff
                      tickCooldown = 2;
                     }
                }else{
          ServerStuff
}

 

the tick cooldown should be --'d every client side tick also.

 

 

Thanks for this but i don't need to separate the client and server anymore I'm having a different problem :P

Link to comment
Share on other sites

The two params are:

 

1) The entity class you are interested in.

2) An axis aligned bounding box.*

 

It's pretty widely used for things like splash potions and mob spawners.  Also pressure plates, if I recall correctly.

 

*You can get one by calling AxisAlignedBoundingBox.getAABBFromPool(xmin, ymin, zmin, xmax, ymax, zmax) if I am recalling the class and method names correctly.

 

Right okay I tried this code out: https://gist.github.com/robertcarr22/21f97f33584c3e0b8468

and it works well in the south east direction but doesn't work at all in any other direction.

This is probably because I've don't the maths for the bounding box wrong but Im not entirely sure..

 

EDIT: Seems to be with the calculation of where the player is looking not the bounding box

 

Okay it actually seems to be something wrong with detecting entities in the box. It detects entities in the bounding box when facing south east but not any other direction. I can't figure out what is going wrong :(

Link to comment
Share on other sites

Because your xMax is less than your xMin (ditto for z).

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

The whole code of mine.

 

public static List GetNearEntityWithPlayer(
		EntityLivingBase player, int range, boolean needToBeSeen) {
	double px = player.posX;
	double py = player.posY;
	double pz = player.posZ;
	List l = player.worldObj.getEntitiesWithinAABB(
			EntityLivingBase.class, 
			AxisAlignedBB.getBoundingBox(px - range, py - range, pz - range,
										 px + range, py + range, pz + range));
	List result = new ArrayList();
	for (int i = 0; i < l.size(); ++i) {
		EntityLivingBase x = (EntityLivingBase) l.get(i);
		if (x != null) {
			if (x.getDistanceToEntity(player) <= range && (!needToBeSeen || x.canEntityBeSeen(player))) {
				result.add(x);
			}
		}
	}
	return result;
}
public static EntityLivingBase GetEntityLookAt(EntityPlayer player, int max_dis) {
	List list = Utils.GetNearEntityWithPlayer(player, 30, true);
	for(Iterator iterator = list.iterator();iterator.hasNext()
	{
		EntityLivingBase obj = (EntityLivingBase) iterator.next();

		Vec3 vec3 = player.getLook(1.0F).normalize();
            Vec3 vec31 = obj.worldObj.getWorldVec3Pool().getVecFromPool(
            		obj.posX - player.posX, 
            		obj.boundingBox.minY + (double)(obj.height / 2.0F) - (player.posY + (double)player.getEyeHeight()), 
            		obj.posZ - player.posZ);
            double d0 = vec31.lengthVector();
            vec31 = vec31.normalize();
            double d1 = vec3.dotProduct(vec31);
            if (d1 > 1.0D - 0.025D / d0 && player.canEntityBeSeen(obj)) {
            	return obj;
            }
	}
	//player.worldObj.spawnParticle(par1Str, par2, par4, par6, par8, par10, par12)
	return null;
}

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.