Jump to content
  • Home
  • Files
  • Docs
  • Merch
Topics
  • All Content

  • This Topic
  • This Forum

  • Advanced Search
  • Existing user? Sign In  

    Sign In



    • Not recommended on shared computers


    • Forgot your password?

  • Sign Up
  • All Activity
  • Home
  • Minecraft Forge
  • General Discussion
  • [Fixed]TileEntity var syncing
Sign in to follow this  
Followers 1
DarkGuardsman

[Fixed]TileEntity var syncing

By DarkGuardsman, August 15, 2012 in General Discussion

  • Reply to this topic
  • Start new topic

Recommended Posts

DarkGuardsman    61

DarkGuardsman

DarkGuardsman    61

  • World Shaper
  • DarkGuardsman
  • Forge Modder
  • 61
  • 1479 posts
Posted August 15, 2012

In 1.2.5 i made a GUI to change settings in my tileEntity. It worked 100% fine saving and recalling the data when i closed/reopened the gui and restart the game. In 1.3.1 it open just fine, i can change the settings, and they keep as long as i do not restart the game. Which i think has too do with the tileEntity not getting the varables client side. I've set up a packet system but can't really tell if its working. I'm going to keep toying with it till i get it working but just in case i don't can someone check out my code and see what is wrong.

Edit: toyed with it more found the data is making its way to the client but all messed up. However the GUI itself doesn't seem to be saving the data to the server side/keeps vars on client. Which i think i can fix with a packet to the server. Though there is now an issue with the packet data getting all messed up. instead of the 8 separate ints getting assigned to there own varables there merging together.

Pic of GUI

 

BarrackSettings.png

 

 

Code is on gitHub easier to read than to post here gitHub

  • Quote

Share this post


Link to post
Share on other sites

LexManos    1519

LexManos

LexManos    1519

  • Reality Controller
  • LexManos
  • Forge Code God
  • 1519
  • 8571 posts
Posted August 15, 2012

Not going to dig through all of your code, so linking to specific files would help.

But I dont get the 'merging together' part, seems to me like you're fucking something up if things are getting merged together.

its not difficult to transfer something over the network and pick it up on the other side.

  • Quote

Share this post


Link to post
Share on other sites

DarkGuardsman    61

DarkGuardsman

DarkGuardsman    61

  • World Shaper
  • DarkGuardsman
  • Forge Modder
  • 61
  • 1479 posts
Posted August 15, 2012

Not going to dig through all of your code, so linking to specific files would help.

But I dont get the 'merging together' part, seems to me like you're fucking something up if things are getting merged together.

its not difficult to transfer something over the network and pick it up on the other side.

found the issue with the vars merging, end up too do something with writing the int to dataStream as a double. which i don't understand why it cause the variables to start to merge together but telling to write as an int fix that issue. Also by merge i meant there should be 8 vars for example 37xA 15yA 100zA  48xT 45yT 113zT 13W 10C. what i was getting was 3715100xA 0yA 1001527zA 0W 0C.

 

to fix the not saving on restart what i think i need to do is send a packet with the new info too the server. However, i don't know how to send a packet too the local server.

 

Here is the code just involving the tileEntity and gui

https://github.com/DarkGuardsman/GSM-Guardsman/blob/master/1.3.1/common/GSM/barrack/TileEntityBarrack.java

https://github.com/DarkGuardsman/GSM-Guardsman/blob/master/1.3.1/common/GSM/Network/PacketManager.java

changing line 78 on the above fixed the merge issue

https://github.com/DarkGuardsman/GSM-Guardsman/blob/master/1.3.1/minecraft/GSMClient/GuiBarrackSettings.java

  • Quote

Share this post


Link to post
Share on other sites

LexManos    1519

LexManos

LexManos    1519

  • Reality Controller
  • LexManos
  • Forge Code God
  • 1519
  • 8571 posts
Posted August 15, 2012

Im pretty sure FML/ML expose a sendPacket fucntion.

As for sending as Double and reading as a int, well no shit that wont work u.u

  • Quote

Share this post


Link to post
Share on other sites

atrain99    68

atrain99

atrain99    68

  • World Shaper
  • atrain99
  • Forge Modder
  • 68
  • 1502 posts
Posted August 15, 2012

Im pretty sure FML/ML expose a sendPacket fucntion.

As for sending as Double and reading as a int, well no shit that wont work u.u

Just do a cast.

  • Quote

Share this post


Link to post
Share on other sites

LexManos    1519

LexManos

LexManos    1519

  • Reality Controller
  • LexManos
  • Forge Code God
  • 1519
  • 8571 posts
Posted August 15, 2012

Right.. thats retarded.

When you write a double to the stream

It write 8 bytes

When you read a int from the stream

you read 4 bytes

see an issue here?

  • Quote

Share this post


Link to post
Share on other sites

DarkGuardsman    61

DarkGuardsman

DarkGuardsman    61

  • World Shaper
  • DarkGuardsman
  • Forge Modder
  • 61
  • 1479 posts
Posted August 15, 2012

Right.. thats retarded.

When you write a double to the stream

It write 8 bytes

When you read a int from the stream

you read 4 bytes

see an issue here?

at least you can be nice about my f' up, it was a copying error from a tut and i forgot to code it to write ints. anyways back to the original issue how to i get the packet to the local server. I'll try the sendPacket it just seem to be too simple seeing as i had to set up a packetManager.class just to send packets to the client.

 

Edit:

is it me or maybe sendPacket is missing/ not added. I'll  keep looking for something to send a packet too the server but tbh i'm not 100% sure what i'm looking for.

 public static void sendPacket(Packet packet) {
        // TODO
//        FMLClientHandler.instance().sendPacket(packet);
    }

  • Quote

Share this post


Link to post
Share on other sites

calclavia    81

calclavia

calclavia    81

  • World Shaper
  • calclavia
  • Forge Modder
  • 81
  • 2281 posts
Posted August 15, 2012

Try using PacketManager.sendTileEntityPacket from UE...

 

Also, you can read doubles and then cast the read doubles into int after reading so it doesn't mess the stream data up.

  • Quote

Share this post


Link to post
Share on other sites

DarkGuardsman    61

DarkGuardsman

DarkGuardsman    61

  • World Shaper
  • DarkGuardsman
  • Forge Modder
  • 61
  • 1479 posts
Posted August 15, 2012

Try using PacketManager.sendTileEntityPacket from UE...

 

Also, you can read doubles and then cast the read doubles into int after reading so it doesn't mess the stream data up.

i am using a recoded version of your code for my packetHandler. only issue is i can't figure out how to send the settings packet to the server to be saved. I've got sending to the player done just fine and gui gets the old settings. However if i go into the gui and change all the vars in the textboxes, it only keep the new setting as long as game stays on. Which means i need to update the server's TileEntity with the new settings.

  • Quote

Share this post


Link to post
Share on other sites

calclavia    81

calclavia

calclavia    81

  • World Shaper
  • calclavia
  • Forge Modder
  • 81
  • 2281 posts
Posted August 16, 2012

Try using PacketManager.sendTileEntityPacket from UE...

 

Also, you can read doubles and then cast the read doubles into int after reading so it doesn't mess the stream data up.

i am using a recoded version of your code for my packetHandler. only issue is i can't figure out how to send the settings packet to the server to be saved. I've got sending to the player done just fine and gui gets the old settings. However if i go into the gui and change all the vars in the textboxes, it only keep the new setting as long as game stays on. Which means i need to update the server's TileEntity with the new settings.

 

I'll look into it and tell you if I got any insight on it.

  • Quote

Share this post


Link to post
Share on other sites

DarkGuardsman    61

DarkGuardsman

DarkGuardsman    61

  • World Shaper
  • DarkGuardsman
  • Forge Modder
  • 61
  • 1479 posts
Posted August 16, 2012

Try using PacketManager.sendTileEntityPacket from UE...

 

Also, you can read doubles and then cast the read doubles into int after reading so it doesn't mess the stream data up.

i am using a recoded version of your code for my packetHandler. only issue is i can't figure out how to send the settings packet to the server to be saved. I've got sending to the player done just fine and gui gets the old settings. However if i go into the gui and change all the vars in the textboxes, it only keep the new setting as long as game stays on. Which means i need to update the server's TileEntity with the new settings.

 

I'll look into it and tell you if I got any insight on it.

ty without being able to update the Barrack settings the block doesn't work past looking good. Other than that my Guardsman are rendering now :), well except for weapons but that an old error that crops up every update.

 

Edit: i see the modloader.sendPacket now does something instead of being empty. Anyways is the onPackData version for the server side?

Edit2: Fixed it turns out i was not getting the right world so when the packet got there it didn't know which world to send it too.

  • Quote

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

  • Insert image from URL
×
  • Desktop
  • Tablet
  • Phone
Sign in to follow this  
Followers 1
Go To Topic Listing



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • matt1999rd
      [1.14-newer] how to keep value when closing minecraft

      By matt1999rd · Posted 6 minutes ago

      it works well with Capability thanks
    • DaemonUmbra
      My Forge 1.12 and 1.12.2 Keep Crashing when i start it up

      By DaemonUmbra · Posted 19 minutes ago

      Any particular reason you're running 1.12 instead of 1.12.2?
    • Simon_kungen
      [1.14.4] TileEntityItemStackSpecialRenderer (TEISR)

      By Simon_kungen · Posted 23 minutes ago

      Hi   I got this item that stores a single stack of something else, and a glass variant of it should render the stack inside, but according to the docs I just need to set the renderer on the item and it should work but as far as I can see nothing happens, not even the console prints anything:   ItemSingleStackGlassContainer.java public class ItemSingleStackGlassContainer extends ItemSingleStackContainer { public ItemSingleStackGlassContainer(String name, float isolation, int tint) { super(new Item.Properties().setTEISR(() -> SingleStackGlassContainerItemRender::new),name,isolation,tint); } ... }   The superclass: ItemSingleStackContainer.java public class ItemSingleStackContainer extends Item { public static final ResourceLocation open = new ResourceLocation(Reference.MODID,"open"); private final float isolation; private final int tint; private static short failedToOpen = 0; private boolean isOpen = false; public ItemSingleStackContainer(Item.Properties properties,String name, float isolation, int tint) { super(properties.maxStackSize(1).group(ItemGroup.TOOLS)); if (isolation < 0 || isolation > 1) throw new IllegalArgumentException("Can only be between 0 and 1!"); addPropertyOverride(open,(itemStack, worldIn, entityLivingBase) -> isOpen ? 1 : 0); this.isolation = isolation; this.tint = tint; setRegistryName(name); } public static ItemStack getContainedItemStack(ItemStack stack) { IItemHandler handler = stack.getCapability(CapabilityItemHandler.ITEM_HANDLER_CAPABILITY).orElseThrow(NullPointerException::new); return handler.getStackInSlot(0); } ... }   The renderer that should just render the stack somewhere visible on the camera for now and print out to the console: SingleStackGlassContainerItemRender.java @OnlyIn(Dist.CLIENT) public class SingleStackGlassContainerItemRender extends ItemStackTileEntityRenderer { @Override public void renderByItem(ItemStack itemStackIn) { System.out.println("Rendering it I guess."); // Doesn't get printed out to the console. if (itemStackIn.getItem() instanceof ItemSingleStackGlassContainer) { ItemStack itemStack = ItemSingleStackContainer.getContainedItemStack(itemStackIn); if (itemStack != ItemStack.EMPTY) { GlStateManager.pushMatrix(); Minecraft.getInstance().getItemRenderer().renderItem(itemStack, ItemCameraTransforms.TransformType.FIXED); GlStateManager.popMatrix(); } } } }  
    • Rohman
      [1.12.2 Build 2847] Server Crash on startup

      By Rohman · Posted 23 minutes ago

      Well aren't I the stupid idiot! Much appreciated for your time! ❤️
    • DaemonUmbra
      [1.12.2 Build 2847] Server Crash on startup

      By DaemonUmbra · Posted 45 minutes ago

      You are missing a mod that LittleTiles depends on, please re-read the mod’s CurseForge page
  • Topics

    • matt1999rd
      5
      [1.14-newer] how to keep value when closing minecraft

      By matt1999rd
      Started 21 hours ago

    • Kuaka
      1
      My Forge 1.12 and 1.12.2 Keep Crashing when i start it up

      By Kuaka
      Started 2 hours ago

    • Simon_kungen
      0
      [1.14.4] TileEntityItemStackSpecialRenderer (TEISR)

      By Simon_kungen
      Started 23 minutes ago

    • Rohman
      4
      [1.12.2 Build 2847] Server Crash on startup

      By Rohman
      Started 3 hours ago

    • JetCobblestone
      12
      [1.14] moving item assignment to a separate function

      By JetCobblestone
      Started 21 hours ago

  • Who's Online (See full list)

    • DaemonUmbra
    • vaartis
    • matt1999rd
    • Skydev
    • Simon_kungen
    • fcelon
    • JetCobblestone
  • All Activity
  • Home
  • Minecraft Forge
  • General Discussion
  • [Fixed]TileEntity var syncing
  • Theme
  • Contact Us
  • Discord

Copyright © 2019 ForgeDevelopment LLC · Ads by Curse Powered by Invision Community