Jump to content

[Solved] Manually set redstone power


tunasushi

Recommended Posts

Does anyone know how to turn redstone wire on by right clicking with an item, and returning it to normal when releasing right click? I am using this code, but it is not working properly:

public boolean onItemUse(ItemStack is, EntityPlayer player, World w, int x, int y, int z, int l, float f, float f1, float f3){
if(w.getBlockId(x, y, z) == Block.redstoneWire.blockID){
	w.setBlockMetadataWithNotify(x, y, z, 15, 3);
}
return false;
}

What happens is if I hold right click on a redstone wire, it will pulse on and off rapidly, and not effect any other wire in the circuit (visibly). If I place a door in the circuit, I can hear a door opening and closing, but nothing visual happens. Obviously, the problem is that the redstone is returning to its normal state as soon as I set it to powered, but is there any way to keep it powered throughout?

 

Thanks

Link to comment
Share on other sites

This is because redstone wires update frequently to keep up with changes to their circuitry. If theres a way around this, it's probably not worth the trouble it will give you. powering a redstone circuit in the normal way is already easy enough. If you really do MUST do this, I suppose we could some up with a solution. Also, you should return true from inside the if block. That method is supposed to return true when it succeeds and false when it fails. Yours always fails.

Link to comment
Share on other sites

You can create your own redstone block class by copying the code from the vanilla redstone block (inheriting may or may not be enough depending on if the methods/fields you need to access are set to private or protected.) Then change your custom class to always be on. Then, when right clicking vanilla redstone, change it to be your custom version of redstone and vice versa to turn it off. This is essentially replacing the redstone with a redstone torch, but makes it more discrete visually.

 

I haven't looked at any of that code, but if it uses tile entities in any way, make sure you clean them up when switching blocks or you'll encounter weird behavior.

width=336 height=83http://img836.imageshack.us/img836/1237/cooltext624963071.png[/img]

I make games, minecraft mods/plugins, and some graphic art.

 

Current Project: LoECraft - An industrial minecraft server with its own modpack and custom launcher.

Link to comment
Share on other sites

You can create your own redstone block class by copying the code from the vanilla redstone block (inheriting may or may not be enough depending on if the methods/fields you need to access are set to private or protected.) Then change your custom class to always be on. Then, when right clicking vanilla redstone, change it to be your custom version of redstone and vice versa to turn it off. This is essentially replacing the redstone with a redstone torch, but makes it more discrete visually.

 

I haven't looked at any of that code, but if it uses tile entities in any way, make sure you clean them up when switching blocks or you'll encounter weird behavior.

 

A very nice solution my friend. That is very well thought out. There are so many things one COULD do with a mod, but not many people harness the possibilities... Sorry for my soliloquy peeps xD

I am Mew. The Legendary Psychic. I behave oddly and am always playing practical jokes.

 

I have also found that I really love making extremely long and extremely but sometimes not so descriptive variables. Sort of like what I just did there xD

Link to comment
Share on other sites

You can create your own redstone block class by copying the code from the vanilla redstone block (inheriting may or may not be enough depending on if the methods/fields you need to access are set to private or protected.) Then change your custom class to always be on. Then, when right clicking vanilla redstone, change it to be your custom version of redstone and vice versa to turn it off. This is essentially replacing the redstone with a redstone torch, but makes it more discrete visually.

 

I haven't looked at any of that code, but if it uses tile entities in any way, make sure you clean them up when switching blocks or you'll encounter weird behavior.

 

Thanks for the suggestion, I'll try that and get back to you!

Link to comment
Share on other sites

Ok, I sorta got that working, but it's buggy as balls. I'm not entirely sure how to register when the user stops hold right clicking, so the block will stay my new redstone wire block until broken. I tried onPlayerStoppedUsing, but that doesn't work. How do I make it so that when I right click, it holds sort of like a bow does (and doesn't look like I'm spamming right click)? If the wire block I click has wires attached to sides opposite each other, it powers the circuit, otherwise, it will just glow red but not power anything else. Very weird. For the new redstone wire block, I pretty much copied the normal redstone wire block, but changed the getMaxCurrentStrength method to always return 15. Thanks for the help.

Link to comment
Share on other sites

I would suggest getting the block that you are looking at...

 

What I mean is, on item right click, get the block you clicked, and then using the functions of that block ( after checking that it is indeed a redstone wire that has been clicked ), set the power to max.

I am Mew. The Legendary Psychic. I behave oddly and am always playing practical jokes.

 

I have also found that I really love making extremely long and extremely but sometimes not so descriptive variables. Sort of like what I just did there xD

Link to comment
Share on other sites

Ok it works sort of well now. When you right click a piece of redstone it will turn on for 1 second then turn off (like a button). The problem is that it only works on some pieces of redstone, specifically with ones that have redstone wire on two opposite sides. If it does't have redstone wire on two opposite sides, the redstone will still light up and power anything directly adjacent, but will not propagate to any other redstone wire. I am almost sure this is a problem with the getMaxCurrentStrength method. I set it to always return 15 (max power) for my new redstone wire. Does anyone who knows how redstone calculations work know of a way to keep it powered without the glitchiness that I am running into? Thanks.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.