Jump to content

Bow render in 3rd person


Fruitsalid

Recommended Posts

My custom bow renders oddly in 3rd person http://imagebin.org/266375

I just have an item class

public class ItemBow extends ItemBow
{
public static final String[] bowPullIconNameArray = new String[] {"mybow_pull_0", "mybow_pull_1", "mybow_pull_2"};
@SideOnly(Side.CLIENT)
private Icon[] iconArray;

public ItemBow (int par1)
{
	super(par1);
	this.maxStackSize = 1;
	this.setMaxDamage(384);
	this.setCreativeTab(MainClass.Tab);
}

/**
 * called when the player releases the use item button. Args: itemstack, world, entityplayer, itemInUseCount
 */
public void onPlayerStoppedUsing(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer, int par4)
{
	int j = this.getMaxItemUseDuration(par1ItemStack) - par4;

	ArrowLooseEvent event = new ArrowLooseEvent(par3EntityPlayer, par1ItemStack, j);
	MinecraftForge.EVENT_BUS.post(event);
	if (event.isCanceled())
	{
		return;
	}
	j = event.charge;

	boolean flag = par3EntityPlayer.capabilities.isCreativeMode || EnchantmentHelper.getEnchantmentLevel(Enchantment.infinity.effectId, par1ItemStack) > 0;

	if (flag || par3EntityPlayer.inventory.hasItem(Item.arrow.itemID))
	{
		float f = (float)j / 10.0F;
		f = (f * f + f * 2.0F) / 3.0F;

		if ((double)f < 0.1D)
		{
			return;
		}

		if (f > 1.0F)
		{
			f = 1.0F;
		}

		EntityArrow entityarrow = new EntityArrow(par2World, par3EntityPlayer, f * 2.0F);

		if (f == 1.0F)
		{
			entityarrow.setIsCritical(true);
		}

		int k = EnchantmentHelper.getEnchantmentLevel(Enchantment.power.effectId, par1ItemStack);

		if (k > 0)
		{
			entityarrow.setDamage(entityarrow.getDamage() + (double)k * 0.5D + 0.5D);
		}

		int l = EnchantmentHelper.getEnchantmentLevel(Enchantment.punch.effectId, par1ItemStack);

		if (l > 0)
		{
			entityarrow.setKnockbackStrength(l);
		}

		if (EnchantmentHelper.getEnchantmentLevel(Enchantment.flame.effectId, par1ItemStack) > 0)
		{
			entityarrow.setFire(100);
		}

		par1ItemStack.damageItem(1, par3EntityPlayer);
		par2World.playSoundAtEntity(par3EntityPlayer, "random.bow", 1.0F, 1.0F / (itemRand.nextFloat() * 0.4F + 1.2F) + f * 0.5F);

		if (flag)
		{
			entityarrow.canBePickedUp = 2;
		}
		else
		{
			par3EntityPlayer.inventory.consumeInventoryItem(Item.arrow.itemID);
		}

		if (!par2World.isRemote)
		{
			par2World.spawnEntityInWorld(entityarrow);
		}
	}
}

public ItemStack onEaten(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer)
{
	return par1ItemStack;
}

/**
 * How long it takes to use or consume an item
 */
public int getMaxItemUseDuration(ItemStack par1ItemStack)
{
	return 72000;
}

/**
 * returns the action that specifies what animation to play when the items is being used
 */
public EnumAction getItemUseAction(ItemStack par1ItemStack)
{
	return EnumAction.bow;
}

/**
 * Called whenever this item is equipped and the right mouse button is pressed. Args: itemStack, world, entityPlayer
 */
public ItemStack onItemRightClick(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer)
{
	ArrowNockEvent event = new ArrowNockEvent(par3EntityPlayer, par1ItemStack);
	MinecraftForge.EVENT_BUS.post(event);
	if (event.isCanceled())
	{
		return event.result;
	}

	if (par3EntityPlayer.capabilities.isCreativeMode || par3EntityPlayer.inventory.hasItem(Item.arrow.itemID))
	{
		par3EntityPlayer.setItemInUse(par1ItemStack, this.getMaxItemUseDuration(par1ItemStack));
	}

	return par1ItemStack;
}

/**
 * Return the enchantability factor of the item, most of the time is based on material.
 */
public int getItemEnchantability()
{
	return 1;
}

@SideOnly(Side.CLIENT)
public void registerIcons(IconRegister par1IconRegister)
{
	this.itemIcon = par1IconRegister.registerIcon("blalalal" + ":" + getUnlocalizedName());
	this.iconArray = new Icon[bowPullIconNameArray.length];

	for (int i = 0; i < this.iconArray.length; ++i)
	{
		this.iconArray[i] = par1IconRegister.registerIcon(MagicElementsMod.modid + ":" + bowPullIconNameArray[i]);
	}
}

@SideOnly(Side.CLIENT)

/**
 * used to cycle through icons based on their used duration, i.e. for the bow
 */
public Icon getIcon(ItemStack stack, int renderPass, EntityPlayer player, ItemStack usingItem, int useRemaining)
{
	if(player.getItemInUse() == null) return this.itemIcon;
	int Pulling = stack.getMaxItemUseDuration() - useRemaining;
	if (Pulling >= 18)
	{
		return iconArray[2];
	}
	else if (Pulling > 13)
	{
		return iconArray[1];
	}
	else if (Pulling > 0)
	{
		return iconArray[0];
	}              
	return itemIcon;
}
}

 

Anyone know whats wrong

Link to comment
Share on other sites

this.itemIcon = par1IconRegister.registerIcon("blalalal" + ":" + getUnlocalizedName());

Is this line supposed to work ?

 

public class ItemBow extends ItemBow

:o

 

I you knew your java...

public class ModBow extends ItemBow{
public static final String[] bowPullIconNameArray = new String[] {"mybow_pull_0", "mybow_pull_1", "mybow_pull_2"};
@SideOnly(Side.CLIENT)
private Icon[] iconArray;

public ModBow (int par1)
{
	super(par1);
	this.setCreativeTab(MainClass.Tab);
}

/**
 * called when the player releases the use item button. Args: itemstack, world, entityplayer, itemInUseCount
 */
public void onPlayerStoppedUsing(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer, int par4)
{
	int j = this.getMaxItemUseDuration(par1ItemStack) - par4;

	ArrowLooseEvent event = new ArrowLooseEvent(par3EntityPlayer, par1ItemStack, j);
	MinecraftForge.EVENT_BUS.post(event);
	if (event.isCanceled())
	{
		return;
	}
	j = event.charge;

	boolean flag = par3EntityPlayer.capabilities.isCreativeMode || EnchantmentHelper.getEnchantmentLevel(Enchantment.infinity.effectId, par1ItemStack) > 0;

	if (flag || par3EntityPlayer.inventory.hasItem(Item.arrow.itemID))
	{
		float f = (float)j / 10.0F;
		f = (f * f + f * 2.0F) / 3.0F;

		if ((double)f < 0.1D)
		{
			return;
		}

		if (f > 1.0F)
		{
			f = 1.0F;
		}

		EntityArrow entityarrow = new EntityArrow(par2World, par3EntityPlayer, f * 2.0F);

		if (f == 1.0F)
		{
			entityarrow.setIsCritical(true);
		}

		int k = EnchantmentHelper.getEnchantmentLevel(Enchantment.power.effectId, par1ItemStack);

		if (k > 0)
		{
			entityarrow.setDamage(entityarrow.getDamage() + (double)k * 0.5D + 0.5D);
		}

		int l = EnchantmentHelper.getEnchantmentLevel(Enchantment.punch.effectId, par1ItemStack);

		if (l > 0)
		{
			entityarrow.setKnockbackStrength(l);
		}

		if (EnchantmentHelper.getEnchantmentLevel(Enchantment.flame.effectId, par1ItemStack) > 0)
		{
			entityarrow.setFire(100);
		}

		par1ItemStack.damageItem(1, par3EntityPlayer);
		par2World.playSoundAtEntity(par3EntityPlayer, "random.bow", 1.0F, 1.0F / (itemRand.nextFloat() * 0.4F + 1.2F) + f * 0.5F);

		if (flag)
		{
			entityarrow.canBePickedUp = 2;
		}
		else
		{
			par3EntityPlayer.inventory.consumeInventoryItem(Item.arrow.itemID);
		}

		if (!par2World.isRemote)
		{
			par2World.spawnEntityInWorld(entityarrow);
		}
	}
}

@SideOnly(Side.CLIENT)
public void registerIcons(IconRegister par1IconRegister)
{
	this.itemIcon = par1IconRegister.registerIcon(MagicElementsMod.modid + ":" + getUnlocalizedName());
	this.iconArray = new Icon[bowPullIconNameArray.length];

	for (int i = 0; i < this.iconArray.length; ++i)
	{
		this.iconArray[i] = par1IconRegister.registerIcon(MagicElementsMod.modid + ":" + bowPullIconNameArray[i]);
	}
}

@SideOnly(Side.CLIENT)

/**
 * used to cycle through icons based on their used duration, i.e. for the bow
 */
public Icon getIcon(ItemStack stack, int renderPass, EntityPlayer player, ItemStack usingItem, int useRemaining)
{
	if(player.getItemInUse() == null) return this.itemIcon;
	int Pulling = stack.getMaxItemUseDuration() - useRemaining;
	if (Pulling >= 18)
	{
		return iconArray[2];
	}
	else if (Pulling > 13)
	{
		return iconArray[1];
	}
	else if (Pulling > 0)
	{
		return iconArray[0];
	}              
	return itemIcon;
}
}

 

 

Link to comment
Share on other sites

this.itemIcon = par1IconRegister.registerIcon("blalalal" + ":" + getUnlocalizedName());

Is this line supposed to work ?

 

public class ItemBow extends ItemBow

:o

 

I you knew your java...

public class ModBow extends ItemBow{
public static final String[] bowPullIconNameArray = new String[] {"mybow_pull_0", "mybow_pull_1", "mybow_pull_2"};
@SideOnly(Side.CLIENT)
private Icon[] iconArray;

public ModBow (int par1)
{
	super(par1);
	this.setCreativeTab(MainClass.Tab);
}

/**
 * called when the player releases the use item button. Args: itemstack, world, entityplayer, itemInUseCount
 */
public void onPlayerStoppedUsing(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer, int par4)
{
	int j = this.getMaxItemUseDuration(par1ItemStack) - par4;

	ArrowLooseEvent event = new ArrowLooseEvent(par3EntityPlayer, par1ItemStack, j);
	MinecraftForge.EVENT_BUS.post(event);
	if (event.isCanceled())
	{
		return;
	}
	j = event.charge;

	boolean flag = par3EntityPlayer.capabilities.isCreativeMode || EnchantmentHelper.getEnchantmentLevel(Enchantment.infinity.effectId, par1ItemStack) > 0;

	if (flag || par3EntityPlayer.inventory.hasItem(Item.arrow.itemID))
	{
		float f = (float)j / 10.0F;
		f = (f * f + f * 2.0F) / 3.0F;

		if ((double)f < 0.1D)
		{
			return;
		}

		if (f > 1.0F)
		{
			f = 1.0F;
		}

		EntityArrow entityarrow = new EntityArrow(par2World, par3EntityPlayer, f * 2.0F);

		if (f == 1.0F)
		{
			entityarrow.setIsCritical(true);
		}

		int k = EnchantmentHelper.getEnchantmentLevel(Enchantment.power.effectId, par1ItemStack);

		if (k > 0)
		{
			entityarrow.setDamage(entityarrow.getDamage() + (double)k * 0.5D + 0.5D);
		}

		int l = EnchantmentHelper.getEnchantmentLevel(Enchantment.punch.effectId, par1ItemStack);

		if (l > 0)
		{
			entityarrow.setKnockbackStrength(l);
		}

		if (EnchantmentHelper.getEnchantmentLevel(Enchantment.flame.effectId, par1ItemStack) > 0)
		{
			entityarrow.setFire(100);
		}

		par1ItemStack.damageItem(1, par3EntityPlayer);
		par2World.playSoundAtEntity(par3EntityPlayer, "random.bow", 1.0F, 1.0F / (itemRand.nextFloat() * 0.4F + 1.2F) + f * 0.5F);

		if (flag)
		{
			entityarrow.canBePickedUp = 2;
		}
		else
		{
			par3EntityPlayer.inventory.consumeInventoryItem(Item.arrow.itemID);
		}

		if (!par2World.isRemote)
		{
			par2World.spawnEntityInWorld(entityarrow);
		}
	}
}

@SideOnly(Side.CLIENT)
public void registerIcons(IconRegister par1IconRegister)
{
	this.itemIcon = par1IconRegister.registerIcon(MagicElementsMod.modid + ":" + getUnlocalizedName());
	this.iconArray = new Icon[bowPullIconNameArray.length];

	for (int i = 0; i < this.iconArray.length; ++i)
	{
		this.iconArray[i] = par1IconRegister.registerIcon(MagicElementsMod.modid + ":" + bowPullIconNameArray[i]);
	}
}

@SideOnly(Side.CLIENT)

/**
 * used to cycle through icons based on their used duration, i.e. for the bow
 */
public Icon getIcon(ItemStack stack, int renderPass, EntityPlayer player, ItemStack usingItem, int useRemaining)
{
	if(player.getItemInUse() == null) return this.itemIcon;
	int Pulling = stack.getMaxItemUseDuration() - useRemaining;
	if (Pulling >= 18)
	{
		return iconArray[2];
	}
	else if (Pulling > 13)
	{
		return iconArray[1];
	}
	else if (Pulling > 0)
	{
		return iconArray[0];
	}              
	return itemIcon;
}
}

You do know that does nothing, right?

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.