Additional renderer fixes?(1.6)

[Cyan]

Hello  there,

 

So while 1.6 has had me swimming in texture changes, I have gotten those all pretty much fixed up. My question is about some of the other additional rendering changes. I have noticed that the scaling will not change, and any rendered text appears to not be showing up anymore. Sooo, just wondering if there is a newer/better method for this, or if I need to find a new way of doing this.

 

RenderDigimon file

import net.minecraft.client.Minecraft;
import net.minecraft.client.gui.FontRenderer;
import net.minecraft.client.model.ModelBase;
import net.minecraft.client.renderer.Tessellator;
import net.minecraft.client.renderer.entity.RenderLiving;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLiving;
import net.minecraft.util.ResourceLocation;


import org.lwjgl.opengl.GL11;

import digimobs.Entities.EntityDigimon;

public class RenderDigimon extends RenderLiving
{
float scale;
    public RenderDigimon(float f, ModelBase model, float scale)
    {
    	
        super(model, f);
        this.scale = scale;
       
    }
    
    
    
    protected void preRenderScale(EntityDigimon entitygiantzombie, float f)
    {
        GL11.glScalef(scale, scale, scale);
    }
    
    protected void passSpecialRender(EntityLiving entityliving, double d, double d1, double d2)
    {
        renderName((EntityDigimon)entityliving, entityliving, d, d1+entityliving.height/2, d2);
    }
    
    protected void renderName(EntityDigimon entityplayer,EntityLiving entityliving, double d, double d1, double d2)
    {
    	 EntityDigimon digimonScreen = entityplayer;	
        if(Minecraft.isGuiEnabled() && (entityliving instanceof EntityDigimon) && entityplayer != renderManager.livingPlayer && digimonScreen.isTamed())
        {
        	 
        	float f = 1.6F;
            float f1 = 0.01666667F * f;
            float f2 = entityplayer.getDistanceToEntity(renderManager.livingPlayer);
            float f3 = entityplayer.isSneaking() ? 32F : 64F;
            if(f2 < f3)
            {
               String s = new StringBuilder().append(entityplayer.getNickname()).append(" lvl").append(entityplayer.getLevel()).toString();
               String s2 = "Status : ";
                if(digimonScreen.isSitting()){
              s2 = new StringBuilder().append("Status : ").append("Sitting").toString();
                }else{
              s2 = new StringBuilder().append("Status : ").append("Following").toString();
                }
                String s3 = new StringBuilder().append(" Owner:").append(digimonScreen.getOwnerName()).toString();
                if(!entityplayer.isSneaking())
                {
                    
                        renderLivingLabel(entityplayer, s, d, d1, d2, 64);
                        renderLivingLabel(entityplayer, s2, d, d1+0.2D, d2, 64);
                        renderLivingLabel(entityplayer, s3, d, d1-0.2D, d2, 64);
                    
                } else
                {
                	
                    FontRenderer fontrenderer = getFontRendererFromRenderManager();
                    GL11.glPushMatrix();
                    GL11.glTranslatef((float)d + 0.0F, (float)d1 + 2.3F, (float)d2);
                    GL11.glNormal3f(0.0F, 1.0F, 0.0F);
                    GL11.glRotatef(-renderManager.playerViewY, 0.0F, 1.0F, 0.0F);
                    GL11.glRotatef(renderManager.playerViewX, 1.0F, 0.0F, 0.0F);
                    GL11.glScalef(-f1, -f1, f1);
                    GL11.glDisable(2896 /*GL_LIGHTING*/);
                    GL11.glTranslatef(0.0F, 0.25F / f1, 0.0F);
                    GL11.glDepthMask(false);
                    GL11.glEnable(3042 /*GL_BLEND*/);
                    GL11.glBlendFunc(770, 771);
                    Tessellator tessellator = Tessellator.instance;
                    GL11.glDisable(3553 /*GL_TEXTURE_2D*/);
                    tessellator.startDrawingQuads();
                    int i = fontrenderer.getStringWidth(null) / 2;
                    tessellator.setColorRGBA_F(0.0F, 0.0F, 0.0F, 0.25F);
                    tessellator.addVertex(-i - 1, -1D, 0.0D);
                    tessellator.addVertex(-i - 1, 8D, 0.0D);
                    tessellator.addVertex(i + 1, 8D, 0.0D);
                    tessellator.addVertex(i + 1, -1D, 0.0D);
                    tessellator.draw();
                    GL11.glEnable(3553 /*GL_TEXTURE_2D*/);
                    GL11.glDepthMask(true);
                    fontrenderer.drawString(s, -fontrenderer.getStringWidth(s) / 2, 0, 0x20ffffff);
                    fontrenderer.drawString(s2, -fontrenderer.getStringWidth(s) / 2, 0, 0x20ffffff);
                  //  fontrenderer.drawString(s3, -fontrenderer.getStringWidth(s) / 2, 0, 0x20ffffff);
                    GL11.glEnable(2896 /*GL_LIGHTING*/);
                    GL11.glDisable(3042 /*GL_BLEND*/);
                    GL11.glColor4f(1.0F, 1.0F, 1.0F, 1.0F);
                    GL11.glPopMatrix();
                }
            }
        }
    }



    protected void preRenderCallback(EntityLiving entityliving, float f)
    {
        preRenderScale((EntityDigimon)entityliving, f);
    }

    public void renderModel(EntityLiving entityliving, double d, double d1, double d2, 
            float f, float f1)
    {
        super.doRenderLiving(entityliving, d, d1, d2, f, f1);
    }

    public void doRenderLiving(EntityLiving entityliving, double d, double d1, double d2, 
            float f, float f1)
    {
        renderModel(entityliving, d, d1, d2, f, f1);
    }

    public void doRender(Entity entity, double d, double d1, double d2, 
            float f, float f1)
    {
        renderModel((EntityLiving)entity, d, d1, d2, f, f1);
    }


    @Override
protected ResourceLocation func_110775_a(Entity entity) {
	return new ResourceLocation(((EntityDigimon) entity).getTexture());
}

}

 

[Cyan]

Bumping as I have not found a solution for this on my own, or through any poor attempts at research.

[GotoLink]

protected void passSpecialRender(EntityLiving entityliving, double d, double d1, double d2)
    {
        renderName((EntityDigimon)entityliving, entityliving, d, d1+entityliving.height/2, d2);
    }
    
    protected void renderName(EntityDigimon entityplayer,EntityLiving entityliving, double d, double d1, double d2)
    {
    	 EntityDigimon digimonScreen = entityplayer;
         if(Minecraft.isGuiEnabled() && (entityliving instanceof EntityDigimon) && ...

Why...

1) passing two times same argument in renderName ?

2) casting to EntityDigimon before checking if it is castable ?

3) saving an argument into a local variable ?

4) using such bad variable naming ?

 

When and where is passSpecialRender method called ?

 

How is that supposed to do anything interesting ?

public void renderModel(EntityLiving entityliving, double d, double d1, double d2, 
            float f, float f1)
    {
        super.doRenderLiving(entityliving, d, d1, d2, f, f1);
    }

    public void doRenderLiving(EntityLiving entityliving, double d, double d1, double d2, 
            float f, float f1)
    {
        renderModel(entityliving, d, d1, d2, f, f1);
    }

    public void doRender(Entity entity, double d, double d1, double d2, 
            float f, float f1)
    {
        renderModel((EntityLiving)entity, d, d1, d2, f, f1);
    }

Your code is looping here.

[Cyan]

While I thank you for pointing all of that out(and I am working on cleaning that up a bit at the moment), I'm more concerned about why my scale is no longer working. I'm wondering what has changed since 1.5, because all of this, despite as messy as it may be, worked just fine. I can't seem to find any details about renderer changes, so I was hoping there might be some information here.

[GotoLink]

The cleaner your code, the better for you and everyone reading it.

 

I'd recommend putting @Override annotation on each method you are supposedly overriding from the parent class.

If you are on Eclipse, it will give you an error message if the method isn't properly overridden.

You'll be able to update faster to Mojang method changes