Draco18s

That gets tricky. The only thing I can suggest is doing what I did back in 1.12: https://github.com/Draco18s/ReasonableRealism/blob/1.12.1/src/main/java/com/draco18s/hardlib/util/LootUtils.java I have not updated this class and it does some reflection magic to get access to things, but it will let you directly modify loot pools. Or at least, give you the information necessary to write such a hook.

Weird, it redirects to https://mcforge.readthedocs.io/en/1.13.x/ for me

Going to: https://mcforge.readthedocs.io/en/ Still leads to 1.12/1.13 (one would expect that regardless of what language you were in, it would take you to the current version) and 1.14/1.15 do not appear in the dropdown. https://mcforge.readthedocs.io/ works as expected though.

Because you're waiting for RenderWorldLastEvent. As indicated by its name, it's last.

Or: don't worry about it. Players have a general acceptance that when chunks are unloaded, nothing happens there. As an example, lets say that your players make a server and zero players are online for a period of 8 hours. How much ash should build up?

We aren't stopping you. Its not illegal. It just might not be wholly accurate.

pop already resets translation. That's the whole point of the pop (push/pop "the matrix" which refers to the transformation matrix, which covers translation, scale, and rotation as well as projection (roughly, the field of view)).

(And its not ready yet.)

1.12 is no longer supported.

If you spent 15 seconds looking at the net.minecraft.items package you'd notice that all the classes are FooItem, not ItemFoo. that is You want SwordItem not ItemSword.

(Similarly some things may only exist in the dedicated server distribution, but is going to be a much, much shorter list that is largely irrelevant for modding).

I didn't either, but I am aware that there are things that I am not aware of. (Any other comments on that PR? I've been literally begging for feedback for months). Thanks.

Works for me, I just wanted to query whether or not that was the best practice for something like this.

Based on comments from Lex on my PR for global loot modifiers (so that modders don't need to replace loot tables when creating new enchantments and other effects), one of the sample test mods is set as making a specific item act like silk touch (the use-case was someone wanted one of their mod items to silk-touch harvest glass blocks and only glass blocks, the test mod doesn't do the check for glass, but the general process is going to be the same). As such, invoking the existing loot tables with the extra context parameter (or rather, a modified itemstack parameter) in order to not make assumptions about what silk touch actually does (as someone could create a block that drops something besides itself when harvested with silk touch) to generate the correct loot is the correct approach. However, this requires rebuilding the LootContext object and Lex made this comment: https://github.com/MinecraftForge/MinecraftForge/pull/6401#discussion_r363968404 What is the better way to do this? Using reflection to access the private-final fields does not feel correct to me, as any changes made need to be undone after invoking the loot table generate (as there may be future loot modifiers waiting to be processed), which is why I (attempted to) clone the context object.

Can you please stop making your posts entirely unreadable? Thanks.

Oh hey look. A static initializer. Don't do this. It fucks everything up. Problematic Code #8. This is literally what @ObjectHolders are for. Not this garbage. Edit, I see you're using this to register your blocks. Don't do this either. Just call new inside the registry event.

Ok. Let me very, very blunt here. Explain your problem and post all relevant code, preferably as a git repo. Your last several posts have flip-flopped back and forth over what you did (or didn't do), that it worked (or didn't), and trying to ask a question about why what you did worked (or didn't) that I have no fucking clue what it is you're asking me (including whether or not you still have a problem!).

1.14 is mostly the same as 1.13, which is why it didn't get updates.

...what? Of course it works with "the basic forge" (there is Forge and there is Forge, there aren't "extra plugins"). Your question makes no sense.

I misunderstood. Yes. You need the forge_marker in order to use forge states.

This is new. Just had to do a search for it, as this is the first I'd heard of it. I hadn't read this thread when it was new:

If it "does the same thing with or without that line" then that line isn't related to the error. (That line is what lets you specify two variants once each, rather than X*Y times)

What do you want to display there?

This is what advacements are for. Look at the vanilla data package data/minecraft/advacements/recipes