Jump to content

Hoping1

Members
  • Posts

    10
  • Joined

  • Last visited

Recent Profile Visitors

The recent visitors block is disabled and is not being shown to other users.

Hoping1's Achievements

Tree Puncher

Tree Puncher (2/8)

2

Reputation

  1. Worked like a charm, thanks! Fancy trees are a little more complicated but I worked them out the same way and looking at the defaultbiomefeatures.java if anyone's curious.
  2. I'm trying to make a biome where the top layer is snow blocks, but of course, no trees are spawning. My immediate solution is just to copy one of the existing tree classes and modify it so it can spawn on snow blocks. How do I do that? Where are the blocks it can spawn on set?
  3. I don't know if this is what you meant but I changed the code so it only declares the HOP_MOB in EntitiesList but doesn't set it to anything until the items registry event (shown below) and just for the heck of it I decided to run AND IT WORKED!! HopMobs are naturally spawning in my world now. THANK you so much, and I'm surprised that the code I took from a 1.14 tutorial is obsolete in that way, of all the possible ways, lol. public class EntitiesList { public static EntityType<?> HOP_MOB; and @SubscribeEvent public static void registerItems(final RegistryEvent.Register<Item> event) { event.getRegistry().registerAll( ItemList.hoping_item = new Item(new Item.Properties().group(ItemGroup.MISC)).setRegistryName(location("hoping_item")), ItemList.hoping_hoe = new HoeItem(ToolMaterialList.hopingmod, 0.0f, new Item.Properties().group(ItemGroup.MISC)).setRegistryName(location("hoping_hoe")), ItemList.hoping_boots = new ArmorItem(ArmorMaterialList.hopingmod, EquipmentSlotType.FEET, new Item.Properties().group(ItemGroup.MISC)).setRegistryName(location("hoping_boots")), ItemList.hoping_block = new BlockItem(BlockList.hoping_block, new Item.Properties().group(ItemGroup.MISC)).setRegistryName(BlockList.hoping_block.getRegistryName()), ItemList.hoping_ore = new BlockItem(BlockList.hoping_ore, new Item.Properties().group(ItemGroup.MISC)).setRegistryName(BlockList.hoping_ore.getRegistryName()), ItemList.hoping_ore_nether = new BlockItem(BlockList.hoping_ore_nether, new Item.Properties().group(ItemGroup.MISC)).setRegistryName(BlockList.hoping_ore_nether.getRegistryName()) ); EntitiesList.HOP_MOB = EntityType.Builder.create(HopMob::new, EntityClassification.CREATURE).build(HopingMod.modid+":hop_mob").setRegistryName(new ResourceLocation(HopingMod.modid, "hop_mob")); EntitiesList.registerEntitySpawnEggs(event); logger.info("Items registered"); } Hopefully, this helps someone besides me, and again, thank you! You have no idea how long I've been looking for how to fix this lmao
  4. I'm confused. You mean don't register the spawn egg until the entity registry event? No, I haven't. Where do I find the vanilla code?
  5. Some console logs that I think might be pertinent, though I'm not a good enough modder to make anything useful out of them. You can see above the line in the HopingMod.java file where I log the logged message. The logs here look the same here as they do elsewhere, except of course for the logged message. [m[36m[18:11:26] [Render thread/DEBUG] [ne.mi.fm.ModList/LOADING]: Dispatching synchronous event LifecycleEvent:LOAD_REGISTRIES [m[36m[18:11:26] [Render thread/DEBUG] [ne.mi.fm.ja.FMLModContainer/LOADING]: Firing event for modid forge : RegistryEvent.Register<minecraft:enchantment> [m[36m[18:11:26] [Render thread/DEBUG] [ne.mi.fm.ja.FMLModContainer/LOADING]: Fired event for modid forge : RegistryEvent.Register<minecraft:enchantment> [m[36m[18:11:26] [Render thread/DEBUG] [ne.mi.fm.ja.FMLModContainer/LOADING]: Firing event for modid hopingmod : RegistryEvent.Register<minecraft:enchantment> [m[36m[18:11:26] [Render thread/DEBUG] [ne.mi.fm.ja.FMLModContainer/LOADING]: Fired event for modid hopingmod : RegistryEvent.Register<minecraft:enchantment> [m[36m[18:11:26] [Render thread/DEBUG] [ne.mi.re.GameData/REGISTRIES]: Applying holder lookups: minecraft:enchantment [m[36m[18:11:26] [Render thread/DEBUG] [ne.mi.re.GameData/REGISTRIES]: Holder lookups applied: minecraft:enchantment [m[36m[18:11:26] [Render thread/DEBUG] [ne.mi.fm.ModList/LOADING]: Dispatching synchronous event LifecycleEvent:LOAD_REGISTRIES [m[36m[18:11:26] [Render thread/DEBUG] [ne.mi.fm.ja.FMLModContainer/LOADING]: Firing event for modid forge : RegistryEvent.Register<minecraft:entity_type> [m[36m[18:11:26] [Render thread/DEBUG] [ne.mi.fm.ja.FMLModContainer/LOADING]: Fired event for modid forge : RegistryEvent.Register<minecraft:entity_type> [m[36m[18:11:26] [Render thread/DEBUG] [ne.mi.fm.ja.FMLModContainer/LOADING]: Firing event for modid hopingmod : RegistryEvent.Register<minecraft:entity_type> [m[32m[18:11:26] [Render thread/INFO] [hopingmod/]: entities registered [m[36m[18:11:26] [Render thread/DEBUG] [ne.mi.fm.ja.FMLModContainer/LOADING]: Fired event for modid hopingmod : RegistryEvent.Register<minecraft:entity_type> Can someone please help me?
  6. Fair enough, I'll change it. Do you know what's wrong with my natural spawn algorithm?
  7. I don't have a github. And yes, that's the tutorial. Forge documentation is effectively useless and there aren't really any 1.15 tutorials except cadiboo's unfinished one
  8. That line can't possibly be the reason it's broken unless I'm very confused about java. I got it from a tutorial but it makes sense to me. As for the full code, prepare for a wall of text: EntitiesList.java package com.hoping1.hopingmod.lists; import com.hoping1.hopingmod.HopingMod; import com.hoping1.hopingmod.entities.HopMob; import net.minecraft.entity.EntityClassification; import net.minecraft.entity.EntityType; import net.minecraft.item.Item; import net.minecraft.item.ItemGroup; import net.minecraft.item.SpawnEggItem; import net.minecraft.util.ResourceLocation; import net.minecraft.world.biome.Biome; import net.minecraft.world.biome.Biome.SpawnListEntry; import net.minecraft.world.biome.Biomes; import net.minecraftforge.event.RegistryEvent; public class EntitiesList { public static EntityType<?> HOP_MOB = EntityType.Builder.create(HopMob::new, EntityClassification.CREATURE).build(HopingMod.modid+":hop_mob").setRegistryName(new ResourceLocation(HopingMod.modid, "hop_mob")); public static Item registerEntitySpawnEgg(EntityType<?> type, int color1, int color2, String name) { SpawnEggItem item = new SpawnEggItem(type, color1, color2, new Item.Properties().group(ItemGroup.MISC)); item.setRegistryName(new ResourceLocation(HopingMod.modid, name)); return item; } public static void registerEntitySpawnEggs(final RegistryEvent.Register<Item> event) { event.getRegistry().registerAll( ItemList.hop_mob_egg = registerEntitySpawnEgg(HOP_MOB, 0x00ffff, 0xaaffaa, "hop_mob_egg") ); } public static void registerEntityWorldSpawn(EntityType<?> entity, Biome... biomes) { for (Biome biome : biomes) { if (biome != null) { biome.getSpawns(entity.getClassification()).add(new SpawnListEntry(entity, 1000, 2, 10)); } } } public static void registerEntityWorldSpawns() { registerEntityWorldSpawn(HOP_MOB, Biomes.FOREST, Biomes.BIRCH_FOREST, Biomes.DARK_FOREST, Biomes.BIRCH_FOREST_HILLS, Biomes.DARK_FOREST_HILLS, Biomes.FLOWER_FOREST, Biomes.TALL_BIRCH_FOREST); } } HopingMod.java package com.hoping1.hopingmod; import org.apache.logging.log4j.Logger; import com.hoping1.hopingmod.client.render.HopingRenderRegistry; import com.hoping1.hopingmod.lists.ArmorMaterialList; import com.hoping1.hopingmod.lists.BlockList; import com.hoping1.hopingmod.lists.EntitiesList; import com.hoping1.hopingmod.lists.ItemList; import com.hoping1.hopingmod.lists.ToolMaterialList; import com.hoping1.hopingmod.world.OreGeneration; import org.apache.logging.log4j.LogManager; import net.minecraft.block.Block; import net.minecraft.block.material.Material; import net.minecraft.entity.EntityType; import net.minecraft.item.ArmorItem; import net.minecraft.item.BlockItem; import net.minecraft.item.HoeItem; import net.minecraft.item.Item; import net.minecraft.item.ItemGroup; import net.minecraft.util.ResourceLocation; import net.minecraftforge.common.MinecraftForge; import net.minecraftforge.event.RegistryEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.fml.common.Mod; import net.minecraftforge.fml.event.lifecycle.FMLClientSetupEvent; import net.minecraftforge.fml.event.lifecycle.FMLCommonSetupEvent; import net.minecraftforge.fml.javafmlmod.FMLJavaModLoadingContext; import net.minecraft.inventory.EquipmentSlotType; @Mod("hopingmod") public class HopingMod { public static HopingMod instance; public static String modid = "hopingmod"; private static Logger logger = LogManager.getLogger(modid); public HopingMod() { instance = this; FMLJavaModLoadingContext.get().getModEventBus().addListener(this::setup); FMLJavaModLoadingContext.get().getModEventBus().addListener(this::clientRegistries); MinecraftForge.EVENT_BUS.register(this); }; private void setup(final FMLCommonSetupEvent event) { OreGeneration.setupOreGeneration(); logger.info("Setup method registered"); }; private void clientRegistries(final FMLClientSetupEvent event) { HopingRenderRegistry.registryEntityRenders(); logger.info("clientRegistries method registered"); } @Mod.EventBusSubscriber(bus=Mod.EventBusSubscriber.Bus.MOD) public static class RegistryEvents{ @SubscribeEvent public static void registerItems(final RegistryEvent.Register<Item> event) { event.getRegistry().registerAll( ItemList.hoping_item = new Item(new Item.Properties().group(ItemGroup.MISC)).setRegistryName(location("hoping_item")), ItemList.hoping_hoe = new HoeItem(ToolMaterialList.hopingmod, 0.0f, new Item.Properties().group(ItemGroup.MISC)).setRegistryName(location("hoping_hoe")), ItemList.hoping_boots = new ArmorItem(ArmorMaterialList.hopingmod, EquipmentSlotType.FEET, new Item.Properties().group(ItemGroup.MISC)).setRegistryName(location("hoping_boots")), ItemList.hoping_block = new BlockItem(BlockList.hoping_block, new Item.Properties().group(ItemGroup.MISC)).setRegistryName(BlockList.hoping_block.getRegistryName()), ItemList.hoping_ore = new BlockItem(BlockList.hoping_ore, new Item.Properties().group(ItemGroup.MISC)).setRegistryName(BlockList.hoping_ore.getRegistryName()), ItemList.hoping_ore_nether = new BlockItem(BlockList.hoping_ore_nether, new Item.Properties().group(ItemGroup.MISC)).setRegistryName(BlockList.hoping_ore_nether.getRegistryName()) ); EntitiesList.registerEntitySpawnEggs(event); logger.info("Items registered"); } @SubscribeEvent public static void registerBlocks(final RegistryEvent.Register<Block> event) { event.getRegistry().registerAll( BlockList.hoping_block = new Block(Block.Properties.create(Material.IRON).hardnessAndResistance(2.0f, 3.0f).lightValue(5)).setRegistryName(location("hoping_block")), BlockList.hoping_ore = new Block(Block.Properties.create(Material.ROCK).hardnessAndResistance(2.0f, 3.0f)).setRegistryName(location("hoping_ore")), BlockList.hoping_ore_nether = new Block(Block.Properties.create(Material.ROCK).hardnessAndResistance(2.0f, 3.0f)).setRegistryName(location("hoping_ore_nether")) ); logger.info("blocks registered"); } @SubscribeEvent public static void registerEntities(final RegistryEvent.Register<EntityType<?>> event) { event.getRegistry().registerAll(EntitiesList.HOP_MOB); EntitiesList.registerEntityWorldSpawns(); logger.info("entities registered"); } private static ResourceLocation location(String name) { return new ResourceLocation(modid, name); } } } No errors and absolutely everything works perfectly except that the HopMob entities don't spawn naturally. If you want code from other files just ask!
  9. This was originally posted in another thread but I think it makes much more sense as its own question. How do you register entity world spawns in 1.15.1? I looked through Cadiboo's tutorial but he hasn't gotten to that bit yet. The code I have is public static void registerEntityWorldSpawn(EntityType<?> entity, Biome... biomes) { for (Biome biome : biomes) { if (biome != null) { biome.getSpawns(entity.getClassification()).add(new SpawnListEntry(entity, 10, 2, 10)); } } } which is called as registerEntityWorldSpawn(HOP_MOB, Biomes.FOREST, Biomes.BIRCH_FOREST, Biomes.DARK_FOREST, Biomes.BIRCH_FOREST_HILLS, Biomes.DARK_FOREST_HILLS, Biomes.FLOWER_FOREST, Biomes.TALL_BIRCH_FOREST); in a @SubscribeEvent public static void registerEntities(final RegistryEvent.Register<EntityType<?>> event) {} which is itself in a @Mod.EventBusSubscriber(bus=Mod.EventBusSubscriber.Bus.MOD) public static class RegistryEvents{} Within my main mod class. Sorry for the odd format but it felt the cleanest way to share my code. I know enough java to know that it isn't some basic syntax error, and anyway, when I run it I don't get any errors. The issue is the mob doesn't spawn naturally at all. I can spawn it in fine with my custom spawn egg and it works perfectly, so the issue is only with natural world spawns. The method I'm using, as seen above, was taken from a 1.14 tutorial released in July 2019, so the reason it doesn't work definitely has to do with something specific to 1.15. That's all the useful info I have, unfortunately. And if I'm wrong in any of my assumptions please let me know. Thanks!
  10. How do you register entity world spawns in 1.15.1? I looked through your tutorial but you haven't gotten to that bit yet. The code I have is public static void registerEntityWorldSpawn(EntityType<?> entity, Biome... biomes) { for (Biome biome : biomes) { if (biome != null) { biome.getSpawns(entity.getClassification()).add(new SpawnListEntry(entity, 10, 2, 10)); } } } which is called as registerEntityWorldSpawn(HOP_MOB, Biomes.FOREST, Biomes.BIRCH_FOREST, Biomes.DARK_FOREST, Biomes.BIRCH_FOREST_HILLS, Biomes.DARK_FOREST_HILLS, Biomes.FLOWER_FOREST, Biomes.TALL_BIRCH_FOREST); in a @SubscribeEvent public static void registerEntities(final RegistryEvent.Register<EntityType<?>> event) {} which is itself in a @Mod.EventBusSubscriber(bus=Mod.EventBusSubscriber.Bus.MOD) public static class RegistryEvents{} Within my main mod class. I know enough java to know that it isn't some basic syntax error, and anyway, when I run it I don't get any errors. The issue the mob doesn't spawn naturally at all. I can spawn it in fine with my custom spawn egg and it works perfectly, so the issue is only with natural world spawns. The method im using, as seen above, was taken from a 1.14 tutorial released July 2019, so the reason it doesn't work definitely has to do with something specific to 1.15. That's all the useful info I have, unfortunately. And if I'm wrong in any of my assumptions please let me know. Thanks! EDIT: Reposted as its own thread because of logic
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.