CAS_ual_TY

I removed the code you are right. I was thinking I would be posting a general concept instead of someone's code which is obviously not true. I should have emphasized it a bit more that I was looking for something the glScissor solution. I mentioned it slightly below the spoiler but I should have been more clear. Thank you, this is exactly what I was looking for. The following is how I did it:

Hello, I would like to render my GUI content inside a certain rectangle with anything beyond the edge of that rectangle getting cut off. I have looked into the advancement GUI for that but it is honestly too confusing for me. (I also tried google) If anyone could point me in the right direction that would be great. I would really like to understand how this works. I mean I could also just check every single element, if it is at the edge and then adjust it, but I am quite sure there is a simpler solution to this (?). Thanks in advance! Any tip or piece of knowledge would be greatly appreciated EDIT: Fixed spoiler and formatting

The greatest Version will always be the newest version. Simply because the additions give you so many new possibilities you did not have before. Sure, a lot of things are lost and some stuff might become harder, but in the end the advantages outweight the disadvantages. Take the last 2 game breakers as an example: Integrated server, 1.3 -> (almost all) mods are now universal Resource Packs, 1.8 -> 3D items and customization have never been easier etc. As an example, I am currently creating another gun mod for 1.12.2. I myself am creating it in 2D but if any user wants to turn it into a 3D mod, he can do that any time now. Go back a couple of versions and things like this are a lot harder to do. The modders who claim that 1.7 is the best version are simply too lazy to adapt. But at some point enough 1.7 "mainstream" mods will be replaceable by new mods on the newest version and the 1.7 leftovers will switch to the new minecraft versions.

NBT, I planned on making the mod opensource anyways. Ill do that the next days. This is my acc: https://github.com/cas-ual-ty

Its easier to make just all different overlays and then overlay them onto the item using IBakedModel. So my item has 6 different layers overlayed onto it. For each layer I have made the different json models and textures, I have not done any combinations, those are done in code. Ill just share my code with you, I think its pretty self explaining, but some comments are there making it easy to understand: @Override public void registerGun(IForgeRegistry<Item> registry, ItemGun gun) { super.registerGun(registry, gun); registeredGuns.add(gun); ModelResourceLocation main = new ModelResourceLocation(GunCus.MOD_ID + ":" + gun.getModelRL() + "/gun", "inventory"); ModelLoader.setCustomModelResourceLocation(gun, 0, main); ArrayList<ModelResourceLocation> list = new ArrayList<ModelResourceLocation>(); list.add(main); int i; int j; Attachment attachment; for(i = 0; i < EnumAttachmentType.values().length; ++i) //All layers { for(j = 0; j < Attachment.getAmmountForSlot(i); ++j) //All attachments per layer { if(gun.canSetAttachment(i, j)) //Check if attachment is compatible { attachment = Attachment.getAttachment(i, j); if(attachment != null && attachment.shouldLoadModel()) //null-attachment exists, as well as some which are not visible { list.add(new ModelResourceLocation(GunCus.MOD_ID + ":" + gun.getModelRL() + "/" + attachment.getModelRL(), "inventory")); //Add MRL to the list } } } } ModelBakery.registerItemVariants(gun, list.toArray(new ModelResourceLocation[list.size()])); //Register all attachment MRLs found so that they will be loaded } @SubscribeEvent public void modelBake(ModelBakeEvent event) { int i; int j; Attachment attachment; ModelResourceLocation mrl; IBakedModel main; IBakedModel[][] models; //These are the attachment models which will be passed onto the gun model for use for(ItemGun gun : ProxyClient.registeredGuns) //Cycle through all guns { models = new IBakedModel[EnumAttachmentType.values().length][]; for(i = 0; i < models.length; ++i) //This represents the layers { models[i] = new IBakedModel[Attachment.getAmmountForSlot(i)]; for(j = 0; j < Attachment.getAmmountForSlot(i); ++j) //Ammount of attachments for each layer { if(gun.canSetAttachment(i, j)) //Check if compatible { attachment = Attachment.getAttachment(i, j); if(attachment != null && attachment.shouldLoadModel()) //Make sure its not null-attachment and the model is needed { models[i][j] = event.getModelRegistry().getObject(new ModelResourceLocation(GunCus.MOD_ID + ":" + gun.getModelRL() + "/" + attachment.getModelRL(), "inventory")); //Add attachment model to the array } } } } mrl = new ModelResourceLocation(GunCus.MOD_ID + ":" + gun.getModelRL() + "/gun", "inventory"); //This is the MRL of the main item (gun) main = event.getModelRegistry().getObject(mrl); //Get the model of the gun event.getModelRegistry().putObject(mrl, new BakedModelGun(main, models)); //Replace model of the gun with custom IBakedModel and pass all the attachment models to it } } public class BakedModelGun implements IBakedModel { /* * The only usage of this class is the item overrides list: * Basically get the itemstack, pass it onto the modelFinal, then return modelFinal for rendering, * so that during the rendering you have information about the itemstack */ private final IBakedModel modelMain; private final BakedModelGunFinalized modelFinal; private final OverridesList overridesList; public BakedModelGun(IBakedModel modelMain, IBakedModel[][] attachmentModels) { this.modelMain = modelMain; this.modelFinal = new BakedModelGunFinalized(this.modelMain, attachmentModels); this.overridesList = new OverridesList(this); } public BakedModelGunFinalized getModelFinal() { return modelFinal; } @Override public ItemOverrideList getOverrides() { return this.overridesList; } @Override public TextureAtlasSprite getParticleTexture() { return this.modelMain.getParticleTexture(); } @Override public List<BakedQuad> getQuads(IBlockState arg0, EnumFacing arg1, long arg2) { return this.modelMain.getQuads(arg0, arg1, arg2); } @Override public boolean isAmbientOcclusion() { return this.modelMain.isAmbientOcclusion(); } @Override public boolean isBuiltInRenderer() { return this.modelMain.isBuiltInRenderer(); } @Override public boolean isGui3d() { return this.modelMain.isGui3d(); } private static class OverridesList extends ItemOverrideList { private BakedModelGun modelGun; public OverridesList(BakedModelGun modelGun) { super(Collections.EMPTY_LIST); this.modelGun = modelGun; } @Override public IBakedModel handleItemState(IBakedModel originalModel, ItemStack itemStack, World world, EntityLivingBase entity) { return this.modelGun.getModelFinal().setCurrentItemStack(itemStack); } } } public class BakedModelGunFinalized implements IBakedModel { private final IBakedModel modelMain; private final IBakedModel[][] attachmentModels; private ItemStack itemStack; public BakedModelGunFinalized(IBakedModel modelMain, IBakedModel[][] attachmentModels) { this.modelMain = modelMain; this.attachmentModels = attachmentModels; this.itemStack = null; } public BakedModelGunFinalized setCurrentItemStack(ItemStack itemStack) { this.itemStack = itemStack; return this; } @Override public ItemOverrideList getOverrides() { return this.modelMain.getOverrides(); } @Override public TextureAtlasSprite getParticleTexture() { return this.modelMain.getParticleTexture(); } @Override public List<BakedQuad> getQuads(IBlockState arg0, EnumFacing arg1, long arg2) { ArrayList<BakedQuad> list = new ArrayList<BakedQuad>(); List<BakedQuad> list1 = this.modelMain.getQuads(arg0, arg1, arg2); ItemGun gun = (ItemGun) this.itemStack.getItem(); Paint paint = gun.<Paint>getAttachmentCalled(this.itemStack, EnumAttachmentType.PAINT.getSlot()); IBakedModel model; if(paint != null && paint.shouldRegister()) { model = this.attachmentModels[EnumAttachmentType.PAINT.getSlot()][paint.getID()]; if(model != null) { list1 = model.getQuads(arg0, arg1, arg2); } } if(list1 != null && !list1.isEmpty()) { list.addAll(list1); } List<BakedQuad> list2; Attachment attachment; for(int i = 0; i < EnumAttachmentType.values().length; ++i) { attachment = gun.getAttachment(itemStack, i); if(attachment != null && attachment.shouldRender()) { model = this.attachmentModels[i][attachment.getID()]; if(model != null) { list2 = model.getQuads(arg0, arg1, arg2); if(list2 != null && !list2.isEmpty()) { list.addAll(list2); } } } } return list; } @Override public boolean isAmbientOcclusion() { return this.modelMain.isAmbientOcclusion(); } @Override public boolean isBuiltInRenderer() { return this.modelMain.isBuiltInRenderer(); } @Override public boolean isGui3d() { return this.modelMain.isGui3d(); } private static final Matrix4f NULL_MATRIX = new Matrix4f(); @Override public Pair<? extends IBakedModel, Matrix4f> handlePerspective(TransformType transformType) { if(transformType == TransformType.FIRST_PERSON_RIGHT_HAND) { EntityPlayer entityPlayer = Minecraft.getMinecraft().player; if(entityPlayer != null && !entityPlayer.isSprinting() && !entityPlayer.isSneaking()) { if(entityPlayer.getHeldItemMainhand().getItem() instanceof ItemGun && entityPlayer.getHeldItemOffhand().isEmpty() && Minecraft.getMinecraft().gameSettings.keyBindUseItem.isKeyDown()) { ItemStack itemStack = entityPlayer.getHeldItemMainhand(); ItemGun gun = (ItemGun) itemStack.getItem(); Optic optic = gun.<Optic>getAttachmentCalled(itemStack, EnumAttachmentType.OPTIC.getSlot()); if(optic != null && optic.canAim()) { return Pair.of(this, NULL_MATRIX); } } } } return Pair.of(this, this.modelMain.handlePerspective(transformType).getRight()); } }

This 100% Once people stop downloading 1.7.x mods then their authors will be forced to quit or update.

readFromNBT contains all the basic stuff of an Entity: Position, motion, fall distance, if its on fire, prev tick rotation etc.. readEntityFromNBT is for classes which extend the Entity class to add their own new variables. So eg. the EntityTNT contains the fuse timer in there. readEntityFromNBT is abstract in the Entity class and gets called by readFromNBT.

Which tutorial did you use? Because from what I can see, your ModBlocks class is not registered to the event bus. I do not know if it is different with the registry stuff, but usually you register the class with your events by using MinecraftForge.EVENT_BUS.register(new_instance_of_your_class); Try add that to the preInit of your mod. In this case the instance would be a new ModBlocks instance.

I have already said that I am in fact defining the rotations in the json models and that I do not modify them in code at all. Here is an example: https://imgur.com/a/thAr5ET Anyways, I have found the solution to the problem. The IBakedModel interface has default methods which are defining that. I have simply added @Override public ItemCameraTransforms getItemCameraTransforms() { return this.modelMain.getItemCameraTransforms(); } @Override public boolean isAmbientOcclusion(IBlockState blockState) { return this.modelMain.isAmbientOcclusion(blockState); } @Override public Pair<? extends IBakedModel, Matrix4f> handlePerspective(TransformType transformType) { return this.modelMain.handlePerspective(transformType); } to the class. The modelMain field is of course the model which previously is stored at the ModelResourceLocation before it is replaced at that exact location with this IBakedModel. EDIT: So I figured some more stuff out. You need to do this instead: @Override public Pair<? extends IBakedModel, Matrix4f> handlePerspective(TransformType transformType) { return Pair.of(this, this.modelMain.handlePerspective(transformType).getRight()); }

Sorry, yes I should have asked more clearly but you nailed it. Rotation is what is off and I need to fix that in code. Basically in the IBakedModel different json models are simply combined and rendered together. Adding rotation inside these json models does not change anything, however. I have googled and it seems that i have to work with ICustomModelLoader ahd IModel, but I have had these questions above about that. Thanks in advance

- Check your common proxy for that import - Make sure a common class does not access a method statically of a class which imports client only stuff These are cases that can happen quickly and without intention (through human error or sometimes when IDEs do stuff) and I have seen them a couple of times already.

hello, itse me again. Basically I setup a working "structure" in which Items have different attachments which are then rendered overlayed on to the item. These attachments have multiple json models and textures: The model and texture of the attachment itself and a model and texture for each item it can be put on to. All IBakedModels are setup correctly and everything is working; except for the rotations, those are off. I have checked and this does not come from the json files (when not using IBakedModels then all rotations are fine, I also tested json+rotation+IBakedModel but the rotations there dont matter at all). Now, I have already researched a bit, about using IModel and ICustomModelLoader but I have questions: - Should I simply point ICustomModelLoader to a new IModel, which then just points to the IBakedModel and thats it? - IBakedModel requires a lot of other models so that i works which are fetched from the ModelBakeEvent. How would I get those when using the ICustomModelLoader? Would I use the ::onResourceManagerReload function to get these models? - Any examples out there I could take a look at? - This is the solution(s) I found via google. Any better ones out there?

Hello! Basically, I have an item which saves a lot of NBT data to an itemstack. Now, this data can become so huge, that when updating the data to the client, the client would be disconnected because of a too big packet. Now, this information is not needed on the client, so I disabled the updating of the NBT to the client. Everything works fine now, except for one thing: When moving the item around in the inventory, while in creative, it loses all stored data! I simply can not explain why or how. I have already tried using the specific nbt share tag method (commented out in the given code below), but that is also not working. I honestly have no idea anymore. Looking for help. Now before posting the code, you will see that I have added a debug output to the method which basically saves the data. This print does not get called at all, when just moving the item around. public class ItemStorage extends Item { public ItemStorage() { this.setMaxStackSize(1); this.setMaxDamage(0); this.setHasSubtypes(false); } @Override public ActionResult<ItemStack> onItemRightClick(World worldIn, EntityPlayer playerIn, EnumHand handIn) { playerIn.openGui(Dueling.instance, 5, worldIn, 0, 0, 0); // ContainerStorage container = (ContainerStorage) playerIn.openContainer; return super.onItemRightClick(worldIn, playerIn, handIn); } public static final String NBT_SIZE = "LIST_SIZE"; public NonNullList<ItemStack> getItems(ItemStack itemStack) { NBTTagCompound nbt = this.getSubCompound(itemStack); int size = nbt.getInteger(ItemStorage.NBT_SIZE); NonNullList<ItemStack> items = NonNullList.<ItemStack>withSize(size, ItemStack.EMPTY); ItemStorage.loadAllItems(nbt, items); return items; } public void setItems(ItemStack itemStack, NonNullList<ItemStack> items) { System.out.println("saving"); NBTTagCompound nbt = new NBTTagCompound(); nbt.setInteger(ItemStorage.NBT_SIZE, items.size()); ItemStorage.saveAllItems(nbt, items); this.setSubCompound(itemStack, nbt); } public NBTTagCompound getSubCompound(ItemStack itemStack) { if(!itemStack.hasTagCompound()) { itemStack.setTagCompound(new NBTTagCompound()); } return itemStack.getTagCompound().getCompoundTag(Dueling.MOD_ID); } public void setSubCompound(ItemStack itemStack, NBTTagCompound tag) { if(!itemStack.hasTagCompound()) { itemStack.setTagCompound(new NBTTagCompound()); } itemStack.getTagCompound().setTag(Dueling.MOD_ID, tag); } @Override public void getSubItems(CreativeTabs tab, NonNullList<ItemStack> items) { super.getSubItems(tab, items); } @Override public boolean getShareTag() { return false; } /*@Override public NBTTagCompound getNBTShareTag(ItemStack itemStack) { NBTTagCompound nbt = itemStack.getTagCompound(); NBTTagCompound nbtNew = new NBTTagCompound(); if(nbt != null) { for(String key : nbt.getKeySet()) { if(!key.equals(Dueling.MOD_ID)) { nbtNew.setTag(key, nbt.getTag(key)); } } } itemStack.setTagCompound(nbt); return nbtNew; }*/ public static NBTTagCompound saveAllItems(NBTTagCompound tag, NonNullList<ItemStack> list) { return ItemStorage.saveAllItems(tag, list, true); } public static NBTTagCompound saveAllItems(NBTTagCompound tag, NonNullList<ItemStack> list, boolean saveEmpty) { NBTTagList nbttaglist = new NBTTagList(); for (int i = 0; i < list.size(); ++i) { ItemStack itemstack = list.get(i); if (!itemstack.isEmpty()) { NBTTagCompound nbttagcompound = new NBTTagCompound(); nbttagcompound.setInteger("Slot", i); itemstack.writeToNBT(nbttagcompound); nbttaglist.appendTag(nbttagcompound); } } if (!nbttaglist.hasNoTags() || saveEmpty) { tag.setTag("Items", nbttaglist); } return tag; } public static void loadAllItems(NBTTagCompound tag, NonNullList<ItemStack> list) { NBTTagList nbttaglist = tag.getTagList("Items", 10); for (int i = 0; i < nbttaglist.tagCount(); ++i) { NBTTagCompound nbttagcompound = nbttaglist.getCompoundTagAt(i); int j = nbttagcompound.getInteger("Slot")/* & 255 */; if (j >= 0 && j < list.size()) { list.set(j, new ItemStack(nbttagcompound)); } } } } Appreciating any help!

Hello! I am currently making a custom villager and I would like to know if there is a way of detecting when a player has successfully traded. I could potentially just overwrite the GUI/Container but I would prefer not having to do that obviously... Google didnt quite help. Thank you for any replies!

Hello, basically the FontRenderer is rendering a given text in white, unless I am holding any Item or Block in my hand. Pictures of what I mean (the Strings in the middle are what Im talking about): [EDIT: It seems like I pasted the code and question inside the spoiler as well and it doesnt let me edit the text. Is there a "raw" option, which shows the bb code instead of compiling them inside the editor?]