Jump to content

[1.10.2][SOLVED] Teleport to the players spawn point


MCrafterzz

Recommended Posts

I want players to teleport to there spawn point this is the code I've use (it crashes with a null Point exception):

 

@Override

public void onEntityCollidedWithBlock(World worldIn, BlockPos pos, IBlockState state, Entity entityIn) {

if (entityIn instanceof EntityLivingBase) {

EntityPlayer player = (EntityPlayer) entityIn;

entityIn.setPosition(player.getBedSpawnLocation(worldIn, player.getBedLocation(), false).getX(),

player.getBedSpawnLocation(worldIn, player.getBedLocation(), false).getY(),

player.getBedSpawnLocation(worldIn, player.getBedLocation(), false).getZ());

entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f);

worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(),

entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0);

}

}

Link to comment
Share on other sites

  • Replies 77
  • Created
  • Last Reply

Top Posters In This Topic

You create an instance of EntityPlayer, but you check if the Entity is an instanceof EntityLivingBase...

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

Updated code:

@Override

public void onEntityCollidedWithBlock(World worldIn, BlockPos pos, IBlockState state, Entity entityIn) {

if (entityIn instanceof EntityLivingBase) {

if (entityIn instanceof EntityPlayer) {

EntityPlayer player = (EntityPlayer) entityIn;

BlockPos spawnPosition = player.getBedLocation();

entityIn.setPosition(spawnPosition.getX(), spawnPosition.getY(), spawnPosition.getZ());

entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f);

worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(),

entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0);

} else {

entityIn.setPosition(worldIn.getSpawnPoint().getX(), worldIn.getSpawnPoint().getY(),

worldIn.getSpawnPoint().getZ());

}

}

}

Link to comment
Share on other sites

You create an instance of EntityPlayer, but you check if the Entity is an instanceof EntityLivingBase...

 

While this is true it wouldn't produce NPE, but CCE.

 

Question is - what is null there? My bet is on #getBedSpawnLocation. Also - this method might be called on both sides - it is worth checking that and place proper server side-check if that is a case (maybe its null on client and present on server and client is crashing?).

 

If you can't figure it out - please say at which line it crashes.

1.7.10 is no longer supported by forge, you are on your own.

Link to comment
Share on other sites

Changed to:

@Override

@SideOnly(Side.SERVER)

public void onEntityCollidedWithBlock(World worldIn, BlockPos pos, IBlockState state, Entity entityIn) {

if (entityIn instanceof EntityLivingBase) {

if (entityIn instanceof EntityPlayer) {

EntityPlayer player = (EntityPlayer) entityIn;

BlockPos spawnPosition = player.getBedLocation();

entityIn.setPosition(spawnPosition.getX(), spawnPosition.getY(), spawnPosition.getZ());

entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f);

worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(),

entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0);

} else {

entityIn.setPosition(worldIn.getSpawnPoint().getX(), worldIn.getSpawnPoint().getY(),

worldIn.getSpawnPoint().getZ());

}

}

}

Link to comment
Share on other sites

What if this code is going to be run in a SinglePlayer world wouldn't it crash because the method doesn't exist

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

Are you talking about in the case of

@SideOnly

?

If so: no, because the method is never directly referred to, Minecraft only refers to the overridden method (the one in Block). It would simply not work in SinglePlayer.

If not: Please clarify.

Well you were correct so it won't crash, but it won't work. That just changes the reason to not use it. Unless the OP wants it to only work on a dedicated server.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

This is how the codes looks like now:

@Override

public void onEntityCollidedWithBlock(World worldIn, BlockPos pos, IBlockState state, Entity entityIn) {

if (!worldIn.isRemote) {

if (entityIn instanceof EntityLivingBase) {

if (entityIn instanceof EntityPlayer) {

EntityPlayer player = (EntityPlayer) entityIn;

BlockPos spawnPosition = player.getBedLocation();

entityIn.setPosition(spawnPosition.getX(), spawnPosition.getY(), spawnPosition.getZ());

entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f);

worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(),

entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0);

} else {

entityIn.setPosition(worldIn.getSpawnPoint().getX(), worldIn.getSpawnPoint().getY(),

worldIn.getSpawnPoint().getZ());

entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f);

worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(),

entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0);

}

}

}

}

Link to comment
Share on other sites

Yes,

@SideOnly

should not be used (unless you really know what you are doing). Which is why I linked both an article called "Why not to use

@SideOnly

" and a tutorial about the concept of sides in Minecraft.

Yes I understood what they do, but once I get some sleep and my brain is working "better" than it is currently I will read all of what you posted to understand it better. Thank you again diesieben.

 

This is how the codes looks like now:

@Override
public void onEntityCollidedWithBlock(World worldIn, BlockPos pos, IBlockState state, Entity entityIn) {
	if (!worldIn.isRemote) {
		if (entityIn instanceof EntityLivingBase) {
			if (entityIn instanceof EntityPlayer) {
				EntityPlayer player = (EntityPlayer) entityIn;
				BlockPos spawnPosition = player.getBedLocation();
				entityIn.setPosition(spawnPosition.getX(), spawnPosition.getY(), spawnPosition.getZ());
				entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f);
				worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(),
						entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0);
			} else {
				entityIn.setPosition(worldIn.getSpawnPoint().getX(), worldIn.getSpawnPoint().getY(),
						worldIn.getSpawnPoint().getZ());
				entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f);
				worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(),
						entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0);
			}
		}
	}
}

Can I assume it is still not working? Also if your code for the TeleportCommand is not "readable" then you should update forge to its most recent version and see if it is readable then.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

I have removed one of the instanceof checks:

@Override

public void onEntityCollidedWithBlock(World worldIn, BlockPos pos, IBlockState state, Entity entityIn) {

if (!worldIn.isRemote) {

if (entityIn instanceof EntityPlayer) {

EntityPlayer player = (EntityPlayer) entityIn;

BlockPos spawnPosition = player.getBedLocation();

entityIn.setPosition(spawnPosition.getX(), spawnPosition.getY(), spawnPosition.getZ());

entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f);

worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(),

entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0);

} else {

entityIn.setPosition(worldIn.getSpawnPoint().getX(), worldIn.getSpawnPoint().getY(),

worldIn.getSpawnPoint().getZ());

entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f);

worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(),

entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0);

}

}

}

 

But I still don't know how to use the commandteleport code

Link to comment
Share on other sites

Changed it to this:

@Override

public void onEntityCollidedWithBlock(World worldIn, BlockPos pos, IBlockState state, Entity entityIn) {

if (!worldIn.isRemote) {

if (entityIn instanceof EntityPlayer) {

EntityPlayer player = (EntityPlayer) entityIn;

BlockPos spawnPosition = player.getBedLocation();

((EntityPlayerMP) entityIn).connection.setPlayerLocation(spawnPosition.getX(), spawnPosition.getY(),

spawnPosition.getZ(), player.getRotationYawHead(), player.getRotationYawHead());

entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f);

worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(),

entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0);

} else {

((EntityPlayerMP) entityIn).connection.setPlayerLocation(worldIn.getSpawnPoint().getX(),

worldIn.getSpawnPoint().getY(), worldIn.getSpawnPoint().getZ(), entityIn.getRotationYawHead(),

entityIn.getRotationYawHead());

entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f);

worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(),

entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0);

}

}

}

 

Testing now

Link to comment
Share on other sites

New error:

http://pastebin.com/TTrPzcdC

 

Line 39(errored line):

((EntityPlayerMP) entityIn).connection.setPlayerLocation(worldIn.getSpawnPoint().getX(),

worldIn.getSpawnPoint().getY(), worldIn.getSpawnPoint().getZ(), entityIn.getRotationYawHead(),

entityIn.getRotationYawHead());

Link to comment
Share on other sites

Why are you casting the entity to an EntityPlayer if it is not an instanceof EntityPlayer

((EntityPlayerMP) entityIn).connection.setPlayerLocation(worldIn.getSpawnPoint().getX(),
                  worldIn.getSpawnPoint().getY(), worldIn.getSpawnPoint().getZ(), entityIn.getRotationYawHead(),
                  entityIn.getRotationYawHead());
            entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f);
            worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(),
                  entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0);
         }

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

So the way you have it set for the player will work however as far as I can tell onEntityCollidedWithBlock doesn't get called for Item Entities.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements




  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I'm using Modrinth as a launcher for a forge modpack on 1.20.1, and can't diagnose the issue on the crash log myself. Have tried repairing the Minecraft instillation as well as removing a few mods that have been problematic for me in the past to no avail. Crash log is below, if any further information is necessary let me know. Thank you! https://paste.ee/p/k6xnS
    • Hey folks. I am working on a custom "Mecha" entity (extended from LivingEntity) that the player builds up from blocks that should get modular stats depending on the used blocks. e.g. depending on what will be used for the legs, the entity will have a different jump strength. However, something unexpected is happening when trying to override a few of LivingEntity's functions and using my new own "Mecha" specific fields: instead of their actual instance-specific value, the default value is used (0f for a float, null for an object...) This is especially strange as when executing with the same entity from a point in the code specific to the mecha entity, the correct value is used. Here are some code snippets to better illustrate what I mean: /* The main Mecha class, cut down for brevity */ public class Mecha extends LivingEntity { protected float jumpMultiplier; //somewhere later during the code when spawning the entity, jumpMultiplier is set to something like 1.5f //changing the access to public didn't help @Override //Overridden from LivingEntity, this function is only used in the jumpFromGround() function, used in the aiStep() function, used in the LivingEntity tick() function protected float getJumpPower() { //something is wrong with this function //for some reason I can't correctly access the fields and methods from the instanciated entity when I am in one of those overridden protected functions. this is very annoying LogUtils.getLogger().info(String.valueOf(this.jumpMultiplier))) //will print 0f return this.jumpMultiplier * super.getJumpPower(); } //The code above does not operate properly. Written as is, the entity will not jump, and adding debug logs shows that when executing the code, the value of this.jumpMultiplier is 0f //in contrast, it will be the correct value when done here: @Override public void tick() { super.tick(); //inherited LivingEntity logic //Custom logic LogUtils.getLogger().info(String.valueOf(this.jumpMultiplier))) //will print 1.5f } } My actual code is slightly different, as the jumpMuliplier is stored in another object (so I am calling "this.legModule.getJumpPower()" instead of the float), but even using a simple float exactly like in the code above didn't help. When running my usual code, the object I try to use is found to be null instead, leading to a crash from a nullPointerException. Here is the stacktrace of said crash: The full code can be viewed here. I have found a workaround in the case of jump strength, but have already found the same problem for another parameter I want to do, and I do not understand why the code is behaving as such, and I would very much like to be able to override those methods as intended - they seemed to work just fine like that for vanilla mobs... Any clues as to what may be happening here?
    • Please delete post. Had not noticed the newest edition for 1.20.6 which resolves the issue.
    • https://paste.ee/p/GTgAV Here's my debug log, I'm on 1.18.2 with forge 40.2.4 and I just want to get it to work!! I cant find any mod names in the error part and I would like some help from the pros!! I have 203 mods at the moment.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.