[1.12.2] Drop an itemstack to a player doesnt work

[nov4e]

Hello guys. Basically I maded a custom recipe with the subscribe event RightClickBlock event.

The main recipe class:

Spoiler

@Mod.EventBusSubscriber
public class GroundDiggingProcessing {
	
	public static List<DiggingRecipe> RECIPES = new ArrayList<>();
	
	public static void initializeRecipes() {
		registerRecipe(new DiggingRecipe("grass_ball_recipe", Blocks.GRASS, ModItems.GRASS_BALL, Blocks.DIRT));
	}
	
	@SubscribeEvent
	public static void onBlockRightClick(PlayerInteractEvent.RightClickBlock e) {
		Block b = e.getWorld().getBlockState(e.getPos()).getBlock();
		ItemStack i = e.getItemStack();
		
		
		for(DiggingRecipe r : RECIPES) {
			if(e.getEntityPlayer() != null) {
				if(!(e.getWorld().isRemote)) {
					if(b == r.getMainBlock() && i.getItem() instanceof ItemMiniShovel) {
						if(e.getEntityPlayer().isSneaking()) {
						    e.getEntityPlayer().dropItem(new ItemStack(r.getBallOutput(), 1), false);
						    e.getEntityLiving().getHeldItemMainhand().damageItem(1, e.getEntityPlayer());
							e.getWorld().playSound(null, e.getPos(), b.getSoundType().getBreakSound(), SoundCategory.BLOCKS, b.getSoundType().getVolume() * 0.4F, b.getSoundType().getPitch() + (float) (Math.random() * 0.2 - 0.1));
						}
					}
				}
			}
		}
	}
	
	public static void registerRecipe(DiggingRecipe recipe) {
		RECIPES.add(recipe);
	}

}

 

The "DiggingRecipe" class, the recipe used:

Spoiler

public String recipeName;
	
	public Block mainBlock;
	public Item ballOutput;
	public Block outputBlock;
	
	public DiggingRecipe(String recipeName, Block block, Item item, Block blockOutput) {
		this.setRecipeName(recipeName);
		this.setMainBlock(block);
		this.setBallOutput(item);
		this.setOutputBlock(blockOutput);
	}
	
	public String getRecipeName() {
		return recipeName;
	}
	
	public Block getOutputBlock() {
		return outputBlock;
	}
	
	public void setOutputBlock(Block outputBlock) {
		this.outputBlock = outputBlock;
	}
	
	public Block getMainBlock() {
		return mainBlock;
	}
	
	public Item getBallOutput() {
		return ballOutput;
	}
	
	public void setRecipeName(String recipeName) {
		this.recipeName = recipeName;
	}
	
	public void setMainBlock(Block mainBlock) {
		this.mainBlock = mainBlock;
	}
	
	public void setBallOutput(Item ballOutput) {
		this.ballOutput = ballOutput;
	}

 

In the main class seems that in the subscribe event the game does not give the itemstack to the player.

And also it does not damage the item. I dont understand why.

Thanks for the help.

Edited April 26, 2019 by nov4e

[nov4e]

I actually registered it with a @EventBusSubscriber. Maybe do I have to register it via MinecraftForge.EVENT_BUS.register(listener);

[loordgek]

for(DiggingRecipe r : RECIPES) {
	if(e.getEntityPlayer() != null) {
		if(!(e.getWorld().isRemote)) {
			if(b == r.getMainBlock() && i.getItem() instanceof ItemMiniShovel) {
				if(e.getEntityPlayer().isSneaking()) {
				    e.getEntityPlayer().dropItem(new ItemStack(r.getBallOutput(), 1), false);
				    e.getEntityLiving().getHeldItemMainhand().damageItem(1, e.getEntityPlayer());
					e.getWorld().playSound(null, e.getPos(), b.getSoundType().getBreakSound(),  SoundCategory.BLOCKS,b.getSoundType().getVolume() * 0.4F, b.getSoundType().getPitch() + (float) (Math.random() * 0.2 - 0.1));
				}
			}
		}
	}
}

nooooo

dont do it like this first check if the player is null and if the world if remote and then loop over your recipes

 

and now on topic:

have you placed a breakpoint on it ??

[nov4e]

13 hours ago, loordgek said:

dont do it like this first check if the player is null and if the world if remote and then loop over your recipes

So I do have to do this checks after checking if the player is sneaking? 

 

13 hours ago, loordgek said:

have you placed a breakpoint on it ??

What do you mean with breakpoint?

[loordgek]

do use idea ?? https://www.jetbrains.com/help/idea/using-breakpoints.html

 

or eclipse https://www.eclipse.org/community/eclipse_newsletter/2017/june/article1.php

[Cadiboo]

19 hours ago, nov4e said:

I actually registered it with a @EventBusSubscriber. Maybe do I have to register it via MinecraftForge.EVENT_BUS.register(listener);

[nov4e]

@Cadiboo Yes, I coded it with Mod.EventBusSubscribe using a static void. I just said if i try the other method  will it work?

54 minutes ago, loordgek said:

do use idea ?? https://www.jetbrains.com/help/idea/using-breakpoints.html

 

or eclipse https://www.eclipse.org/community/eclipse_newsletter/2017/june/article1.php

@loordgek So basically I have to run the debug client, right?

[loordgek]

yes

 

[nov4e]

26 minutes ago, loordgek said:

yes

done. Basically its the same thing it does not work.

[loordgek]

can you put your mod on github so i can look

[nov4e]

https://github.com/nov4e/Exa/tree/master/src/main/java/exa_resources/forge/processing

[loordgek]

got it working.

 

the problem was you set the recipe to early and your grass_ball was null

move https://github.com/nov4e/Exa/blob/master/src/main/java/exa_resources/forge/ExaResources.java#L38 to init.

 

the way you register your items and blocks is wrong

https://github.com/nov4e/Exa/blob/master/src/main/java/exa_resources/forge/features/ModItems.java#L81

dont do that let forge do that for you, that is why @ObjectHolder exist

 

https://github.com/nov4e/Exa/blob/master/src/main/java/exa_resources/forge/base/ItemMiniShovel.java#L70

dont compare strings like that, read this https://stackoverflow.com/questions/513832/how-do-i-compare-strings-in-java

 

[nov4e]

Thank you @loordgek for your reply!! I finally fixed it. I will fix the item registry and i will give a look to string comparing. Thank you?

 

Can I ask 1 more thing? How can I set a block to another block?

Edited April 27, 2019 by nov4e

[loordgek]

21 minutes ago, nov4e said:

Can I ask 1 more thing? How can I set a block to another block?

?? i dont understand

[nov4e]

1 hour ago, loordgek said:

?? i dont understand

Basically replace a block with another block.

[loordgek]

in world ??

[nov4e]

yes

[loordgek]

world.setblockstate(Blockpos)