Jump to content

Why i can't call obj model on 1.13.2 ?


zlappedx3

Recommended Posts

Looks like the issue is in ModelBakery#loadModel, specifically, where ".json" is appended to the resource path. In 1.12.2, this was not done:

 

1.13.2: 

iresource = this.resourceManager.getResource(new ResourceLocation(location.getNamespace(), "models/" + location.getPath() + ".json"));

 

1.12.2

iresource = this.resourceManager.getResource(this.getModelLocation(location));

 

which means you should be seeing a message like:

[minecraft/ModelBakery]: Unable to load model: ':block/some_model.obj' referenced from: some_blockstate: java.io.FileNotFoundException: mod_id:models/block/some_model.obj.json

 

Edit: 

 

Oops.. not entirely correct. While hat was true, seems I didn't follow the rabbit hole deep enough as getModelLocation actually does what is in 1.13.2, just with one less method.  

 

 

Edited by lehjr
Link to comment
Share on other sites

IIRC you need to call obj loader.add domain earlier. Try putting it in your mods initialiser (inside a proxy of course). Putting it in a static initialiser in your statically subscribed ClientEventSubsciber (or the initialiser of a non static one) should work

Edited by Cadiboo

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

On 3/9/2019 at 5:59 PM, Cadiboo said:

IIRC you need to call obj loader.add domain earlier. Try putting it in your mods initialiser (inside a proxy of course). Putting it in a static initialiser in your statically subscribed ClientEventSubsciber (or the initialiser of a non static one) should work

I've tried and can't get it to work. I threw together a basic test out of the MDK and bits from ModelLoaderRegistryDebug out of Forge 1.10.2 debug. The Blockstate json probably isn't quite right as I'm a little hazy on the syntax changes for 1.13.2, but should be good enough for testing:  

https://github.com/lehjr/Forge-1.13.2-OBJ-Test 

Link to comment
Share on other sites

 

On 3/12/2019 at 5:28 AM, lehjr said:

I've tried and can't get it to work. I threw together a basic test out of the MDK and bits from ModelLoaderRegistryDebug out of Forge 1.10.2 debug. The Blockstate json probably isn't quite right as I'm a little hazy on the syntax changes for 1.13.2, but should be good enough for testing:  

https://github.com/lehjr/Forge-1.13.2-OBJ-Test 

Thank you but your method is not available.

Link to comment
Share on other sites

 

 

9 minutes ago, zlappedx3 said:

Yes which method do you use ? I just download your src and use only But not yet write more.

That's just a stand alone test to see whether or not the obj model is loading. For help and bug reports, it's always best to see things in their simplest form. Since none of the Forge test/debugging mods have been ported, it's possible there's something still missing in order for the OBJ models to be loaded from blockstate files. 

Link to comment
Share on other sites

Custom model loaders have not been implemented, as such you can't load .obj models right now.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites

On 3/13/2019 at 12:20 PM, larsgerrits said:

Custom model loaders have not been implemented, as such you can't load .obj models right now.

Actually, the model loaders are there and implemented. You can load the models just fine manually (I'm this right now). However, this is not the desired behavior if you want to be able to override the model with a resource pack. 

Link to comment
Share on other sites

  • 4 weeks later...
On 3/14/2019 at 7:23 PM, lehjr said:

Actually, the model loaders are there and implemented. You can load the models just fine manually (I'm this right now). However, this is not the desired behavior if you want to be able to override the model with a resource pack. 

lehjr, I would like to know how you've achieved this. I know OBJ models worked in 1.12, but I also know 1.13 was a pretty large rewrite. Trying to load OBJ models I'm getting errors telling me it cannot load a .obj.json file, so it *almost* knows what file to load, but it's getting the extension wrong.

Link to comment
Share on other sites

4 hours ago, DoctorLOGiQ said:

lehjr, I would like to know how you've achieved this. I know OBJ models worked in 1.12, but I also know 1.13 was a pretty large rewrite. Trying to load OBJ models I'm getting errors telling me it cannot load a .obj.json file, so it *almost* knows what file to load, but it's getting the extension wrong.

For now, you can do this in the model bake event. You’ll also need to register the model textures manually as well in the texture stitch event. 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
    • It is an issue with quark - update it to this build: https://www.curseforge.com/minecraft/mc-mods/quark/files/3642325
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.