[SOLVED] [1.12] can't use vanilla items to craft modded item

[Mango106]

(SOLUTION: forgot to add data tag for cooked fish)

basically, i'm simply trying to create a food item that can be crafted using cooked fish, and a baked potato (which are vanilla items). whenever i make .json files for recipes that use items from my mod, i can craft them. but whenever I try using a vanilla item, i can't craft the item I want to craft.

the .json for the recipe that isn't working is attached, and here is the code:

{
    "type": "minecraft:crafting_shapeless",
 
    "ingredients":
    [
 
    {
      "item": "minecraft:baked_potato"
    },
 
    {
      "item": "minecraft:cooked_fish"
    }
   
    ],
 
    "result":
    {
        "item": "tm:fish_and_chips",
        "count": 1
    }
}

i've been searching for more than an hour, i don't know what to do

recipe_fish_and_chips.json

Edited February 20, 2019 by Mango106

[sunsigne]

I bet my right hand it's because the game doesn't recognize "cooked_fish" as a Vanilla item. I got the same problem with the LAPIS_LAZULI a month ago. A lot of items have seen there names change between 1.12.2 and 1.13.2, be carefull and try to find the real name of vanilla items in your version.

 

do a test with a couple of vanillacobblestone. If it works, you can be sure I hit the target ?

Edited February 19, 2019 by sunsigne

[Mango106]

i tried, it didn't work. I also forgot to mention i'm making a mod on 1.12, not 1.13.

[sunsigne]

do you have a github ? It would be simplier for us to analyze your code. Are you sure you put your recipe in the good package ? And that "tm" is modid of your mod ?

 

does :

{
    "type": "minecraft:crafting_shapeless",
 
    "ingredients":
    [
 
    {
      "item": "minecraft:cobblestone"
    }
   
    ],
 
    "result":
    {
        "item": "tm:fish_and_chips",
        "count": 1
    }
}

really not work ?

[Mango106]

yeah, tm is the modid. I just copy and pasted your code, and it works! i tried using two cobblestone instead of one, and that also worked. That must mean the only thing i got wrong was the ID names for the baked potato and cooked fish.

[sunsigne]

that's what i said in the first place ^^

 

btw it's cool if your problem is solved

 

Edited February 19, 2019 by sunsigne

[MX_wb]

You need to specify the metadata of the fish. cooked_fish is either Cooked Fish (data=0) or Cooked Salmon (data=1).

[Mango106]

i know, it just stands for test mod, I don't plan on releasing it anyways. If i do release a complete mod i'm going to use a good modid. also, is this how i would format the metadata, below the item?

{
    "type": "minecraft:crafting_shapeless",
 
    "ingredients":
    [
 
    {
      "item": "minecraft:baked_potato"
    },
    
    {
      "item": "minecraft:cooked_fish",
      "data": "0"
    }
    
    ],
 
    "result":
    {
        "item": "tm:fish_and_chips",
        "count": 1
    }
}

 

Edited February 19, 2019 by Mango106

[MX_wb]

Yes

[Mango106]

it still doesn't work for some reason

[MX_wb]

Actually, I think it should be "data": 0 instead of "data": "0"

[Mango106]

YES ok it works thanks