How do I return based on the NBT tag of an item?

[thedarkcolour]

I am trying to create an item that has a different effect based on its NBT tag. However, instead of picking a single effect, the item does every effect at once. Here is my return code:

 

    protected void onFoodEaten(ItemStack stack, World worldIn, EntityPlayer player) { //Only supposed to add one effect.
        if (!worldIn.isRemote) {
            String tag = (stack.getTagCompound().getString("effect"));
            switch(tag) {
                case "REGEN": player.addPotionEffect(new PotionEffect(MobEffects.REGENERATION, 140, 1));
                case "JUMP": player.addPotionEffect(new PotionEffect(MobEffects.JUMP_BOOST, 100, 1));
                case "POISON": player.addPotionEffect(new PotionEffect(MobEffects.POISON, 220, 1));
                case "WITHER": player.addPotionEffect(new PotionEffect(MobEffects.WITHER, 140, 1));
                case "WEAKNESS":player.addPotionEffect(new PotionEffect(MobEffects.WEAKNESS, 160, 1));
                case "BLINDNESS":player.addPotionEffect(new PotionEffect(MobEffects.BLINDNESS, 140, 1));
                case "FIRE_RESISTANCE":player.addPotionEffect(new PotionEffect(MobEffects.FIRE_RESISTANCE, 60, 1));
                case "SATURATION":player.addPotionEffect(new PotionEffect(MobEffects.SATURATION, 100, 1));
                case "SPEED":player.addPotionEffect(new PotionEffect(MobEffects.SPEED, 100, 1));
            }
        }
    }

 

...and here is the code for my tag. The tag works properly, so I doubt it is an error here:

 

    public void onUpdate(ItemStack stack, World world, Entity entity, int metadata, boolean bool) {
        NBTTagCompound nbt = stack.getTagCompound();
        if(nbt == null) {stack.setTagCompound(new NBTTagCompound());}
        if(nbt.hasNoTags()) {
            nbt.setString("effect", "NULL");
        }
    }

 

[Draco18s]

https://www.tutorialspoint.com/java/switch_statement_in_java.htm

[thedarkcolour]

Thanks! Adding break; fixed it

[desht]

11 hours ago, thedarkcolour said:

Thanks! Adding break; fixed it

I'd also question why you're running code every single tick just to add a marker to your item's NBT.  Why not just check stack.hasTagCompound() in your onFoodEaten() method?

 

(I appreciate the code you're running isn't terribly expensive in CPU terms, but it's good practice not to run unnecessary tick-based code).

[thedarkcolour]

6 hours ago, desht said:

I'd also question why you're running code every single tick just to add a marker to your item's NBT.  Why not just check stack.hasTagCompound() in your onFoodEaten() method?

 

(I appreciate the code you're running isn't terribly expensive in CPU terms, but it's good practice not to run unnecessary tick-based code).

NEVERMIND: I got the stack.hasTagCompound to work, thanks

Edited January 4, 2019 by thedarkcolour