Jump to content

[1.12.2] sounds efect for weapon cause lag in virtualserver


perromercenary00

Recommended Posts

goog days  i have a trouble and a broken english

 

im doing some code to make guns  in minecraft but i have this trouble

i have a basic gun is this moment i make it shoot  for rounds every time i press rigthclick  one bullet every 256 milliseconds

the gun works the shoot animation runs but notice than most of the times there was no sound effect and  the code is not execute and no  damage is cause to the target entity

 

	    // ###########################################################
    public boolean disparo(ItemStack stack, World world, Entity entity) {
	        if (world.isRemote) {
	            //entity.world.playSound(null, entity.getPosition(), sonidos.pistola75nf_disparo, SoundCategory.PLAYERS, 2.0F,1.0F);
            return true;
        }
	        if (!world.isRemote) {
            if (this.ammunition > 0) {
	                entity.world.playSound(null, entity.getPosition(), sonidos.pistola75nf_disparo, SoundCategory.PLAYERS,2.0F, 1.0F);
	 
	// this class do all the math necessary to calculate the bullet trajectory and return the affected entities
                objetoobjetivo objetivo = new objetoobjetivo(world, entity, 20, 1);
                if (objetivo.getHayEntidades()) { //there is afected entities ?
	                    ArrayList<Entity> entidades = objetivo.getEntidades();
                    Entity targetEntity = entidades.get(0);
                    boolean isheadshoot = false;
	
                    float dice = rollsAd100dice(); //random float number from 0.0F to 100
	                    boolean iscritico = (dice < this.critico) ? true : false;
	                    dice = rollsAd100dice();
                    boolean iselemental = (dice < this.echange) ? true : false;
	                    for (int e = 0; e < entidades.size(); e++) {
	                        if (targetEntity != null && targetEntity instanceof EntityLivingBase) {
                            EntityLivingBase livingtarget = (EntityLivingBase) targetEntity;
	                            isheadshoot = objetivo.isheadshoot(livingtarget);
	                            float hp = livingtarget.getHealth();
                            float maxhp = livingtarget.getMaxHealth();
	                            float pain = (iscritico) ? (this.damage * 1.5F) : this.damage;
                            pain = (isheadshoot) ? (pain * 1.5F) : pain;
	                            hp -= pain;
	                            hp =(hp < 0.0F)? 0.0F : hp ;
                            livingtarget.setHealth(hp);
	//shows mesage on the player screen
	                            chat.chatm(entity, "#" + this.getTic() + " headshoot=" + isheadshoot + " iscritico=" + iscritico + " hp=" + livingtarget.getHealth()+"/"+maxhp);
	                        }
	                    }
	                }
            }
            this.ammunition--;
            this.ammunition = (this.ammunition < 1) ? 0 : this.ammunition;
            return true;
        }
	        return false;
    }
	

 

soo i disable the sound before the shoot code and now its runs perfect

	        if (!world.isRemote) {
            if (this.ammunition > 0) {
	               // entity.world.playSound(null, entity.getPosition(), sonidos.pistola75nf_disparo, SoundCategory.PLAYERS,2.0F, 1.0F);
	

 

also notice than the sound dont'n works when i execute this client side

      entity.world.playSound(null, entity.getPosition(), sonidos.pistola75nf_disparo, SoundCategory.PLAYERS,2.0F, 1.0F);

 

 

when i play the sound for the bullet shoot its most of the times fucks up server side

is not like totally crashig the virtual server but it stalls and run no more code until next tic

 

soo  i must wrong using sounds

 

is this the right way to play a sound ?? and why is not working client side

entity.world.playSound(null, entity.getPosition(), sonidos.pistola75nf_disparo, SoundCategory.PLAYERS,2.0F, 1.0F);

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
    • It is an issue with quark - update it to this build: https://www.curseforge.com/minecraft/mc-mods/quark/files/3642325
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.