Game Crash from Apple Drop - 1.12.2

[UM3 F0R TH3 W1N]

I have recently been working on having my custom apple drop from oak trees and dark oak trees, however as I was testing it the game crashed, here's the crash log: https://hastebin.com/xifabokeci.sql.

Here's ApplesFromLeavesEvent.java: https://hastebin.com/alipepoqok.java.

If you need any other classes tell me.

Thanks for the help in advance!

 

[UM3 F0R TH3 W1N]

I may be wrong however I believe it has something to do with: 

if(event.getState().getValue(BlockOldLeaf.VARIANT) == EnumType.OAK)

and

else if(event.getState().getValue(BlockOldLeaf.VARIANT) == EnumType.DARK_OAK)

[UM3 F0R TH3 W1N]

im currently testing this code here:

if(event.getState().getBlock() == Blocks.LEAVES.getDefaultState().withProperty(BlockOldLeaf.VARIANT, BlockPlanks.EnumType.OAK))
        {
            event.getDrops().add(new ItemStack(ItemInit.GREEN_APPLE));
            event.setDropChance(0.05f);
        }
        
        else if(event.getState().getBlock() == Blocks.LEAVES2.getDefaultState().withProperty(BlockNewLeaf.VARIANT, BlockPlanks.EnumType.DARK_OAK))
        {
            event.getDrops().add(new ItemStack(ItemInit.GREEN_APPLE));
            event.setDropChance(0.05f);
        }

[Choonster]

HarvestDropsEvent can be called for any block in the game, 99% of which won't have the BlockOldLeaf.VARIANT property in their block state. As you've seen, calling IBlockState#getValue with an invalid property throws an exception.

 

You need to check the Block itself first, use IBlockState#getBlock to get it and then check that it's equal to Blocks.LEAVES/Blocks.LEAVES2.

 

16 minutes ago, UM3 F0R TH3 W1N said:

if(event.getState().getBlock() == Blocks.LEAVES.getDefaultState().withProperty(BlockOldLeaf.VARIANT, BlockPlanks.EnumType.OAK))

IBlockState#getBlock returns a Block, which will never be equal to an IBlockState. You need to check the Block and the properties in two separate expressions within the if condition.

 

Edit: It looks like @diesieben07 already explained most of this in your previous threads. Please stop creating new threads for the same topic.

Edited December 27, 2018 by Choonster

[UM3 F0R TH3 W1N]

13 hours ago, Choonster said:

Edit: It looks like @diesieben07 already explained most of this in your previous threads. 

he explained how to do the event but not the check for what block, I know how to check for a block without meta but not for a block with meta

Edited December 27, 2018 by UM3 F0R TH3 W1N