Jump to content

ItemStack Player Drop Event


Siqhter

Recommended Posts

So if I have, lets say, a stack of 10 bottles, when I right click to milk a cow, it deletes the whole stack and replaces it with a filled bottle, whereas it needs to just add a filled bottle to the inventory and not delete the stack. I looked through EntityCow code in the milking event, but it's not working. Not sure what concept I'd have to add to the code below.

Spoiler

@SubscribeEvent
public void onEntityRightClicked(PlayerInteractEvent.EntityInteract event) {
    World world = event.getWorld();
    EntityPlayer player = event.getEntityPlayer();
    ItemStack itemstack = player.inventory.getCurrentItem();

    if (!world.isRemote) {
        if (event.getTarget() instanceof EntityCow) {

            if (itemstack.getItem() == MyItems.BOTTLE && !event.getEntityPlayer().capabilities.isCreativeMode) {

                player.inventory.setInventorySlotContents(event.getEntityPlayer().inventory.currentItem, new ItemStack(MyItems.MILK));
                player.playSound(SoundEvents.ENTITY_COW_MILK, 1.0F, 1.0F);
            }
        }
    }
}

 

Link to comment
Share on other sites

1 hour ago, Siqhter said:

event.getEntityPlayer()

First off this is a little repetitive you created a variable for this.

1 hour ago, Siqhter said:

setInventorySlotContents

This method sets the slots contents whereas you just want to decrease the stack size. Use ItemStack#setCount to set the count. Then call InventoryPlayer#addItemStackToInventory or similar

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

1 minute ago, Siqhter said:

but I'm just not clear on the set count.

An ItemStack has a count of how many "items" are in it. So if you fill one you need to set the count to the count - 1.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

20 minutes ago, Siqhter said:

Ok, that makes sense, but for some reason I'm crashing when I initialize the variable player that I defined at the top of my class.

Post the whole class file.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

Spoiler



public class MainEvents {

   
    EntityPlayer player;

    @SubscribeEvent
    public void onEntityRightClicked(PlayerInteractEvent.EntityInteract event) {
        World world = event.getWorld();
        ItemStack itemstack = player.inventory.getCurrentItem();

        if (!world.isRemote) {
            if (event.getTarget() instanceof EntityCow) {

                if (itemstack.getItem() == ModItems.EMPTY_BOTTLE && !player.capabilities.isCreativeMode) {

                    itemstack.setCount(-1);
                    player.inventory.addItemStackToInventory(new ItemStack(ModItems.BOTTLED_MILK));
                    player.playSound(SoundEvents.ENTITY_COW_MILK, 1.0F, 1.0F);
                }
            }
        }
        }
    }

If I define player locally it works, but I'm not sure why. Also I posted what I originally had, I know the .setCount isn't correct.

Edited by Siqhter
Link to comment
Share on other sites

13 minutes ago, Siqhter said:

public class MainEvents {

    
    @SubscribeEvent
    public void inventoryif isRemoteif instanceof if EMPTY_BOTTLE capabilitiesisCreativeModeinventorynew BOTTLED_MILKENTITY_COW_MILK1.0F1.0F

That doesnt even compile.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

13 minutes ago, Siqhter said:

EntityPlayer player;

You never instantiate it, so it is null. Basic Java.

  • Like 1

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

16 minutes ago, Siqhter said:

itemstack.setCount(-1)

This sets the count of how many items are in the stack. So when this is called you know have -1 bottles. Use ItemStack#getCount

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

Ah, I see. I debugged my code and can confirm it is running twice. e.g. Instead of subtracting 1 bottle from the stack, it takes 2. Aside from that it it working. Here is the correct class.

Spoiler

public class MainEvents {

    EntityPlayer player;

    @SubscribeEvent
    public void onEntityRightClicked(PlayerInteractEvent.EntityInteract event) {
        World world = event.getWorld();
        player = event.getEntityPlayer();
        ItemStack itemstack = player.inventory.getCurrentItem();
        int stackCount = itemstack.getCount();

        if (!world.isRemote) {
            if (event.getTarget() instanceof EntityCow) {

                if (itemstack.getItem() == MyItems.BOTTLE && !player.capabilities.isCreativeMode) {

                    player.playSound(SoundEvents.ENTITY_COW_MILK, 1.0F, 1.0F);
                    player.inventory.addItemStackToInventory(new ItemStack(MyItems.MILK));

                    itemstack.setCount(stackCount-1);
                }
            }
        }
    }

I added this so it would add the final bottled item to the players current hand when the stack of empty bottles is depleted.

Spoiler

if (itemstack.isEmpty()) {
    player.setHeldItem(player.getActiveHand(), new ItemStack(MyItems.MILK));
}

 

Edited by Siqhter
Link to comment
Share on other sites

Well, I realized if I return true then it doesn't allow both hands (from EnumHand) to be fired. But it still runs the addItemStackToInventory code twice.

Spoiler

EntityPlayer player;

@SubscribeEvent
public boolean onEntityRightClicked(PlayerInteractEvent.EntityInteract event) {

    World world = event.getWorld();
    player = event.getEntityPlayer();
    ItemStack itemstack = player.inventory.getCurrentItem();
    int stackCount = itemstack.getCount();
    EnumHand hand = EnumHand.MAIN_HAND;

    if (!world.isRemote) {
        if (event.getTarget() instanceof EntityCow) {

            if (itemstack.getItem() == MyItems.BOTTLE && !player.capabilities.isCreativeMode) {
                player.playSound(SoundEvents.ENTITY_COW_MILK, 1.0F, 1.0F);
                itemstack.setCount(stackCount-1);
                System.out.println("break_1");

                if (itemstack.isEmpty()) {

                    System.out.println("break_2");

                    player.setHeldItem(hand, new ItemStack(MyItems.MILK));
                } else if (!player.inventory.addItemStackToInventory(new ItemStack(MyItems.MILK))) {
                    System.out.println("break_3");
                    player.dropItem(new ItemStack(MyItems.MILK), false);
                }
            }
        }
    }
    return true;
}

 

Link to comment
Share on other sites

Try checking if the hand from the event is the hand holding the ItemStack. You can also use ItemStack#shrink()

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

On 11/20/2018 at 11:07 PM, Cadiboo said:

Try checking if the hand from the event is the hand holding the ItemStack.

Well I tried making a conditional like this, but I'm not sure if I'm following you. I understand the idea.

Spoiler

if (player.getHeldItemMainhand().equals(MyItems.MILK)) { }

 

Link to comment
Share on other sites

If event.getHand == player.getActiveHand

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Minecraft Version: 1.8-1.20.X Forge Version: All (Tested on 49.0.27, 11.14.4.1577 and some others) Steps to Reproduce: Setup a server with IPV6 only Setup a docker container with forge Try to connect to the Forge Server Description of issue: Hello, I am reaching out to seek your expertise within this forum to clarify a technical situation I am encountering, suspecting a potential issue related to Forge in a Docker environment, specifically in an IPv6 context. Initial Configuration: Debian 12 server, configured exclusively for IPv6, with Docker installed. Using the Docker image ghcr.io/pterodactyl/yolks:java_17, launching a Minecraft Vanilla server version 1.20.4 proceeds without any issues. Problem: The issue arises when deploying a Minecraft Forge server version 1.20.4 with the same Docker image (ghcr.io/pterodactyl/yolks:java_17), where connecting to the server becomes impossible. Notably, this issue does not occur when launching outside of Docker, where the server functions as expected. Hypothesis: This situation leads me to question the interaction between Forge and Docker, particularly in an IPv6-only configuration, despite several resolution attempts (testing with different versions of Forge, adjusting container network configurations (0.0.0.0, ::/0, and the server's ipv6), trials with various network settings, and modifications of Java options). Further testing was conducted with and without the use of the Pterodactyl game panel, unsuccessfully. The parameter -Djava.net.preferIPv4Stack=false also did not provide a solution. I tried to do the same things on multiple Minecraft server (include vanilla,spigot,fabric,sponge) and this work fine. The problem only happend with Forge. This issue seem to happend on all forge versions.   I appreciate your time and assistance in advance.
    • The game crashed whilst exception ticking world Error: java.lang.NullPointerException: Cannot invoke "net.minecraft.resources.ResourceLocation.equals(Object)" because "this.lootTableId" is null Error given is above. I was already playing for around 15 minutes and wasn't doing anything specific or even breaking anything when the crashed happened. This is update 1.19.2 forge: 43.2.23 Mod list: ESSENTIAL Mod (by SparkUniverse_) Traveler's Titles (Forge) (by YUNGNICKYOUNG) Resourceful Config (by ThatGravyBoat) Dynamic Lights (by atomicstrykergrumpy) TenzinLib (by CommodoreThrawn) Nature's Compass (by Chaosyr) Library Ferret - Forge (by jtl_elisa) Cold Sweat (by Mikul) Simple Voice Chat (by henkelmax) Waystones (by BlayTheNinth) Carry On (by Tschipp) [Let's Do] Meadow (by satisfy) Creeper Overhaul (by joosh_7889) AutoRegLib (by Vazkii) Moonlight Lib (by MehVahdJukaar) AppleSkin (by squeek502) Xaero's World Map (by xaero96) Rotten Creatures (by fusionstudiomc) YUNG's API (Forge) (by YUNGNICKYOUNG) Village Artifacts (by Lothrazar) Right Click, Get Crops (by TeamCoFH) Supplementaries (by MehVahdJukaar) Automatic Tool Swap (by MelanX) Better Third Person (by Socolio) Supplementaries Squared (by plantspookable) Traveler's Backpack (by Tiviacz1337) Caelus API (Forge/NeoForge) (by TheIllusiveC4) Creatures and Beasts (by joosh_7889) Architectury API (Fabric/Forge/NeoForge) (by shedaniel) Quark Oddities (by Vazkii) Origins (Forge) (by EdwinMindcraft) Villager Names (by Serilum) GeckoLib (by Gecko) Realistic Bees (by Serilum) Illuminations Forge 🔥 (by dimadencep) Serene Seasons (by TheAdubbz) Critters and Companions (by joosh_7889) [Let's Do] Bakery (by satisfy) Falling Leaves (Forge) (by Cheaterpaul) Jade 🔍 (by Snownee) Collective (by Serilum) TerraBlender (Forge) (by TheAdubbz) [Let's Do] API (by Cristelknight) Towns and Towers (by Biban_Auriu) More Villagers (by SameDifferent) Biomes O' Plenty (by Forstride) Goblin Traders (by MrCrayfish) Corpse (by henkelmax) Tree Harvester (by Serilum) Balm (Forge Edition) (by BlayTheNinth) Mouse Tweaks (by YaLTeR) Sound Physics Remastered (by henkelmax) Xaero's Minimap (by xaero96) Just Enough Items (JEI) (by mezz) Terralith (by Starmute) Quark (by Vazkii) [Let's Do] Vinery (by satisfy) [Let's Do] Candlelight (by satisfy) Repurposed Structures (Neoforge/Forge) (by telepathicgrunt) Dusty Decorations (by flint_mischiff) Immersive Armors [Fabric/Forge] (by Conczin) Serene Seasons Fix (by Or_OS) Shutup Experimental Settings! (by Corgi_Taco) Skin Layers 3D (Fabric/Forge) (by tr7zw)
    • Make sure Java is running via Nvidia GPU https://windowsreport.com/minecraft-not-using-gpu/  
    • Also make a test with other Custom Launchers like AT Launcher, MultiMC or Technic Launcher
    • Embeddium and valkyrienskies are not working together - remove one of these mods With removing Embeddium, also remove Oculus, TexTrue's Embeddium Options and Embeddium Extras Or use Rubidium instead
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.