Jump to content

[SOLVED] NBT Data not syncing/saving


hiotewdew

Recommended Posts

I'm aware at least 50000 threads exist with this exact topic. And trust me, I have read them. But my tile entity just refuses to save/sync data.

Here's my code.

package its_meow.betteranimalsplus.block;

import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.network.NetworkManager;
import net.minecraft.network.play.server.SPacketUpdateTileEntity;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.math.AxisAlignedBB;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public class TileEntityHandOfFate extends TileEntity {
	
	private boolean onFire = false;
	
	
	public TileEntityHandOfFate() {
	}
	
	
	public void setOnFire(boolean b) {
		this.onFire = b;
		this.markDirty();
	}
	
	public boolean isOnFire() {
		return onFire;
	}
	
	
	@Override
	public void readFromNBT(NBTTagCompound compound) {
		super.readFromNBT(compound);
		this.onFire = compound.getBoolean("OnFire");
	}



	@Override
	public NBTTagCompound writeToNBT(NBTTagCompound compound) {
		super.writeToNBT(compound);
		compound.setBoolean("OnFire", this.onFire);
		return compound;
	}

	@Override
	public SPacketUpdateTileEntity getUpdatePacket() {
		NBTTagCompound tag = new NBTTagCompound();
		this.writeToNBT(tag);
		return new SPacketUpdateTileEntity(pos, 1, tag);
	}


	@Override
	public void onDataPacket(NetworkManager net, SPacketUpdateTileEntity packet) {
		readFromNBT(packet.getNbtCompound());
		world.scheduleUpdate(this.pos, this.blockType, 100);
	}
	
	
	
	
	
	@Override
	@SideOnly(Side.CLIENT)
	public AxisAlignedBB getRenderBoundingBox() {
		return new AxisAlignedBB(getPos().add(-2, -4, -2), getPos().add(2, 4, 2));
	}
	
}

 

Yes, the tile entity is registered and exists. It has a TESR that renders fire (the render method uses the isOnFire() method and creates fire particles).

When I exit the world and reload it (not even leave game) the fire disappears.

Nothing external to this touches the NBT.

Edited by hiotewdew
Link to comment
Share on other sites

try using a constant for the tag name, first checking if the tag exists before setting your variable and please post your code as a github repository

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

11 hours ago, Cadiboo said:

try using a constant for the tag name, first checking if the tag exists before setting your variable and please post your code as a github repository

https://github.com/itsmeow/betteranimalsplus/blob/master/src/main/java/its_meow/betteranimalsplus/block/TileEntityHandOfFate.java

 

After doing all the suggested the problem still persists.

Link to comment
Share on other sites

28 minutes ago, hiotewdew said:

After doing all the suggested the problem still persists.

You also need to override TileEntity#getUpdateTag and TileEntity#handleUpdateTag

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

10 minutes ago, Animefan8888 said:

You also need to override TileEntity#getUpdateTag and TileEntity#handleUpdateTag

Yeah, I just figured out it was the syncing that was the issue.

That seems to have fixed it. Thanks! I read somewhere that those two were only nessecary for stuff related to capabilities.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.