Jump to content

Custom Furnace is not smelting


CrashCZ

Recommended Posts

I love how you have this flag:

boolean flag = this.isBurning();

And then keep doing this:

if(this.isBurning() || ...

if(this.isBurning())

if(this.isBurning() && ...

Also don't use IInventory, use ItemStackHandler and Capabilities instead.

Also don't use ITileEntityProvider, override the hasTileEntity and getTileEntity methods present in the Block class.

You haven't overridden shouldRefresh, which likely causes your TE to get deleted and recreated when your block changes from not-lit to lit (and back). This is because you went the dumb vanilla route of using two blocks instead of a block state property to store that particular value.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

45 minutes ago, Draco18s said:

I love how you have this flag:

boolean flag = this.isBurning();

And then keep doing this:

if(this.isBurning() || ...

if(this.isBurning())

if(this.isBurning() && ...

Also don't use IInventory, use ItemStackHandler and Capabilities instead.

Also don't use ITileEntityProvider, override the hasTileEntity and getTileEntity methods present in the Block class.

You haven't overridden shouldRefresh, which likely causes your TE to get deleted and recreated when your block changes from not-lit to lit (and back). This is because you went the dumb vanilla route of using two blocks instead of a block state property to store that particular value.

OK I chnged it and now it does some weired stuff...

Link to comment
Share on other sites

I can't diagnose weird.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Use the debugger. Set some breakpoints and figure it out.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

9 hours ago, Draco18s said:

This is because you went the dumb vanilla route of using two blocks instead of a block state property to store that particular value

Don’t copy the vanilla furnace, it’s code that’s existed for many (6?) years without much change while everything else has changed substantially. Forge also provides additional systems that make stuff like furnaces very easy to create such as the ItemStackHandler. Use it instead of IInventory.

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.