Jump to content

[1.12.2] Give Player an Item


vin0m

Recommended Posts

I am trying to give an item to a player and for some reason this code that was working in 1.10.2 will not work in 1.12.2.  I can't figure out what I need to do differently.  Code:

 

ItemStack stack = new ItemStack(ModItems.goldSatchel);
Item item = stack.getItem();
int newItemValue = maxItemDamage - value;
item.setDamage(stack, newItemValue);
player.inventory.addItemStackToInventory(stack);

 

The new item is not placed in the players inventory.  Did something change in 1.12?

Link to comment
Share on other sites

4 minutes ago, cubicoder said:

Where are you running this code?

I am running it in my class "CommandGoldCoins implements ICommand {" in the section "public void execute(MinecraftServer server, ICommandSender sender, String[] input) throws CommandException".

 

5 minutes ago, aw_wolfe said:

you can set the damage directly to the stack

 

stack.setItemDamage();

 

Are you getting an item in inventory, or just not a damaged item?

A part of this command modifies the current item damage.  That works fine. It is also supposed to make a new item (code above) with a set damage amount.  The new item does not appear in the inventory.  It worked fine in 1.10.2 so I'm confused on what has changed.

Link to comment
Share on other sites

Looking at the code for the /give command, it looks like you have to have the player drop the item stack using player.dropItem(itemstack, false). Then make the resulting EntityItem have no pickup delay and set the owner to the player (entityitem.setNoPickupDelay() and entityitem.setOwner(entityplayer.getName()), respectively). I've never messed with commands before, though, so I may be wrong.

Edited by cubicoder

Check out my tutorials at https://cubicoder.github.io/.

Link to comment
Share on other sites

22 hours ago, vin0m said:

Apparently you can only set the item damage up to 4 digits.  Anything over that and it fails to create the item.  That was the issue.  

ItemStack#itemDamage is truncated to a short value aka the max is 32767(thank you Draco18s). ItemStacks are considered empty if their itemDamage is greater than 65535 or less than -32767.

Edited by Animefan8888
Error

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

12 hours ago, Animefan8888 said:

ItemStack#itemDamage is truncated to a short value aka the max is 65535.

*cough*

32766.

32767 is the Wildcard Value ("match any").

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.