Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[1.12.2] Adding NBT Data To Item

Lambda

By Lambda
in Modder Support

 Share

Recommended Posts

Lambda Diamond Finder

Lambda

Posted
Posted

Hello,

 

So I'm trying to store so information onto an NBTTag however, I'm running into an issue where the item doesn't actually have an NBTTagCompound.

Ex:

stack.hasTagCompound()

returns false; thus I cannot access it as it will return null.

Here is my code:

Spoiler 

package com.unassigned.customenchants.items;

import java.util.HashSet;
import java.util.Set;

import com.unassigned.customenchants.CustomEnchants;
import com.unassigned.customenchants.blocks.tile.TileEntityEnchantmentFab;
import com.unassigned.customenchants.items.base.ItemBase;
import com.unassigned.customenchants.util.ModUtil;

import net.minecraft.enchantment.Enchantment;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagList;
import net.minecraft.nbt.NBTTagString;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.ActionResult;
import net.minecraft.util.EnumActionResult;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.EnumHand;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.text.TextComponentTranslation;
import net.minecraft.world.World;
import net.minecraftforge.common.util.Constants;

public class EnchantmentFabCopier extends ItemBase {
	
	public EnchantmentFabCopier(String name) {
		super(name);
		this.maxStackSize = 0;
	}
		
	@Override
	public EnumActionResult onItemUse(EntityPlayer player, World worldIn, BlockPos pos, EnumHand hand, EnumFacing facing, float hitX, float hitY, float hitZ) {
		ItemStack stack = player.getHeldItem(hand);
		if(player != null)
		{
			TileEntity tile = worldIn.getTileEntity(pos);
			if(tile != null && stack.hasTagCompound())
			{
				if((tile instanceof TileEntityEnchantmentFab))
				{
					NBTTagCompound itemCompound = stack.getTagCompound();
					if(player.isSneaking()) //sneaking
					{
						Set<Enchantment> getterEnch = ((TileEntityEnchantmentFab) tile).getKnownEnchants();

				    	NBTTagList enchantList = new NBTTagList();
				        for(Enchantment e : getterEnch) {
				        	NBTTagString eString = new NBTTagString(e.getRegistryName().toString());
				        	enchantList.appendTag(eString);
				        }
				        itemCompound.setTag("enchantList", enchantList);
				        player.sendMessage(new TextComponentTranslation("tooltip."+ModUtil.MOD_ID+".enchantCopier.copySuccess"));
				        
				        return EnumActionResult.SUCCESS;
				        
					}else { //NOT sneaking
						Set<Enchantment> setterEnch = new HashSet<Enchantment>();
					    NBTTagList list = itemCompound.getTagList("enchantList", Constants.NBT.TAG_STRING);
						for (int i = 0; i < list.tagCount(); i++) {
							Enchantment theEnch = Enchantment.getEnchantmentByLocation(list.getStringTagAt(i));
							setterEnch.add(theEnch);
						}
						if(!setterEnch.isEmpty()) {
							((TileEntityEnchantmentFab) tile).setEnchants(setterEnch);
					        player.sendMessage(new TextComponentTranslation("tooltip."+ModUtil.MOD_ID+".enchantCopier.applySuccess"));
					        return EnumActionResult.SUCCESS;
						}
				        player.sendMessage(new TextComponentTranslation("tooltip."+ModUtil.MOD_ID+".enchantCopier.applyFail"));
					}
				}else {
			        player.sendMessage(new TextComponentTranslation("tooltip."+ModUtil.MOD_ID+".enchantCopier.invaildTile"));
				}
			}
		}
		return EnumActionResult.PASS;
	}
}

 

 

 

Thanks.

Relatively new to modding.

Currently developing:

https://github.com/LambdaXV/DynamicGenerators

Link to comment
Share on other sites
Draco18s Reality Controller

Draco18s

Posted
Posted

No tag?

Create one, set the tag to it.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites
Lambda Diamond Finder

Lambda

Posted
  • Author
Posted

Okay, I got it half-working now.

 

Is there any way I can cancel the action of the TE opening (or even delay it); so that everything within: 

player.isSneaking()

is called?

 

As currently, trying to right click it to set said store list to the TE results in opening it instead.

 

Thank you.

Relatively new to modding.

Currently developing:

https://github.com/LambdaXV/DynamicGenerators

Link to comment
Share on other sites
Cadiboo Reality Controller

Cadiboo

Posted
Posted

Please post updates code, I think you might want to override doesSneakBypassUse (I think that’s the name of the method) or use Events

About Me

Spoiler

My Discord - Cadiboo#8887

My Website - Cadiboo.github.io

My Mods - Cadiboo.github.io/projects

My Tutorials - Cadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites
Lambda Diamond Finder

Lambda

Posted
  • Author
Posted

That isn't exactly what I wanted. I need it to be bypassed when unsneaked and the player right clicks. I do believe I need to use an event, I just don't exactly know which one to use.

 

Here is the reformated and updated code:

Spoiler 

package com.unassigned.customenchants.items;

import java.util.HashSet;
import java.util.List;
import java.util.Set;

import com.unassigned.customenchants.CustomEnchants;
import com.unassigned.customenchants.blocks.tile.TileEntityEnchantmentFab;
import com.unassigned.customenchants.items.base.ItemBase;
import com.unassigned.customenchants.util.ModUtil;

import net.minecraft.block.state.IBlockState;
import net.minecraft.client.resources.I18n;
import net.minecraft.client.util.ITooltipFlag;
import net.minecraft.enchantment.Enchantment;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagList;
import net.minecraft.nbt.NBTTagString;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.ActionResult;
import net.minecraft.util.EnumActionResult;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.EnumHand;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.text.TextComponentTranslation;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
import net.minecraftforge.common.util.Constants;

public class EnchantmentFabCopier extends ItemBase {

	public EnchantmentFabCopier(String name) {
		super(name);
		this.maxStackSize = 1;
	}

	@Override
	public EnumActionResult onItemUse(EntityPlayer player, World worldIn, BlockPos pos, EnumHand hand, EnumFacing facing, float hitX, float hitY, float hitZ) {
		ItemStack stack = player.getHeldItem(hand);
		TileEntity tile = worldIn.getTileEntity(pos);

		if(!stack.hasTagCompound())
			stack.setTagCompound(new NBTTagCompound());

		NBTTagCompound compound = stack.getTagCompound();

		if(player != null)
		{
			if(tile != null) {
				if(tile instanceof TileEntityEnchantmentFab)
				{
					if(!player.isSneaking()) //if player uses item - while not sneaking
					{
						Set<Enchantment> storedList = new HashSet<Enchantment>();
						NBTTagList list = compound.getTagList("enchantList", Constants.NBT.TAG_STRING);
						for (int i = 0; i < list.tagCount(); i++) {
							Enchantment theEnch = Enchantment.getEnchantmentByLocation(list.getStringTagAt(i));
							storedList.add(theEnch);
						}
						((TileEntityEnchantmentFab) tile).setEnchants(storedList);
						player.sendMessage(new TextComponentTranslation("temp: successfully set!"));

						return EnumActionResult.SUCCESS;
					}else { //uses item while sneaking
						NBTTagList enchantList = new NBTTagList();
						for(Enchantment e : ((TileEntityEnchantmentFab) tile).getKnownEnchants()) {
							NBTTagString eString = new NBTTagString(e.getRegistryName().toString());
							enchantList.appendTag(eString);
						}
						compound.setTag("enchantList", enchantList);
						player.sendMessage(new TextComponentTranslation("temp: successfully stored!"));

						return EnumActionResult.SUCCESS;
					}
				}
			}else {
				if(compound.hasKey("enchantList") && player.isSneaking()) //if they shift+right click something that isn't the TE -> clear it.
				{
					compound.removeTag("enchantList");
					player.sendMessage(new TextComponentTranslation("temp: successfully cleared!"));
					return EnumActionResult.SUCCESS;
				}
			}
		}

		return EnumActionResult.PASS;
	}
	
	@Override
	public void addInformation(ItemStack stack, World worldIn, List<String> tooltip, ITooltipFlag flagIn) {
		super.addInformation(stack, worldIn, tooltip, flagIn);
		if(stack.hasTagCompound())
		{
			if(stack.getTagCompound().hasKey("enchantList"))
			{
				tooltip.add("[temp]Currently Storing: ");
				NBTTagList list = stack.getTagCompound().getTagList("enchantList", Constants.NBT.TAG_STRING);
				for (int i = 0; i < list.tagCount(); i++) {
					Enchantment theEnch = Enchantment.getEnchantmentByLocation(list.getStringTagAt(i));
					tooltip.add("- "+I18n.format(theEnch.getName()));
				}
				
			}else {
				tooltip.add("[temp]No Enchantments stored!");
			}
		}else {
			tooltip.add("[temp]No Enchantments stored!");
		}
	}
	
	@Override
	public boolean doesSneakBypassUse(ItemStack stack, IBlockAccess world, BlockPos pos, EntityPlayer player) {
		return false;
	}
}

 

 

Thanks.

Relatively new to modding.

Currently developing:

https://github.com/LambdaXV/DynamicGenerators

Link to comment
Share on other sites
V0idWa1k3r World Shaper

V0idWa1k3r

Posted
Posted

If you use Item#onItemUseFirst instead of Item#onItemUse returning EnumActionResult.SUCCESS will prevent Block#onBlockActivated from firing thus preventing any GUI/Container showing up. 

Alternatively you may set the result of PlayerInteractEvent.RightClickBlock to DENY

Link to comment
Share on other sites
Lambda Diamond Finder

Lambda

Posted
  • Author
Posted (edited)
8 minutes ago, diesieben07 said:

You are returning PASS which means "I don't care about this right click", hence the game continues with the next possible target (the TE). You need to return the correct EnumActionResult.

 

 

Even with this change ( EnumActionResult.PASS ) to ( EnumActionResult.SUCCESS or even EnumActionResult.FAIL ) it still does not function. (It just opens the TE)

Am I missing something?

 

Edited by Lambda

Relatively new to modding.

Currently developing:

https://github.com/LambdaXV/DynamicGenerators

Link to comment
Share on other sites
Lambda Diamond Finder

Lambda

Posted
  • Author
Posted
7 minutes ago, V0idWa1k3r said:

If you use Item#onItemUseFirst instead of Item#onItemUse returning EnumActionResult.SUCCESS will prevent Block#onBlockActivated from firing thus preventing any GUI/Container showing up. 

Alternatively you may set the result of PlayerInteractEvent.RightClickBlock to DENY

Okay, this seemed to fix it.

 

However, as I've been experiencing this issue, I would like to see if I could fix it:

It seems that my chat messages I send to the player print twice, I don't know if the method is getting called twice, regardless, it is not intended.

7b77431de2aa9baa5158e215520e42e8.png

 

Here is my updated code:

Spoiler 

package com.unassigned.customenchants.items;

import java.util.HashSet;
import java.util.List;
import java.util.Set;

import com.unassigned.customenchants.CustomEnchants;
import com.unassigned.customenchants.blocks.tile.TileEntityEnchantmentFab;
import com.unassigned.customenchants.items.base.ItemBase;
import com.unassigned.customenchants.util.ModUtil;

import net.minecraft.block.state.IBlockState;
import net.minecraft.client.resources.I18n;
import net.minecraft.client.util.ITooltipFlag;
import net.minecraft.enchantment.Enchantment;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagList;
import net.minecraft.nbt.NBTTagString;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.ActionResult;
import net.minecraft.util.EnumActionResult;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.EnumHand;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.text.TextComponentTranslation;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
import net.minecraftforge.common.util.Constants;

public class EnchantmentFabCopier extends ItemBase {

	public EnchantmentFabCopier(String name) {
		super(name);
		this.maxStackSize = 1;
	}

	@Override
	public EnumActionResult onItemUseFirst(EntityPlayer player, World world, BlockPos pos, EnumFacing side, float hitX, float hitY, float hitZ, EnumHand hand) {
		ItemStack stack = player.getHeldItem(hand);
		TileEntity tile = world.getTileEntity(pos);

		if(!stack.hasTagCompound())
			stack.setTagCompound(new NBTTagCompound());

		NBTTagCompound compound = stack.getTagCompound();

		if(player != null)
		{
			if(tile != null) {
				if(tile instanceof TileEntityEnchantmentFab)
				{
					if(!player.isSneaking()) //if player uses item - while not sneaking
					{
						Set<Enchantment> storedList = new HashSet<Enchantment>();
						NBTTagList list = compound.getTagList("enchantList", Constants.NBT.TAG_STRING);
						for (int i = 0; i < list.tagCount(); i++) {
							Enchantment theEnch = Enchantment.getEnchantmentByLocation(list.getStringTagAt(i));
							storedList.add(theEnch);
						}
						((TileEntityEnchantmentFab) tile).setEnchants(storedList);
						player.sendMessage(new TextComponentTranslation("temp: successfully set!"));

						return EnumActionResult.SUCCESS;
					}else { //uses item while sneaking
						NBTTagList enchantList = new NBTTagList();
						for(Enchantment e : ((TileEntityEnchantmentFab) tile).getKnownEnchants()) {
							NBTTagString eString = new NBTTagString(e.getRegistryName().toString());
							enchantList.appendTag(eString);
						}
						compound.setTag("enchantList", enchantList);
						player.sendMessage(new TextComponentTranslation("temp: successfully stored!"));

						return EnumActionResult.SUCCESS;
					}
				}
			}else {
				if(compound.hasKey("enchantList") && player.isSneaking()) //if they shift+right click something that isn't the TE -> clear it.
				{
					compound.removeTag("enchantList");
					player.sendMessage(new TextComponentTranslation("temp: successfully cleared!"));
					return EnumActionResult.SUCCESS;
				}
			}
		}

		return EnumActionResult.SUCCESS;
	}
	
	@Override
	public void addInformation(ItemStack stack, World worldIn, List<String> tooltip, ITooltipFlag flagIn) {
		super.addInformation(stack, worldIn, tooltip, flagIn);
		if(stack.hasTagCompound())
		{
			if(stack.getTagCompound().hasKey("enchantList"))
			{
				tooltip.add("[temp]Currently Storing: ");
				NBTTagList list = stack.getTagCompound().getTagList("enchantList", Constants.NBT.TAG_STRING);
				for (int i = 0; i < list.tagCount(); i++) {
					Enchantment theEnch = Enchantment.getEnchantmentByLocation(list.getStringTagAt(i));
					tooltip.add("- "+I18n.format(theEnch.getName()));
				}
				
			}else {
				tooltip.add("[temp]No Enchantments stored!");
			}
		}else {
			tooltip.add("[temp]No Enchantments stored!");
		}
	}
	
	@Override
	public boolean doesSneakBypassUse(ItemStack stack, IBlockAccess world, BlockPos pos, EntityPlayer player) {
		return false;
	}
}

 

 

 

Thank you.

Relatively new to modding.

Currently developing:

https://github.com/LambdaXV/DynamicGenerators

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • Manafu284
      STRONG SANGOMA BRITS +27735908989, KLERKSDORP, RUSTENBURG, MAHIKENG, MARIKANA, POTCHEFSTROOM, BOITUMELONG, LICHTENBURG, MMAKAU,

      By Manafu284 · Posted

      Baba  Serege [[+27-73 590 8989]] has experience of 27 years in helping and guiding many people from all over the world. His psychic abilities may help you answer and resolve many unanswered questions. He specialize in helping women and men from all walks of life.. 1) – Bring back lost lover. even if lost for a long time. 2) – My lover is abusing alcohol, partying and cheating on me I urgently need help” 3) – Divorce or court issues. 4) – Is your love falling apart? 5) – Do you want your love to grow stronger? 6) – Is your partner losing interest in you? 7) – Do you want to catch your partner cheating on you? – We help to keep your partner faithful and loyal to you. 9) – We recover love and happiness when relationship breaks down. 10) – Making your partner loves you alone. 11) – We create loyalty and everlasting love between couples. 12) – Get a divorce settlement quickly from your ex-partner. 13) – We create everlasting love between couples. 14) – We help you look for the best suitable partner. 15) – We bring back lost lover even if lost for a long time. 16) – We strengthen bonds in all love relationship and marriages 17) – Are you an herbalist who wants to get more powers? 18) – Buy a house or car of your dream. 19) – Unfinished jobs by other doctors come to me. 20) – I help those seeking employment. 21) – Pensioners free treatment. 22) – Win business tenders and contracts. 23) – Do you need to recover your lost property? 24) – Promotion at work and better pay. 25) – Do you want to be protected from bad spirits and nightmares? 26) – Financial problems. 27) – Why you can’t keep money or lovers? 28) – Why you have a lot of enemies? 29) – Why you are fired regularly on jobs? 30) – Speed up money claim spell, delayed payments, pension and accident funds 31) – I help students pass their exams/interviews. 33) – Removal of bad luck and debts. 34) – Are struggling to sleep because of a spiritual wife or husband. 35- ) Recover stolen property
    • songkran
      Situs Togel Online | Live Draw Hk | Live Draw SDY

      By songkran · Posted

    • m18hd3hua
      OLXTOTO ✘ Situs Link Terbaru Anti Blokir 2024

      By m18hd3hua · Posted

      OLXTOTO adalah situs bandar togel online resmi terbesar dan terpercaya di Indonesia. Bergabunglah dengan OLXTOTO dan nikmati pengalaman bermain togel yang aman dan terjamin. Koleksi toto 4D dan togel toto terlengkap di OLXTOTO membuat para member memiliki pilihan taruhan yang lebih banyak. Sebagai situs togel terpercaya, OLXTOTO menjaga keamanan dan kenyamanan para membernya dengan sistem keamanan terbaik dan enkripsi data. Transaksi yang cepat, aman, dan terpercaya merupakan jaminan dari OLXTOTO. Nikmati layanan situs toto terbaik dari OLXTOTO dengan tampilan yang user-friendly dan mudah digunakan. Layanan pelanggan tersedia 24/7 untuk membantu para member. Bergabunglah dengan OLXTOTO sekarang untuk merasakan pengalaman bermain togel yang menyenangkan dan menguntungkan.
    • Manafu284
      SANGOMA/ LOVE SPELLS MANKWENG +27735908989, TZANEEN, POLOKWANE, LEBOWAKGOMO, MOKOPANE, LEPHALALE, BURGERSFORT, JANE FURSE, GIYAN

      By Manafu284 · Posted

      Baba  Serege [[+27-73 590 8989]] has experience of 27 years in helping and guiding many people from all over the world. His psychic abilities may help you answer and resolve many unanswered questions. He specialize in helping women and men from all walks of life.. 1) – Bring back lost lover. even if lost for a long time. 2) – My lover is abusing alcohol, partying and cheating on me I urgently need help” 3) – Divorce or court issues. 4) – Is your love falling apart? 5) – Do you want your love to grow stronger? 6) – Is your partner losing interest in you? 7) – Do you want to catch your partner cheating on you? – We help to keep your partner faithful and loyal to you. 9) – We recover love and happiness when relationship breaks down. 10) – Making your partner loves you alone. 11) – We create loyalty and everlasting love between couples. 12) – Get a divorce settlement quickly from your ex-partner. 13) – We create everlasting love between couples. 14) – We help you look for the best suitable partner. 15) – We bring back lost lover even if lost for a long time. 16) – We strengthen bonds in all love relationship and marriages 17) – Are you an herbalist who wants to get more powers? 18) – Buy a house or car of your dream. 19) – Unfinished jobs by other doctors come to me. 20) – I help those seeking employment. 21) – Pensioners free treatment. 22) – Win business tenders and contracts. 23) – Do you need to recover your lost property? 24) – Promotion at work and better pay. 25) – Do you want to be protected from bad spirits and nightmares? 26) – Financial problems. 27) – Why you can’t keep money or lovers? 28) – Why you have a lot of enemies? 29) – Why you are fired regularly on jobs? 30) – Speed up money claim spell, delayed payments, pension and accident funds 31) – I help students pass their exams/interviews. 33) – Removal of bad luck and debts. 34) – Are struggling to sleep because of a spiritual wife or husband. 35- ) Recover stolen property
    • slott
      BD303 : SITUS SLOT ONLINE GACOR RESMI TERPECAYA MUDAH MAXWIN

      By slott · Posted

      BD303 merupakan salah satu situs slot mudah scatter paling populer dan digemari oleh kalangan slot online di tahun 2024 mainkan sekarang dengan kesempatan yang mudah menang jackpot jutaan rupiah.

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept