Jump to content

Get list of blocks in a chunk (1.12)


ssherris

Recommended Posts

I'm trying to count the number of blocks of each type in a region bounded by minX,minZ to maxX,maxZ.  I'm struggling to figure out how to capture this.

 

I've tried iterating through the x,y,z using Chunk.getBlockState to get IBlockState or Block.  From this I can see the registry name (ex. "minecraft:leaves") or the Unlocalized name (ex. "tile.leaves").  I can also pull up a list of properties, including variant, for those blocks that have them.  The problem is, for blocks like Stone or Leaves, I'm unable to get the unique variant name.  It's buried in Properties and I can't find a way to generically access that for all blocks without knowing which block I'm looking at.  I also don't care whether dirt is snowy or not, just whether it's dirt, coarse dirt, or podzol, so I don't want to pull the entire state.

 

I thought I'd be able to use the Chunk storage.longarray and the palette. However it doesn't appear there's a way to access that via the code, just the debugger.  In any event palette stores Block and and properties, so I'd have the same issue.

 

I'd really like to check the block ID, but I can't see any way to get it.

 

Ideally my code would be something like:

 

Map<String,int> chunkBlocks;

for (x=0;x<16;x++) {

  for (z=0,z<16,z++) {

      for(y=0,y<255,y++) {

         chunkBlocks.getValue("BlockID/Var")=chunkBlocks.getValue("BlockID/Var")+1}}}

 

How do I get the BlockID? Or at least get a unique identifier of Block Type with Variant?

 

(Note: I know in 1.13 the block variants should be going away, but I'd still like to get this working)

Link to comment
Share on other sites

What's wrong with using the registry name?

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Then you need to use the IBlockState as your key.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

3 hours ago, Draco18s said:

Then you need to use the IBlockState as your key.

Would you mind expanding on that?  IBlockState isn't the right type to use as the key in Block.properties (that's ImmutableMapEntry).  For example if -238, 66, -127 has a BlockState of "minecraft:dirt[snowy=false,variant=dirt]", what would be the generic way of getting minecraft:dirt/dirt?  That is, can I pull the variant without knowing it's a dirt block, or do I need to implement a large switch statement slipping through all of the block types that have variants in order to do

 

Chunk chunk  = server.getWorld(0).getChunkFromBlockCoords(position);
IBlockState block = chunk.getBlockState(-238,66,-127);
String blockFullName = block2.getBlock().getLocalizedName()
String blockVariant;
switch (blockFullName) {
    case "Dirt": blockVariant = block2.getValue(BlockDirt.VARIANT).toString();
        break;
    case "Stone": blockVariant = block2.getValue(BlockStone.VARIANT).toString();
        break:
    .
    .
    .
}
blockFullName = blockFullName + "/" + blockVariant;

 

Is there really no way to pull the BlockId number with variant? The above method not only seems like it will bog down the client with this check on every block, hardcoding the types will also break if there's a block type introduced by a mod that I'm not aware of.

 

Link to comment
Share on other sites

7 hours ago, ssherris said:

what would be the generic way of getting minecraft:dirt/dirt?  That is, can I pull the variant without knowing it's a dirt block

You can get the list of properties from an IBlockState with state.getProperties(). Each property would then be examine-able for its name, type, and allowed values.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.