Jump to content

NBT What am I doing wrong?


American2050

Recommended Posts

So I have this on my readFromNBT in a TileEntity

 

Problem is... Why this if is false?

 

    @Override
    public void readFromNBT(NBTTagCompound compound) {
        
        super.readFromNBT(compound);

        LogHelper.info("CALLED HERE!!! " + compound);

        if (compound.hasKey(PANELS)) {

            LogHelper.info("CALLED INSIDE HAS KEY PANELS");

            NBTTagCompound panels = compound.getCompoundTag(PANELS);
            this.stackPanelUp = new ItemStack(panels.getCompoundTag("up"));

        } else {
            LogHelper.info("NOT TRUE PANELS");
        }

    }

 

Console shows:

 

[21:46:03] [main/INFO] [LogHelper]: CALLED HERE!!! {ForgeData:{factory.panels:{east:{id:"minecraft:air",Count:1b,Damage:0s},south:{id:"minecraft:air",Count:1b,Damage:0s},north:{id:"minecraft:air",Count:1b,Damage:0s},west:{id:"minecraft:air",Count:1b,Damage:0s},up:{id:"minecraft:air",Count:1b,Damage:0s},down:{id:"minecraft:air",Count:1b,Damage:0s}}},x:50,y:83,z:272,id:"factoryblock:te_factory"}
[21:46:03] [main/INFO] [LogHelper]: NOT TRUE PANELS

 

 

PANEL is:

 

public static final String PANELS = "factory.panels";

 

Link to comment
Share on other sites

19 minutes ago, TheAwesomeGem said:

Show  your  writeToNBT method.

Here:
 

    @Override
    public NBTTagCompound writeToNBT(NBTTagCompound compound) {
        // this is called by minecraft to give you the posibility to update your NBT before being saved to the world
        super.writeToNBT(compound);

        compound.setTag("up", this.stackPanelUp.writeToNBT(new NBTTagCompound()));
        compound.setTag("down", this.stackPanelDown.writeToNBT(new NBTTagCompound()));
        compound.setTag("east", this.stackPanelEast.writeToNBT(new NBTTagCompound()));
        compound.setTag("west", this.stackPanelWest.writeToNBT(new NBTTagCompound()));
        compound.setTag("north", this.stackPanelNorth.writeToNBT(new NBTTagCompound()));
        compound.setTag("south", this.stackPanelSouth.writeToNBT(new NBTTagCompound()));

        return compound;
    }

 

The whole class, just in case:

 

Spoiler

package org.bitbucket.factoryblock.tileentity;

import org.bitbucket.factoryblock.LogHelper;
import org.bitbucket.factoryblock.enums.EnumPanels;
import org.bitbucket.factoryblock.interfaces.IPanel;

import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.ITickable;
import net.minecraft.util.NonNullList;

public class TileEntityFactory extends TileEntity implements ITickable, net.minecraft.client.renderer.texture.ITickable {

    public static final String PANELS = "factory.panels";

    private NonNullList<EnumPanels> factoryPanels = NonNullList.withSize(6, EnumPanels.EMPTY);

    private ItemStack stackPanelUp = ItemStack.EMPTY;
    private ItemStack stackPanelDown = ItemStack.EMPTY;
    private ItemStack stackPanelEast = ItemStack.EMPTY;
    private ItemStack stackPanelWest = ItemStack.EMPTY;
    private ItemStack stackPanelNorth = ItemStack.EMPTY;
    private ItemStack stackPanelSouth = ItemStack.EMPTY;

    public TileEntityFactory() {
        this.getTileData().setTag(PANELS, createNBTData());
    }

    @Override
    public void update() {
        // TODO Auto-generated method stub

    }

    // TODO Do we need this?
    @Override
    public void tick() {
        // TODO Auto-generated method stub

    }

    public void setPanelAt(EnumFacing facing, ItemStack stack) {
        switch (facing) {
            case UP:
                this.stackPanelUp = stack;
                break;
            case DOWN:
                this.stackPanelUp = stack;
                break;
            case EAST:
                this.stackPanelUp = stack;
                break;
            case WEST:
                this.stackPanelUp = stack;
                break;
            case NORTH:
                this.stackPanelUp = stack;
                break;
            case SOUTH:
                this.stackPanelUp = stack;
                break;
        }

        // This Force NBT Update?
        this.markDirty();
    }

    public EnumPanels getPanelTypeAt(EnumFacing facing) {

        switch (facing) {
            case UP:
                if (this.stackPanelUp.getItem() instanceof IPanel) {
                    IPanel thePanel = (IPanel) this.stackPanelUp.getItem();
                    return thePanel.getPanelType();
                }
            case DOWN:
                if (this.stackPanelDown.getItem() instanceof IPanel) {
                    IPanel thePanel = (IPanel) this.stackPanelDown.getItem();
                    return thePanel.getPanelType();
                }
            case EAST:
                if (this.stackPanelEast.getItem() instanceof IPanel) {
                    IPanel thePanel = (IPanel) this.stackPanelEast.getItem();
                    return thePanel.getPanelType();
                }
            case WEST:
                if (this.stackPanelWest.getItem() instanceof IPanel) {
                    IPanel thePanel = (IPanel) this.stackPanelWest.getItem();
                    return thePanel.getPanelType();
                }
            case NORTH:
                if (this.stackPanelNorth.getItem() instanceof IPanel) {
                    IPanel thePanel = (IPanel) this.stackPanelNorth.getItem();
                    return thePanel.getPanelType();
                }
            case SOUTH:
                if (this.stackPanelSouth.getItem() instanceof IPanel) {
                    IPanel thePanel = (IPanel) this.stackPanelSouth.getItem();
                    return thePanel.getPanelType();
                }
        }

        return EnumPanels.EMPTY;
    }

    public NBTTagCompound createNBTData() {
        NBTTagCompound panels = new NBTTagCompound();

        // NBTTagCompound panelUp = new NBTTagCompound();
        // NBTTagCompound panelDown = new NBTTagCompound();
        // NBTTagCompound panelEast = new NBTTagCompound();
        // NBTTagCompound panelWest = new NBTTagCompound();
        // NBTTagCompound panelNorth = new NBTTagCompound();
        // NBTTagCompound panelSouth = new NBTTagCompound();

        // panelUp.setString("panel", EnumPanels.EMPTY.getName());
        // stackPanelUp.writeToNBT(panelUp);
        panels.setTag("up", stackPanelUp.writeToNBT(new NBTTagCompound()));

        // panelDown.setString("panel", EnumPanels.EMPTY.getName());
        // stackPanelDown.writeToNBT(panelDown);
        panels.setTag("down", stackPanelDown.writeToNBT(new NBTTagCompound()));

        // panelEast.setString("panel", EnumPanels.EMPTY.getName());
        // stackPanelEast.writeToNBT(panelEast);
        panels.setTag("east", stackPanelEast.writeToNBT(new NBTTagCompound()));

        // panelWest.setString("panel", EnumPanels.EMPTY.getName());
        // stackPanelWest.writeToNBT(panelWest);
        panels.setTag("west", stackPanelWest.writeToNBT(new NBTTagCompound()));

        // panelNorth.setString("panel", EnumPanels.EMPTY.getName());
        // stackPanelNorth.writeToNBT(panelNorth);
        panels.setTag("north", stackPanelNorth.writeToNBT(new NBTTagCompound()));

        // panelSouth.setString("panel", EnumPanels.EMPTY.getName());
        // stackPanelSouth.writeToNBT(panelSouth);
        panels.setTag("south", stackPanelSouth.writeToNBT(new NBTTagCompound()));

        return panels;
    }

    @Override
    public NBTTagCompound writeToNBT(NBTTagCompound compound) {
        // this is called by minecraft to give you the posibility to update your NBT before being saved to the world
        super.writeToNBT(compound);

        compound.setTag("up", this.stackPanelUp.writeToNBT(new NBTTagCompound()));
        compound.setTag("down", this.stackPanelDown.writeToNBT(new NBTTagCompound()));
        compound.setTag("east", this.stackPanelEast.writeToNBT(new NBTTagCompound()));
        compound.setTag("west", this.stackPanelWest.writeToNBT(new NBTTagCompound()));
        compound.setTag("north", this.stackPanelNorth.writeToNBT(new NBTTagCompound()));
        compound.setTag("south", this.stackPanelSouth.writeToNBT(new NBTTagCompound()));

        return compound;
    }

    @Override
    public void readFromNBT(NBTTagCompound compound) {

        super.readFromNBT(compound);

        LogHelper.info("CALLED HERE!!! " + compound);

        if (compound.hasKey(PANELS)) {

            LogHelper.info("CALLED INSIDE HAS KEY PANELS");

            NBTTagCompound panels = compound.getCompoundTag(PANELS);

            this.stackPanelUp = new ItemStack(panels.getCompoundTag("up"));
            this.stackPanelDown = new ItemStack(panels.getCompoundTag("down"));
            this.stackPanelEast = new ItemStack(panels.getCompoundTag("east"));
            this.stackPanelWest = new ItemStack(panels.getCompoundTag("west"));
            this.stackPanelNorth = new ItemStack(panels.getCompoundTag("north"));
            this.stackPanelSouth = new ItemStack(panels.getCompoundTag("south"));

        } else {
            LogHelper.info("NOT TRUE PANELS");
        }

    }

    @Override
    public NBTTagCompound getUpdateTag() {
        // TODO Auto-generated method stub
        return super.getUpdateTag();
    }

}

 

PS: I believe I now see the problem :P But lets see...

Edited by American2050
Link to comment
Share on other sites

22 minutes ago, American2050 said:

Here:
 


    @Override
    public NBTTagCompound writeToNBT(NBTTagCompound compound) {
        // this is called by minecraft to give you the posibility to update your NBT before being saved to the world
        super.writeToNBT(compound);

        compound.setTag("up", this.stackPanelUp.writeToNBT(new NBTTagCompound()));
        compound.setTag("down", this.stackPanelDown.writeToNBT(new NBTTagCompound()));
        compound.setTag("east", this.stackPanelEast.writeToNBT(new NBTTagCompound()));
        compound.setTag("west", this.stackPanelWest.writeToNBT(new NBTTagCompound()));
        compound.setTag("north", this.stackPanelNorth.writeToNBT(new NBTTagCompound()));
        compound.setTag("south", this.stackPanelSouth.writeToNBT(new NBTTagCompound()));

        return compound;
    }

 

The whole class, just in case:

 

  Hide contents


package org.bitbucket.factoryblock.tileentity;

import org.bitbucket.factoryblock.LogHelper;
import org.bitbucket.factoryblock.enums.EnumPanels;
import org.bitbucket.factoryblock.interfaces.IPanel;

import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.ITickable;
import net.minecraft.util.NonNullList;

public class TileEntityFactory extends TileEntity implements ITickable, net.minecraft.client.renderer.texture.ITickable {

    public static final String PANELS = "factory.panels";

    private NonNullList<EnumPanels> factoryPanels = NonNullList.withSize(6, EnumPanels.EMPTY);

    private ItemStack stackPanelUp = ItemStack.EMPTY;
    private ItemStack stackPanelDown = ItemStack.EMPTY;
    private ItemStack stackPanelEast = ItemStack.EMPTY;
    private ItemStack stackPanelWest = ItemStack.EMPTY;
    private ItemStack stackPanelNorth = ItemStack.EMPTY;
    private ItemStack stackPanelSouth = ItemStack.EMPTY;

    public TileEntityFactory() {
        this.getTileData().setTag(PANELS, createNBTData());
    }

    @Override
    public void update() {
        // TODO Auto-generated method stub

    }

    // TODO Do we need this?
    @Override
    public void tick() {
        // TODO Auto-generated method stub

    }

    public void setPanelAt(EnumFacing facing, ItemStack stack) {
        switch (facing) {
            case UP:
                this.stackPanelUp = stack;
                break;
            case DOWN:
                this.stackPanelUp = stack;
                break;
            case EAST:
                this.stackPanelUp = stack;
                break;
            case WEST:
                this.stackPanelUp = stack;
                break;
            case NORTH:
                this.stackPanelUp = stack;
                break;
            case SOUTH:
                this.stackPanelUp = stack;
                break;
        }

        // This Force NBT Update?
        this.markDirty();
    }

    public EnumPanels getPanelTypeAt(EnumFacing facing) {

        switch (facing) {
            case UP:
                if (this.stackPanelUp.getItem() instanceof IPanel) {
                    IPanel thePanel = (IPanel) this.stackPanelUp.getItem();
                    return thePanel.getPanelType();
                }
            case DOWN:
                if (this.stackPanelDown.getItem() instanceof IPanel) {
                    IPanel thePanel = (IPanel) this.stackPanelDown.getItem();
                    return thePanel.getPanelType();
                }
            case EAST:
                if (this.stackPanelEast.getItem() instanceof IPanel) {
                    IPanel thePanel = (IPanel) this.stackPanelEast.getItem();
                    return thePanel.getPanelType();
                }
            case WEST:
                if (this.stackPanelWest.getItem() instanceof IPanel) {
                    IPanel thePanel = (IPanel) this.stackPanelWest.getItem();
                    return thePanel.getPanelType();
                }
            case NORTH:
                if (this.stackPanelNorth.getItem() instanceof IPanel) {
                    IPanel thePanel = (IPanel) this.stackPanelNorth.getItem();
                    return thePanel.getPanelType();
                }
            case SOUTH:
                if (this.stackPanelSouth.getItem() instanceof IPanel) {
                    IPanel thePanel = (IPanel) this.stackPanelSouth.getItem();
                    return thePanel.getPanelType();
                }
        }

        return EnumPanels.EMPTY;
    }

    public NBTTagCompound createNBTData() {
        NBTTagCompound panels = new NBTTagCompound();

        // NBTTagCompound panelUp = new NBTTagCompound();
        // NBTTagCompound panelDown = new NBTTagCompound();
        // NBTTagCompound panelEast = new NBTTagCompound();
        // NBTTagCompound panelWest = new NBTTagCompound();
        // NBTTagCompound panelNorth = new NBTTagCompound();
        // NBTTagCompound panelSouth = new NBTTagCompound();

        // panelUp.setString("panel", EnumPanels.EMPTY.getName());
        // stackPanelUp.writeToNBT(panelUp);
        panels.setTag("up", stackPanelUp.writeToNBT(new NBTTagCompound()));

        // panelDown.setString("panel", EnumPanels.EMPTY.getName());
        // stackPanelDown.writeToNBT(panelDown);
        panels.setTag("down", stackPanelDown.writeToNBT(new NBTTagCompound()));

        // panelEast.setString("panel", EnumPanels.EMPTY.getName());
        // stackPanelEast.writeToNBT(panelEast);
        panels.setTag("east", stackPanelEast.writeToNBT(new NBTTagCompound()));

        // panelWest.setString("panel", EnumPanels.EMPTY.getName());
        // stackPanelWest.writeToNBT(panelWest);
        panels.setTag("west", stackPanelWest.writeToNBT(new NBTTagCompound()));

        // panelNorth.setString("panel", EnumPanels.EMPTY.getName());
        // stackPanelNorth.writeToNBT(panelNorth);
        panels.setTag("north", stackPanelNorth.writeToNBT(new NBTTagCompound()));

        // panelSouth.setString("panel", EnumPanels.EMPTY.getName());
        // stackPanelSouth.writeToNBT(panelSouth);
        panels.setTag("south", stackPanelSouth.writeToNBT(new NBTTagCompound()));

        return panels;
    }

    @Override
    public NBTTagCompound writeToNBT(NBTTagCompound compound) {
        // this is called by minecraft to give you the posibility to update your NBT before being saved to the world
        super.writeToNBT(compound);

        compound.setTag("up", this.stackPanelUp.writeToNBT(new NBTTagCompound()));
        compound.setTag("down", this.stackPanelDown.writeToNBT(new NBTTagCompound()));
        compound.setTag("east", this.stackPanelEast.writeToNBT(new NBTTagCompound()));
        compound.setTag("west", this.stackPanelWest.writeToNBT(new NBTTagCompound()));
        compound.setTag("north", this.stackPanelNorth.writeToNBT(new NBTTagCompound()));
        compound.setTag("south", this.stackPanelSouth.writeToNBT(new NBTTagCompound()));

        return compound;
    }

    @Override
    public void readFromNBT(NBTTagCompound compound) {

        super.readFromNBT(compound);

        LogHelper.info("CALLED HERE!!! " + compound);

        if (compound.hasKey(PANELS)) {

            LogHelper.info("CALLED INSIDE HAS KEY PANELS");

            NBTTagCompound panels = compound.getCompoundTag(PANELS);

            this.stackPanelUp = new ItemStack(panels.getCompoundTag("up"));
            this.stackPanelDown = new ItemStack(panels.getCompoundTag("down"));
            this.stackPanelEast = new ItemStack(panels.getCompoundTag("east"));
            this.stackPanelWest = new ItemStack(panels.getCompoundTag("west"));
            this.stackPanelNorth = new ItemStack(panels.getCompoundTag("north"));
            this.stackPanelSouth = new ItemStack(panels.getCompoundTag("south"));

        } else {
            LogHelper.info("NOT TRUE PANELS");
        }

    }

    @Override
    public NBTTagCompound getUpdateTag() {
        // TODO Auto-generated method stub
        return super.getUpdateTag();
    }

}

 

PS: I believe I now see the problem :P But lets see...

You are not saving the PANELS tag.

Link to comment
Share on other sites

9 hours ago, TheAwesomeGem said:

You are not saving the PANELS tag.

Yes now that I see the writeToNBT I noticed that, but how come that when I print the compound to the console it does show the tag PANELS there and the default values for each side?

PS: the createNBT is implemented correctly? Is it ok to call it from the constructor?

Thanks a lot.

Link to comment
Share on other sites

Also... Independent of the fact that I was missing to write the tag PANELS... How come it's there on the NBT I receive, but the hasKey still is false?

 

@Override
    public NBTTagCompound writeToNBT(NBTTagCompound compound) {
        // this is called by minecraft to give you the posibility to update your NBT before being saved to the world
        super.writeToNBT(compound);

        LogHelper.info("CALLED WRITE " + compound + " content");

        if (compound.hasKey(PANELS)) {
            LogHelper.info("HAS PANELS");
        }

 

Console shows:

 

[08:35:04] [Server thread/INFO] [LogHelper]: CALLED WRITE {ForgeData:{factory.panels:{east:{id:"minecraft:air",Count:1b,Damage:0s},south:{id:"minecraft:air",Count:1b,Damage:0s},north:{id:"minecraft:air",Count:1b,Damage:0s},west:{id:"minecraft:air",Count:1b,Damage:0s},up:{id:"minecraft:air",Count:1b,Damage:0s},down:{id:"minecraft:air",Count:1b,Damage:0s}}},x:50,y:83,z:272,id:"factoryblock:te_factory"} content

 

but HAS PANELS never shows... isn't {ForgeData:{factory.panels:{east:{id indicating the precense of the tag PANELS there, or I'm missing something?

Link to comment
Share on other sites

Judging by the "ForgeData" tag, it looks like you're using TileEntity#getTileData somewhere; don't do this. The tag returned by TileEntity#getTileData is for mods to store custom data on external TileEntities; but the capability system is a much better way to do this.

 

When you call TileEntity#writeToNBT, pass an empty compound tag as the argument.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Link to comment
Share on other sites

9 minutes ago, Choonster said:

Judging by the "ForgeData" tag, it looks like you're using TileEntity#getTileData somewhere; don't do this. The tag returned by TileEntity#getTileData is for mods to store custom data on external TileEntities; but the capability system is a much better way to do this.

 

When you call TileEntity#writeToNBT, pass an empty compound tag as the argument.

Ohh ok. Well a friend told me that apparently I should never call the writeToNBT myself, not sure where he saw that. Is it ok to call it from the createNBT method that I have in my constructor, so each time the tileentity is set on the world, it creates the default values?

 

PD: I had the getTileData at the constructor as // this.getTileData().setTag(PANELS, createNBTData());

Link to comment
Share on other sites

6 minutes ago, American2050 said:

Ohh ok. Well a friend told me that apparently I should never call the writeToNBT myself, not sure where he saw that. Is it ok to call it from the createNBT method that I have in my constructor, so each time the tileentity is set on the world, it creates the default values?

 

PD: I had the getTileData at the constructor as // this.getTileData().setTag(PANELS, createNBTData());

 

Don't call TileEntity#writeToNBT unless you actually need to serialise the TileEntity to NBT (e.g. to store the data in an ItemStack). Minecraft automatically calls it when the chunk is written to disk.

 

Your TileEntity's data should be stored in regular fields and only written to NBT when necessary.

  • Like 1

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Link to comment
Share on other sites

Just now, Choonster said:

 

Don't call TileEntity#writeToNBT unless you actually need to serialise the TileEntity to NBT (e.g. to store the data in an ItemStack). Minecraft automatically calls it when the chunk is written to disk.

 

Your TileEntity's data should be stored in regular fields and only written to NBT when necessary.

Ohhh ok, so I don't need to worry about storing the values for the first time when the TileEntity is placed in the world?

 

I was doing this so, when I call methods from the Block, for example onBlockActivated I already "know" and can be "sure" that the TileEntity already has default values. But I guess I check against variables and not the data on the NBT right? Like if I want to change the value of for example ItemStack on side "UP" I just change the value of that variable and whenever Minecraft calls the writeToNBT it will update that value?

 

Thanks, and sorry for so many questions NBT was/is (and hopefully not will always be) a shady part on codding that I never clearly understand.

Link to comment
Share on other sites

Apparently the problem is that the server isn't receiving the updated information.

 

This is a log when loading a world with one of my TileEntities placed on it...

 

[09:35:44] [Server thread/INFO] [LogHelper]: CALLED HERE ON READ!!!
[09:35:44] [Server thread/INFO] [LogHelper]: COMPOUND ON READ IS: {ForgeData:{factory.data:{factory.panels:{east:{id:"minecraft:air",Count:1b,Damage:0s},south:{id:"minecraft:air",Count:1b,Damage:0s},north:{id:"minecraft:air",Count:1b,Damage:0s},west:{id:"minecraft:air",Count:1b,Damage:0s},up:{id:"minecraft:air",Count:1b,Damage:0s},down:{id:"minecraft:air",Count:1b,Damage:0s}}}},x:52,y:83,z:269,id:"factoryblock:te_factory",factory.data:{factory.panels:{east:{id:"minecraft:air",Count:0b,Damage:0s},south:{id:"minecraft:air",Count:0b,Damage:0s},north:{id:"minecraft:air",Count:0b,Damage:0s},west:{id:"minecraft:air",Count:0b,Damage:0s},up:{id:"minecraft:air",Count:0b,Damage:0s},down:{id:"minecraft:air",Count:0b,Damage:0s}}}}
[09:35:44] [Server thread/INFO] [LogHelper]: HAS TAG ON READ
[09:35:44] [Server thread/INFO] [LogHelper]: HAS PANELS ON READ

[09:35:49] [Server thread/INFO] [LogHelper]: COMPOUND ON WRITE IS: {ForgeData:{factory.data:{factory.panels:{east:{id:"minecraft:air",Count:1b,Damage:0s},south:{id:"minecraft:air",Count:1b,Damage:0s},north:{id:"minecraft:air",Count:1b,Damage:0s},west:{id:"minecraft:air",Count:1b,Damage:0s},up:{id:"minecraft:air",Count:1b,Damage:0s},down:{id:"minecraft:air",Count:1b,Damage:0s}}}},x:52,y:83,z:269,id:"factoryblock:te_factory",factory.data:{factory.panels:{east:{id:"minecraft:air",Count:0b,Damage:0s},south:{id:"minecraft:air",Count:0b,Damage:0s},north:{id:"minecraft:air",Count:0b,Damage:0s},west:{id:"minecraft:air",Count:0b,Damage:0s},up:{id:"minecraft:air",Count:0b,Damage:0s},down:{id:"minecraft:air",Count:0b,Damage:0s}}}}
[09:35:49] [Server thread/INFO] [LogHelper]: HAS TAG ON WRITE
[09:35:49] [Server thread/INFO] [LogHelper]: HAS PANELS ON WRITE
[09:35:49] [Server thread/INFO] [LogHelper]: HAS up ON WRITE

[09:35:49] [main/INFO] [LogHelper]: CALLED HERE ON READ!!!
[09:35:49] [main/INFO] [LogHelper]: COMPOUND ON READ IS: {ForgeData:{factory.data:{factory.panels:{east:{id:"minecraft:air",Count:1b,Damage:0s},south:{id:"minecraft:air",Count:1b,Damage:0s},north:{id:"minecraft:air",Count:1b,Damage:0s},west:{id:"minecraft:air",Count:1b,Damage:0s},up:{id:"minecraft:air",Count:1b,Damage:0s},down:{id:"minecraft:air",Count:1b,Damage:0s}}}},x:52,y:83,z:269,id:"factoryblock:te_factory"}

[09:35:53] [Server thread/INFO] [LogHelper]: COMPOUND ON WRITE IS: {ForgeData:{factory.data:{factory.panels:{east:{id:"minecraft:air",Count:1b,Damage:0s},south:{id:"minecraft:air",Count:1b,Damage:0s},north:{id:"minecraft:air",Count:1b,Damage:0s},west:{id:"minecraft:air",Count:1b,Damage:0s},up:{id:"minecraft:air",Count:1b,Damage:0s},down:{id:"minecraft:air",Count:1b,Damage:0s}}}},x:52,y:83,z:269,id:"factoryblock:te_factory",factory.data:{factory.panels:{east:{id:"minecraft:air",Count:0b,Damage:0s},south:{id:"minecraft:air",Count:0b,Damage:0s},north:{id:"minecraft:air",Count:0b,Damage:0s},west:{id:"minecraft:air",Count:0b,Damage:0s},up:{id:"minecraft:air",Count:0b,Damage:0s},down:{id:"minecraft:air",Count:0b,Damage:0s}}}}
[09:35:53] [Server thread/INFO] [LogHelper]: HAS TAG ON WRITE
[09:35:53] [Server thread/INFO] [LogHelper]: HAS PANELS ON WRITE
[09:35:53] [Server thread/INFO] [LogHelper]: HAS up ON WRITE
[09:35:53] [Server thread/INFO]: Saving chunks for level 'New World'/the_nether
[09:35:53] [Server thread/INFO]: Saving chunks for level 'New World'/the_end

 

This are the differences I notice: The Write was only called on server.

 

And when the read is called both, Server and Client side, the information on the NBT is different

 

SERVER on READ
{ForgeData:{factory.data:
{factory.panels:{
east:{id:"minecraft:air",Count:1b,Damage:0s},
south:{id:"minecraft:air",Count:1b,Damage:0s},
north:{id:"minecraft:air",Count:1b,Damage:0s},
west:{id:"minecraft:air",Count:1b,Damage:0s},
up:{id:"minecraft:air",Count:1b,Damage:0s},
down:{id:"minecraft:air",Count:1b,Damage:0s}}}},
x:52,y:83,z:269,id:"factoryblock:te_factory",

factory.data:
{factory.panels:{
east:{id:"minecraft:air",Count:0b,Damage:0s},
south:{id:"minecraft:air",Count:0b,Damage:0s},
north:{id:"minecraft:air",Count:0b,Damage:0s},
west:{id:"minecraft:air",Count:0b,Damage:0s},
up:{id:"minecraft:air",Count:0b,Damage:0s},
down:{id:"minecraft:air",Count:0b,Damage:0s}}}}


CLIENT on READ
{ForgeData:{factory.data:
{factory.panels:{
east:{id:"minecraft:air",Count:1b,Damage:0s},
south:{id:"minecraft:air",Count:1b,Damage:0s},
north:{id:"minecraft:air",Count:1b,Damage:0s},
west:{id:"minecraft:air",Count:1b,Damage:0s},
up:{id:"minecraft:air",Count:1b,Damage:0s},
down:{id:"minecraft:air",Count:1b,Damage:0s}}}},
x:52,y:83,z:269,id:"factoryblock:te_factory"}

 

What I don't understand why is the ForgeData there? And how the client go it?

PS: I guess the fix for this is to work with packets now? I remember I saw something about overwriting 4 packet methods for TileEntities but will have to read about this as I have not idea.
 

This is my TE code now after cleanup:

 

package org.bitbucket.factoryblock.tileentity;

import org.bitbucket.factoryblock.LogHelper;
import org.bitbucket.factoryblock.enums.EnumPanels;
import org.bitbucket.factoryblock.interfaces.IPanel;

import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.ITickable;

public class TileEntityFactory extends TileEntity implements ITickable, net.minecraft.client.renderer.texture.ITickable {

    public static final String TAG = "factory.data";
    public static final String PANELS = "factory.panels";

    private ItemStack stackPanelUp = ItemStack.EMPTY;
    private ItemStack stackPanelDown = ItemStack.EMPTY;
    private ItemStack stackPanelEast = ItemStack.EMPTY;
    private ItemStack stackPanelWest = ItemStack.EMPTY;
    private ItemStack stackPanelNorth = ItemStack.EMPTY;
    private ItemStack stackPanelSouth = ItemStack.EMPTY;

    public TileEntityFactory() {
    }

    @Override
    public void update() {
        // TODO Auto-generated method stub

    }

    // TODO Do we need this?
    @Override
    public void tick() {
        // TODO Auto-generated method stub

    }

    public void setPanelAt(EnumFacing facing, ItemStack stack) {
        switch (facing) {
            case UP:
                this.stackPanelUp = stack;
                break;
            case DOWN:
                this.stackPanelUp = stack;
                break;
            case EAST:
                this.stackPanelUp = stack;
                break;
            case WEST:
                this.stackPanelUp = stack;
                break;
            case NORTH:
                this.stackPanelUp = stack;
                break;
            case SOUTH:
                this.stackPanelUp = stack;
                break;
        }

        // This Force NBT Update?
        this.markDirty();
    }

    public EnumPanels getPanelTypeAt(EnumFacing facing) {

        switch (facing) {
            case UP:
                if (this.stackPanelUp.getItem() instanceof IPanel) {
                    IPanel thePanel = (IPanel) this.stackPanelUp.getItem();
                    return thePanel.getPanelType();
                }
            case DOWN:
                if (this.stackPanelDown.getItem() instanceof IPanel) {
                    IPanel thePanel = (IPanel) this.stackPanelDown.getItem();
                    return thePanel.getPanelType();
                }
            case EAST:
                if (this.stackPanelEast.getItem() instanceof IPanel) {
                    IPanel thePanel = (IPanel) this.stackPanelEast.getItem();
                    return thePanel.getPanelType();
                }
            case WEST:
                if (this.stackPanelWest.getItem() instanceof IPanel) {
                    IPanel thePanel = (IPanel) this.stackPanelWest.getItem();
                    return thePanel.getPanelType();
                }
            case NORTH:
                if (this.stackPanelNorth.getItem() instanceof IPanel) {
                    IPanel thePanel = (IPanel) this.stackPanelNorth.getItem();
                    return thePanel.getPanelType();
                }
            case SOUTH:
                if (this.stackPanelSouth.getItem() instanceof IPanel) {
                    IPanel thePanel = (IPanel) this.stackPanelSouth.getItem();
                    return thePanel.getPanelType();
                }
        }

        return EnumPanels.EMPTY;
    }

    @Override
    public NBTTagCompound writeToNBT(NBTTagCompound compound) {

        super.writeToNBT(compound);

        // DATA
        NBTTagCompound data = new NBTTagCompound();

        // PANELS
        NBTTagCompound panels = new NBTTagCompound();

        panels.setTag("up", this.stackPanelUp.writeToNBT(new NBTTagCompound()));
        panels.setTag("down", this.stackPanelDown.writeToNBT(new NBTTagCompound()));
        panels.setTag("east", this.stackPanelEast.writeToNBT(new NBTTagCompound()));
        panels.setTag("west", this.stackPanelWest.writeToNBT(new NBTTagCompound()));
        panels.setTag("north", this.stackPanelNorth.writeToNBT(new NBTTagCompound()));
        panels.setTag("south", this.stackPanelSouth.writeToNBT(new NBTTagCompound()));

        // STORE PANELS ON DATA
        data.setTag(PANELS, panels);

        // STORE DATA ON A MAIN TAG
        compound.setTag(TAG, data);

        LogHelper.info("COMPOUND ON WRITE IS: " + compound);

        if (compound.hasKey(TAG)) {
            LogHelper.info("HAS TAG ON WRITE");
            NBTTagCompound temp = compound.getCompoundTag(TAG);
            if (temp.hasKey(PANELS)) {
                LogHelper.info("HAS PANELS ON WRITE");
                NBTTagCompound temp_panels = temp.getCompoundTag(PANELS);

                if (temp_panels.hasKey("up")) {
                    LogHelper.info("HAS up ON WRITE");
                }
            }
        }
        return compound;
    }

    @Override
    public void readFromNBT(NBTTagCompound compound) {

        super.readFromNBT(compound);

        LogHelper.info("CALLED HERE ON READ!!!");
        LogHelper.info("COMPOUND ON READ IS: " + compound);

        if (compound.hasKey(TAG)) {

            LogHelper.info("HAS TAG ON READ");

            NBTTagCompound data = compound.getCompoundTag(TAG);

            if (data.hasKey(PANELS)) {

                LogHelper.info("HAS PANELS ON READ");

                NBTTagCompound panels = data.getCompoundTag(PANELS);

                this.stackPanelUp = new ItemStack(panels.getCompoundTag("up"));
                this.stackPanelDown = new ItemStack(panels.getCompoundTag("down"));
                this.stackPanelEast = new ItemStack(panels.getCompoundTag("east"));
                this.stackPanelWest = new ItemStack(panels.getCompoundTag("west"));
                this.stackPanelNorth = new ItemStack(panels.getCompoundTag("north"));
                this.stackPanelSouth = new ItemStack(panels.getCompoundTag("south"));
            }

        }

    }

    /*
     * @Override
     * public NBTTagCompound getUpdateTag() {
     * return super.getUpdateTag();
     * }
     */

}

 

Link to comment
Share on other sites

26 minutes ago, diesieben07 said:

Some things to clear up:

  • Saving to disk for tile entities (and normal entities) happens automatically, you get no control over when it happens. The only thing you must do is call TileEntity::markDirty when data that needs saving has changed. This tells Minecraft "Hey, I need saving before you unload me". When that happens does not matter and you should not care about it. markDirty also tells nearby blocks "hey, my tile entity data has changed" (by calling Block::onNeighborChange if Block::getWeakChanges returns true for the neighboring block). This is used to update comparators when a nearby inventory changes. Making these two things one method is ugly, but that's how it is.
  • Loading from disk for tile entities happens automatically. You can (usually) assume that your tile entity will not be in a state of "I am freshly created but do not have the data yet". Only exception is a constructor in your TileEntity class (seriously, you almost never should write one) and obviously the Block::createTileEntity method, where you just created the fresh instance.
  • Stop thinking in terms of "store stuff in NBT". NBT is a serialization format (like JSON). You store things in your tile entity, which happens to use NBT to persist data into the world. But nobody but the methods writeToNbt and readFromNbt need to care about this and nobody else but them should touch NBT.
  • getUpdateTag (which you have pointlessly overridden) is vanilla's crude tile entity synchronization mechanism. For vanilla this mechanism is "take the complete tile entity state, serialize it like we would if saving to disk and then shove it down the network". Adopting this mechanism in modded code is terrible, since modded tile entities often have incredibly complex functionality and produce lots of data when saving to disk. There is no need to shove all this crap down the network. Only send over what you need to and if you are feeling especially nice, stop using the terrible NBT-based syncing that vanilla uses.

Now, on to the issues with your code:

  • Do not implement that client-only ITickable interface on your tile entity. You will crash a dedicated server.
  • Never, ever use getTileData. Seriously. For your own tile entities, store data in normal fields (see above). Do not use NBT here, NBT is for saving to disk, only (ignore ItemStacks, they are terrible).

Thanks a lot for all this, great information. Some points here. I used the getUpdateTag  because I was following a tutorial and example code from MinecraftByExamples on the TileEntities examples

https://github.com/TheGreyGhost/MinecraftByExample/tree/master/src/main/java/minecraftbyexample/mbe20_tileentity_data

(so now I have the 4 methods suggested there getUpdatePacket(), getUpdateTag(), onDataPacket(), and handleUpdateTag() been overriden.

 

Now going with the thinking of "I store things in my TileEntity" problem comes when I change a variable on my TileEntity but those changes are made server only, then the client doesn't know about them until writeToNBT and readFromNBT are called.

 

I have a point on my TileEntity after I set x ItemStack to any given side, at the end of that method I call this.markDirty (But you mention I shouldn't care of "When" that happens) I would like for it to happen inmediatly, so my block knows about the changes.

 

Now on my block, on the method onBlockActivated (And server side) I set the ItemStacks on my tile entity and, after that is done I am calling .notifyBlockUpdate on the client side. It's not until the 2nd time I right click that you can see the render update (At this point I'm not sure if it's because the first time it's called, it still doesn't have the information of what ItemStack is on X side or what) I will have to see what's going on there.

 

PS: What do you mean with "ignore ItemStacks they are terrible"? You mean why I'm storing itemstacks on my TileEntity this way?

Edited by American2050
Link to comment
Share on other sites

diesieben07 Thanks a lot for the time you take answering this questions and clarifying all the points. I believe that I finally have a better understanding on what's happening and when it's happening and more important, on how to handle this things.

I'm gonna start implementing all this and let you know how it went.

 

I was super super lost because I'm using a lot of things I never experiment with before. Special Rendering for my block, extended unlisted properties, and all this data sync across server and client. Tons of stuff going on at the same time, and I unsure on how to implement all of those, so it literally fell like 1 step forward and 10 back for each thing I got working. Always hitting some bump :P

 

Thanks once again. :x

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • it crashed again     What the console says : [00:02:03] [Server thread/INFO] [Easy NPC/]: [EntityManager] Server started! [00:02:03] [Server thread/INFO] [co.gi.al.ic.IceAndFire/]: {iceandfire:fire_dragon_roost=true, iceandfire:fire_lily=true, iceandfire:spawn_dragon_skeleton_fire=true, iceandfire:lightning_dragon_roost=true, iceandfire:spawn_dragon_skeleton_lightning=true, iceandfire:ice_dragon_roost=true, iceandfire:ice_dragon_cave=true, iceandfire:lightning_dragon_cave=true, iceandfire:cyclops_cave=true, iceandfire:spawn_wandering_cyclops=true, iceandfire:spawn_sea_serpent=true, iceandfire:frost_lily=true, iceandfire:hydra_cave=true, iceandfire:lightning_lily=true, iceandfireixie_village=true, iceandfire:myrmex_hive_jungle=true, iceandfire:myrmex_hive_desert=true, iceandfire:silver_ore=true, iceandfire:siren_island=true, iceandfire:spawn_dragon_skeleton_ice=true, iceandfire:spawn_stymphalian_bird=true, iceandfire:fire_dragon_cave=true, iceandfire:sapphire_ore=true, iceandfire:spawn_hippocampus=true, iceandfire:spawn_death_worm=true} [00:02:03] [Server thread/INFO] [co.gi.al.ic.IceAndFire/]: {TROLL_S=true, HIPPOGRYPH=true, AMPHITHERE=true, COCKATRICE=true, TROLL_M=true, DREAD_LICH=true, TROLL_F=true} [00:02:03] [Server thread/INFO] [ne.be.lo.WeaponRegistry/]: Encoded Weapon Attribute registry size (with package overhead): 41976 bytes (in 5 string chunks with the size of 10000) [00:02:03] [Server thread/INFO] [patchouli/]: Sending reload packet to clients [00:02:03] [Server thread/WARN] [voicechat/]: [voicechat] Running in offline mode - Voice chat encryption is not secure! [00:02:03] [VoiceChatServerThread/INFO] [voicechat/]: [voicechat] Using server-ip as bind address: 0.0.0.0 [00:02:03] [Server thread/WARN] [ModernFix/]: Dedicated server took 22.521 seconds to load [00:02:03] [VoiceChatServerThread/INFO] [voicechat/]: [voicechat] Voice chat server started at 0.0.0.0:25565 [00:02:03] [Server thread/WARN] [minecraft/SynchedEntityData]: defineId called for: class net.minecraft.world.entity.player.Player from class tschipp.carryon.common.carry.CarryOnDataManager [00:02:03] [Server thread/INFO] [ne.mi.co.AdvancementLoadFix/]: Using new advancement loading for net.minecraft.server.PlayerAdvancements@2941ffd5 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 0 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 1 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 2 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 3 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 4 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 5 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 6 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 7 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 8 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 9 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 10 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 11 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 12 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 13 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 14 [00:02:19] [Server thread/INFO] [ne.mi.co.AdvancementLoadFix/]: Using new advancement loading for net.minecraft.server.PlayerAdvancements@ebc7ef2 [00:02:19] [Server thread/INFO] [minecraft/PlayerList]: ZacAdos[/90.2.17.162:49242] logged in with entity id 1062 at (-1848.6727005281205, 221.0, -3054.2468255848935) [00:02:19] [Server thread/ERROR] [ModernFix/]: Skipping entity ID sync for com.talhanation.smallships.world.entity.ship.Ship: java.lang.NoClassDefFoundError: net/minecraft/client/CameraType [00:02:19] [Server thread/INFO] [minecraft/MinecraftServer]: - Gloop - ZacAdos joined the game [00:02:19] [Server thread/INFO] [xa.pa.OpenPartiesAndClaims/]: Updating all forceload tickets for cc56befd-d376-3526-a760-340713c478bd [00:02:19] [Server thread/INFO] [se.mi.te.da.DataManager/]: Sending data to client: ZacAdos [00:02:19] [Server thread/INFO] [voicechat/]: [voicechat] Received secret request of - Gloop - ZacAdos (17) [00:02:19] [Server thread/INFO] [voicechat/]: [voicechat] Sent secret to - Gloop - ZacAdos [00:02:21] [VoiceChatPacketProcessingThread/INFO] [voicechat/]: [voicechat] Successfully authenticated player cc56befd-d376-3526-a760-340713c478bd [00:02:22] [VoiceChatPacketProcessingThread/INFO] [voicechat/]: [voicechat] Successfully validated connection of player cc56befd-d376-3526-a760-340713c478bd [00:02:22] [VoiceChatPacketProcessingThread/INFO] [voicechat/]: [voicechat] Player - Gloop - ZacAdos (cc56befd-d376-3526-a760-340713c478bd) successfully connected to voice chat stop [00:02:34] [Server thread/INFO] [minecraft/MinecraftServer]: Stopping the server [00:02:34] [Server thread/INFO] [mo.pl.ar.ArmourersWorkshop/]: stop local service [00:02:34] [Server thread/INFO] [minecraft/MinecraftServer]: Stopping server [00:02:34] [Server thread/INFO] [minecraft/MinecraftServer]: Saving players [00:02:34] [Server thread/INFO] [minecraft/ServerGamePacketListenerImpl]: ZacAdos lost connection: Server closed [00:02:34] [Server thread/INFO] [minecraft/MinecraftServer]: - Gloop - ZacAdos left the game [00:02:34] [Server thread/INFO] [xa.pa.OpenPartiesAndClaims/]: Updating all forceload tickets for cc56befd-d376-3526-a760-340713c478bd [00:02:34] [Server thread/INFO] [minecraft/MinecraftServer]: Saving worlds [00:02:34] [Server thread/INFO] [minecraft/MinecraftServer]: Saving chunks for level 'ServerLevel[world]'/minecraft:overworld [00:02:34] [Server thread/INFO] [minecraft/MinecraftServer]: Saving chunks for level 'ServerLevel[world]'/minecraft:the_end [00:02:34] [Server thread/INFO] [minecraft/MinecraftServer]: Saving chunks for level 'ServerLevel[world]'/minecraft:the_nether [00:02:34] [Server thread/INFO] [minecraft/MinecraftServer]: ThreadedAnvilChunkStorage (world): All chunks are saved [00:02:34] [Server thread/INFO] [minecraft/MinecraftServer]: ThreadedAnvilChunkStorage (DIM1): All chunks are saved [00:02:34] [Server thread/INFO] [minecraft/MinecraftServer]: ThreadedAnvilChunkStorage (DIM-1): All chunks are saved [00:02:34] [Server thread/INFO] [minecraft/MinecraftServer]: ThreadedAnvilChunkStorage: All dimensions are saved [00:02:34] [Server thread/INFO] [xa.pa.OpenPartiesAndClaims/]: Stopping IO worker... [00:02:34] [Server thread/INFO] [xa.pa.OpenPartiesAndClaims/]: Stopped IO worker! [00:02:34] [Server thread/INFO] [Calio/]: Removing Dynamic Registries for: net.minecraft.server.dedicated.DedicatedServer@7dc879e1 [MineStrator Daemon]: Checking server disk space usage, this could take a few seconds... [MineStrator Daemon]: Updating process configuration files... [MineStrator Daemon]: Ensuring file permissions are set correctly, this could take a few seconds... [MineStrator Daemon]: Pulling Docker container image, this could take a few minutes to complete... [MineStrator Daemon]: Finished pulling Docker container image container@pterodactyl~ java -version openjdk version "17.0.10" 2024-01-16 OpenJDK Runtime Environment Temurin-17.0.10+7 (build 17.0.10+7) OpenJDK 64-Bit Server VM Temurin-17.0.10+7 (build 17.0.10+7, mixed mode, sharing) container@pterodactyl~ java -Xms128M -Xmx6302M -Dterminal.jline=false -Dterminal.ansi=true -Djline.terminal=jline.UnsupportedTerminal -p libraries/cpw/mods/bootstraplauncher/1.1.2/bootstraplauncher-1.1.2.jar:libraries/cpw/mods/securejarhandler/2.1.4/securejarhandler-2.1.4.jar:libraries/org/ow2/asm/asm-commons/9.5/asm-commons-9.5.jar:libraries/org/ow2/asm/asm-util/9.5/asm-util-9.5.jar:libraries/org/ow2/asm/asm-analysis/9.5/asm-analysis-9.5.jar:libraries/org/ow2/asm/asm-tree/9.5/asm-tree-9.5.jar:libraries/org/ow2/asm/asm/9.5/asm-9.5.jar:libraries/net/minecraftforge/JarJarFileSystems/0.3.16/JarJarFileSystems-0.3.16.jar --add-modules ALL-MODULE-PATH --add-opens java.base/java.util.jar=cpw.mods.securejarhandler --add-opens java.base/java.lang.invoke=cpw.mods.securejarhandler --add-exports java.base/sun.security.util=cpw.mods.securejarhandler --add-exports jdk.naming.dns/com.sun.jndi.dns=java.naming -Djava.net.preferIPv6Addresses=system -DignoreList=bootstraplauncher-1.1.2.jar,securejarhandler-2.1.4.jar,asm-commons-9.5.jar,asm-util-9.5.jar,asm-analysis-9.5.jar,asm-tree-9.5.jar,asm-9.5.jar,JarJarFileSystems-0.3.16.jar -DlibraryDirectory=libraries -DlegacyClassPath=libraries/cpw/mods/securejarhandler/2.1.4/securejarhandler-2.1.4.jar:libraries/org/ow2/asm/asm/9.5/asm-9.5.jar:libraries/org/ow2/asm/asm-commons/9.5/asm-commons-9.5.jar:libraries/org/ow2/asm/asm-tree/9.5/asm-tree-9.5.jar:libraries/org/ow2/asm/asm-util/9.5/asm-util-9.5.jar:libraries/org/ow2/asm/asm-analysis/9.5/asm-analysis-9.5.jar:libraries/net/minecraftforge/accesstransformers/8.0.4/accesstransformers-8.0.4.jar:libraries/org/antlr/antlr4-runtime/4.9.1/antlr4-runtime-4.9.1.jar:libraries/net/minecraftforge/eventbus/6.0.3/eventbus-6.0.3.jar:libraries/net/minecraftforge/forgespi/6.0.0/forgespi-6.0.0.jar:libraries/net/minecraftforge/coremods/5.0.1/coremods-5.0.1.jar:libraries/cpw/mods/modlauncher/10.0.8/modlauncher-10.0.8.jar:libraries/net/minecraftforge/unsafe/0.2.0/unsafe-0.2.0.jar:libraries/com/electronwill/night-config/core/3.6.4/core-3.6.4.jar:libraries/com/electronwill/night-config/toml/3.6.4/toml-3.6.4.jar:libraries/org/apache/maven/maven-artifact/3.8.5/maven-artifact-3.8.5.jar:libraries/net/jodah/typetools/0.8.3/typetools-0.8.3.jar:libraries/net/minecrell/terminalconsoleappender/1.2.0/terminalconsoleappender-1.2.0.jar:libraries/org/jline/jline-reader/3.12.1/jline-reader-3.12.1.jar:libraries/org/jline/jline-terminal/3.12.1/jline-terminal-3.12.1.jar:libraries/org/spongepowered/mixin/0.8.5/mixin-0.8.5.jar:libraries/org/openjdk/nashorn/nashorn-core/15.3/nashorn-core-15.3.jar:libraries/net/minecraftforge/JarJarSelector/0.3.16/JarJarSelector-0.3.16.jar:libraries/net/minecraftforge/JarJarMetadata/0.3.16/JarJarMetadata-0.3.16.jar:libraries/net/minecraftforge/fmlloader/1.19.2-43.3.0/fmlloader-1.19.2-43.3.0.jar:libraries/net/minecraft/server/1.19.2-20220805.130853/server-1.19.2-20220805.130853-extra.jar:libraries/com/github/oshi/oshi-core/5.8.5/oshi-core-5.8.5.jar:libraries/com/google/code/gson/gson/2.8.9/gson-2.8.9.jar:libraries/com/google/guava/failureaccess/1.0.1/failureaccess-1.0.1.jar:libraries/com/google/guava/guava/31.0.1-jre/guava-31.0.1-jre.jar:libraries/com/mojang/authlib/3.11.49/authlib-3.11.49.jar:libraries/com/mojang/brigadier/1.0.18/brigadier-1.0.18.jar:libraries/com/mojang/datafixerupper/5.0.28/datafixerupper-5.0.28.jar:libraries/com/mojang/javabridge/1.2.24/javabridge-1.2.24.jar:libraries/com/mojang/logging/1.0.0/logging-1.0.0.jar:libraries/commons-io/commons-io/2.11.0/commons-io-2.11.0.jar:libraries/io/netty/netty-buffer/4.1.77.Final/netty-buffer-4.1.77.Final.jar:libraries/io/netty/netty-codec/4.1.77.Final/netty-codec-4.1.77.Final.jar:libraries/io/netty/netty-common/4.1.77.Final/netty-common-4.1.77.Final.jar:libraries/io/netty/netty-handler/4.1.77.Final/netty-handler-4.1.77.Final.jar:libraries/io/netty/netty-resolver/4.1.77.Final/netty-resolver-4.1.77.Final.jar:libraries/io/netty/netty-transport/4.1.77.Final/netty-transport-4.1.77.Final.jar:libraries/io/netty/netty-transport-classes-epoll/4.1.77.Final/netty-transport-classes-epoll-4.1.77.Final.jar:libraries/io/netty/netty-transport-native-epoll/4.1.77.Final/netty-transport-native-epoll-4.1.77.Final-linux-x86_64.jar:libraries/io/netty/netty-transport-native-epoll/4.1.77.Final/netty-transport-native-epoll-4.1.77.Final-linux-aarch_64.jar:libraries/io/netty/netty-transport-native-unix-common/4.1.77.Final/netty-transport-native-unix-common-4.1.77.Final.jar:libraries/it/unimi/dsi/fastutil/8.5.6/fastutil-8.5.6.jar:libraries/net/java/dev/jna/jna/5.10.0/jna-5.10.0.jar:libraries/net/java/dev/jna/jna-platform/5.10.0/jna-platform-5.10.0.jar:libraries/net/sf/jopt-simple/jopt-simple/5.0.4/jopt-simple-5.0.4.jar:libraries/org/apache/commons/commons-lang3/3.12.0/commons-lang3-3.12.0.jar:libraries/org/apache/logging/log4j/log4j-api/2.17.0/log4j-api-2.17.0.jar:libraries/org/apache/logging/log4j/log4j-core/2.17.0/log4j-core-2.17.0.jar:libraries/org/apache/logging/log4j/log4j-slf4j18-impl/2.17.0/log4j-slf4j18-impl-2.17.0.jar:libraries/org/slf4j/slf4j-api/1.8.0-beta4/slf4j-api-1.8.0-beta4.jar cpw.mods.bootstraplauncher.BootstrapLauncher --launchTarget forgeserver --fml.forgeVersion 43.3.0 --fml.mcVersion 1.19.2 --fml.forgeGroup net.minecraftforge --fml.mcpVersion 20220805.130853 [00:02:42] [main/INFO] [cp.mo.mo.Launcher/MODLAUNCHER]: ModLauncher running: args [--launchTarget, forgeserver, --fml.forgeVersion, 43.3.0, --fml.mcVersion, 1.19.2, --fml.forgeGroup, net.minecraftforge, --fml.mcpVersion, 20220805.130853] [00:02:42] [main/INFO] [cp.mo.mo.Launcher/MODLAUNCHER]: ModLauncher 10.0.8+10.0.8+main.0ef7e830 starting: java version 17.0.10 by Eclipse Adoptium; OS Linux arch amd64 version 6.1.0-12-amd64 [00:02:43] [main/INFO] [mixin/]: SpongePowered MIXIN Subsystem Version=0.8.5 Source=union:/home/container/libraries/org/spongepowered/mixin/0.8.5/mixin-0.8.5.jar%2363!/ Service=ModLauncher Env=SERVER [00:02:43] [main/WARN] [ne.mi.fm.lo.mo.ModFileParser/LOADING]: Mod file /home/container/libraries/net/minecraftforge/fmlcore/1.19.2-43.3.0/fmlcore-1.19.2-43.3.0.jar is missing mods.toml file [00:02:43] [main/WARN] [ne.mi.fm.lo.mo.ModFileParser/LOADING]: Mod file /home/container/libraries/net/minecraftforge/javafmllanguage/1.19.2-43.3.0/javafmllanguage-1.19.2-43.3.0.jar is missing mods.toml file [00:02:43] [main/WARN] [ne.mi.fm.lo.mo.ModFileParser/LOADING]: Mod file /home/container/libraries/net/minecraftforge/lowcodelanguage/1.19.2-43.3.0/lowcodelanguage-1.19.2-43.3.0.jar is missing mods.toml file [00:02:43] [main/WARN] [ne.mi.fm.lo.mo.ModFileParser/LOADING]: Mod file /home/container/libraries/net/minecraftforge/mclanguage/1.19.2-43.3.0/mclanguage-1.19.2-43.3.0.jar is missing mods.toml file [00:02:44] [main/WARN] [ne.mi.ja.se.JarSelector/]: Attempted to select two dependency jars from JarJar which have the same identification: Mod File: and Mod File: . Using Mod File: [00:02:44] [main/WARN] [ne.mi.ja.se.JarSelector/]: Attempted to select a dependency jar for JarJar which was passed in as source: resourcefullib. Using Mod File: /home/container/mods/resourcefullib-forge-1.19.2-1.1.24.jar [00:02:44] [main/INFO] [ne.mi.fm.lo.mo.JarInJarDependencyLocator/]: Found 13 dependencies adding them to mods collection Latest log [29Mar2024 00:02:42.803] [main/INFO] [cpw.mods.modlauncher.Launcher/MODLAUNCHER]: ModLauncher running: args [--launchTarget, forgeserver, --fml.forgeVersion, 43.3.0, --fml.mcVersion, 1.19.2, --fml.forgeGroup, net.minecraftforge, --fml.mcpVersion, 20220805.130853] [29Mar2024 00:02:42.805] [main/INFO] [cpw.mods.modlauncher.Launcher/MODLAUNCHER]: ModLauncher 10.0.8+10.0.8+main.0ef7e830 starting: java version 17.0.10 by Eclipse Adoptium; OS Linux arch amd64 version 6.1.0-12-amd64 [29Mar2024 00:02:43.548] [main/INFO] [mixin/]: SpongePowered MIXIN Subsystem Version=0.8.5 Source=union:/home/container/libraries/org/spongepowered/mixin/0.8.5/mixin-0.8.5.jar%2363!/ Service=ModLauncher Env=SERVER [29Mar2024 00:02:43.876] [main/WARN] [net.minecraftforge.fml.loading.moddiscovery.ModFileParser/LOADING]: Mod file /home/container/libraries/net/minecraftforge/fmlcore/1.19.2-43.3.0/fmlcore-1.19.2-43.3.0.jar is missing mods.toml file [29Mar2024 00:02:43.877] [main/WARN] [net.minecraftforge.fml.loading.moddiscovery.ModFileParser/LOADING]: Mod file /home/container/libraries/net/minecraftforge/javafmllanguage/1.19.2-43.3.0/javafmllanguage-1.19.2-43.3.0.jar is missing mods.toml file [29Mar2024 00:02:43.877] [main/WARN] [net.minecraftforge.fml.loading.moddiscovery.ModFileParser/LOADING]: Mod file /home/container/libraries/net/minecraftforge/lowcodelanguage/1.19.2-43.3.0/lowcodelanguage-1.19.2-43.3.0.jar is missing mods.toml file [29Mar2024 00:02:43.878] [main/WARN] [net.minecraftforge.fml.loading.moddiscovery.ModFileParser/LOADING]: Mod file /home/container/libraries/net/minecraftforge/mclanguage/1.19.2-43.3.0/mclanguage-1.19.2-43.3.0.jar is missing mods.toml file [29Mar2024 00:02:44.033] [main/WARN] [net.minecraftforge.jarjar.selection.JarSelector/]: Attempted to select two dependency jars from JarJar which have the same identification: Mod File: and Mod File: . Using Mod File: [29Mar2024 00:02:44.034] [main/WARN] [net.minecraftforge.jarjar.selection.JarSelector/]: Attempted to select a dependency jar for JarJar which was passed in as source: resourcefullib. Using Mod File: /home/container/mods/resourcefullib-forge-1.19.2-1.1.24.jar [29Mar2024 00:02:44.034] [main/INFO] [net.minecraftforge.fml.loading.moddiscovery.JarInJarDependencyLocator/]: Found 13 dependencies adding them to mods collection
    • I am unable to do that. Brigadier is a mojang library that parses commands.
    • Hi, i appreciate the answer. I would love to do that, but we have active players with all their belongings in SSN. Also this mod is really handy and they would be mad if we removed it. Are you really certain that SSN is causing this? It would require lots of work to test it and SSN was not really an issue before we removed Fast Suite. Can it be related somehow? I will provide you with log before removing FS. PasteBin: https://pastebin.com/Y5EpLpNe (crash before removing Fast Suite, which I suspected to be a problem from some crash before)
    • Backup the world and make a test without storagenetwork
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.