[1.12.2] [UNSOLVED] TileEntity priority Multiblock (performance)

[Bektor]

Hi,

 

I've just finished my basic fluid tank and I want to have it work now as a multi-block with different priorities:

The numbers represent the priorities. Multiply tanks with the same priority mean that those parts of the tank will be filled equaly at the same time.

Only when all blocks with the priority 1 are completly full all blocks with the priority 2 will begin to fill.

 

Currently I'm only building up the list of all surrounding blocks. Note: Improvements of the code (regarding look and performance) are highly welcome.

    public void generateMultiblock() {
        this.findTanks();
    }
    
    public void disbandMultiblock() {
        
    }
    
    private void findTanks() {
        this.tempTank = new HashSet<>();
        
        ArrayList<BlockPos> adjacentTanks = null;
        ArrayList<BlockPos> currentTanks = new ArrayList<>();
        
        // add this to the list to initiate the search
        currentTanks.add(this.getPos());
        // searches around all blocks and all adjacent blocks
        do {
            for(BlockPos curTank : currentTanks) {
                adjacentTanks = this.findAdjacentTanks(curTank);
                for(BlockPos adTank : adjacentTanks) {
                    // add to list but make sure it's no duplicate
                    if(this.tempTank.add(adTank))
                        currentTanks.add(adTank);
                }
            }
            currentTanks.clear();
        } while (currentTanks.size() > 0);
    }
    
    private ArrayList<BlockPos> findAdjacentTanks(BlockPos tank) {
        if(tank == null)
            return null;
        ArrayList<BlockPos> adjacentTanks = new ArrayList<>();
        
        for(EnumFacing face : EnumFacing.VALUES) {
            // find tile entity in offset direction
            BlockPos offset = tank.offset(face);
            TileEntity tile = this.getWorld().getTileEntity(offset);
            if(tile != null && tile instanceof TileEntityFluidTank) {
                // check if the tile entity is already connected to another tank as it can't have two masters
                if(!((TileEntityFluidTank)tile).isConnected())
                    adjacentTanks.add(offset);
            }
        }
        return adjacentTanks;
    }

 

It should also be noted that my TileEntityFluidTank is currently emtpy except for the isConnected method which currently always returns false (functionality to return true when already connected to a master block isn't quite there yet)

Only the master block contains fluid logic and can hold fluids! The other blocks hold the fluid just client side (in terms of rendering), meaning that they don't have one line and should not have one line of code to handle fluids except for a value used

for rendering (like x amount of fluid stored which is only used to render the x amount of fluid inside the tank at the location).

 

I'm just having problems on how to get a performant way to build up the whole priority list. 

 

Thx in advance.

Bektor

[Draco18s]

Dead simple solution: give no fucks.

Tank "is there a tank below me with available space?" insert liquid.

[Bektor]

1 minute ago, Draco18s said:

Dead simple solution: give no fucks.

 

Could be that simple but I quite like those small details. ^^