1.12.2 isSneaking() not working

[Acrogenous 1]

I have legitimately simplified this code as much as possible to see if this was a parenthesis error, but to no avail

 @Override
    public boolean onBlockActivated(World world, BlockPos blockpos, IBlockState p_onBlockActivated_3_, EntityPlayer player, EnumHand hand, EnumFacing p_onBlockActivated_6_, float p_onBlockActivated_7_, float p_onBlockActivated_8_, float p_onBlockActivated_9_) {
        ItemStack stack = player.getHeldItem(hand);
        if (stack.hasTagCompound() && stack.getItem() == ModItems.logiCard && player.isSneaking())
        {
            NBTTagCompound card = stack.getTagCompound();
            card.setInteger("xpos", blockpos.getX());
            card.setInteger("ypos", blockpos.getY());
            card.setInteger("zpos", blockpos.getZ());
        }
        if (stack.hasTagCompound() && stack.getItem() == ModItems.logiCard && !player.isSneaking())
        {
            direction(stack, player, world, blockpos);
        }
        return super.onBlockActivated(world, blockpos, p_onBlockActivated_3_,player,hand, p_onBlockActivated_6_, p_onBlockActivated_7_, p_onBlockActivated_8_, p_onBlockActivated_9_);
    }

it is fine with detecting if the player is not sneaking, but it does absolutely nothing when the player is sneaking (there is already a compound tag on the item i am using, this was created originally but the code is greatly simplified, as said above) . A further point is when I invert the statements still only the !isSneaking works.

thanks in advance

~Acro

[lethinh 1]

3 hours ago, Acrogenous said:

I have legitimately simplified this code as much as possible to see if this was a parenthesis error, but to no avail

 @Override
    public boolean onBlockActivated(World world, BlockPos blockpos, IBlockState p_onBlockActivated_3_, EntityPlayer player, EnumHand hand, EnumFacing p_onBlockActivated_6_, float p_onBlockActivated_7_, float p_onBlockActivated_8_, float p_onBlockActivated_9_) {
        ItemStack stack = player.getHeldItem(hand);
        if (stack.hasTagCompound() && stack.getItem() == ModItems.logiCard && player.isSneaking())
        {
            NBTTagCompound card = stack.getTagCompound();
            card.setInteger("xpos", blockpos.getX());
            card.setInteger("ypos", blockpos.getY());
            card.setInteger("zpos", blockpos.getZ());
        }
        if (stack.hasTagCompound() && stack.getItem() == ModItems.logiCard && !player.isSneaking())
        {
            direction(stack, player, world, blockpos);
        }
        return super.onBlockActivated(world, blockpos, p_onBlockActivated_3_,player,hand, p_onBlockActivated_6_, p_onBlockActivated_7_, p_onBlockActivated_8_, p_onBlockActivated_9_);
    }

it is fine with detecting if the player is not sneaking, but it does absolutely nothing when the player is sneaking (there is already a compound tag on the item i am using, this was created originally but the code is greatly simplified, as said above) . A further point is when I invert the statements still only the !isSneaking works.

thanks in advance

~Acro

 

Dude, you have to first check if the ItemStack is not null first. Then do whatever you want

[Silly511 9]

1 hour ago, lethinh said:

 

Dude, you have to first check if the ItemStack is not null first. Then do whatever you want

In 1.12 item stacks are never null.

[jabelar 583]

To debug this sort of thing is easy -- just put console (system.out.println()) statements in the code in judicious places and then see what gets printed. I personally put a print statement immediately before the if which prints out the value of every term, and then put a print statement in each path so I can confirm which path was actually executed.

 

with that information it is very easy to see what is going wrong. For example one thing in your code is you're not checking which hand, so it is probably running for both hands, and maybe that is somehow screwing things up a bit.

[lethinh 1]

8 hours ago, Silly511 said:

In 1.12 item stacks are never null.

Come on dude, you understand that. Check if the ItemStack is not EMPTY (ItemStack.EMPTY) or by using ItemStack#isEmpty.

[jabelar 583]

6 hours ago, lethinh said:

Check if the ItemStack is not EMPTY (ItemStack.EMPTY) or by using ItemStack#isEmpty.

Using ItemStack#isEmpty is best because it checks for malformed Itemstacks as well (including somehow being null which can still happen in mods if modder uses old habits or code when emptying a stack).

[Draco18s 1913]

1 hour ago, jabelar said:

Using ItemStack#isEmpty is best because it checks for malformed Itemstacks as well (including somehow being null which can still happen in mods if modder uses old habits or code when emptying a stack).

ItemStack#isEmpty does not work on null stacks. It will crash. 

[Acrogenous 1]

so are we reckoning isSneaking() isn't working because I haven't checked if the ItemStack is null?

[Acrogenous 1]

11 hours ago, jabelar said:

To debug this sort of thing is easy -- just put console (system.out.println()) statements in the code in judicious places and then see what gets printed. I personally put a print statement immediately before the if which prints out the value of every term, and then put a print statement in each path so I can confirm which path was actually executed.

 

with that information it is very easy to see what is going wrong. For example one thing in your code is you're not checking which hand, so it is probably running for both hands, and maybe that is somehow screwing things up a bit.

I tried that, from that I gauged that it was the actual ifSneaking() statment that wasn't working

[Acrogenous 1]

Nope, didn't work, I didn't think it had anything to do with the itemstack (otherwise the latter statement wouldn't work either)

 public boolean onBlockActivated(World world, BlockPos blockpos, IBlockState p_onBlockActivated_3_, EntityPlayer player, EnumHand hand, EnumFacing p_onBlockActivated_6_, float p_onBlockActivated_7_, float p_onBlockActivated_8_, float p_onBlockActivated_9_)
    {
        if(player.getHeldItem(hand) != ItemStack.EMPTY)
        {
            ItemStack stack = player.getHeldItem(hand);
            if (stack.hasTagCompound() && stack.getItem() == ModItems.logiCard && player.isSneaking() )
            {
                NBTTagCompound card = stack.getTagCompound();
                card.setInteger("xpos", blockpos.getX());
                card.setInteger("ypos", blockpos.getY());
                card.setInteger("zpos", blockpos.getZ());
            }
            if (stack.hasTagCompound() && stack.getItem() == ModItems.logiCard && !player.isSneaking())
            {
                direction(stack, player, world, blockpos);
            }
        }
        return super.onBlockActivated(world, blockpos, p_onBlockActivated_3_,player,hand, p_onBlockActivated_6_, p_onBlockActivated_7_, p_onBlockActivated_8_, p_onBlockActivated_9_);
    }

 

[Choonster 1587]

Sneak-right clicking on a Block with an Item will only call Item#onItemUse by default, ignoring Block#onBlockActivated. To change this behaviour, either override Item#doesSneakBypassUse to return true (for your own Items) or subscribe to PlayerInteractEvent.RightClickBlock and call PlayerInteractEvent.RightClickBlock#setUseBlock with Result.ALLOW (for Items from Vanilla or other mods).

 

This is handled in PlayerInteractionManager#processRightClickBlock on the server and PlayerControllerMP#processRightClickBlock on the client.

 

Don't compare to ItemStack.EMPTY directly, it's just one of many possible empty ItemStacks. Use ItemStack#isEmpty instead.

[jabelar 583]

6 hours ago, Acrogenous said:

I tried that, from that I gauged that it was the actual ifSneaking() statment that wasn't working

Sorry, you couldn't have done that fully or it would be obvious where the problem happens. As Choonster mentions, onBlockActivated() probably isn't even being called -- which would be obvious in the console statements (since they wouldn't print when you expect them to). Also, your if statements are still not that simple as there are conditions besides the sneaking that need to be satisfied. 

 

The thing with debugging is you have to double-check all your assumptions. Of course you expect everything is working because you wrote the code intending for it to work. So you literally have to confirm that every step of code executes exactly as you expect. You need to confirm that the method is called when you expect, that the parameter values are what you expect, that the if statement executes as you expect, and so forth.

Edited December 16, 2017 by jabelar

[Acrogenous 1]

thank you @Choonster it wasn't being activated, and fair point @jabelar it was not printing anything, that's what I meant to say, I probably didn't word it correctly  thank you all that helped!