Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[1.11.2][Solved] Using commands serverside when client interact

Kporal

By Kporal
in Modder Support

 Share

Recommended Posts

Kporal Tree Puncher

Kporal

Posted
Posted (edited)

Hello, i'm looking for a way to execute a command server side when a player interaction event.

For now in single player or LAN i used : 

FMLCommonHandler.instance().getMinecraftServerInstance().getCommandManager().executeCommand()

But idk how to tell the server to do that, i'm looking on some other thread and it should be done with packet ?

Edited by Kporal
solved
Link to comment
Share on other sites
Kporal Tree Puncher

Kporal

Posted
  • Author
Posted

Ok i'm trying this and sure it don't work ( but no error ), i think i've missed something or doing something wrong : 

package com.kporal.lau.events;

import com.kporal.lau.LAU;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.SoundEvents;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.network.play.client.CPacketChatMessage;
import net.minecraft.server.MinecraftServer;
import net.minecraft.util.EnumParticleTypes;
import net.minecraft.util.SoundCategory;
import net.minecraftforge.event.entity.player.PlayerInteractEvent;
import net.minecraftforge.fml.common.FMLCommonHandler;
import net.minecraftforge.fml.common.eventhandler.EventPriority;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import net.minecraftforge.fml.server.FMLServerHandler;

public class OnPlayerInteract {

	@SubscribeEvent ( priority = EventPriority.HIGH )
	public void onPlayerRightClick( PlayerInteractEvent.RightClickBlock e ) {
		
		EntityPlayer p = e.getEntityPlayer();
		
		if( p.getHeldItemMainhand().getItem() == LAU.windstaff ) {
			
			double px = e.getPos().getX() + 0.5;
			double py = e.getPos().getY() + 1;
			double pz = e.getPos().getZ() + 0.5;
			
			ItemStack is = p.getHeldItemMainhand();
			NBTTagCompound t = is.getTagCompound() == null ? new NBTTagCompound() : is.getTagCompound();
			t.setDouble( "px_" + p.dimension, px );
			t.setDouble( "py_" + p.dimension, py );
			t.setDouble( "pz_" + p.dimension, pz );
			is.setTagCompound( t );
			
			for( int x = 0; x < 10; x++ ) {
				p.world.spawnParticle( EnumParticleTypes.PORTAL, px + ( Math.random() - 0.5D ), py + ( Math.random() - 0.25D ), pz + ( Math.random() - 0.5D ), ( Math.random() - 0.5D ) * 0.2D, Math.random(), ( Math.random() - 0.5D ) * 0.2D, new int[0] );
			}
			p.world.playSound( px, py, pz, SoundEvents.BLOCK_PORTAL_TRIGGER, SoundCategory.AMBIENT, 1.5F, 1.0F, false );
		}
	}
	
	@SubscribeEvent ( priority = EventPriority.HIGH )
	public void onPlayerLeftClick( PlayerInteractEvent.LeftClickEmpty e ) {
		
		EntityPlayer p = e.getEntityPlayer();
		
		if( p.getHeldItemMainhand().getItem() == LAU.windstaff ) {
			
			ItemStack is = p.getHeldItemMainhand();
			NBTTagCompound nbt = is.getTagCompound();
			
			if( nbt == null || !nbt.hasKey( "px_" + p.dimension ) ) { return; }
			
			double px = nbt.getDouble( "px_" + p.dimension );
			double py = nbt.getDouble( "py_" + p.dimension );
			double pz = nbt.getDouble( "pz_" + p.dimension );
			
			//MinecraftServer s = FMLCommonHandler.instance().getMinecraftServerInstance() != null ? FMLCommonHandler.instance().getMinecraftServerInstance() : ( FMLServerHandler.instance().getServer() != null ? FMLServerHandler.instance().getServer() : null );
			MinecraftServer s = FMLCommonHandler.instance().getMinecraftServerInstance();
			
			if( s != null ) {
				s.getCommandManager().executeCommand( s, "/tp " + p.getName() + " " + px + " " + py + " " + pz );
				p.world.playSound( px, py, pz, SoundEvents.ENTITY_ENDERMEN_TELEPORT, SoundCategory.AMBIENT, 1.5F, 1.0F, false );
			}
			else {
				if( !p.world.isRemote ) {
					FMLServerHandler.instance().getClientToServerNetworkManager().sendPacket( new CPacketChatMessage( "/tp " + p.getName() + " " + px + " " + py + " " + pz ) );
				}
			}
		}
	}
}

 

Link to comment
Share on other sites
Kporal Tree Puncher

Kporal

Posted
  • Author
Posted 
if( !p.world.isRemote ) {
	System.out.println( "debug" );
}

if( p.world.isRemote ) {
	MinecraftServer s = FMLCommonHandler.instance().getMinecraftServerInstance();
	s.getCommandManager().executeCommand( s, "/tp " + p.getName() + " " + px + " " + py + " " + pz );
}

I back on my code to the start to understand where i'm wrong, by doing this, the debug string is never called and whatever if i'm writing p.world.isRemote or e.getWorld().isRemote, the result is the same, so maybe i'm mistaking something about world::isRemote ?

 

By reading the documentation, world.isRemote may return true for single or lan game and false to integrated or dedicated, so whatever if the mod is on client or server, world.isRemote may return the same result each time, and ... it seem to be wrong : 

if( !e.getWorld().isRemote ) {
	System.out.println( "debug server" );
}
			
if( e.getWorld().isRemote ) {
	System.out.println( "debug client" );
}

By doing this, the result is every time the same, only debug client work, server side and client side.

So i just think i'm doing thing wrong but here by testing, it seem i miss something or theire is a problem

Link to comment
Share on other sites
Kporal Tree Puncher

Kporal

Posted
  • Author
Posted

Ok my mod is on server too, this is what i've misunderstand, so in that case, i've rewrite my code : 

package com.kporal.lau.events;

import com.kporal.lau.LAU;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.SoundEvents;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
//import net.minecraft.network.play.client.CPacketChatMessage;
import net.minecraft.server.MinecraftServer;
import net.minecraft.util.EnumParticleTypes;
import net.minecraft.util.SoundCategory;
import net.minecraftforge.event.entity.player.PlayerInteractEvent;
import net.minecraftforge.fml.common.FMLCommonHandler;
import net.minecraftforge.fml.common.eventhandler.EventPriority;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

public class OnPlayerInteract {

	@SubscribeEvent ( priority = EventPriority.HIGH )
	public void onPlayerRightClick( PlayerInteractEvent.RightClickBlock e ) {
		
		EntityPlayer p = e.getEntityPlayer();
		
		if( p.getHeldItemMainhand().getItem() == LAU.windstaff ) {
			
			double px = e.getPos().getX() + 0.5;
			double py = e.getPos().getY() + 1;
			double pz = e.getPos().getZ() + 0.5;
			
			ItemStack is = p.getHeldItemMainhand();
			NBTTagCompound t = is.getTagCompound() == null ? new NBTTagCompound() : is.getTagCompound();
			t.setDouble( "px_" + p.dimension, px );
			t.setDouble( "py_" + p.dimension, py );
			t.setDouble( "pz_" + p.dimension, pz );
			is.setTagCompound( t );
			
			for( int x = 0; x < 10; x++ ) {
				p.world.spawnParticle( EnumParticleTypes.PORTAL, px + ( Math.random() - 0.5D ), py + ( Math.random() - 0.25D ), pz + ( Math.random() - 0.5D ), ( Math.random() - 0.5D ) * 0.2D, Math.random(), ( Math.random() - 0.5D ) * 0.2D, new int[0] );
			}
			p.world.playSound( px, py, pz, SoundEvents.BLOCK_PORTAL_TRIGGER, SoundCategory.AMBIENT, 1.5F, 1.0F, false );
		}
	}
	
	@SubscribeEvent ( priority = EventPriority.HIGH )
	public void onPlayerLeftClick( PlayerInteractEvent.LeftClickEmpty e ) {
		
		EntityPlayer p = e.getEntityPlayer();
		
		if( p.getHeldItemMainhand().getItem() == LAU.windstaff ) {
			
			ItemStack is = p.getHeldItemMainhand();
			NBTTagCompound nbt = is.getTagCompound();
			
			if( nbt == null || !nbt.hasKey( "px_" + p.dimension ) ) { return; }
			
			double px = nbt.getDouble( "px_" + p.dimension );
			double py = nbt.getDouble( "py_" + p.dimension );
			double pz = nbt.getDouble( "pz_" + p.dimension );
			
			if( !p.world.isRemote ) {
				/* SERVER STUFF ? with CPacketChatMessage must be here ? */
			}
			
			if( p.world.isRemote ) {
				MinecraftServer s = FMLCommonHandler.instance().getMinecraftServerInstance();
				if( s != null ) {
					s.getCommandManager().executeCommand( s, "/tp " + p.getName() + " " + px + " " + py + " " + pz );
				}
			}
			p.world.playSound( px, py, pz, SoundEvents.ENTITY_ENDERMEN_TELEPORT, SoundCategory.AMBIENT, 1.5F, 1.0F, false );
		}
	}
}

So in case i've really understand what you said, my must must be like that ? just with a new CPacketMessage( String ) if i'm right ?

Link to comment
Share on other sites
Kporal Tree Puncher

Kporal

Posted
  • Author
Posted

Then EntityPlayerMP isn't required, and i do not need packet, ok so my code is finally just that : 

MinecraftServer s = FMLCommonHandler.instance().getMinecraftServerInstance();
if( s != null ) {
	s.getCommandManager().executeCommand( s, "/tp " + p.getName() + " " + px + " " + py + " " + pz );
}
p.world.playSound( px, py, pz, SoundEvents.ENTITY_ENDERMEN_TELEPORT, SoundCategory.AMBIENT, 1.5F, 1.0F, false );

Yes i know it's wrong like you said, because if i do that i never check if i'm on the server and this must be done from server ( when player is on ).

So this code work fine for single player / lan, and don't get error because for client "s" is null so, how to send the command from the server ?

Link to comment
Share on other sites
Kporal Tree Puncher

Kporal

Posted
  • Author
Posted

yes yes sorry for my bad english, s is null serverside not clientside this is why ( to get single and lan work i used if( s != null ) !

Maybe i need to write something like that ?: 

if( FMLCommonHandler.instance().getEffectiveSide().isServer() ) {
	MinecraftServer x = FMLCommonHandler.instance().getMinecraftServerInstance();
	x.getCommandManager().executeCommand( x, "/tp " + p.getName() + " " + px + " " + py + " " + pz );
}

i havn't test it yet and just copied the other code, just to know if i'm on the good way

Link to comment
Share on other sites
Kporal Tree Puncher

Kporal

Posted
  • Author
Posted

ok so back to p.world.isRemote, so using FMLCommonHandler.instance().getMinecraftServerInstance() is wrong, so how to get the server to execute my command ?

because FMLCommonHandler.instance().getMinecraftServerInstance() work really fine for single and lan, but because the mod is serverside too, using FMLCommonHandler.instance().getMinecraftServerInstance() must return the serverside instance ?

Link to comment
Share on other sites
Draco18s Reality Controller

Draco18s

Posted
Posted
38 minutes ago, Kporal said:

ok so back to p.world.isRemote, so using FMLCommonHandler.instance().getMinecraftServerInstance() is wrong, so how to get the server to execute my command ?

If you are on the client and you want to tell the server soemthing, there is...

Only.

Ever.

One.

Solution.

Packets.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites
Kporal Tree Puncher

Kporal

Posted
  • Author
Posted
1 hour ago, diesieben07 said:

If your mod is serverside, too, then you do not need the packet. Simply check for being on the server and then execute the command.

Currently you are checking whether you are on the client and if so, you access the server instance. This is bad and will crash!

 

2 minutes ago, Draco18s said:

If you are on the client and you want to tell the server soemthing, there is...

Only.

Ever.

One.

Solution.

Packets.

diesieben said, because my mod is serverside too, i don't need to use packet ?..

Link to comment
Share on other sites
Kporal Tree Puncher

Kporal

Posted
  • Author
Posted 
if( !p.world.isRemote ) {
	MinecraftServer s = FMLCommonHandler.instance().getMinecraftServerInstance();
	s.getCommandManager().executeCommand( s, cmd );
}

I just said, whatever if i do that or not, nothing happend ( where, s here must be on server and must exec the command ), or like you said, i just need to learn something more before continue

Link to comment
Share on other sites
Kporal Tree Puncher

Kporal

Posted
  • Author
Posted

OnPlayerInteract.java 

package com.kporal.lau.events;

import com.kporal.lau.LAU;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.SoundEvents;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.server.MinecraftServer;
import net.minecraft.util.EnumParticleTypes;
import net.minecraft.util.SoundCategory;
import net.minecraftforge.event.entity.player.PlayerInteractEvent;
import net.minecraftforge.fml.common.FMLCommonHandler;
import net.minecraftforge.fml.common.eventhandler.EventPriority;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

public class OnPlayerInteract {

	@SubscribeEvent ( priority = EventPriority.HIGH )
	public void onPlayerRightClick( PlayerInteractEvent.RightClickBlock e ) {
		
		EntityPlayer p = e.getEntityPlayer();
		
		if( p.getHeldItemMainhand().getItem() == LAU.windstaff ) {
			
			double px = e.getPos().getX() + 0.5;
			double py = e.getPos().getY() + 1;
			double pz = e.getPos().getZ() + 0.5;
			
			ItemStack is = p.getHeldItemMainhand();
			NBTTagCompound t = is.getTagCompound() == null ? new NBTTagCompound() : is.getTagCompound();
			t.setDouble( "px_" + p.dimension, px );
			t.setDouble( "py_" + p.dimension, py );
			t.setDouble( "pz_" + p.dimension, pz );
			is.setTagCompound( t );
			
			for( int x = 0; x < 10; x++ ) {
				p.world.spawnParticle( EnumParticleTypes.PORTAL, px + ( Math.random() - 0.5D ), py + ( Math.random() - 0.25D ), pz + ( Math.random() - 0.5D ), ( Math.random() - 0.5D ) * 0.2D, Math.random(), ( Math.random() - 0.5D ) * 0.2D, new int[0] );
			}
			p.world.playSound( px, py, pz, SoundEvents.BLOCK_PORTAL_TRIGGER, SoundCategory.AMBIENT, 1.5F, 1.0F, false );
		}
	}
	
	@SubscribeEvent ( priority = EventPriority.HIGH )
	public void onPlayerLeftClick( PlayerInteractEvent.LeftClickEmpty e ) {
		
		EntityPlayer p = e.getEntityPlayer();
		
		if( p.getHeldItemMainhand().getItem() == LAU.windstaff ) {
			
			ItemStack is = p.getHeldItemMainhand();
			NBTTagCompound nbt = is.getTagCompound();
			
			if( nbt == null || !nbt.hasKey( "px_" + p.dimension ) ) { return; }
			
			double px = nbt.getDouble( "px_" + p.dimension );
			double py = nbt.getDouble( "py_" + p.dimension );
			double pz = nbt.getDouble( "pz_" + p.dimension );
			String cmd = "/tp " + p.getName() + " " + px + " " + py + " " + pz;
			
			if( !p.world.isRemote ) {
				MinecraftServer s = FMLCommonHandler.instance().getMinecraftServerInstance();
				s.getCommandManager().executeCommand( s, cmd );
			}
			
			/*MinecraftServer s = FMLCommonHandler.instance().getMinecraftServerInstance();
			if( s != null ) {
				s.getCommandManager().executeCommand( s, cmd );
			}*/
			p.world.playSound( px, py, pz, SoundEvents.ENTITY_ENDERMEN_TELEPORT, SoundCategory.AMBIENT, 1.5F, 1.0F, false );
		}
	}
}

 

LAU.java ( main class ) 

package com.kporal.lau;

//import com.kporal.lau.events.LookatGUIHandler;
import com.kporal.lau.events.OnPlayerInteract;
import com.kporal.lau.items.ItemKitbag;
import com.kporal.lau.items.ItemMultitool;
import com.kporal.lau.items.ItemWindstaff;
import com.kporal.lau.items.kitbag.KitbagGuiHandler;

import net.minecraft.client.Minecraft;
import net.minecraft.client.renderer.block.model.ModelResourceLocation;
import net.minecraft.init.Items;
import net.minecraft.item.Item;
import net.minecraft.item.Item.ToolMaterial;
import net.minecraft.item.ItemStack;
import net.minecraft.world.GameRules;
import net.minecraftforge.common.MinecraftForge;
import net.minecraftforge.fml.common.FMLCommonHandler;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.Mod.EventHandler;
import net.minecraftforge.fml.common.Mod.Instance;
import net.minecraftforge.fml.common.event.FMLInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPostInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPreInitializationEvent;
import net.minecraftforge.fml.common.event.FMLServerStartedEvent;
import net.minecraftforge.fml.common.network.NetworkRegistry;
import net.minecraftforge.fml.common.registry.GameRegistry;
import net.minecraftforge.fml.relauncher.Side;

@Mod(modid = LAU.MODID, name = LAU.NAME, version = LAU.VERSION, acceptedMinecraftVersions = LAU.ACCEPTED_VERSIONS)
public class LAU {
	
	@Instance
	public static LAU instance;
	
	public static final String MODID = "klau";
	public static final String NAME = "Light and Usefull Mod";
	public static final String VERSION = "1.0";
	public static final String ACCEPTED_VERSIONS = "[1.11.2]";
	
	public static ToolMaterial LAUMAT = net.minecraftforge.common.util.EnumHelper.addToolMaterial( "LAUMAT", 3, 1000, 15.0F, 6.0F, 30 );
	
	public static Item windstaff = new ItemWindstaff();
	public static Item kitbag = new ItemKitbag();
	public static Item multitool = new ItemMultitool( LAUMAT );
	
	public static enum LAUItems {
		WINDSTAFF( "windstaff", "itemwindstaff" ),
		KITBAG( "kitbag", "itemkitbag" ),
		MULTITOOL( "multitool", "itemmultitool" );
		
		private String unlocalizedName;
		private String registryName;
		
		LAUItems( String unlocalizedName, String registryName ) {
			this.unlocalizedName = unlocalizedName;
			this.registryName = registryName;
		}
		
		public String getUnlocalizedName() { return unlocalizedName; }
		public String getRegistryName() { return registryName; }
	}
	
	@EventHandler
	public void PreInit( FMLPreInitializationEvent e ) {
		GameRegistry.register( windstaff );
		GameRegistry.register( kitbag );
		GameRegistry.register( multitool );
	}
	
	@EventHandler
	public void Init( FMLInitializationEvent e ) {
		if( e.getSide() == Side.CLIENT ) {
			RegisterRender( windstaff );
			RegisterRender( kitbag );
			RegisterRender( multitool );
		}
		
		RegisterRecipe( windstaff, "F", "S", 'F', Items.FEATHER, 'S', Items.STICK );
		RegisterRecipe( kitbag, "S", "L", 'S', Items.STRING, 'L', Items.LEATHER );
		RegisterRecipe( multitool, "III", "IS ", " S ", 'I', Items.IRON_INGOT, 'S', Items.STICK );
		
		NetworkRegistry.INSTANCE.registerGuiHandler( LAU.instance, new KitbagGuiHandler() );
		
		MinecraftForge.EVENT_BUS.register( new OnPlayerInteract() );
	}
	
	@EventHandler
	public void PostInit( FMLPostInitializationEvent e ) {
		//MinecraftForge.EVENT_BUS.register( new LookatGUIHandler() );
	}
	
	@EventHandler
	public void ServerStarted( FMLServerStartedEvent e ) {
		int count = FMLCommonHandler.instance().getMinecraftServerInstance().worlds.length - 1;
		for( int id = 0; id < count; id++ ) {
			GameRules gr = FMLCommonHandler.instance().getMinecraftServerInstance().worlds[id].getGameRules();
			gr.setOrCreateGameRule( "keepInventory", "true" );
			gr.setOrCreateGameRule( "doFireTick", "false" );
			gr.setOrCreateGameRule( "mobGriefing", "false" );
		}
	}
	
	public void RegisterRender( Item i ) {
		Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register( i, 0, new ModelResourceLocation( i.getRegistryName(), "inventory" ) );
	}
	
	public void RegisterRecipe( Item i, Object... o ) {
		GameRegistry.addShapedRecipe( new ItemStack( i ), o );
	}
}

 

The mod is installed on server and client and working on forge 1.11.2-13.20.2386

Link to comment
Share on other sites
Kporal Tree Puncher

Kporal

Posted
  • Author
Posted (edited)

i've totally forgot this thing ... i used event because it's easier to separate item action, because here i have two action on same click but whatever going to overide onItemRightClick directly on my item, and cheking if player click block or not

Edited by Kporal
error
Link to comment
Share on other sites
Differentiation Dragon Slayer

Differentiation

Posted
Posted (edited)
10 hours ago, Kporal said:

if( !p.world.isRemote ) { MinecraftServer s = FMLCommonHandler.instance().getMinecraftServerInstance(); s.getCommandManager().executeCommand( s, cmd ); }

this is ignored if only client reads the code...

You have to send a packet to the server to do this action. It's not THAT difficult.

But I guess you found your way out, so you can just move on :/

Edited by Differentiation
Link to comment
Share on other sites
Kporal Tree Puncher

Kporal

Posted
  • Author
Posted
2 hours ago, Differentiation said:

this is ignored if only client reads the code...

You have to send a packet to the server to do this action. It's not THAT difficult.

But I guess you found your way out, so you can just move on :/

I never said it was hard ^^, all my code was fine finally, the only thing i was wrong is about my leftClickEmpty event wich in case is never called serverside, this is just a stupid misstake from me, whatever, my code is good and work fine :)

  • Like 1
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept