[1.12.1] Potion Effects on items

[Erfurt]

Hey guys,

 

So I'm working on some Baubles rings and other stuff, that adds potion/beacon effects to the wearer. And my first testing was fine, no problems. But when I tried to use health boost, I noticed some 'weird' behavior, there was no regeneration on the extra hearts. I do understand why this is, and it's because I reapply the effect on every worn tick (I don't know any other way to do that). I can't see any easy fix to this, other than giving the wearer a short burst of regeneration or instant health, but that would mess up if the player is in combat, or is low on hunger. That would not be a good solution, in my mind. So that made me wonder if there is another way to add effects to players, and if I would be able to base the effects on what items that player is wearing? I would assume that I could use nbttags to do that, although I have not worked with that before, so I'm not sure how it works.

 

Because I'm trying to find another way to do the effects, I don't have much code to show, but this is more of a question about what I'm able to do, and not as much a question of what is wrong with my code. I think that it's ok.

 

I should also mention that at the moment I'm just doing some testing of the effects and what I'm able to do with them. But at some point I will be converting from having all the effects static on the items, to have some of the effects come from enchantments instead. And at this point I have no clue where to begin on the enchantments, however that's not what this is about (but if you guys know a good guide or place to learn this, that would be very much appreciated).

 

So to recap, I need to find a way to add potion/beacon effects to the wearer of an item, with a specific effect and/or enchantment.

If some of you can guide me towards a tutorial or some other guides on this, especial the health boost thing, as that was one of the main things I wanted to add with my mod. I would be very happy. Or just shoot me down if I'm being stupid

[Draco18s]

Regeneration specifically requires certain "time remaining" ticks to be hit in order to produce any healing factor. Reapplying the potion every tick is the wrong way to do this. Instead, apply the potion effect for a 1 second duration, then check to see if the player has the potion effect, if they do not, reapply it.

[Erfurt]

9 hours ago, Draco18s said:

Regeneration specifically requires certain "time remaining" ticks to be hit in order to produce any healing factor. Reapplying the potion every tick is the wrong way to do this. Instead, apply the potion effect for a 1 second duration, then check to see if the player has the potion effect, if they do not, reapply it.

This isn't really an option, because every time Health Boost gets reapplied, it starts with empty hearts. And as I mentioned I don't really want to have any healing factors, other than when it gets applied the first time, as it can otherwise mess up if the player is in combat or something like that. But maybe there's a way to alternate the max health of the player by other means? I have the means to apply stuff when the player equip the item, and remove stuff when the player unequip the item. So it's just a matter of finding the other way, as I have little to no clue

 

But thanks for your input, might be useful for other effects