[1.12] Make a block drop itself when mined by hand

[DragonFerocity]

Hey,

 

I'm trying to make one of my custom ores drop itself when mined by hand.

 

I ran across this article and did what it suggested:

ModOre::getHarvestTool

@Override
    public String getHarvestTool(IBlockState state)
    {
      if (this == BlockHandler.copperOre)
        return null;
      else
        return this.harvestTool[getMetaFromState(state)];
    }

However, this doesn't work. When I debug, it gets to this point in the forge code:

ForgeHooks::blockStrength

    public static float blockStrength(@Nonnull IBlockState state, @Nonnull EntityPlayer player, @Nonnull World world, @Nonnull BlockPos pos)
    {
        float hardness = state.getBlockHardness(world, pos);
        if (hardness < 0.0F)
        {
            return 0.0F;
        }

        if (!canHarvestBlock(state.getBlock(), player, world, pos))
        {
            return player.getDigSpeed(state, pos) / hardness / 100F;
        }
        else
        {
            return player.getDigSpeed(state, pos) / hardness / 30F;
        }
    }

And it always goes into the second if, meaning that canHarvestBlock is returning false, even though I return null above. I'm not sure what I'm doing wrong, as setting the harvest level to 0 or -1 doesn't fix it and setting the harvest tool to null also doesn't fix it.

 

Here's a link to my git repo if you want all the code

Edited August 2, 2017 by DragonFerocity

[Draco18s]

There's a ! there.

 

if (!canHarvestBlock(state.getBlock(), player, world, pos))

Edited August 2, 2017 by Draco18s

[Jay Avery]

5 hours ago, DragonFerocity said:

And it always goes into the second if, meaning that canHarvestBlock is returning false, even though I return null above.

Step into that method in the debugger and find out why it's returning false.

[DragonFerocity]

8 hours ago, Draco18s said:

There's a ! there.

 

if (!canHarvestBlock(state.getBlock(), player, world, pos))

The function inside returns false, and !false = true, therefore it goes inside the if.

 

I should have been more clear.

 

I think the problem is that I set the material type to rock, and it seems to check if it's harvestable based on the material, not that function I overrode alone.

 

EDIT: Setting it's material type to something that can be mined by hand; dirt, grass, wood...; fixed it.

Edited August 2, 2017 by DragonFerocity

[Draco18s]

3 hours ago, DragonFerocity said:

I think the problem is that I set the material type to rock, and it seems to check if it's harvestable based on the material, not that function I overrode alone.

 

EDIT: Setting it's material type to something that can be mined by hand; dirt, grass, wood...; fixed it.

Well. Yes.

All blocks behave that way.