Jump to content

[1.11.2]GUI to view villager's inventory crashes


OrangeVillager61

Recommended Posts

When I created a GUI to view the villager inventory, it crashes the game. It is an arraysize error, however, I cannot find the cause.

 

java.util.concurrent.ExecutionException: java.lang.IndexOutOfBoundsException: Index: 51, Size: 51
	at java.util.concurrent.FutureTask.report(Unknown Source) ~[?:1.8.0_121]
	at java.util.concurrent.FutureTask.get(Unknown Source) ~[?:1.8.0_121]
	at net.minecraft.util.Util.runTask(Util.java:30) [Util.class:?]
	at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:1117) [Minecraft.class:?]
	at net.minecraft.client.Minecraft.run(Minecraft.java:407) [Minecraft.class:?]
	at net.minecraft.client.main.Main.main(Main.java:118) [Main.class:?]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_121]
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_121]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_121]
	at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_121]
	at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]
	at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_121]
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_121]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_121]
	at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_121]
	at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97) [start/:?]
	at GradleStart.main(GradleStart.java:26) [start/:?]
Caused by: java.lang.IndexOutOfBoundsException: Index: 51, Size: 51
	at java.util.ArrayList.rangeCheck(Unknown Source) ~[?:1.8.0_121]
	at java.util.ArrayList.get(Unknown Source) ~[?:1.8.0_121]
	at net.minecraft.inventory.Container.getSlot(Container.java:135) ~[Container.class:?]
	at net.minecraft.inventory.Container.setAll(Container.java:559) ~[Container.class:?]
	at net.minecraft.client.network.NetHandlerPlayClient.handleWindowItems(NetHandlerPlayClient.java:1306) ~[NetHandlerPlayClient.class:?]
	at net.minecraft.network.play.server.SPacketWindowItems.processPacket(SPacketWindowItems.java:72) ~[SPacketWindowItems.class:?]
	at net.minecraft.network.play.server.SPacketWindowItems.processPacket(SPacketWindowItems.java:13) ~[SPacketWindowItems.class:?]
	at net.minecraft.network.PacketThreadUtil$1.run(PacketThreadUtil.java:21) ~[PacketThreadUtil$1.class:?]
	at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) ~[?:1.8.0_121]
	at java.util.concurrent.FutureTask.run(Unknown Source) ~[?:1.8.0_121]

 

The container:

public class ContainerIvVillagerInventory extends Container{

	private IvVillager villager;
	
	private IInventory handler; 

	
	public ContainerIvVillagerInventory(IvVillager villager, IInventory playerInv){
		this.villager = villager;
		this.handler = this.villager.getVillagerInventory();
		
		this.addSlotToContainer(new Slot(handler, 0, 40, 66));
		this.addSlotToContainer(new Slot(handler, 1, 58, 66));
		this.addSlotToContainer(new Slot(handler, 2, 76, 66));
		this.addSlotToContainer(new Slot(handler, 3, 94, 66));
		this.addSlotToContainer(new Slot(handler, 4, 112, 66));
		this.addSlotToContainer(new Slot(handler, 5, 40, 84));
		this.addSlotToContainer(new Slot(handler, 6, 58, 84));
		this.addSlotToContainer(new Slot(handler, 7, 76, 84));
		this.addSlotToContainer(new Slot(handler, 8, 94, 84));
		this.addSlotToContainer(new Slot(handler, 9, 112, 84));
		this.addSlotToContainer(new Slot(handler, 10, 40, 102));
		this.addSlotToContainer(new Slot(handler, 11, 58, 102));
		this.addSlotToContainer(new Slot(handler, 12, 76, 102));
		this.addSlotToContainer(new Slot(handler, 13, 94, 102));
		this.addSlotToContainer(new Slot(handler, 14, 112, 102));
		this.addSlotToContainer(new Slot(handler, 15, 40, 120));
		this.addSlotToContainer(new Slot(handler, 16, 58, 120));
		this.addSlotToContainer(new Slot(handler, 17, 76, 120));
		this.addSlotToContainer(new Slot(handler, 18, 94, 120));
		this.addSlotToContainer(new Slot(handler, 19, 112, 120));

		int xPos = 8;
		int yPos = 153;
				
		for (int y = 0; y < 3; ++y) {
			for (int x = 0; x < 9; ++x) {
				this.addSlotToContainer(new Slot(playerInv, x + y * 9 + 9, xPos + x * 18, yPos + y * 18));
			}
		}
				
		for (int x = 0; x < 9; ++x) {
			this.addSlotToContainer(new Slot(playerInv, x, xPos + x * 18, yPos + 58));
		}
	}
	@Override
	public boolean canInteractWith(EntityPlayer player) {
		return false;
	}
}

GUI Handler:

public class GuiHandler implements IGuiHandler{

	public static final int Hire = 0;
	public static final int Hauler = 1;
	public static final int Info = 2;
	public static final int Inventory = 3;

	@Override
	public Object getServerGuiElement(int ID, EntityPlayer player, World world, int x, int y, int z) {
		// x is used as the entity ID for entity-based GUIs, suggested by Choonster
		if (ID == Hire){
			return new ContainerIvVillagerHireNitwit((IvVillager) world.getEntityByID(x), player.inventory);
		}
		else if (ID == Hauler){
			return new ContainerIvVillagerHauler((IvVillager) world.getEntityByID(x), player.inventory);		
			}
		else if (ID == Info)
		{
			return new ContainerIvVillagerInfo((IvVillager) world.getEntityByID(x), player.inventory);		
		}
		else if (ID == Inventory)
		{
			return new ContainerIvVillagerInventory((IvVillager) world.getEntityByID(x), player.inventory);		
		}
		else {
			return null;
		}
	}

	@Override
	public Object getClientGuiElement(int ID, EntityPlayer player, World world, int x, int y, int z) {
		// x is used as the entity ID for entity-based GUIs, suggested by Choonster
		if (ID == Hire)
		{
			return new GuiIvVillagerHireNitwit((IvVillager) world.getEntityByID(x), player.inventory, player);
		}
		else if (ID == Hauler){
			return new GuiIvVillagerHauler((IvVillager) world.getEntityByID(x), player.inventory);
		}
		else if (ID == Info){
			return new GuiIvVillagerInfo((IvVillager) world.getEntityByID(x), player.inventory);
		}
		else if (ID == Inventory){
			return new GuiIvVillagerInventory((IvVillager) world.getEntityByID(x), player.inventory);
		}
		else {
			return null;
		}
	}

 

Link to comment
Share on other sites

It looks like the server-side Container has more Slots than the client-side Container. Are you sure your GUIs are using the right Containers?

  • Like 1

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Link to comment
Share on other sites

10 hours ago, diesieben07 said:

Show where you open the GUI.

public class GuiHandler implements IGuiHandler{

	public static final int Hire = 0;
	public static final int Hauler = 1;
	public static final int Info = 2;
	public static final int Inventory = 3;

	@Override
	public Object getServerGuiElement(int ID, EntityPlayer player, World world, int x, int y, int z) {
		// x is used as the entity ID for entity-based GUIs, suggested by Choonster
		if (ID == Hire){
			return new ContainerIvVillagerHireNitwit((IvVillager) world.getEntityByID(x), player.inventory);
		}
		else if (ID == Hauler){
			return new ContainerIvVillagerHauler((IvVillager) world.getEntityByID(x), player.inventory);		
			}
		else if (ID == Info)
		{
			return new ContainerIvVillagerInfo((IvVillager) world.getEntityByID(x), player.inventory);		
		}
		else if (ID == Inventory)
		{
			return new ContainerIvVillagerInventory((IvVillager) world.getEntityByID(x), player.inventory);		
		}
		else {
			return null;
		}
	}

	@Override
	public Object getClientGuiElement(int ID, EntityPlayer player, World world, int x, int y, int z) {
		// x is used as the entity ID for entity-based GUIs, suggested by Choonster
		if (ID == Hire)
		{
			return new GuiIvVillagerHireNitwit((IvVillager) world.getEntityByID(x), player.inventory, player);
		}
		else if (ID == Hauler){
			return new GuiIvVillagerHauler((IvVillager) world.getEntityByID(x), player.inventory);
		}
		else if (ID == Info){
			return new GuiIvVillagerInfo((IvVillager) world.getEntityByID(x), player.inventory);
		}
		else if (ID == Inventory){
			return new GuiIvVillagerInventory((IvVillager) world.getEntityByID(x), player.inventory);
		}
		else {
			return null;
		}
	}

}

 

17 hours ago, Choonster said:

It looks like the server-side Container has more Slots than the client-side Container. Are you sure your GUIs are using the right Containers?

public class GuiIvVillagerInventory extends GuiContainer{

	private IvVillager villager;
	private IInventory playerInv;
	private String button_text;
	
	public GuiIvVillagerInventory(IvVillager villager, IInventory playerInv) {
		super(new ContainerIvVillagerInventory(villager, playerInv));
		
		this.xSize = 176;
		this.ySize = 234;
		
		this.villager = villager;
		this.playerInv = playerInv;
	}
	@Override
	public void initGui()
	{
		super.initGui();
        this.addButton(new GuiButton(0, this.getGuiLeft(), this.getGuiTop(), 50, 20, "Info"));
        this.addButton(new GuiButton(0, this.getGuiLeft() + 100, this.getGuiTop(), 50, 20, "Inventory"));
        if (this.villager.getProfession() == 5 && this.villager.getHired())
        {
            this.addButton(new GuiButton(0, this.getGuiLeft() + 50, this.getGuiTop(), 50, 20, "Hauler"));
        }
        else if (this.villager.getProfession() == 5 && !this.villager.getHired())
        {
            this.addButton(new GuiButton(0, this.getGuiLeft() + 50, this.getGuiTop(), 50, 20, "Hire"));
        }
        else if (!(this.villager.getProfession() == 5) && !this.villager.isChild())
        {
            this.addButton(new GuiButton(0, this.getGuiLeft() + 50, this.getGuiTop(), 50, 20, "Trade"));
        }
	}
	@Override
	protected void drawGuiContainerBackgroundLayer(float partialTicks, int mouseX, int mouseY) {
		GlStateManager.color(1.0F, 1.0F, 1.0F, 1.0F);
		this.mc.getTextureManager().bindTexture(new ResourceLocation(Reference.MOD_ID, "gui/nitwit_tab.png"));
		this.drawTexturedModalRect(this.getGuiLeft(), this.getGuiTop(), 0, 0, this.xSize, this.ySize);
	}
	@Override
    protected void actionPerformed(GuiButton button)
    {
		if (button.displayString.equals("Info"))
		{
	    	Reference.PACKET_MODID.sendToServer(new MessageChangeTab(this.villager.getEntityId(), 0));
		}
		else if (button.displayString.equals("Hire"))
		{
	    	Reference.PACKET_MODID.sendToServer(new MessageChangeTab(this.villager.getEntityId(), 1));
		}
		else if (button.displayString.equals("Hauler"))
		{
	    	Reference.PACKET_MODID.sendToServer(new MessageChangeTab(this.villager.getEntityId(), 2));
		}
		else if (button.displayString.equals("Trade"))
		{
	    	Reference.PACKET_MODID.sendToServer(new MessageChangeTab(this.villager.getEntityId(), 3));
		
		}
    }
	@Override
	protected void drawGuiContainerForegroundLayer(int mouseX, int mouseY)
    {
        String s = this.villager.getName();
        this.mc.fontRenderer.drawString(s, this.xSize / 2 - this.mc.fontRenderer.getStringWidth(s) / 2, 40, 4210752);
        this.mc.fontRenderer.drawString(this.playerInv.getDisplayName().getFormattedText(), 8, 138, 4210752);
        if (this.villager.getFollowing()){
			this.button_text = "Following";
		}
		else 
		{
			this.button_text = "Follow";
		}
    }



}

 

Link to comment
Share on other sites

On 7/14/2017 at 3:41 PM, diesieben07 said:

Thats your GUI handler. Not where you open the GUI.

 @Override
	 public boolean processInteract(EntityPlayer player, EnumHand hand){
				else if (this.getTab().equals("Inventory"))
        {
        	if (!world.isRemote) {
        		player.openGui(Iv.instance, GuiHandler.Inventory, world, getEntityId(), 0, 0);
        		}
        	return true;
        }
}

 

Link to comment
Share on other sites

Alright, thank you, but I've been having many issues with it.

 

1. I can interact with the GUI, it just doesn't update my changes after I'm done.

 

2. It doesn't show the village inventory, it is only empty even though I saw a farmer plant seeds from his inventory.

 

public class ContainerIvVillagerInventory extends Container{

	private IvVillager villager;
	
	private IInventory handler; 

	
	public ContainerIvVillagerInventory(IvVillager villager, IInventory playerInv){
		this.villager = villager;
		this.handler = this.villager.getVillagerInventory();
		
		this.addSlotToContainer(new ViewSlot(handler, 0, 40, 66));
		this.addSlotToContainer(new ViewSlot(handler, 1, 58, 66));
		this.addSlotToContainer(new ViewSlot(handler, 2, 76, 66));
		this.addSlotToContainer(new ViewSlot(handler, 3, 94, 66));
		this.addSlotToContainer(new ViewSlot(handler, 4, 112, 66));
		this.addSlotToContainer(new ViewSlot(handler, 5, 40, 84));
		this.addSlotToContainer(new ViewSlot(handler, 6, 58, 84));
		this.addSlotToContainer(new ViewSlot(handler, 7, 76, 84));
		this.addSlotToContainer(new ViewSlot(handler, 8, 94, 84));
		this.addSlotToContainer(new ViewSlot(handler, 9, 112, 84));
		this.addSlotToContainer(new ViewSlot(handler, 10, 40, 102));
		this.addSlotToContainer(new ViewSlot(handler, 11, 58, 102));
		this.addSlotToContainer(new ViewSlot(handler, 12, 76, 102));
		this.addSlotToContainer(new ViewSlot(handler, 13, 94, 102));
		this.addSlotToContainer(new ViewSlot(handler, 14, 112, 102));
		this.addSlotToContainer(new ViewSlot(handler, 15, 40, 120));
		this.addSlotToContainer(new ViewSlot(handler, 16, 58, 120));
		this.addSlotToContainer(new ViewSlot(handler, 17, 76, 120));
		this.addSlotToContainer(new ViewSlot(handler, 18, 94, 120));
		this.addSlotToContainer(new ViewSlot(handler, 19, 112, 120));

		int xPos = 8;
		int yPos = 153;
				
		for (int y = 0; y < 3; ++y) {
			for (int x = 0; x < 9; ++x) {
				this.addSlotToContainer(new Slot(playerInv, x + y * 9 + 9, xPos + x * 18, yPos + y * 18));
			}
		}
				
		for (int x = 0; x < 9; ++x) {
			this.addSlotToContainer(new Slot(playerInv, x, xPos + x * 18, yPos + 58));
		}
	}
	@Override
	public boolean canInteractWith(EntityPlayer player) {
		return true;
	}
	
    protected ViewSlot addSlotToContainer(ViewSlot slotIn)
    {
        slotIn.slotNumber = this.inventorySlots.size();
        this.inventorySlots.add(slotIn);
        this.inventoryItemStacks.add(ItemStack.EMPTY);
        return slotIn;
    }
}

 

public class ViewSlot extends Slot{

	public ViewSlot(IInventory inventoryIn, int index, int xPosition, int yPosition) {
		super(inventoryIn, index, xPosition, yPosition);
	}

    public boolean canTakeStack(EntityPlayer playerIn)
    {
        return false;
    }
}

 

Link to comment
Share on other sites

17 hours ago, diesieben07 said:

Not sure. Please post a working Git repo of your mod so I can debug this.

 

The repo is here: https://github.com/Orange1861/Improved-Villagers

 

However, I am having issues with the repo with that there is a nested version of my mod stuck in it. I'd recommend removing this folder when debuging: https://github.com/Orange1861/Improved-Villagers/tree/master/src/main/java/orangeVillager61/ImprovedVillagers

Link to comment
Share on other sites

On 7/17/2017 at 10:45 AM, diesieben07 said:

canInteractWith means if the GUI can stay open. You can make slots read-only by overriding canTakeStack to return false.

Or as I like to think about it, canInteractWithThisEntity

If you can't interact, then you can't view, viewing is interaction.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

  • 2 weeks later...
16 minutes ago, diesieben07 said:

If I put stuff into the villager's inventory manually using code, your GUI works just fine. I don't know why vanilla does not put stuff in there, you have to check that out yourself.

Yeah, but the issue is that I'm not supposed to be able put stuff in that GUI.

Edited by OrangeVillager61
Link to comment
Share on other sites

54 minutes ago, diesieben07 said:

Which your Slot never specifies. Your slot specifies "you can't take stuff out of here". Nothing else.

Oh okay, Also, I can't seem to find why I keep getting Index out of bounds from this, I'm thinking its something to do with addslottocontainer:

 

public ContainerIvVillagerInventory(IvVillager villager, IInventory playerInv){
		this.villager = villager;
		this.handler = this.villager.getVillagerInventory();
		
		this.addSlotToContainer(new ViewSlot(handler, 0, 40, 66));
		this.addSlotToContainer(new ViewSlot(handler, 1, 58, 66));
		this.addSlotToContainer(new ViewSlot(handler, 2, 76, 66));
		this.addSlotToContainer(new ViewSlot(handler, 3, 94, 66));
		this.addSlotToContainer(new ViewSlot(handler, 4, 112, 66));
		this.addSlotToContainer(new ViewSlot(handler, 5, 40, 84));
		this.addSlotToContainer(new ViewSlot(handler, 6, 58, 84));
		this.addSlotToContainer(new ViewSlot(handler, 7, 76, 84));
		this.addSlotToContainer(new ViewSlot(handler, 8, 94, 84));
		this.addSlotToContainer(new ViewSlot(handler, 9, 112, 84));
		this.addSlotToContainer(new ViewSlot(handler, 10, 40, 102));
		this.addSlotToContainer(new ViewSlot(handler, 11, 58, 102));
		this.addSlotToContainer(new ViewSlot(handler, 12, 76, 102));
		this.addSlotToContainer(new ViewSlot(handler, 13, 94, 102));
		this.addSlotToContainer(new ViewSlot(handler, 14, 112, 102));
		this.addSlotToContainer(new ViewSlot(handler, 15, 40, 120));
		this.addSlotToContainer(new ViewSlot(handler, 16, 58, 120));
		this.addSlotToContainer(new ViewSlot(handler, 17, 76, 120));
		this.addSlotToContainer(new ViewSlot(handler, 18, 94, 120));
		this.addSlotToContainer(new ViewSlot(handler, 19, 112, 120));

		int xPos = 8;
		int yPos = 153;
				
		for (int y = 0; y < 3; ++y) {
			for (int x = 0; x < 9; ++x) {
				this.addSlotToContainer(new Slot(playerInv, x + y * 9 + 9, xPos + x * 18, yPos + y * 18));
			}
		}
				
		for (int x = 0; x < 9; ++x) {
			this.addSlotToContainer(new Slot(playerInv, x, xPos + x * 18, yPos + 58));
		}
	}
	@Override
	public boolean canInteractWith(EntityPlayer player) {
		return true;

	}
	
    protected ViewSlot addSlotToContainer(ViewSlot slotIn)
    {
        slotIn.slotNumber = this.inventorySlots.size() + 1;
        this.inventorySlots.add(slotIn);
        //this.inventoryItemStacks.add(ItemStack.EMPTY);
        return slotIn;
    }
}

 

Edited by OrangeVillager61
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.