Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[1.11.2] Fixing an ore generator

jedijoe

By jedijoe
in Modder Support

 Share

Recommended Posts

jedijoe Tree Puncher

jedijoe

Posted
Posted

So I ported my 1.7 ore generation to a 1.11.2 workspace, but I can't seem to figure out how to properly impliment the WorldGenMineable variable, can someone tell me what I'm doing wrong here?

  

package jedijoe.mods.worldgen;

import java.util.Random;

import jedijoe.mods.init.ModBlocks;
import net.minecraft.block.Block;
import net.minecraft.init.Blocks;
import net.minecraft.world.DimensionType;
import net.minecraft.world.World;
import net.minecraft.world.chunk.IChunkGenerator;
import net.minecraft.world.chunk.IChunkProvider;
import net.minecraft.world.gen.feature.WorldGenMinable;
import net.minecraftforge.fml.common.IWorldGenerator;

public class Ore implements IWorldGenerator {

	@Override
	public void generate(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator,
			IChunkProvider chunkProvider) {
		switch(world.provider.getDimensionType()) { case
		OVERWORLD:
			generateOverWorld(random, chunkX * 16, chunkZ * 16, world);
			break;
		case THE_END:
			generateEnd(random, chunkX * 16, chunkZ * 16, world);
			break;
		case NETHER:
			generateNether(random, chunkX * 16, chunkZ * 16, world);
			break;

			
		
			
			
		}
		
	}

	private void generateNether(Random random, int i, int j, World world) {
		// TODO Auto-generated method stub
		
	}

	private void generateEnd(Random random, int chunkX, int chunkZ, World world) {
		addOre(ModBlocks.EAtomicO, Blocks.END_STONE, random, world, chunkX, chunkZ, 5, 12, 2, 4, 4);
		
	}

	private void generateOverWorld(Random random, int i, int j, World world) {
		// TODO Auto-generated method stub
		
	}

	private void addOre(Block block, Block blockspawn, Random random, World world, int posX, int posZ, int minY, int maxY, int minVein, int maxVein, int spawnChance) {
		for(int i = 0; i < spawnChance; i++) {
			int defaultChunkSize = 16;
			int veinSize = minVein + random.nextInt(maxVein - minVein);
			int heightRange = maxY - minY;
			int xPos= posX + random.nextInt(defaultChunkSize);
			int yPos = minY + random.nextInt(maxY - minY);
			int zPos= posZ + random.nextInt(defaultChunkSize);
			WorldGenMinable gen = new WorldGenMinable(block, veinSize, generateIn);
			
		}
	}
}

 

Link to comment
Share on other sites
jedijoe Tree Puncher

jedijoe

Posted
  • Author
Posted (edited)

The WorldGenMineable line here is popping a syntax error at generateIn saying that it can not be resolved to a variable, removing it causes bigger errors, following the path of errors and trying to resolve them via the suggested methods by eclipse just causes more errors. I tried removing the line entirely, but of course that just prevents ores from spawning entirely.

  

			WorldGenMinable gen = new WorldGenMinable(block, veinSize, generateIn);

 

 

Edited by jedijoe
grammar fix
Link to comment
Share on other sites
larsgerrits Reality Controller

larsgerrits

Posted
Posted

Well, you never declare generateIn anywhere...

 

You do however have a variable called blockspawn, of which you need to make a Predicate<IBlockState> and pass that instead of generateIn. You can use BlockMatcher.forBlock(Block) to create a Predicate<IBlocKState>.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites
jedijoe Tree Puncher

jedijoe

Posted
  • Author
Posted

Alright, I got it to stop spitting errors at me, but now I just can't get it to generate the ores I am telling it to, and I am quite sure it's probably some giant mistake I am not seeing here 

package jedijoe.mods.init;

import java.util.Random;

import com.google.common.base.Predicate;

import net.minecraft.block.state.IBlockState;
import net.minecraft.block.state.pattern.BlockMatcher;
import net.minecraft.init.Blocks;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.DimensionType;
import net.minecraft.world.World;
import net.minecraft.world.chunk.IChunkGenerator;
import net.minecraft.world.chunk.IChunkProvider;
import net.minecraft.world.gen.feature.WorldGenMinable;
import net.minecraft.world.gen.feature.WorldGenerator;
import net.minecraftforge.fml.common.IWorldGenerator;

public class Worldgen implements IWorldGenerator {
	
	private WorldGenerator ATOMICORE;
	
	public Worldgen() {
		
	}

	@Override
	public void generate(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator,
			IChunkProvider chunkProvider) {
		switch (world.provider.getDimension())
	{
		case 0:
		addOreSpawn(ModBlocks.AtomicO.getDefaultState(), world, random, chunkX, chunkZ, 16, 16, 50, 30, 10, 100, BlockMatcher.forBlock(Blocks.STONE));
		break;
	
		default:
			break;
		
		
	}


	}

	private void genSurface(World world, Random random, int chunkX, int chunkZ){
		 addOreSpawn(ModBlocks.AtomicO.getDefaultState(), world, random, chunkX, chunkZ, 16, 16, 50, 20, 10, 100, BlockMatcher.forBlock(Blocks.STONE));
		}

	private void addOreSpawn(IBlockState defaultState, World world, Random random, int blockXpos, int blockZpos, int maxX, int maxZ,
			int maxVeinSize, int chance, int minY, int maxY, Predicate<IBlockState> Stone) {
		int diffMinMaxY = maxY - minY;
		for (int x = 0; x < chance; x++) {
		  int posX = blockXpos + random.nextInt(maxX);
		  int posY = minY + random.nextInt(diffMinMaxY);
		  int posZ = blockZpos + random.nextInt(maxZ);
		   (new WorldGenMinable(defaultState, maxVeinSize, Stone)).generate(world, random, new BlockPos(posX, posY, posZ));
		}

		
	}
	
}

 

Link to comment
Share on other sites
larsgerrits Reality Controller

larsgerrits

Posted
Posted

In your addOreSpawn method, you pass in the chunk X and Z coordinate for the block X and Z parameters.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites
jedijoe Tree Puncher

jedijoe

Posted
  • Author
Posted

I adjusted it to swap out the chunk variables for the block variables, and matched the syntax, however these changes did not fix the issue where no ore is generating 

package jedijoe.mods.init;

import java.util.Random;

import com.google.common.base.Predicate;

import net.minecraft.block.state.IBlockState;
import net.minecraft.block.state.pattern.BlockMatcher;
import net.minecraft.init.Blocks;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.DimensionType;
import net.minecraft.world.World;
import net.minecraft.world.chunk.IChunkGenerator;
import net.minecraft.world.chunk.IChunkProvider;
import net.minecraft.world.gen.feature.WorldGenMinable;
import net.minecraft.world.gen.feature.WorldGenerator;
import net.minecraftforge.fml.common.IWorldGenerator;

public class Worldgen implements IWorldGenerator {
	
	private WorldGenerator ATOMICORE;
	
	public Worldgen() {
		
	}

	@Override
	public void generate(Random random, int blockXpos, int blockZpos, World world, IChunkGenerator chunkGenerator,
			IChunkProvider chunkProvider) {
		switch (world.provider.getDimension())
	{
		case 0:
		addOreSpawn(ModBlocks.AtomicO.getDefaultState(), world, random, blockXpos, blockZpos, 16, 16, 50, 30, 10, 100, BlockMatcher.forBlock(Blocks.STONE));
		break;
	
		default:
			break;
		
		
	}


	}

	private void genSurface(World world, Random random, int blockXpos, int blockZpos){
		 addOreSpawn(ModBlocks.AtomicO.getDefaultState(), world, random, blockXpos, blockZpos, 16, 16, 50, 20, 10, 100, BlockMatcher.forBlock(Blocks.STONE));
		}

	private void addOreSpawn(IBlockState defaultState, World world, Random random, int blockXpos, int blockZpos, int maxX, int maxZ,
			int maxVeinSize, int chance, int minY, int maxY, Predicate<IBlockState> Stone) {
		int diffMinMaxY = maxY - minY;
		for (int x = 0; x < chance; x++) {

			
	          int posX = blockXpos + random.nextInt(maxX);
	          int posY = minY + random.nextInt(diffMinMaxY);
	          int posZ = blockZpos + random.nextInt(maxZ);
		   (new WorldGenMinable(defaultState, maxVeinSize, Stone)).generate(world, random, new BlockPos(posX, posY, posZ));
		}

		
	}
	
}

 

 

Link to comment
Share on other sites
larsgerrits Reality Controller

larsgerrits

Posted
Posted

Simply changing the name won't change the value. This is basic Java.

 

You should convert the chunk coordinates to block coordinates by using chunkX << 4. The same for chunkZ.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites
jedijoe Tree Puncher

jedijoe

Posted
  • Author
Posted

I'm pretty sure this is closer to what you meant. I know I still managed to mess it up. 

public class Worldgen implements IWorldGenerator {
   
    private WorldGenerator ATOMICORE;
   
    public Worldgen() {
       
    }
 
    @Override
    public void generate(Random random, int blockXPos, int blockZPos, World world, IChunkGenerator chunkGenerator,
            IChunkProvider chunkProvider) {
        switch (world.provider.getDimension())
    {
        case 0:
        addOreSpawn(ModBlocks.AtomicO.getDefaultState(), world, random, blockXPos, blockZPos, 16, 16, 50, 30, 10, 100, BlockMatcher.forBlock(Blocks.STONE));
        break;
   
        default:
            break;
       
       
    }
 
 
    }
 
    private void genSurface(World world, Random random, int chunkX, int chunkZ){
         addOreSpawn(ModBlocks.AtomicO.getDefaultState(), world, random, chunkX, chunkZ, 16, 16, 50, 20, 10, 100, BlockMatcher.forBlock(Blocks.STONE));
        }
 
    private void addOreSpawn(IBlockState defaultState, World world, Random random, int chunkX, int chunkZ, int maxX, int maxZ,
            int maxVeinSize, int chance, int minY, int maxY, Predicate<IBlockState> Stone) {
    	int defaultchunksize = 16; 
        int diffMinMaxY = maxY - minY;
        for (int x = 0; x < chance; x++) {
        int blockXpos = chunkX << 4;
        int blockZpos = chunkZ << 4;
          int posX = blockXpos + random.nextInt(maxX);
          int posY = minY + random.nextInt(diffMinMaxY);
          int posZ = blockZpos + random.nextInt(maxZ);
           (new WorldGenMinable(defaultState, maxVeinSize, Stone)).generate(world, random, new BlockPos(posX, posY, posZ));
        }
 
       
    }
   
}

 

Link to comment
Share on other sites
jeffryfisher World Shaper

jeffryfisher

Posted
Posted

Step through your generate method (and  into the methods it calls) using the debugger to see what you are actually doing. Examine local variables to see which block (positions) are being changed to what.

The debugger is a powerful and necessary tool in any IDE, so learn how to use it. You'll be able to tell us more and get better help here if you investigate your runtime problems in the debugger before posting.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • RAJAHOKI
      SLOT BANK Lampung 🚀 slot maxwin akun pro kamboja Anti Rungkat

      By RAJAHOKI · Posted

      Akun Pro Kamboja adalah pilihan terbaik bagi Anda yang mencari pengalaman bermain slot Maxwin dengan transaksi mudah menggunakan Bank Lampung. Berikut adalah beberapa alasan mengapa Anda harus memilih Akun Pro Kamboja: Slot Maxwin Terbaik Kami menyajikan koleksi slot Maxwin terbaik yang menawarkan kesenangan bermain dan peluang kemenangan besar. Dengan fitur-fitur unggulan dan tema-tema menarik, setiap putaran permainan akan memberikan Anda pengalaman yang tak terlupakan. Transaksi Mudah dengan Bank Lampung Kami menyediakan layanan transaksi mudah melalui Bank Lampung untuk kenyamanan dan keamanan Anda. Dengan proses yang cepat dan efisien, Anda dapat melakukan deposit dan penarikan dana dengan lancar dan tanpa hambatan. Anti Rungkat Akun Pro Kamboja memberikan jaminan "anti rungkat" kepada para pemainnya. Dengan fitur ini, Anda dapat merasakan sensasi bermain dengan percaya diri, karena kami memastikan pengalaman bermain yang adil dan menyenangkan bagi semua pemain.  
    • admin 2
      BINGO188 | SITUS SLOT GARANSI KEKALAHAN 100 SALDO KEMBALI JIKA KALAH BEBAS IP TANPA TO | SERVER THAILAND PALING GACOR HARI INI

      By admin 2 · Posted

      BINGO188: Destinasi Terbaik untuk Pengalaman Slot yang Terjamin Selamat datang di BINGO188, tempat terbaik bagi para pecinta slot yang mencari pengalaman bermain yang terjamin dan penuh kemenangan. Di sini, kami menawarkan fitur unggulan yang dirancang untuk memastikan kepuasan dan keamanan Anda. Situs Slot Garansi Kekalahan 100 Kami memahami bahwa kadang-kadang kekalahan adalah bagian dari permainan. Namun, di BINGO188, kami memberikan jaminan keamanan dengan fitur garansi kekalahan 100. Jika Anda mengalami kekalahan, kami akan mengembalikan saldo Anda secara penuh. Kemenangan atau uang kembali, kami memastikan Anda tetap merasa aman dan nyaman. Bebas IP Tanpa TO Nikmati kebebasan bermain tanpa batasan IP dan tanpa harus khawatir tentang TO (Turn Over) di BINGO188. Fokuslah pada permainan Anda dan rasakan sensasi kemenangan tanpa hambatan. Server Thailand Paling Gacor Hari Ini Bergabunglah dengan server terbaik di Thailand hanya di BINGO188! Dengan tingkat kemenangan yang tinggi dan pengalaman bermain yang lancar, server kami dijamin akan memberikan Anda pengalaman slot yang tak tertandingi. Kesimpulan BINGO188 adalah pilihan terbaik bagi Anda yang menginginkan pengalaman bermain slot yang terjamin dan penuh kemenangan. Dengan fitur situs slot garansi kekalahan 100, bebas IP tanpa TO, dan server Thailand paling gacor hari ini, kami siap memberikan Anda pengalaman bermain yang aman, nyaman, dan menguntungkan. Bergabunglah sekarang dan mulailah petualangan slot Anda di BINGO188!
    • RAJAHOKI
      SLOT BANK panin 🚀 SLOT Gacor Pgsoft alibabaslot AKURAT

      By RAJAHOKI · Posted

      Mengapa Memilih AlibabaSlot? AlibabaSlot adalah pilihan terbaik bagi Anda yang mencari slot gacor dari Pgsoft dengan transaksi mudah menggunakan Bank Panin. Berikut adalah beberapa alasan mengapa Anda harus memilih AlibabaSlot: Slot Gacor dari Pgsoft Kami menyajikan koleksi slot gacor terbaik dari Pgsoft. Dengan fitur-fitur unggulan dan peluang kemenangan yang tinggi, setiap putaran permainan akan memberikan Anda kesenangan dan keuntungan yang maksimal. Transaksi Mudah dengan Bank Panin Kami menyediakan layanan transaksi mudah melalui Bank Panin untuk kenyamanan dan keamanan Anda. Dengan proses yang cepat dan efisien, Anda dapat melakukan deposit dan penarikan dana dengan lancar dan tanpa masalah.  
    • TileEntity
      Exception in server tick loop

      By TileEntity · Posted

      Delete the jei-server.toml file in your config folder and test it again
    • TileEntity
      My Forge 1.20.1 wont load even without mods

      By TileEntity · Posted

      java.util.ConcurrentModificationException at java.base/java.util.HashMap.computeIfAbsent(Unknown Source) at Genesis//com.moonsworth.lunar. ... Looks like an issue with the Launcher - Make a test with another Launcher like MultiMC, AT Launcher or Technic Launcher or try the original one

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept