Jump to content

[1.7.10] Detect if slot item changed to sword


exys

Recommended Posts

I'm trying to make a mod with some sword that should emit sound only once at its equip. Detection of slot change works like this: last item in player's hand being written to static variable lastSlotItem, and then if  equipped item on next tick != lastSlotItem means that slot is changed. And by some unknown reason onPlayerTick is being called like this:

First change tick: item == sword

Second change tick: item == previous item (why does it goes back to prev. item on this tick?)

Third change tick: item == sword (again)

 

There's my code:

onPlayerTick:

Spoiler

public class FMLEventHandler
{
	public static Item lastSlotItem;
	
	@SubscribeEvent
	public void onPlayerTick(PlayerTickEvent event)
	{
		if(event.phase == TickEvent.Phase.START)
		{
			ItemStack itemStack = event.player.getCurrentEquippedItem();
			if(itemStack != null)
			{
				Item item = itemStack.getItem();
				if(item instanceof ItemTestSword)
				{
					if(lastSlotItem != null) event.player.addChatComponentMessage(new ChatComponentText(item.getClass().getName()));
					if(lastSlotItem != item)
					{
						event.player.addChatComponentMessage(new ChatComponentText("Test sword!"));
					}
				}
				lastSlotItem = item;
			}
			else lastSlotItem = null;
		}
	}
}

 

 

preInit:

Spoiler

@EventHandler
public void preInit(FMLPreInitializationEvent event)
{
    MinecraftForge.EVENT_BUS.register(new ModEventHandler());
    FMLCommonHandler.instance().bus().register(new FMLEventHandler());
    ModItems.init();
}

 

 

And even if i trying to handle slot change detection with onUpdate override in my sword class it does the same thing.

Sword Class:

Spoiler

public class ItemTestSword extends ModItemSword
{
	public List itemDescription = Arrays.asList(new String[]
			{
					"Some",
					"Description",
              		"Here"
			});
	
	public boolean isHeld;
	
	public ItemTestSword(String unlocalizedName, ToolMaterial material)
	{
        super(material);
        this.setUnlocalizedName(unlocalizedName);
	}
	
	@Override
	public void addInformation(ItemStack itemStack, EntityPlayer entityPlayer, List list, boolean bool)
	{
		list.addAll(itemDescription);
	}
	
	@Override
    public ItemStack onItemRightClick(ItemStack itemStack, World world, EntityPlayer entityPlayer)
    {
		return itemStack;
    }
	
	public void onUpdate(ItemStack itemStack, World world, Entity entity, int integer, boolean bool)
	{
      	if(entity instanceof EntityPlayer)
        {
            if(bool && !isHeld)
            {
                    EntityPlayer ep = (EntityPlayer)entity;
                    ep.addChatMessage(new ChatComponentText("Test sword!"));
                    isHeld = true;
            }
            else if(!bool && isHeld) isHeld = false;
        }
	}
}

 

 

Link to comment
Share on other sites

That's bad... I need to create mod on 1.7.10 because of some other mods are still on this version, like GregTech or Extra Bees (Binnie's mods).

But maybe someone can help me with this thing?.. I don't know what to do...

Edited by exys
Link to comment
Share on other sites

5 minutes ago, exys said:

Thanks, i'll check this later.

Note: Using Capabilities requires upgrading past 1.7.10

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
    • It is an issue with quark - update it to this build: https://www.curseforge.com/minecraft/mc-mods/quark/files/3642325
    • Remove Instant Massive Structures Mod from your server     Add new crash-reports with sites like https://paste.ee/  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.