Jump to content

Help Generating Trees in 1.10.2


Poseidon5001

Recommended Posts

Hi everyone. I was attempting to generate trees in the overworld, but I seem to have had little success.
Just wanted to see where I went wrong.
Thanks
 

package com.daposeidonguy.testmod.world;

import java.util.Random;

import com.daposeidonguy.testmod.ModBlocks;

import net.minecraft.block.state.IBlockState;
import net.minecraft.init.Biomes;
import net.minecraft.init.Blocks;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;
import net.minecraft.world.chunk.IChunkGenerator;
import net.minecraft.world.chunk.IChunkProvider;
import net.minecraft.world.gen.feature.WorldGenMinable;
import net.minecraft.world.gen.feature.WorldGenTrees;
import net.minecraftforge.fml.common.IWorldGenerator;

public class ModWorldGeneration implements IWorldGenerator {
	@Override
	public void generate(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator, IChunkProvider chunkProvider) {
		if (world.provider.getDimension() == 0) {
			generateOverworld(random, chunkX, chunkZ, world, chunkGenerator, chunkProvider);
		}
		
	}
	
	private void generateOverworld(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator, IChunkProvider chunkProvider) {
		generateRubberTree(world, random, chunkX, chunkZ, 20);
		generateOre(ModBlocks.oreLead.getDefaultState(), world, random, chunkX, chunkZ, 12, 48, 8 + random.nextInt(5), 8);
	}
	
	private void generateRubberTree(World world, Random random, int chunkX, int chunkZ, int chances) {
		int x = chunkX * 16;
		int z = chunkZ * 16;
		BlockPos biomePos = new BlockPos(chunkX, 64, chunkZ);
		if(world.getBiome(biomePos)== Biomes.SWAMPLAND) {
			for(int i=0;i<chances;i++) {
				
				BlockPos pos = new BlockPos(x + random.nextInt(16), findGround(x,z,world) + 1,z + random.nextInt(16));
				
				WorldGenTrees generator = new WorldGenTrees(true, 4,  Blocks.COAL_BLOCK.getDefaultState(), Blocks.BOOKSHELF.getDefaultState(), false);
				generator.generate(world, random, pos);
				System.out.println("Generated tree");
			}
		}
		
	}
	
	private void generateOre(IBlockState ore, World world, Random random, int chunkX,int chunkZ, int minY, int maxY, int size, int chances) {
		int deltaY = maxY - minY;
		int x = chunkX * 16;
		int z = chunkZ * 16;
		
		for (int i=0; i< chances; i++) {
			BlockPos newPos = new BlockPos(x + random.nextInt(16), minY + random.nextInt(deltaY), z + random.nextInt(16));
		
			WorldGenMinable generator = new WorldGenMinable(ore, size);
			generator.generate(world, random, newPos);
		}
	}
	
	private int findGround(int x,int z, World world) {
		int y=255;
		boolean foundGround = false;
		while(foundGround == false && y > 0) {
			y = y -1;
			IBlockState block = world.getBlockState(new BlockPos(x,y,z));
			if (block == Blocks.GRASS.getDefaultState()) {
				foundGround = true;
			}
			else if (block == Blocks.DIRT.getDefaultState()) {
				foundGround = true;
			}
			else {
				foundGround = false;
			}
		}
		return y;
	}
	
}

 

Edited by Poseidon5001
Updated code
Link to comment
Share on other sites

You are putting chunkX and chunkY directly to the position. It should be x and y, isn't it?

I. Stellarium for Minecraft: Configurable Universe for Minecraft! (WIP)

II. Stellar Sky, Better Star Rendering&Sky Utility mod, had separated from Stellarium.

Link to comment
Share on other sites

41 minutes ago, Abastro said:

You are putting chunkX and chunkY directly to the position. It should be x and y, isn't it?

Oh, you're right. Thank you! Hopefully that's the only thing that's wrong.

 

EDIT: Still doesnt seem to be working. I also updated the code embedded in the main post

Edited by Poseidon5001
Link to comment
Share on other sites

I think you should do the same with biomePos(for World::getBiome), If I recall correctly the position is not the chunk coordinates, but positions of each block.

I. Stellarium for Minecraft: Configurable Universe for Minecraft! (WIP)

II. Stellar Sky, Better Star Rendering&Sky Utility mod, had separated from Stellarium.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.