Jump to content

[1.11.2] Custom Chunk Data


TLHPoE

Recommended Posts

I'm trying to use WorldSavedData to keep track of every chunk that's been loaded and assign it an NBTTagCompound. Right now I have a map that stores a custom class I made called ChunkPos as the key and the NBT tag as the entry. The ChunkPos class is mainly for converting from Chunk to a String for storing the chunk's NBT tag when loading/saving.

 

WorldSavedData (with ChunkPos at the bottom):

package com.kain.slippworld;

import java.util.*;

import net.minecraft.nbt.*;
import net.minecraft.world.*;
import net.minecraft.world.chunk.*;
import net.minecraft.world.storage.*;

public class WorldSavedDataMod extends WorldSavedData {
	public static final String NAME = Reference.NAME + "_WorldData";

	public boolean isDragonSlain = false;

	public Map<ChunkPos, NBTTagCompound> chunkData = null;

	public WorldSavedDataMod(String name) {
		super(name);

		chunkData = new HashMap<ChunkPos, NBTTagCompound>();
	}

	public WorldSavedDataMod() {
		this(NAME);
	}

	@Override
	public void readFromNBT(NBTTagCompound nbt) {
		isDragonSlain = nbt.getBoolean(Reference.DRAGON_SLAIN_TAG);

		NBTTagCompound chunks = nbt.getCompoundTag(Reference.WORLD_DATA_CHUNKS);

		for(String string : chunks.getKeySet()) {
			chunkData.put(new ChunkPos(string), chunks.getCompoundTag(string));
		}
	}

	@Override
	public NBTTagCompound writeToNBT(NBTTagCompound nbt) {
		nbt.setBoolean(Reference.DRAGON_SLAIN_TAG, isDragonSlain);

		NBTTagCompound chunks = new NBTTagCompound();

		for(ChunkPos chunk : chunkData.keySet()) {
			chunks.setTag(chunk.toString(), chunkData.get(chunk));
		}

		nbt.setTag(Reference.WORLD_DATA_CHUNKS, chunks);

		return nbt;
	}

	public NBTTagCompound getChunkData(Chunk chunk) {
		return chunkData.get(new ChunkPos(chunk));
	}

	public void setChunkData(Chunk chunk, NBTTagCompound nbt) {
		chunkData.put(new ChunkPos(chunk), nbt);
	}

	public static WorldSavedDataMod get(World w) {
		MapStorage s = w.getMapStorage();
		WorldSavedDataMod d = (WorldSavedDataMod) s.getOrLoadData(WorldSavedDataMod.class, NAME);

		if(d == null) {
			d = new WorldSavedDataMod();
			s.setData(NAME, d);
		}

		return d;
	}

	public class ChunkPos {
		public long x, z;

		public ChunkPos(long x, long z) {
			this.x = x;
			this.z = z;
		}

		public ChunkPos(Chunk chunk) {
			this(chunk.xPosition, chunk.zPosition);
		}

		public ChunkPos(String string) {
			for(int i = 0; i < string.length(); i++) {
				if(string.charAt(i) == ',') {
					try {
						this.x = Long.parseLong(string.substring(0, i));
						this.z = Long.parseLong(string.substring(i + 1, string.length()));
					} catch(Exception e) {
						e.printStackTrace();
					}
				}
			}
		}

		public String toString() {
			return x + "," + z;
		}
	}
}

 

Data Attachment and Reading:

	@SubscribeEvent
	public void chunkLoad(ChunkDataEvent.Save e) {
		World w = e.getWorld();

		if(!w.isRemote) {
			WorldSavedDataMod data = WorldSavedDataMod.get(w);
			NBTTagCompound nbt = data.getChunkData(e.getChunk());

			if(nbt == null) {
				nbt = new NBTTagCompound();

				data.setChunkData(e.getChunk(), nbt);
				data.markDirty();

				System.out.println("Chunk doesn't have data, creating");
			}
		}
	}

 

The problem is that the chunks are either not saved correctly or not loaded correctly (the "Chunk doesn't have data, creating" is being constantly spammed in one area). I know for a fact that the WorldSavedData class is actually being saved to the world since the isDragonSlain field is being properly saved/loaded and that the ChunkPos class is correctly converting from Chunk to String.

Edited by TLHPoE

Kain

Link to comment
Share on other sites

5 hours ago, TLHPoE said:

public void chunkLoad(ChunkDataEvent.Save e)

o_0

So... which one?

5 hours ago, TLHPoE said:

NBTTagCompound chunks = nbt.getCompoundTag(Reference.WORLD_DATA_CHUNKS);
for(String string : chunks.getKeySet()) {
  chunkData.put(new ChunkPos(string), chunks.getCompoundTag(string));
}

NBTTagCompound chunks = new NBTTagCompound();

for(ChunkPos chunk : chunkData.keySet()) {
	chunks.setTag(chunk.toString(), chunkData.get(chunk));
}

nbt.setTag(Reference.WORLD_DATA_CHUNKS, chunks);

 

WorldSavedData is not a correct place to store per chunk data.  You have access to chunk NBT in both chunk load a save events for a reason ;).

5 hours ago, TLHPoE said:

public class ChunkPos

Did you know, that vanilla already has a ChunkPos class?

 

Also, hash maps won't work if you don't implement hashCode and equals (use your IDE to generate them).

  • Like 1
Link to comment
Share on other sites

7 hours ago, Elix_x said:

o_0

So... which one?

WorldSavedData is not a correct place to store per chunk data.  You have access to chunk NBT in both chunk load a save events for a reason ;).

Did you know, that vanilla already has a ChunkPos class?

 

Also, hash maps won't work if you don't implement hashCode and equals (use your IDE to generate them).

... Oops

 

I know that the event gives access to the chunk's NBT, but I haven't been able to get the data to save at all:

	@SubscribeEvent
	public void chunkSave(ChunkDataEvent.Save e) {
		World w = e.getWorld();

		if(!w.isRemote) {
			WorldSavedDataMod data = WorldSavedDataMod.get(w);
			NBTTagCompound nbt = e.getData();

			if(data.isDragonSlain) {
				if(!nbt.hasKey(Reference.CHUNK_REJUVENATED_TAG)) {
					nbt.setBoolean(Reference.CHUNK_REJUVENATED_TAG, true);

					System.out.println("Generating new ores");

					...

					e.getChunk().setModified(true);
					data.markDirty();
				} else {
					System.out.println("Chunk already has ores");
				}
			} else {
				System.out.println("Dragon hasn't been slain yet");
			}
		}
	}

The code above is what I first tried and it doesn't save the data. The only reason I tried to store it within my WorldSavedData was because of this thread.

Kain

Link to comment
Share on other sites

Seeing as how no one has responded about using the actual chunk's NBT, I fixed my original method of storing my own chunk data in my WorldSavedData:

package com.kain.slippworld;

import java.util.*;

import net.minecraft.nbt.*;
import net.minecraft.util.math.*;
import net.minecraft.world.*;
import net.minecraft.world.storage.*;

public class WorldSavedDataMod extends WorldSavedData {
	public static final String NAME = Reference.NAME + "_WorldData";

	public boolean isDragonSlain = false;

	public Map<ChunkPos, NBTTagCompound> chunkData;

	public WorldSavedDataMod(String name) {
		super(name);

		chunkData = new HashMap<ChunkPos, NBTTagCompound>();
	}

	public WorldSavedDataMod() {
		this(NAME);
	}

	@Override
	public void readFromNBT(NBTTagCompound nbt) {
		isDragonSlain = nbt.getBoolean(Reference.DRAGON_SLAIN_TAG);

		NBTTagCompound chunks = nbt.getCompoundTag(Reference.WORLD_DATA_CHUNKS);

		for(String pos : chunks.getKeySet()) {
			chunkData.put(fromString(pos), chunks.getCompoundTag(pos));
		}
	}

	@Override
	public NBTTagCompound writeToNBT(NBTTagCompound nbt) {
		nbt.setBoolean(Reference.DRAGON_SLAIN_TAG, isDragonSlain);

		NBTTagCompound chunks = new NBTTagCompound();

		for(ChunkPos pos : chunkData.keySet()) {
			chunks.setTag(pos.toString(), chunkData.get(pos));
		}

		nbt.setTag(Reference.WORLD_DATA_CHUNKS, chunks);

		return nbt;
	}

	public NBTTagCompound getChunkData(ChunkPos pos) {
		NBTTagCompound nbt = chunkData.get(pos);

		if(nbt == null) {
			nbt = new NBTTagCompound();
			chunkData.put(pos, nbt);
		}

		return nbt;
	}

	public static WorldSavedDataMod get(World w) {
		MapStorage s = w.getMapStorage();
		WorldSavedDataMod d = (WorldSavedDataMod) s.getOrLoadData(WorldSavedDataMod.class, NAME);

		if(d == null) {
			d = new WorldSavedDataMod();
			s.setData(NAME, d);
		}

		return d;
	}

	public static ChunkPos fromString(String pos) {
		pos = pos.substring(1, pos.length() - 1);

		for(int i = 0; i < pos.length(); i++) {
			if(pos.charAt(i) == ',') {
				return new ChunkPos(Integer.parseInt(pos.substring(0, i)), Integer.parseInt(pos.substring(i + 2, pos.length())));
			}
		}

		return null;
	}
}

 

Kain

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.