Jump to content

Portal Tick Update


AzureusNation123

Recommended Posts

Hey All,

 

Ive currently made a portal so when a feather is dropped in to the open space the portal appears.

 

only problem is it does it on a random tick.

 

is there any way so it does a update every tick or 2

 

 

 

package skycraft.blocks;

 

import java.util.Iterator;

import java.util.List;

import java.util.Random;

 

import cpw.mods.fml.common.TickType;

import cpw.mods.fml.relauncher.Side;

import cpw.mods.fml.relauncher.SideOnly;

import skycraft.SkyCraft;

import skycraft.SkyCraftBlocks;

import skycraft.core.client.ClientProxySkyCraft;

import skycraft.core.common.CommonProxySkyCraft;

import net.minecraft.block.Block;

import net.minecraft.block.material.Material;

import net.minecraft.creativetab.CreativeTabs;

import net.minecraft.entity.Entity;

import net.minecraft.entity.item.EntityItem;

import net.minecraft.item.Item;

import net.minecraft.item.ItemStack;

import net.minecraft.util.AxisAlignedBB;

import net.minecraft.world.IBlockAccess;

import net.minecraft.world.World;

 

public class CloudBlock extends Block

{

    public CloudBlock(int id, int texture, Material material)

    {

    super(id, texture, material);

    this.setBlockName("Cloud");

    this.setHardness(0.01f);

    this.setStepSound(Block.soundSnowFootstep);

    this.setCreativeTab(SkyCraft.tabSkyCraftBlocks);

    }

 

    public int getRenderBlockPass()

    {

        return 1;

    }

   

    public boolean isOpaqueCube()

    {

        return false;

    }

   

    public int getMobilityFlag()

    {

        return 1;

    }

   

    public String getTextureFile()

    {

        return CommonProxySkyCraft.Blocks_PNG;

    }

   

    public void updateTick(World par1World, int par2, int par3, int par4, Random par5Random)

    {

    int cloud = SkyCraftBlocks.cloudBlock.blockID;

   

    if(par1World.getBlockId(par2 + 1, par3, par4) == cloud)

    {

    //Check for cloud frame

    if(par1World.getBlockId(par2 + 2, par3, par4) == cloud && par1World.getBlockId(par2 + 3, par3, par4) == cloud &&

    par1World.getBlockId(par2 + 4, par3, par4) == cloud && par1World.getBlockId(par2, par3, par4 + 1) == cloud &&

    par1World.getBlockId(par2, par3, par4 + 2) == cloud && par1World.getBlockId(par2, par3, par4 + 3) == cloud &&

    par1World.getBlockId(par2, par3, par4 + 4) == cloud && par1World.getBlockId(par2 + 1, par3, par4 + 4) == cloud &&

    par1World.getBlockId(par2 + 2, par3, par4 + 4) == cloud && par1World.getBlockId(par2 + 3, par3, par4 + 4) == cloud &&

    par1World.getBlockId(par2 + 4, par3, par4 + 4) == cloud && par1World.getBlockId(par2 + 4, par3, par4 + 1) == cloud &&

    par1World.getBlockId(par2 + 4, par3, par4 + 2) == cloud && par1World.getBlockId(par2 + 4, par3, par4 + 3) == cloud)

    {

    //empty middle

    if(par1World.getBlockId(par2 + 1, par3, par4 + 1) == 0 && par1World.getBlockId(par2 + 2, par3, par4 + 1) == 0 &&

    par1World.getBlockId(par2 + 3, par3, par4 + 1) == 0 && par1World.getBlockId(par2 + 1, par3, par4 + 2) == 0 &&

    par1World.getBlockId(par2 + 2, par3, par4 + 2) == 0 && par1World.getBlockId(par2 + 3, par3, par4 + 2) == 0 &&

    par1World.getBlockId(par2 + 1, par3, par4 + 3) == 0 && par1World.getBlockId(par2 + 2, par3, par4 + 3) == 0 &&

    par1World.getBlockId(par2 + 3, par3, par4 + 3) == 0)

    {

    ItemStack stack = null;

    EntityItem item = null;

    List list = null;

   

    list = par1World.getEntitiesWithinAABB(EntityItem.class, AxisAlignedBB.getAABBPool().addOrModifyAABBInPool(par2, par3, par4, par2 + 3, par3 + 1, par4 + 3));

   

    if(list != null)

    {

    Iterator iterator = list.iterator();

   

    while(iterator.hasNext())

    {

    Entity entity = (Entity)iterator.next();

   

    if(entity instanceof EntityItem)

    {

    item = (EntityItem) entity;

    stack = item.func_92014_d();

    }

    }

    }

   

    if(stack != null)

    {

    if(stack.getItem() == Item.feather)

        {

        par1World.setBlock(par2 + 1, par3, par4 + 1, SkyCraftBlocks.portalBlock.blockID);

        par1World.setBlock(par2 + 2, par3, par4 + 1, SkyCraftBlocks.portalBlock.blockID);

            par1World.setBlock(par2 + 3, par3, par4 + 1, SkyCraftBlocks.portalBlock.blockID);

            par1World.setBlock(par2 + 1, par3, par4 + 2, SkyCraftBlocks.portalBlock.blockID);

            par1World.setBlock(par2 + 2, par3, par4 + 2, SkyCraftBlocks.portalBlock.blockID);

            par1World.setBlock(par2 + 3, par3, par4 + 2, SkyCraftBlocks.portalBlock.blockID);

            par1World.setBlock(par2 + 1, par3, par4 + 3, SkyCraftBlocks.portalBlock.blockID);

            par1World.setBlock(par2 + 2, par3, par4 + 3, SkyCraftBlocks.portalBlock.blockID);

            par1World.setBlock(par2 + 3, par3, par4 + 3, SkyCraftBlocks.portalBlock.blockID);

           

            if(item != null)

            {

            item.setDead();

            }

        }

    }

    }

    }

    }

    }

}

 

 

 

Thanks in advance

Link to comment
Share on other sites

So, I downloaded your code and mucked about with it, and did some searching online and found that scheduling the tick did the trick.  Here is the relevant code:

 

 

 

@Override

public void onBlockAdded(World par1World, int par2, int par3, int par4) {

par1World.scheduleBlockUpdate(par2, par3, par4, this.blockID, 1);

}

 

@ the bottom of your updateTick routine

 

par1World.scheduleBlockUpdate(par2, par3, par4, this.blockID, 1);

 

 

 

I altered the code to generate glass so I could tell if it was working or not, but it should work with your portal as well. 

 

Something I don't know is if it checking every tick is a bad idea or not.  You might want to update your code to be smarter about rescheduling the tick, like having blocks only schedule a new tick if there is any cloud block next to it, or having the portal frame check be able to work for any block in the frame, instead of just the corner. 

 

Anyhow, cool idea and it works instantly this way, not needing a surface under it and being able to hang in mid air. :)

Link to comment
Share on other sites

can u show me where to put it on here please and underline it so i can see thankyou :)

 

 

public class CloudBlock extends Block

{

    public CloudBlock(int id, int texture, Material material)

    {

    super(id, texture, material);

    this.setBlockName("Cloud");

    this.setHardness(0.01f);

    this.setStepSound(Block.soundSnowFootstep);

    this.setCreativeTab(SkyCraft.tabSkyCraftBlocks);

    }

 

    public int getRenderBlockPass()

    {

        return 1;

    }

   

    public boolean isOpaqueCube()

    {

        return false;

    }

   

    public int getMobilityFlag()

    {

        return 1;

    }

   

    public String getTextureFile()

    {

        return CommonProxySkyCraft.Blocks_PNG;

    }

   

    public void updateTick(World par1World, int par2, int par3, int par4, Random par5Random)

    {

    int cloud = SkyCraftBlocks.cloudBlock.blockID;

   

    if(par1World.getBlockId(par2 + 1, par3, par4) == cloud)

    {

    //Check for cloud frame

    if(par1World.getBlockId(par2 + 2, par3, par4) == cloud && par1World.getBlockId(par2 + 3, par3, par4) == cloud &&

    par1World.getBlockId(par2 + 4, par3, par4) == cloud && par1World.getBlockId(par2, par3, par4 + 1) == cloud &&

    par1World.getBlockId(par2, par3, par4 + 2) == cloud && par1World.getBlockId(par2, par3, par4 + 3) == cloud &&

    par1World.getBlockId(par2, par3, par4 + 4) == cloud && par1World.getBlockId(par2 + 1, par3, par4 + 4) == cloud &&

    par1World.getBlockId(par2 + 2, par3, par4 + 4) == cloud && par1World.getBlockId(par2 + 3, par3, par4 + 4) == cloud &&

    par1World.getBlockId(par2 + 4, par3, par4 + 4) == cloud && par1World.getBlockId(par2 + 4, par3, par4 + 1) == cloud &&

    par1World.getBlockId(par2 + 4, par3, par4 + 2) == cloud && par1World.getBlockId(par2 + 4, par3, par4 + 3) == cloud)

    {

    //empty middle

    if(par1World.getBlockId(par2 + 1, par3, par4 + 1) == 0 && par1World.getBlockId(par2 + 2, par3, par4 + 1) == 0 &&

    par1World.getBlockId(par2 + 3, par3, par4 + 1) == 0 && par1World.getBlockId(par2 + 1, par3, par4 + 2) == 0 &&

    par1World.getBlockId(par2 + 2, par3, par4 + 2) == 0 && par1World.getBlockId(par2 + 3, par3, par4 + 2) == 0 &&

    par1World.getBlockId(par2 + 1, par3, par4 + 3) == 0 && par1World.getBlockId(par2 + 2, par3, par4 + 3) == 0 &&

    par1World.getBlockId(par2 + 3, par3, par4 + 3) == 0)

    {

    ItemStack stack = null;

    EntityItem item = null;

    List list = null;

   

    list = par1World.getEntitiesWithinAABB(EntityItem.class, AxisAlignedBB.getAABBPool().addOrModifyAABBInPool(par2, par3, par4, par2 + 3, par3 + 1, par4 + 3));

   

    if(list != null)

    {

    Iterator iterator = list.iterator();

   

    while(iterator.hasNext())

    {

    Entity entity = (Entity)iterator.next();

   

    if(entity instanceof EntityItem)

    {

    item = (EntityItem) entity;

    stack = item.func_92014_d();

    }

    }

    }

   

    if(stack != null)

    {

    if(stack.getItem() == Item.feather)

        {

        par1World.setBlock(par2 + 1, par3, par4 + 1, SkyCraftBlocks.portalBlock.blockID);

        par1World.setBlock(par2 + 2, par3, par4 + 1, SkyCraftBlocks.portalBlock.blockID);

            par1World.setBlock(par2 + 3, par3, par4 + 1, SkyCraftBlocks.portalBlock.blockID);

            par1World.setBlock(par2 + 1, par3, par4 + 2, SkyCraftBlocks.portalBlock.blockID);

            par1World.setBlock(par2 + 2, par3, par4 + 2, SkyCraftBlocks.portalBlock.blockID);

            par1World.setBlock(par2 + 3, par3, par4 + 2, SkyCraftBlocks.portalBlock.blockID);

            par1World.setBlock(par2 + 1, par3, par4 + 3, SkyCraftBlocks.portalBlock.blockID);

            par1World.setBlock(par2 + 2, par3, par4 + 3, SkyCraftBlocks.portalBlock.blockID);

            par1World.setBlock(par2 + 3, par3, par4 + 3, SkyCraftBlocks.portalBlock.blockID);

           

            if(item != null)

            {

            item.setDead();

            }

        }

    }

    }

    }

    }

    }

}

 

 

Link to comment
Share on other sites

can u show me where to put it on here please and underline it so i can see thankyou :)

 

 

public class CloudBlock extends Block

{

    public CloudBlock(int id, int texture, Material material)

    {

    super(id, texture, material);

    this.setBlockName("Cloud");

    this.setHardness(0.01f);

    this.setStepSound(Block.soundSnowFootstep);

    this.setCreativeTab(SkyCraft.tabSkyCraftBlocks);

    }

 

    public int getRenderBlockPass()

    {

        return 1;

    }

   

    public boolean isOpaqueCube()

    {

        return false;

    }

   

    public int getMobilityFlag()

    {

        return 1;

    }

   

    public String getTextureFile()

    {

        return CommonProxySkyCraft.Blocks_PNG;

    }

   

    public void updateTick(World par1World, int par2, int par3, int par4, Random par5Random)

    {

    int cloud = SkyCraftBlocks.cloudBlock.blockID;

   

    if(par1World.getBlockId(par2 + 1, par3, par4) == cloud)

    {

    //Check for cloud frame

    if(par1World.getBlockId(par2 + 2, par3, par4) == cloud && par1World.getBlockId(par2 + 3, par3, par4) == cloud &&

    par1World.getBlockId(par2 + 4, par3, par4) == cloud && par1World.getBlockId(par2, par3, par4 + 1) == cloud &&

    par1World.getBlockId(par2, par3, par4 + 2) == cloud && par1World.getBlockId(par2, par3, par4 + 3) == cloud &&

    par1World.getBlockId(par2, par3, par4 + 4) == cloud && par1World.getBlockId(par2 + 1, par3, par4 + 4) == cloud &&

    par1World.getBlockId(par2 + 2, par3, par4 + 4) == cloud && par1World.getBlockId(par2 + 3, par3, par4 + 4) == cloud &&

    par1World.getBlockId(par2 + 4, par3, par4 + 4) == cloud && par1World.getBlockId(par2 + 4, par3, par4 + 1) == cloud &&

    par1World.getBlockId(par2 + 4, par3, par4 + 2) == cloud && par1World.getBlockId(par2 + 4, par3, par4 + 3) == cloud)

    {

    //empty middle

    if(par1World.getBlockId(par2 + 1, par3, par4 + 1) == 0 && par1World.getBlockId(par2 + 2, par3, par4 + 1) == 0 &&

    par1World.getBlockId(par2 + 3, par3, par4 + 1) == 0 && par1World.getBlockId(par2 + 1, par3, par4 + 2) == 0 &&

    par1World.getBlockId(par2 + 2, par3, par4 + 2) == 0 && par1World.getBlockId(par2 + 3, par3, par4 + 2) == 0 &&

    par1World.getBlockId(par2 + 1, par3, par4 + 3) == 0 && par1World.getBlockId(par2 + 2, par3, par4 + 3) == 0 &&

    par1World.getBlockId(par2 + 3, par3, par4 + 3) == 0)

    {

    ItemStack stack = null;

    EntityItem item = null;

    List list = null;

   

    list = par1World.getEntitiesWithinAABB(EntityItem.class, AxisAlignedBB.getAABBPool().addOrModifyAABBInPool(par2, par3, par4, par2 + 3, par3 + 1, par4 + 3));

   

    if(list != null)

    {

    Iterator iterator = list.iterator();

   

    while(iterator.hasNext())

    {

    Entity entity = (Entity)iterator.next();

   

    if(entity instanceof EntityItem)

    {

    item = (EntityItem) entity;

    stack = item.func_92014_d();

    }

    }

    }

   

    if(stack != null)

    {

    if(stack.getItem() == Item.feather)

        {

        par1World.setBlock(par2 + 1, par3, par4 + 1, SkyCraftBlocks.portalBlock.blockID);

        par1World.setBlock(par2 + 2, par3, par4 + 1, SkyCraftBlocks.portalBlock.blockID);

            par1World.setBlock(par2 + 3, par3, par4 + 1, SkyCraftBlocks.portalBlock.blockID);

            par1World.setBlock(par2 + 1, par3, par4 + 2, SkyCraftBlocks.portalBlock.blockID);

            par1World.setBlock(par2 + 2, par3, par4 + 2, SkyCraftBlocks.portalBlock.blockID);

            par1World.setBlock(par2 + 3, par3, par4 + 2, SkyCraftBlocks.portalBlock.blockID);

            par1World.setBlock(par2 + 1, par3, par4 + 3, SkyCraftBlocks.portalBlock.blockID);

            par1World.setBlock(par2 + 2, par3, par4 + 3, SkyCraftBlocks.portalBlock.blockID);

            par1World.setBlock(par2 + 3, par3, par4 + 3, SkyCraftBlocks.portalBlock.blockID);

           

            if(item != null)

            {

            item.setDead();

            }

        }

    }

    }

    }

    }

    }

  par1World.scheduleBlockUpdate(par2, par3, par4, this.blockID, 1);

}

 

 

 

Sure, but understanding what is going on is important here.  The updateTick for the block gets called when the block is scheduled for update.  The onBlockAdded call makes sure it is scheduled for update the first time.  Putting it in the updateTick routine makes sure it is called again.

 

You could probably add logic to not do it if a portal was successfully created or if none of the blocks next to the block are of type cloud.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.