[1.11.2] ISidedInventory#canInsertItem not being called

[Tschipp]

I want to make it so that a slot from my machine is accessable from up and all the sides, but the  ISidedInventory#canInsertItem method doesn't seem to get called... ever. I've checked with the debug tool.

This is my method, but as I said it isn't even being called.. Am I understanding something wrong?

 

@Override
	public boolean canInsertItem(int index, ItemStack stack, EnumFacing direction) {
		return  (direction == EnumFacing.EAST || direction == EnumFacing.NORTH || direction == EnumFacing.SOUTH || direction == EnumFacing.WEST || direction == EnumFacing.UP) && index == 9;
	}

 

[Kokkie]

5 minutes ago, Tschipp said:

(direction == EnumFacing.EAST || direction == EnumFacing.NORTH || direction == EnumFacing.SOUTH || direction == EnumFacing.WEST || direction == EnumFacing.UP)

Why all this? You can also just check once if it isn't EnumFacing.DOWN...

[Tschipp]

9 hours ago, Kokkie said:

Why all this? You can also just check once if it isn't EnumFacing.DOWN...

Whoops

 

But still, I removed all this and just return true all the time, I also added a print statement... nothing. The method is supposed to be executed when a hopper tries to insert an item into the machine, right? Becasue the ISidedInventory#canExtractItem method gets executed when a hopper tries to pull items out of it...

Edited March 5, 2017 by Tschipp

[Tschipp]

6 hours ago, diesieben07 said:

Don't use ISidedInventory, use the IItemHandler capability.

But then I have to rewrite everything...  Why shouldn't I use ISidedInventory? Because it's  old?

[larsgerrits]

It's an old, bad API which is still used by Minecraft itself, while capabilities are added by Forge to offer much better compatibility between mods. If you still use IInventory/ISidedInventory, most mods wouldn't know how to interact with your inventories, and can't be used in automation.

[Tschipp]

18 minutes ago, larsgerrits said:

It's an old, bad API which is still used by Minecraft itself, while capabilities are added by Forge to offer much better compatibility between mods. If you still use IInventory/ISidedInventory, most mods wouldn't know how to interact with your inventories, and can't be used in automation.

Ok, I see. But in this case, automation really doesn't matter. The block just gives you some text information about the item that you put in, so it's only useable by players. I'll still take a look at the capability thing, in the long run it seems less complicated.

[Draco18s]

https://github.com/Draco18s/ReasonableRealism/blob/master/src/main/java/com/draco18s/ores/block/BlockMillstone.java#L73-L95

 

Lines 77 and 83 are the important ones for your usage.  Most of the rest of that method is just to give an achievement.

Edited March 5, 2017 by Draco18s