Jump to content

[SOLVED] How do I implement on-tick methods in my mod?


Qwertygiy

Recommended Posts

Hello,

 

I'm currently working on a really simple mod that basically just adds a ton more achievements via the achievement page feature. And one thing I'm trying to do is check the player's inventory every so often (100 ticks is the length currently in my code but I'll probably adjust it as needed once I can get it working) so that you can earn an achievement by taking something out of a chest or by having it in your inventory without having to drop it.

 

I've looked through the code, and found the Forge ModLoader class ITickHandler. But I can't seem to get it to work. I have implemented it in my mod class, and include this code:

 

public void tickStart(EnumSet<TickType> type, Object... tickData)
{

}

public EnumSet<TickType> ticks()
{
	return EnumSet.of(TickType.WORLD);
}

public String getLabel()
{
	return "Achievementizer";
}

public void tickEnd(EnumSet<TickType> type, Object... tickData)
{
	System.out.println("Tick Recieved");
	Minecraft minecraft = ModLoader.getMinecraftInstance();
	tickCounter = tickCounter + 1;
	if(tickCounter > 100)
	{
		tickCounter = 0;
		System.out.println("Checking inventory");
		EntityPlayer entityplayer = minecraft.thePlayer;
		for (int g = 0; g < entityplayer.inventory.mainInventory.length; g++)
			{
				ItemStack checkForAchievement = entityplayer.inventory.mainInventory[g];
				handler.getAchievements(entityplayer, checkForAchievement.itemID, checkForAchievement.getItemDamage());
			}
	}
}

 

It recompiles and runs fine, but I get no response, so I don't think the function is firing. I suspect I'm missing an important line or two somewhere. Can anybody help me with this?

Link to comment
Share on other sites

/**
 * Load up
 */
@Override
public void load() {
	ModLoader.setInGameHook(this, true, false);
	ModLoader.setInGUIHook(this, true, false);
}

/**
 * Handle ingame ticks
 * @return 
 */

int create = 0;
int i, j, k;
public boolean onTickInGame(float time, Minecraft minecraftInstance)
    {
	if(mc.theWorld != null) {
		i = (int) mc.thePlayer.posX;
		j = (int) mc.thePlayer.posY;
		k = (int) mc.thePlayer.posZ;
	}



	create++;
	System.out.println(create);

	if(mc.theWorld != null && create == 50 && mc.thePlayer != null) {
                    Do Stuff Here
	}

        return true;
    }


/**
 * Handle GUI ticks
 */
    public boolean onTickInGUI(float tick, Minecraft game, GuiScreen gui)
    {
    	boolean mainmenu = mc.currentScreen instanceof GuiMainMenu;
    	if(mainmenu) {
    		create = 0;
    	}
        return true;
    }

 

Hope that helps, that is how I do it.

Link to comment
Share on other sites

Hello,

 

I'm currently working on a really simple mod that basically just adds a ton more achievements via the achievement page feature. And one thing I'm trying to do is check the player's inventory every so often (100 ticks is the length currently in my code but I'll probably adjust it as needed once I can get it working) so that you can earn an achievement by taking something out of a chest or by having it in your inventory without having to drop it.

 

I've looked through the code, and found the Forge ModLoader class ITickHandler. But I can't seem to get it to work. I have implemented it in my mod class, and include this code:

 

public void tickStart(EnumSet<TickType> type, Object... tickData)
{

}

public EnumSet<TickType> ticks()
{
	return EnumSet.of(TickType.WORLD);
}

public String getLabel()
{
	return "Achievementizer";
}

public void tickEnd(EnumSet<TickType> type, Object... tickData)
{
	System.out.println("Tick Recieved");
	Minecraft minecraft = ModLoader.getMinecraftInstance();
	tickCounter = tickCounter + 1;
	if(tickCounter > 100)
	{
		tickCounter = 0;
		System.out.println("Checking inventory");
		EntityPlayer entityplayer = minecraft.thePlayer;
		for (int g = 0; g < entityplayer.inventory.mainInventory.length; g++)
			{
				ItemStack checkForAchievement = entityplayer.inventory.mainInventory[g];
				handler.getAchievements(entityplayer, checkForAchievement.itemID, checkForAchievement.getItemDamage());
			}
	}
}

 

It recompiles and runs fine, but I get no response, so I don't think the function is firing. I suspect I'm missing an important line or two somewhere. Can anybody help me with this?

 

 

ITickHandler needs to be registered at FMLCommonHandler.instance().registerTickHandler(<instanceofmyitickhandlerclass>);

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.